[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Aschroet added a comment. Just as an information, it istill not fixed on Commons: https://commons.wikimedia.org/w/index.php?title=User_talk:Aschroet=360277621=359912218 https://commons.wikimedia.org/w/index.php?title=User_talk:Aschroet=361175442=360665676 TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Jeff_G added a comment. In T220828#5352582 , @whym wrote: > Note to @Jeff_G: you might still see the bug on Commons, but that's expected. It might take some time before I update ArchiverBot@Commons to reflect the bug fix. (Maybe next

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

whym added a comment. Note to @Jeff_G: you might still see the bug on Commons, but that's expected. It might take some time before I update ArchiverBot@Commons to reflect the bug fix. (Maybe next weekend.) TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

gerritbot added a comment. Change 524305 **merged** by jenkins-bot: [pywikibot/core@master] archivebot.py: don't reorder template parameters https://gerrit.wikimedia.org/r/524305 TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

gerritbot added a comment. Change 524305 had a related patch set uploaded (by Mpaa; owner: Mpaa): [pywikibot/core@master] archivebot.py: don't reorder template parameters https://gerrit.wikimedia.org/r/524305 TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Mpaa added a comment. Wouldn't loading config from `self.page.raw_extracted_templates` instead of `self.page.templatesWithParams()` keep the right order? TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Jeff_G added a comment. However, as of this diff 07:59, 14 July 2019 (UTC) it is still happening. TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Jeff_G added a comment. As of this diff 07:48, 3 July 2019 (UTC), it is thankfully no longer shuffling parameters on my user talk page on Commons. TASK DETAIL https://phabricator.wikimedia.org/T220828

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Dvorapa added a comment. Okay, examples now show just the fiddling with optional parameters. The fix was easy for mandatory parameters, but it may not be an easy task for optional parameters. TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

whym added a comment. Sorry, the link in the description was not adequate - it was done before I updated Pywikibot. I replaced it with newer examples. TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Dvorapa added a comment. Like setting their initial empty value? Anyway the example in the description seems like there was Pywikibot downgraded or Python version changed between 2 and 3 on outdated Pywikibot version. Weird. TASK DETAIL https://phabricator.wikimedia.org/T220828

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Xqt added a comment. In T220828#5108653 , @Dvorapa wrote: > - //other parameters in the order they've been found (which still differs between Python 2 and 3, but if your bot uses only one Python version, then it should be fine)//

[Pywikipedia-bugs] [Maniphest] [Commented On] T220828: archivebot.py: don't reorder template parameters

Dvorapa added a comment. This has been fixed a while ago. Which Pywikibot version does ArchiverBot use? TASK DETAIL https://phabricator.wikimedia.org/T220828 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Dvorapa,