[Pywikipedia-bugs] [Maniphest] [Commented On] T331243: redirect.py: problem with the build-in generator

2023-04-05 Thread gerritbot
gerritbot added a comment. Change 904875 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Fix -namespace usage if RedirectGenerator is used https://gerrit.wikimedia.org/r/904875 TASK DETAIL https://phabricator.wikimedia.org/T331243 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T331243: redirect.py: problem with the build-in generator

2023-04-02 Thread Shalomori123
Shalomori123 added a comment. Got it, thanks  TASK DETAIL https://phabricator.wikimedia.org/T331243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Shalomori123 Cc: Aklapper, pywikibot-bugs-list, Shalomori123, Themindcoder, Adamm71,

[Pywikipedia-bugs] [Maniphest] [Commented On] T331243: redirect.py: problem with the build-in generator

2023-04-01 Thread Xqt
Xqt added a comment. I haven’t removed any option. fullscan as well as both actions uses Site.allpages which has a namespace parameter and does not need additional namespace filter. Also -xml has its own filter. yielding a page object might be a good idea anyway but needs further changes

[Pywikipedia-bugs] [Maniphest] [Commented On] T331243: redirect.py: problem with the build-in generator

2023-04-01 Thread Shalomori123
Shalomori123 added a comment. @Xqt why to deprecate this option actually? I think the problem is in this strange generator. We have no other generator in `pagegenerators` that yield `str()` type. I don't understand in the software efficiency of the `Page()` class, but I think that the

[Pywikipedia-bugs] [Maniphest] [Commented On] T331243: redirect.py: problem with the build-in generator

2023-04-01 Thread gerritbot
gerritbot added a comment. Change 904875 had a related patch set uploaded (by Xqt; author: Xqt): [pywikibot/core@master] [bugfix] Fix -namespace usage if RedirectGenerator is used https://gerrit.wikimedia.org/r/904875 TASK DETAIL https://phabricator.wikimedia.org/T331243 EMAIL