[Pywikipedia-bugs] [Maniphest] [Commented On] T134640: site_tests.py fails for TestUserContribsWithoutUser with TimeoutError

2016-11-27 Thread Dalba
Dalba added a comment. @Magul Well, I think it would be better if we increased the timeouts as low as necessary. Especially that in multi-threaded environments these timeouts make the application completely unresponsive. When there is actually a problem with the connection somewhere an early

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T148121: [CGI template easy task] Find and fix syntax errors in translated messages

2016-11-27 Thread Aklapper
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment. Imported as https://codein.withgoogle.com/tasks/5695759668215808/TASK

[Pywikipedia-bugs] [Maniphest] [Unassigned] T132158: Page title too long pages errors with nondescriptive message "has neither 'pageid' nor 'missing' attribute"

2016-11-27 Thread Magul
Magul removed Magul as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T132158EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: Magul, gerritbot, Mpaa, Xqt, jayvdb, Aklapper, Senapa, pywikibot-bugs-list, zhuyifei1999, MayS,

[Pywikipedia-bugs] [Maniphest] [Closed] T132158: Page title too long pages errors with nondescriptive message "has neither 'pageid' nor 'missing' attribute"

2016-11-27 Thread Magul
Magul closed this task as "Resolved".Magul claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T132158EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: gerritbot, Mpaa, Xqt, jayvdb, Aklapper, Senapa, pywikibot-bugs-list, zhuyifei1999,

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T114574: Create an alias "mul" for -lang: syntax in pywikibot

2016-11-27 Thread Aklapper
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment. Imported as https://codein.withgoogle.com/tasks/5727455453118464/TASK

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T70797: script_wui hardcoded to use User:DrTrigon

2016-11-27 Thread Aklapper
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment. In T70797#2758117, @DrTrigon wrote: I will mentor this in #GCI2016 @DrTrigon: Could you please reply to the mentor registration email you received, and register? :) If

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T90149: LDAP based login is broken in pywikibot because lgdomain is not set

2016-11-27 Thread Aklapper
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment. Imported as https://codein.withgoogle.com/tasks/5099661157203968/TASK

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T130805: Create some tests for pywikibot.diff.PatchManager

2016-11-27 Thread Aklapper
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment. Imported as https://codein.withgoogle.com/tasks/5757373792649216/TASK

[Pywikipedia-bugs] [Maniphest] [Retitled] T130805: Create some tests for pywikibot.diff.PatchManager

2016-11-27 Thread Aklapper
Aklapper changed the title from "pywikibot.diff.PatchManager has no tests" to "Create some tests for pywikibot.diff.PatchManager". TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Vennela0212,

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T124005: Create tests for fake user agent

2016-11-27 Thread Aklapper
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment. Imported as https://codein.withgoogle.com/tasks/5710305380270080/TASK

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T92856: Assertion failure testing namespace restriction

2016-11-27 Thread Magul
Magul added subscribers: Xqt, XXN, Dalba, valhallasw.Magul added a comment. The reason that (I believe) cause failing tests here (and in few other tasks) is, that these tests aren't unittests. The work on live Mediawiki instances and they assume that there will be no change during test. As You

[Pywikipedia-bugs] [Maniphest] [Retitled] T151733: Compat deprecation message broke compat

2016-11-27 Thread Masti
Masti changed the title from "Compat deprecation message broke comat" to "Compat deprecation message broke compat". TASK DETAILhttps://phabricator.wikimedia.org/T151733EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MastiCc: Aklapper, Masti,

[Pywikipedia-bugs] [Maniphest] [Created] T151733: Compat deprecation message broke comat

2016-11-27 Thread Masti
Masti created this task.Masti added a project: Pywikibot-compat.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONwarning message in throttle.py introduced in https://gerrit.wikimedia.org/r/322502 crasshes with EOFError: EOF when reading a line example: Press to continue.

[Pywikipedia-bugs] [Maniphest] [Commented On] T134640: site_tests.py fails for TestUserContribsWithoutUser with TimeoutError

2016-11-27 Thread Magul
Magul added a comment. I have just pushed update to my patch that will change default timeout to 1 minute instead of 5 (and fixing commit message typo). @Dalba I'm not certain what kind of advantage we will get, if we will distinguish read timeout and connect timeout. @Xqt I get Your hesitation

[Pywikipedia-bugs] [Maniphest] [Updated] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt added a parent task: T151110: Regressions of core should be rethinked or solved. TASK DETAILhttps://phabricator.wikimedia.org/T151727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Xqt, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Updated] T151110: Regressions of core should be rethinked or solved

2016-11-27 Thread Xqt
Xqt added a subtask: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T151110EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: zhuyifei1999, pywikibot-bugs-list, Aklapper, Magul, Xqt, MayS, Mdupont, JJMC89, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Updated] T73646: replace.py: async output messages jumbled with user interaction on main thread

2016-11-27 Thread Xqt
Xqt added a subtask: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T73646EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mpaa, XqtCc: Xqt, Aklapper, gerritbot, Mpaa, JAnD, jayvdb, valhallasw, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Updated] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt added parent tasks: T144698: Missing warning for the anti-spam filter error, T74942: replace.py display_edit_counter throws AttributeError: 'NoneType' object has no attribute 'output', T73646: replace.py: async output messages jumbled with user interaction on main thread, T132135: template.py

[Pywikipedia-bugs] [Maniphest] [Updated] T74942: replace.py display_edit_counter throws AttributeError: 'NoneType' object has no attribute 'output'

2016-11-27 Thread Xqt
Xqt added a subtask: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T74942EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Xqt, JAnD, pywikibot-bugs-list, Multichill, Mpaa, Ramalepe, Liugev6, Magul, MayS,

[Pywikipedia-bugs] [Maniphest] [Updated] T132135: template.py does not show when a page is saved

2016-11-27 Thread Xqt
Xqt added a subtask: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T132135EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: jayvdb, gerritbot, Mpaa, Aklapper, pywikibot-bugs-list, Meno25, Xqt, Ramalepe, Liugev6,

[Pywikipedia-bugs] [Maniphest] [Updated] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt removed a subtask: T73646: replace.py: async output messages jumbled with user interaction on main thread. TASK DETAILhttps://phabricator.wikimedia.org/T151727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Xqt, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Updated] T73646: replace.py: async output messages jumbled with user interaction on main thread

2016-11-27 Thread Xqt
Xqt removed a parent task: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T73646EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mpaa, XqtCc: Xqt, Aklapper, gerritbot, Mpaa, JAnD, jayvdb, valhallasw, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Updated] T73646: replace.py: async output messages jumbled with user interaction on main thread

2016-11-27 Thread Xqt
Xqt added a parent task: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T73646EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mpaa, XqtCc: Xqt, Aklapper, gerritbot, Mpaa, JAnD, jayvdb, valhallasw, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Updated] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt added a subtask: T73646: replace.py: async output messages jumbled with user interaction on main thread. TASK DETAILhttps://phabricator.wikimedia.org/T151727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Xqt, pywikibot-bugs-list, Magul,

[Pywikipedia-bugs] [Maniphest] [Updated] T57880: Functionality existing in compat but missing from core (tracking)

2016-11-27 Thread Xqt
Xqt added a subtask: T151727: Port cache_output from compat. TASK DETAILhttps://phabricator.wikimedia.org/T57880EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: binbot, Aklapper, APerson, Xqt, Nemo_bis, droid, Ricordisamoa, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Updated] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt added a parent task: T57880: Functionality existing in compat but missing from core (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T151727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Xqt, pywikibot-bugs-list, Magul, MayS,

[Pywikipedia-bugs] [Maniphest] [Triaged] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T151727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Xqt, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, jayvdb, Dalba, droid, Masti, Alchimista,

[Pywikipedia-bugs] [Maniphest] [Created] T151727: Port cache_output from compat

2016-11-27 Thread Xqt
Xqt created this task.Xqt added projects: Pywikibot-core, Pywikibot-compat-to-core, Pywikibot-General.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONcompat has some code (cache_output dict, cache_output(), flush_output_cache() methods and some others) which enables

[Pywikipedia-bugs] [Maniphest] [Commented On] T134640: site_tests.py fails for TestUserContribsWithoutUser with TimeoutError

2016-11-27 Thread Xqt
Xqt added a comment. config.py setting is a default setting for all bot users. I guess most bot task does not exceed that given limit. For these problems while testing I think it would be better to use a changed value in the private user-config.py or set that config.py value for our tests. inside

[Pywikipedia-bugs] [Maniphest] [Commented On] T151092: Change in quantities broke pywikibot

2016-11-27 Thread Lokal_Profil
Lokal_Profil added a comment. In T151092#2822773, @Wesalius wrote: But this error was raised when trying to edit wikidata. So without the site object the function cannot determine which version of Wikibase is running. So it assumes the old version... which isn't what Wikidata runs. The

[Pywikipedia-bugs] [Maniphest] [Closed] T151712: Page.purge(forcelinkupdate=None) gives a wrong result

2016-11-27 Thread Magul
Magul closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T151712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MagulCc: gerritbot, Ricordisamoa, Aklapper, Xqt, pywikibot-bugs-list, Ramalepe, Liugev6, Magul, MayS, Lewizho99,

[Pywikipedia-bugs] [Maniphest] [Commented On] T151712: Page.purge(forcelinkupdate=None) gives a wrong result

2016-11-27 Thread gerritbot
gerritbot added a comment. Change 323686 merged by jenkins-bot: [bugfix] Fix purgepages() result https://gerrit.wikimedia.org/r/323686TASK DETAILhttps://phabricator.wikimedia.org/T151712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T151706: WbQuantity now expects a 'site' parameter

2016-11-27 Thread Magul
Magul added a comment. I believe there is other issue here. The WbQuantity now expects a 'site' parameter. This is needed to ensure correct handling of error bounds. is just a warning. After this warning code goes here: if error is None: self.upperBound = self.lowerBound = Decimal(0) elif

[Pywikipedia-bugs] [Maniphest] [Commented On] T151677: FamilyMaintenanceWarning: Family name wikimediachapter does not match family module name wikimedia

2016-11-27 Thread Magul
Magul added a comment. Ok, I have digg into this issue and it looks, that You're mixing unicode with str here. I would assume that it happened here: rowi=unicode(str(row[0]),'UTF-8') but it's something that You need to check. I could only suggest that You're loosing decode('cp1256') somehere. I'm

[Pywikipedia-bugs] [Maniphest] [Closed] T151677: FamilyMaintenanceWarning: Family name wikimediachapter does not match family module name wikimedia

2016-11-27 Thread Magul
Magul closed this task as "Invalid". TASK DETAILhttps://phabricator.wikimedia.org/T151677EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: Magul, Aklapper, pywikibot-bugs-list, Jar, MayS, Mdupont, JJMC89, jayvdb, Dalba, Masti, Alchimista,

[Pywikipedia-bugs] [Maniphest] [Updated] T151712: Page.purge(forcelinkupdate=None) gives a wrong result

2016-11-27 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T151712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Ricordisamoa, Aklapper, Xqt, pywikibot-bugs-list, Ramalepe, Liugev6, Magul, MayS,

[Pywikipedia-bugs] [Maniphest] [Commented On] T151712: Page.purge(forcelinkupdate=None) gives a wrong result

2016-11-27 Thread gerritbot
gerritbot added a comment. Change 323686 had a related patch set uploaded (by Xqt): [bugfix] Fix purgepages() result https://gerrit.wikimedia.org/r/323686TASK DETAILhttps://phabricator.wikimedia.org/T151712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt,

[Pywikipedia-bugs] [Maniphest] [Triaged] T151712: Page.purge(forcelinkupdate=None) gives a wrong result

2016-11-27 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T151712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Ricordisamoa, Aklapper, Xqt, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, jayvdb, Dalba, Masti,

[Pywikipedia-bugs] [Maniphest] [Created] T151712: Page.purge(forcelinkupdate=None) gives a wrong result

2016-11-27 Thread Xqt
Xqt created this task.Xqt added projects: Pywikibot-core, Pywikibot-General.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONPage.purge(forcelinkupdate=None) returns always False because site.purgepages() wrongly assumes that forcelinkupdate is set but api.py removes

[Pywikipedia-bugs] [Maniphest] [Commented On] T151677: FamilyMaintenanceWarning: Family name wikimediachapter does not match family module name wikimedia

2016-11-27 Thread Magul
Magul added a comment. @Jar I just used some of Your edits and created simple script: # -*- coding: utf-8 -*- import pywikibot as pwb site = pwb.getSite("ar") address = u'مستخدم:MagulBot' message = u'مستخدم' text=u""" {{إحصاء}} تعرض هذه الصفحة قائمة الـ500 [[وب:ويكيبيديون|ويكيبيدي]]

[Pywikipedia-bugs] [Maniphest] [Commented On] T151677: FamilyMaintenanceWarning: Family name wikimediachapter does not match family module name wikimedia

2016-11-27 Thread Magul
Magul added a comment. @Jar I still don't know how You installed it?TASK DETAILhttps://phabricator.wikimedia.org/T151677EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: Magul, Aklapper, pywikibot-bugs-list, Jar, MayS, Mdupont, JJMC89, jayvdb, Dalba,

[Pywikipedia-bugs] [Maniphest] [Commented On] T151677: FamilyMaintenanceWarning: Family name wikimediachapter does not match family module name wikimedia

2016-11-27 Thread Magul
Magul added a comment. @Jar I was trying to recreate Your issue with this warning and wasn't able to do so. I assume that it caused by import family at the top of Your script. I don't have such module in fresh #pywikibot-core code, so I was getting ImportError: No module named family. After

[Pywikipedia-bugs] [Maniphest] [Commented On] T151706: WbQuantity now expects a 'site' parameter

2016-11-27 Thread Dalba
Dalba added a comment. @Wesalius Does the following change resolve your issue? https://gerrit.wikimedia.org/r/#/c/322672/3/tests/wikibase_tests.pyTASK DETAILhttps://phabricator.wikimedia.org/T151706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc:

[Pywikipedia-bugs] [Maniphest] [Created] T151706: WbQuantity now expects a 'site' parameter

2016-11-27 Thread Wesalius
Wesalius created this task.Wesalius added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONNow when writing statements to wd using pwb I get WbQuantity now expects a 'site' parameter. This is needed to ensure correct handling of error bounds.

[Pywikipedia-bugs] [Maniphest] [Closed] T98707: Replace.py does not catch exceptions when saving

2016-11-27 Thread Magul
Magul closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T98707EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: gerritbot, Xqt, binbot, jayvdb, pywikibot-bugs-list, Aklapper, Mpaa, Ramalepe, Liugev6, Magul, MayS, Lewizho99,