Ari Sundholm writes:
> Hi,
>
> On 9/11/20 11:03 AM, Markus Armbruster wrote:
>> Ari Sundholm writes:
>>
>>> Hi Vladimir!
>>>
>>> Thank you for working on this. My comments below.
>>>
>>> On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote:
It's simple to avoid error propagation in
Hi,
On 9/11/20 11:03 AM, Markus Armbruster wrote:
Ari Sundholm writes:
Hi Vladimir!
Thank you for working on this. My comments below.
On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote:
It's simple to avoid error propagation in blk_log_writes_open(), we
just need to refactor
Greg Kurz writes:
> On Fri, 11 Sep 2020 07:30:37 +0200
> Markus Armbruster wrote:
[...]
>> No, the patch is okay as is.
>>
>> Dumbing it down to keep it simple would also be okay.
>>
>
> What about Ari's proposal to add ERRP_GUARD() and check errors
> with "if (*errp)" like we do for void
Ari Sundholm writes:
> Hi Vladimir!
>
> Thank you for working on this. My comments below.
>
> On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote:
>> It's simple to avoid error propagation in blk_log_writes_open(), we
>> just need to refactor blk_log_writes_find_cur_log_sector() a bit.
>>
On Fri, 11 Sep 2020 07:30:37 +0200
Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Greg Kurz writes:
> >
> >> On Wed, 9 Sep 2020 21:59:23 +0300
> >> Vladimir Sementsov-Ogievskiy wrote:
> >>
> >>> It's simple to avoid error propagation in blk_log_writes_open(), we
> >>> just need
Markus Armbruster writes:
> Greg Kurz writes:
>
>> On Wed, 9 Sep 2020 21:59:23 +0300
>> Vladimir Sementsov-Ogievskiy wrote:
>>
>>> It's simple to avoid error propagation in blk_log_writes_open(), we
>>> just need to refactor blk_log_writes_find_cur_log_sector() a bit.
>>>
>>> Signed-off-by:
Greg Kurz writes:
> On Wed, 9 Sep 2020 21:59:23 +0300
> Vladimir Sementsov-Ogievskiy wrote:
>
>> It's simple to avoid error propagation in blk_log_writes_open(), we
>> just need to refactor blk_log_writes_find_cur_log_sector() a bit.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
Hi Vladimir!
Thank you for working on this. My comments below.
On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote:
It's simple to avoid error propagation in blk_log_writes_open(), we
just need to refactor blk_log_writes_find_cur_log_sector() a bit.
Signed-off-by: Vladimir
On Wed, 9 Sep 2020 21:59:23 +0300
Vladimir Sementsov-Ogievskiy wrote:
> It's simple to avoid error propagation in blk_log_writes_open(), we
> just need to refactor blk_log_writes_find_cur_log_sector() a bit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/blklogwrites.c | 23
It's simple to avoid error propagation in blk_log_writes_open(), we
just need to refactor blk_log_writes_find_cur_log_sector() a bit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/blklogwrites.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git
10 matches
Mail list logo