Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-17 Thread Markus Armbruster
Ari Sundholm writes: > Hi, > > On 9/11/20 11:03 AM, Markus Armbruster wrote: >> Ari Sundholm writes: >> >>> Hi Vladimir! >>> >>> Thank you for working on this. My comments below. >>> >>> On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: It's simple to avoid error propagation in

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-16 Thread Ari Sundholm
Hi, On 9/11/20 11:03 AM, Markus Armbruster wrote: Ari Sundholm writes: Hi Vladimir! Thank you for working on this. My comments below. On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: It's simple to avoid error propagation in blk_log_writes_open(), we just need to refactor

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-11 Thread Markus Armbruster
Greg Kurz writes: > On Fri, 11 Sep 2020 07:30:37 +0200 > Markus Armbruster wrote: [...] >> No, the patch is okay as is. >> >> Dumbing it down to keep it simple would also be okay. >> > > What about Ari's proposal to add ERRP_GUARD() and check errors > with "if (*errp)" like we do for void

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-11 Thread Markus Armbruster
Ari Sundholm writes: > Hi Vladimir! > > Thank you for working on this. My comments below. > > On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: >> It's simple to avoid error propagation in blk_log_writes_open(), we >> just need to refactor blk_log_writes_find_cur_log_sector() a bit. >>

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-11 Thread Greg Kurz
On Fri, 11 Sep 2020 07:30:37 +0200 Markus Armbruster wrote: > Markus Armbruster writes: > > > Greg Kurz writes: > > > >> On Wed, 9 Sep 2020 21:59:23 +0300 > >> Vladimir Sementsov-Ogievskiy wrote: > >> > >>> It's simple to avoid error propagation in blk_log_writes_open(), we > >>> just need

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-10 Thread Markus Armbruster
Markus Armbruster writes: > Greg Kurz writes: > >> On Wed, 9 Sep 2020 21:59:23 +0300 >> Vladimir Sementsov-Ogievskiy wrote: >> >>> It's simple to avoid error propagation in blk_log_writes_open(), we >>> just need to refactor blk_log_writes_find_cur_log_sector() a bit. >>> >>> Signed-off-by:

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-10 Thread Markus Armbruster
Greg Kurz writes: > On Wed, 9 Sep 2020 21:59:23 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> It's simple to avoid error propagation in blk_log_writes_open(), we >> just need to refactor blk_log_writes_find_cur_log_sector() a bit. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> ---

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-10 Thread Ari Sundholm
Hi Vladimir! Thank you for working on this. My comments below. On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: It's simple to avoid error propagation in blk_log_writes_open(), we just need to refactor blk_log_writes_find_cur_log_sector() a bit. Signed-off-by: Vladimir

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-10 Thread Greg Kurz
On Wed, 9 Sep 2020 21:59:23 +0300 Vladimir Sementsov-Ogievskiy wrote: > It's simple to avoid error propagation in blk_log_writes_open(), we > just need to refactor blk_log_writes_find_cur_log_sector() a bit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/blklogwrites.c | 23

[PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's simple to avoid error propagation in blk_log_writes_open(), we just need to refactor blk_log_writes_find_cur_log_sector() a bit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/blklogwrites.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git