Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-21 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: On 21 May 2015 at 12:09, Markus Armbruster arm...@redhat.com wrote: Kevin Wolf kw...@redhat.com writes: Am 21.05.2015 um 12:11 hat Peter Maydell geschrieben: 2b add a subsection, send the subsection always in new qemu, if receiving from

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-21 Thread Peter Maydell
On 21 May 2015 at 10:42, Kevin Wolf kw...@redhat.com wrote: Am 20.05.2015 um 14:07 hat Peter Maydell geschrieben: On 20 May 2015 at 12:55, John Snow js...@redhat.com wrote: So even if /currently/ we can reconstitute it from the register values, we may eventually be unable to. post_load

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-20 Thread John Snow
On 05/20/2015 05:24 AM, Peter Maydell wrote: On 20 May 2015 at 09:43, Kevin Wolf kw...@redhat.com wrote: Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: That handles migration, which is good. But I still think that storing the same information in two places in the device state (phase

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-20 Thread Kevin Wolf
Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: On 20 May 2015 at 08:54, Kevin Wolf kw...@redhat.com wrote: Am 19.05.2015 um 22:57 hat Peter Maydell geschrieben: Yeah, if there's genuinely an underlying state machine that's not completely visible in registers you need to actually

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 09:43, Kevin Wolf kw...@redhat.com wrote: Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: That handles migration, which is good. But I still think that storing the same information in two places in the device state (phase field and the register fields) is error-prone.

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-19 Thread Peter Maydell
On 19 May 2015 at 21:52, John Snow js...@redhat.com wrote: Hmm, I think this is not purely derived state because the flags are not necessarily sufficient for regenerating that state. Yeah, if there's genuinely an underlying state machine that's not completely visible in registers you need to

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-19 Thread John Snow
On 05/19/2015 11:35 AM, Kevin Wolf wrote: The floppy controller spec describes three different controller phases, which are currently not explicitly modelled in our emulation. Instead, each phase is represented by a combination of flags in registers. This patch makes explicit in which

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-19 Thread Peter Maydell
On 19 May 2015 at 16:35, Kevin Wolf kw...@redhat.com wrote: The floppy controller spec describes three different controller phases, which are currently not explicitly modelled in our emulation. Instead, each phase is represented by a combination of flags in registers. This patch makes