Hi
On Fri, Mar 29, 2024 at 12:35 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 28.03.24 13:20, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > ../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized
> > [-Werror=maybe-uninitialized]
> >
On 27/3/24 20:27, Kevin Wolf wrote:
Coverity complains that the check introduced in commit 3f934817 suggests
that qiov could be NULL and we dereference it before reaching the check.
In fact, all of the callers pass a non-NULL pointer, so just remove the
misleading check.
Resolves: Coverity CID
Hi
On Thu, Mar 28, 2024 at 3:31 PM Philippe Mathieu-Daudé
wrote:
>
> On 28/3/24 11:20, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > ../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized
> > [-Werror=maybe-uninitialized]
> >
> > False-positive, because
On Mar 28 14:20, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized
> [-Werror=maybe-uninitialized]
>
> It's not obvious that 'result' is set in all code paths. When is
> a returned argument, it's even less
On 02.04.24 12:12, Marc-André Lureau wrote:
Hi
On Fri, Mar 29, 2024 at 12:35 PM Vladimir Sementsov-Ogievskiy
wrote:
On 28.03.24 13:20, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized
From: Marc-André Lureau
../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized
[-Werror=maybe-uninitialized]
It's not obvious that 'result' is set in all code paths. When is
a returned argument, it's even less clear.
Looking at various assignments, 0 seems to be a suitable
The CONFIG_SOFTMMU_GATE definition was never used, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Richard Henderson
Message-Id: <20240313213339.82071-2-phi...@linaro.org>
---
accel/tcg/plugin-gen.c | 6 --
1 file changed, 6 deletions(-)
diff --git
From: Yajun Wu
When vhost-user or vhost-kernel is handling virtio net datapath,
QEMU should not touch used ring.
But with vhost-user socket reconnect scenario, in a very rare case
(has pending kick event). VRING_USED_F_NO_NOTIFY is set by QEMU in
following code path:
#0
From: Artem Chernyshev
In xen_evtchn_soft_reset() variable flush_kvm_routes can
be used before being initialized.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Oleg Sviridov
Signed-off-by: Artem Chernyshev
Reviewed-by: Philippe Mathieu-Daudé
Message-ID:
CXL is based on PCIe. In is pointless to initialize
its context on non-PCI machines.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Jonathan Cameron
Message-ID: <20240327161642.33574-1-phi...@linaro.org>
---
hw/i386/pc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Am 02.04.2024 um 12:53 hat Philippe Mathieu-Daudé geschrieben:
> On 27/3/24 20:27, Kevin Wolf wrote:
> > Coverity complains that the check introduced in commit 3f934817 suggests
> > that qiov could be NULL and we dereference it before reaching the check.
> > In fact, all of the callers pass a
Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using
inlined functions with external linkage"):
None of our code base require / use inlined functions with external
linkage. Some places use internal inlining in the hot path. These
two functions are certainly not in any hot path
Since size_to_prdtl() is only used within ahci.c,
declare it statically. This removes the last use
of "inlined function with external linkage". See
previous commit and commit 9de9fa5cf2 for rationale.
Suggested-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
From: Glenn Miles
It was noticed that my linux.vnet.ibm.com address does not
always work so dropping the vnet to see if that works better.
Signed-off-by: Glenn Miles
Message-ID: <20240328194914.2145709-1-mil...@linux.vnet.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 +-
From: Zhao Liu
The commit 15002f60f792 ("util: rename qemu-error.c to match its header
name") renamed util/qemu-error.c to util/error-report.c but missed to
change the corresponding entry.
To avoid get_maintainer.pl failing, update the error-report.c entry.
Fixes: 15002f60f7 ("util: rename
On Tue, Apr 02, 2024 at 12:58:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > Again, same false-positives, because of WITH_GRAPH_RDLOCK_GUARD()..
> > >
> > > Didn't you try to change WITH_ macros somehow, so that compiler believe
> > > in our good intentions?
> > >
> >
> >
> > #define
On Tue, 2 Apr 2024 at 15:25, Philippe Mathieu-Daudé wrote:
>
> The following changes since commit 7fcf7575f3d201fc84ae168017ffdfd6c86257a6:
>
> Merge tag 'pull-target-arm-20240402' of
> https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-04-02
&
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Richard Henderson
Message-Id: <20240313213339.82071-3-phi...@linaro.org>
---
gdbstub/internals.h | 20 ++--
gdbstub/system.c| 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git
Unify with other init_excp_FOO() in the same file.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Nicholas Piggin
Message-Id: <20240313213339.82071-5-phi...@linaro.org>
---
target/ppc/cpu_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/ppc/cpu_init.c
The following changes since commit 7fcf7575f3d201fc84ae168017ffdfd6c86257a6:
Merge tag 'pull-target-arm-20240402' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-04-02
11:34:49 +0100)
are available in the Git repository at:
https://github.com/philmd/qemu.git tags/hw
From: Marc-André Lureau
../plugins/loader.c:405:15: error: ‘ctx’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
Reviewed-by: Pierrick Bouvier
Message-ID: <20240328102052.3499331-15-marcandre.lur...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
On Mon, 1 Apr 2024 11:33:09AM -0500, Eric Blake wrote:
> On Mon, Apr 01, 2024 at 08:41:20PM +0800, Zhu Yangyang wrote:
> > Coroutines are not supposed to block. Instead, they should yield.
> >
> > Fixes: f95910f ("nbd: implement TLS support in the protocol negotiation")
> > Signed-off-by: Zhu
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20240313213339.82071-4-phi...@linaro.org>
---
gdbstub/internals.h | 8
gdbstub/system.c| 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdbstub/internals.h
See previous commit and commit 9de9fa5cf2 ("Avoid using inlined
functions with external linkage") for rationale.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Richard Henderson
Message-Id: <20240313184954.42513-3-phi...@linaro.org>
---
target/arm/hvf/hvf.c | 2
From: Kevin Wolf
Coverity complains that the check introduced in commit 3f934817 suggests
that qiov could be NULL and we dereference it before reaching the check.
In fact, all of the callers pass a non-NULL pointer, so just remove the
misleading check.
Resolves: Coverity CID 1542668
On 02.04.24 18:34, Eric Blake wrote:
On Tue, Apr 02, 2024 at 12:58:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Again, same false-positives, because of WITH_GRAPH_RDLOCK_GUARD()..
Didn't you try to change WITH_ macros somehow, so that compiler believe in our
good intentions?
#define
On 07.03.24 16:47, Fiona Ebner wrote:
From: John Snow
for the mirror job. The bitmap's granularity is used as the job's
granularity.
The new @bitmap parameter is marked unstable in the QAPI and can
currently only be used for @sync=full mode.
Clusters initially dirty in the bitmap as well as
On Thu, Mar 28, 2024 at 02:20:46PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../hw/block/virtio-blk.c:1212:12: error: ‘rq’ may be used uninitialized
> [-Werror=maybe-uninitialized]
>
> Signed-off-by: Marc-André Lureau
> ---
> hw/block/virtio-blk.c | 2 +-
> 1
On Mon, Apr 01, 2024 at 11:26:25PM +0200, Yu Zhang wrote:
> Hello Peter und Zhjian,
>
> Thank you so much for letting me know about this. I'm also a bit surprised at
> the plan for deprecating the RDMA migration subsystem.
It's not too late, since it looks like we do have users not yet notified
On Thu, Mar 28, 2024 at 02:20:34PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../util/qemu-coroutine.c:150:8: error: ‘batch’ may be used uninitialized
> [-Werror=maybe-uninitialized]
>
> Signed-off-by: Marc-André Lureau
> ---
> util/qemu-coroutine.c | 2 +-
> 1
30 matches
Mail list logo
