Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Fam Zheng
On Wed, 04/01 12:42, Bin Wu wrote: From: Bin Wu wu.wu...@huawei.com What's the issue are you fixing? I think the coroutine already is running in the AioContext of bs. Fam Signed-off-by: Bin Wu wu.wu...@huawei.com --- block/mirror.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-block] block-commit dropping privs

2015-04-01 Thread Michael Tokarev
30.03.2015 18:36, Kevin Wolf wrote: Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: On 03/27/2015 09:36 AM, Michael Tokarev wrote: Wonder how to specify cache mode, or should I open these with proper O_DIRECT/O_SYNC/whatever? It looks like it's possible to change O_DIRECT at runtime but

Re: [Qemu-block] block-commit dropping privs

2015-04-01 Thread Michael Tokarev
01.04.2015 12:26, Michael Tokarev пишет: 30.03.2015 18:36, Kevin Wolf wrote: Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: On 03/27/2015 09:36 AM, Michael Tokarev wrote: Wonder how to specify cache mode, or should I open these with proper O_DIRECT/O_SYNC/whatever? It looks like it's

Re: [Qemu-block] block-commit dropping privs

2015-04-01 Thread Kevin Wolf
Am 01.04.2015 um 11:54 hat Michael Tokarev geschrieben: 01.04.2015 12:26, Michael Tokarev пишет: 30.03.2015 18:36, Kevin Wolf wrote: Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: On 03/27/2015 09:36 AM, Michael Tokarev wrote: Wonder how to specify cache mode, or should I open these

Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Stefan Hajnoczi
On Wed, Apr 01, 2015 at 04:49:39PM +0800, Bin Wu wrote: On 2015/4/1 16:19, Fam Zheng wrote: On Wed, 04/01 12:42, Bin Wu wrote: From: Bin Wu wu.wu...@huawei.com What's the issue are you fixing? I think the coroutine already is running in the AioContext of bs. Fam In the

Re: [Qemu-block] [PATCH v2 0/3] null driver patches

2015-04-01 Thread Stefan Hajnoczi
On Wed, Apr 01, 2015 at 09:45:37AM +0800, Fam Zheng wrote: v2: Change patch 01 to use realtime clock, that way we don't need to check the VCPU state. [Stefan] Added Eric's rev-by in 23. Change title to Null block driver in 3. [Eric] The second patch allows testing commit to a

[Qemu-block] qemu-img behavior for locating backing files

2015-04-01 Thread John Snow
Kevin, what's the correct behavior for qemu-img and relative paths when creating a new qcow2 file? Example: (in e.g. /home/qemu/build/ or anywhere not /home: ) qemu-img create -f qcow2 base.qcow2 32G qemu-img create -f qcow2 -F qcow2 -b base.qcow2 /home/overlay.qcow2 In 1.7.0., this produces

Re: [Qemu-block] [Qemu-devel] qemu-img behavior for locating backing files

2015-04-01 Thread Eric Blake
On 04/01/2015 10:16 AM, John Snow wrote: Kevin, what's the correct behavior for qemu-img and relative paths when creating a new qcow2 file? Example: (in e.g. /home/qemu/build/ or anywhere not /home: ) qemu-img create -f qcow2 base.qcow2 32G creates /home/qemu/build/base.qcow2 qemu-img

Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Bin Wu
On 2015/4/1 19:59, Stefan Hajnoczi wrote: On Wed, Apr 01, 2015 at 04:49:39PM +0800, Bin Wu wrote: On 2015/4/1 16:19, Fam Zheng wrote: On Wed, 04/01 12:42, Bin Wu wrote: From: Bin Wu wu.wu...@huawei.com What's the issue are you fixing? I think the coroutine already is running in the