[Qemu-block] [PATCH for-2.5 0/1] blockdev: Mark {insert, remove}-medium experimental

designs). Can you please apply this patch directly? I am sorry for the inconvencience. Max Max Reitz (1): blockdev: Mark {insert,remove}-medium experimental blockdev.c | 10 +- qapi/block-core.json | 18 -- qmp-commands.hx| 24

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

On 2015-12-11 at 16:40, Peter Maydell wrote: On 11 December 2015 at 15:30, Eric Blake <ebl...@redhat.com> wrote: On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium +x-blockdev-remove-medium -- Formatting nit, but not worth holding t

[Qemu-block] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

blockdev-{insert,remove}-medium can be considered completely stable. Therefore, mark these functions experimental for the time being. Suggested-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Max Reitz <mre...@redhat.com> Acked-by: Markus Armbruster <arm...@redhat.com> Acked-

Re: [Qemu-block] [PATCH v2 3/4] qemu-img: abort when full_backing_filename not present

u-img.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v2 2/4] block/qapi: always report full_backing_filename

On 12.12.2015 02:25, John Snow wrote: > Always report full_backing_filename, even if it's the same as > backing_filename. In the next patch, full_backing_filename may be > omitted if it cannot be generated instead of allowing e.g. drive_query > to abort if it runs into this scenario. > > The

Re: [Qemu-block] [PATCH v2 2/4] block/qapi: always report full_backing_filename

On 14.12.2015 17:38, John Snow wrote: > > > On 12/14/2015 11:36 AM, Max Reitz wrote: >> On 12.12.2015 02:25, John Snow wrote: >>> Always report full_backing_filename, even if it's the same as >>> backing_filename. In the next patch, full_backing_filenam

Re: [Qemu-block] [PATCH v2 4/4] block/qapi: allow best-effort query

| 7 --- > tests/qemu-iotests/110.out | 5 - > 2 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v2 0/4] block: allow partial info-block query

On 12.12.2015 02:25, John Snow wrote: > Max: Did you have in mind something like this? What I had in mind was fixing the whole thing (the test case in 110 should actually work just fine, because you can easily determine the base directory to be used). ;-) I've been working on that myself anyway,

Re: [Qemu-block] [PATCH v3 5/5] block/qapi: allow best-effort query

| 7 --- > tests/qemu-iotests/110.out | 5 - > 2 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

+++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

On 14.12.2015 20:55, John Snow wrote: > Disambiguate "Backing filename and full backing filename" are equivalent Just noticed: R-b is assuming s/" are equivalent/ are equivalent"/. Max > from "full backing filename could not be determined." > > Signed-off-by: John Snow > ---

Re: [Qemu-block] [PATCH v3 0/5] block: allow partial info-block query

On 14.12.2015 20:55, John Snow wrote: > Allow info-block to succeed even when it cannot reconstruct filenames, > but be explicit about this failure. Utilities that rely on the current > behavior are modified to report this explicit failure to users. > > v3: > - Fix qemu-img output such that

Re: [Qemu-block] [PATCH v4 11/14] vmdk: Return extent's file in bdrv_get_block_status

On 24.12.2015 06:50, Fam Zheng wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index f5a56fd..b60a5af

Re: [Qemu-block] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions

On 24.12.2015 06:50, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. It's value should be ignored unless *Its > BDRV_BLOCK_OFFSET_VALID in ret is set. > > Until block drivers fill in the right value, let's clear it

Re: [Qemu-block] [PATCH v4 00/14] qemu-img map: Allow driver to return file of the allocated block

On 24.12.2015 06:50, Fam Zheng wrote: > v4: Rebase and resend, adding Eric's and Stefan's reviewed-by. > > Fix one typo in patch 13. > > Drop previous patch 14 for a later rework because it is not a hard > requirement, but it is pending on Eric's QAPI-to-JSON visitor series: > >

Re: [Qemu-block] [PATCH v4 4/5] qmp: Add blockdev-mirror command

+++ > qapi/block-core.json | 48 > qmp-commands.hx | 50 +- > 3 files changed, 159 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v9 1/2] mirror: Rewrite mirror_iteration

On 05.01.2016 09:46, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > >

Re: [Qemu-block] [PATCH v9 1/2] mirror: Rewrite mirror_iteration

On 05.01.2016 09:46, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > >

Re: [Qemu-block] [PATCH v4 0/5] qmp: Add blockdev-mirror

On 24.12.2015 05:45, Fam Zheng wrote: > v4: 02: Add Max's rev-by. > 04: buf_size -> buf-size. > Add Markus' Ack-by. > 05: 'node1' -> qmp_target. > Fix double quotes. > Add Max's Rev-by. > > v3: Rebase to master. > > v2: 01: Move bdrv_op_block_all down. [Max] >

Re: [Qemu-block] [PATCH v5 12/15] block: Remove the "bs->file" test in bdrv_co_get_block_status

On 05.01.2016 09:11, Fam Zheng wrote: > Now that all drivers return the right "file" pointer, we can remove this > check. > > Signed-off-by: Fam Zheng > --- > block/io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/io.c b/block/io.c > index

Re: [Qemu-block] [PATCH v5 01/15] block: Add "file" output parameter to block status query functions

On 05.01.2016 09:11, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. Its value should be ignored unless > BDRV_BLOCK_OFFSET_VALID in ret is set. > > Until block drivers fill in the right value, let's clear it explicitly >

Re: [Qemu-block] [PATCH v5 11/15] vmdk: Return extent's file in bdrv_get_block_status

On 05.01.2016 09:11, Fam Zheng wrote: > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > block/vmdk.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking

On 24.12.2015 06:41, Denis V. Lunev wrote: > On 12/24/2015 02:19 AM, Max Reitz wrote: >> So the benefits of a qcow2 flag are only minor ones. However, I >> personally believe that automatic unlock on crash is a very minor >> benefit as well. That should never happ

[Qemu-block] [PULL 16/21] qemu-iotests: s390x: fix test 051

uted for s390x platform. Signed-off-by: Bo Tu <t...@linux.vnet.ibm.com> Message-id: 1451885360-20236-2-git-send-email-t...@linux.vnet.ibm.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/051| 32 tests/qemu-iotests/051.out| 70 +++

[Qemu-block] [PULL 05/21] iotests: 018: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-2-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/018 | 8

[Qemu-block] [PULL 03/21] block: use drained section in bdrv_close

.@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- block.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 411edbf..01655de 100644 --- a/block.c +++ b/block.c @@ -2154,9 +2154,10 @@ void bdrv_close(BlockDriverState *bs) bdrv_io

[Qemu-block] [PULL 11/21] iotests: 037: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-8-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/037 | 5 - te

[Qemu-block] [PULL 09/21] iotests: 028: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-6-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/028 | 5 - te

[Qemu-block] [PULL 19/21] block: Add check on mirror target

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450932306-13717-4-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- blockdev.c| 3 +++ includ

[Qemu-block] [PULL 14/21] iotests: 095: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Message-id: 1450752561-9300-11-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/095 | 6 ++ tests/qemu-iotests/095.out | 4 ++-- 2 files cha

[Qemu-block] [PULL 13/21] iotests: 050: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-10-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/050 | 9 +++--

[Qemu-block] [PULL 02/21] qemu-iotests: make check-block.sh work on out-of-tree builds

4-05-24). So, it is wrong to invoke "check" from the source path like check-block.sh does. Fix it. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 1450867341-11100-1-git-send-email-pbonz...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/ch

[Qemu-block] [PULL 01/21] iotests: 086: Add raw format

From: Fam Zheng <f...@redhat.com> Raw is as qualified as qcow2 for this test case, add it for more coverage. Signed-off-by: Fam Zheng <f...@redhat.com> Message-id: 1450851979-15580-1-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iot

[Qemu-block] [PULL 20/21] qmp: Add blockdev-mirror command

nsible for assigning a name to the new node, so we don't have 'node-name' parameter. Signed-off-by: Fam Zheng <f...@redhat.com> Acked-by: Markus Armbruster <arm...@redhat.com> Message-id: 1450932306-13717-5-git-send-email-f...@redhat.com Reviewed-by: Max Reitz <mre...@redhat.com> Signe

[Qemu-block] [PULL 15/21] iotests: 095: Filter _img_info output

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Message-id: 1450752561-9300-12-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/095 | 4 ++-- tests/qemu-iotests/095.out | 2 -- 2 files changed,

[Qemu-block] [PULL 06/21] iotests: 019: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-3-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/019 | 13 +++--

[Qemu-block] [PULL 12/21] iotests: 038: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-9-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/038 | 5 - te

[Qemu-block] [PULL 18/21] block: Extract blockdev part of qmp_drive_mirror

From: Fam Zheng <f...@redhat.com> This is the part that will be reused by blockdev-mirror. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450932306-13717-3-git-send-email-f...@redhat.com Signed-off-by: Max Reitz

[Qemu-block] [PULL 10/21] iotests: 034: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-7-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/034 | 6 +- te

[Qemu-block] [PULL 08/21] iotests: 024: Use TEST_IMG override instead of "mv"

From: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1450752561-9300-5-git-send-email-f...@redhat.com Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/024 | 10 --

Re: [Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On 29.12.2015 01:27, Programmingkid wrote: > I do realize you are busy Kevin, but I would > appreciate knowing my patch is in line > for review. Primarily, he's been on holiday since before christmas until next week. (I'm telling you so you don't wonder why nothing happens.) Max

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 07.01.2016 22:42, Peter Maydell wrote: > On 7 January 2016 at 20:14, Max Reitz <mre...@redhat.com> wrote: >> On 07.01.2016 20:56, Peter Maydell wrote: >>> It looks like sd.c is the only one which implements a change_media_cb >>> but no is_tray_open, but it wo

Re: [Qemu-block] [PATCH 1/2] nbd: do not check request length except for reads and writes

e Wheeler <sits...@yahoo.com> > Cc: qemu-block@nongnu.org > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > nbd.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH 2/2] nbd: do not exit on failed memory allocation

in that case. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > block/block-backend.c | 5 + > include/sysemu/block-backend.h | 1 + > nbd.c | 6 +- > 3 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Max Rei

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 07.01.2016 23:19, Peter Maydell wrote: > On 7 January 2016 at 21:57, Max Reitz <mre...@redhat.com> wrote: >> On 07.01.2016 22:42, Peter Maydell wrote: >>> Well, previously sd.c didn't need to have any state for this >>> to all work right (or indeed care about im

[Qemu-block] [PATCH 0/2] block/vhdx: Small cleanups

Just some bits I discovered while going through the Coverity report. (The issue reported by Coverity actually was not an issue.) Max Reitz (2): vhdx: DIV_ROUND_UP() in vhdx_calc_bat_entries() vhdx: Simplify vhdx_set_shift_bits() block/vhdx.c | 18 ++ 1 file changed, 6

[Qemu-block] [PATCH 1/2] vhdx: DIV_ROUND_UP() in vhdx_calc_bat_entries()

We have DIV_ROUND_UP(), so we can use it to produce more easily readable code. It may be slower than the bit shifting currently performed (because it actually performs a division), but since vhdx_calc_bat_entries() is never used in a hot path, this is completely fine. Signed-off-by: Max Reitz

Re: [Qemu-block] [PATCH 10/10] iotests: 095: Use TEST_IMG override instead of "mv"

On 16.12.2015 10:54, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/095 | 12 ++-- > tests/qemu-iotests/095.out | 8 > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/tests/qemu-iotests/095

Re: [Qemu-block] [PATCH v6 1/2] mirror: Rewrite mirror_iteration

On 20.11.2015 11:12, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > >

Re: [Qemu-block] [PATCH v6 2/2] mirror: Add mirror_wait_for_io

On 20.11.2015 11:12, Fam Zheng wrote: > The three lines are duplicated a number of times now, refactor a > function. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > block/mirror.c | 24 > 1 file changed, 12 insertions(+), 12 deletions

[Qemu-block] [PATCH 2/2] vhdx: Simplify vhdx_set_shift_bits()

For values which are powers of two (and we do assume all of these to be), sizeof(x) * 8 - 1 - clz(x) == ctz(x). Therefore, use ctz(). Signed-off-by: Max Reitz <mre...@redhat.com> --- block/vhdx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vhdx.c b

Re: [Qemu-block] [PATCH 00/10] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

gle > file, > which is not true for VMDK or the coming QBM format. On top of this, those > formats can be added to these cases later. > > The patches stems from QBM work, but I will also take a look at adding > applicable VMDK subformats once merged. > > Please review. Pa

Re: [Qemu-block] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

fix both flaws. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > block/mirror.c | 308 > +++-- > 1 file changed, 188 insertions(+), 120 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 0/5] qmp: Add blockdev-mirror

On 23.12.2015 06:59, Fam Zheng wrote: > v3: Rebase to master. Why did you drop patch 1? Max > v2: 01: Move bdrv_op_block_all down. [Max] > 02, 04: Add Max's rev-by. > 03: Check has_mode and fix "return;". [Max] > 05: Check target->blk. > Drop superfluous whitespace. [Max] >

Re: [Qemu-block] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

On 24.12.2015 01:15, Max Reitz wrote: > On 23.12.2015 05:12, Fam Zheng wrote: >> The "pnum < nb_sectors" condition in deciding whether to actually copy >> data is unnecessarily strict, and the qiov initialization is >> unnecessarily for bdrv_aio_write_zeroes a

Re: [Qemu-block] [PATCH v3 2/5] block: Extract blockdev part of qmp_drive_mirror

, 58 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 4/5] qmp: Add blockdev-mirror command

On 23.12.2015 06:59, Fam Zheng wrote: > This will start a mirror job from a named device to another named > device, its relation with drive-mirror is similar with blockdev-backup > to drive-backup. > > In blockdev-mirror, the target node should be prepared by blockdev-add, > which will be

Re: [Qemu-block] [PATCH v3 5/5] iotests: Add test cases for blockdev-mirror

On 23.12.2015 06:59, Fam Zheng wrote: > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > tests/qemu-iotests/041 | 100 > ++--- > tests/qemu-iotests/041.out | 4 +- > 2 files changed, 79 insertions(+), 25 deletions(-) Rev

Re: [Qemu-block] [PATCH] iotests: 086: Add raw format

On 23.12.2015 07:26, Fam Zheng wrote: > Raw is as qualified as qcow2 for this test case, add it for more > coverage. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/086 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree:

Re: [Qemu-block] [Qemu-devel] [PATCH] block/qapi: Clear err for further error

On 22.12.2015 15:39, John Snow wrote: > > > On 12/22/2015 05:11 AM, Fam Zheng wrote: >> Since a5002d5 (block/qapi: allow best-effort query) we don't return at >> this error, however err must be cleared before passing to >> bdrv_query_snapshot_info_list below, as required by error API. >> >>

Re: [Qemu-block] [PATCH] block: use drained section in bdrv_close

On 23.12.2015 11:48, Paolo Bonzini wrote: > bdrv_close is used when ejecting a medium. Is it still? Other than it maybe being indirectly called through bdrv_delete(), it shouldn't be. > Use a drained section to ensure > that all I/O goes to either the

Re: [Qemu-block] [PATCH] block: use drained section in bdrv_close

On 23.12.2015 22:55, Paolo Bonzini wrote: > >> On 23.12.2015 11:48, Paolo Bonzini wrote: >>> bdrv_close is used when ejecting a medium. >> >> Is it still? Other than it maybe being indirectly called through >> bdrv_delete(), it shouldn't be. > > Yes, through blk_remove_bs -> bdrv_unref ->

Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking

On 23.12.2015 04:14, Fam Zheng wrote: > On Tue, 12/22 17:46, Kevin Wolf wrote: >> Enough innocent images have died because users called 'qemu-img snapshot' >> while >> the VM was still running. Educating the users doesn't seem to be a working >> strategy, so this series adds locking to qcow2 that

Re: [Qemu-block] [PATCH v2 00/11] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

On 22.12.2015 03:49, Fam Zheng wrote: > v2: Add Max's rev-by in patches 1-9. > Fix quote bugs in patch 10 and split out _img_info filtering patch 11. > > Commit 794d00f71d fixed two "mv" commands into the TEST_IMG override approach. > There are still more occasions of "mv", this series fixes

Re: [Qemu-block] [PATCH] qemu-iotests: make check-block.sh work on out-of-tree builds

On 23.12.2015 11:42, Paolo Bonzini wrote: > Since check-block.sh, the "check" script has learnt to find the source > path. On the other hand, it expects common.env to be in the build tree > (both changes made in commit 76c7560, "configure: Enable out-of-tree > iotests", 2014-05-24). So, it is

Re: [Qemu-block] [PATCH v7 12/24] virtio-blk: Functions for op blocker management

On 25.11.2015 16:57, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Put the code for setting up and removing op blockers into an own >> function, respectively. Then, we can invoke those functions whenever a >> BDS is removed from an virt

Re: [Qemu-block] [PATCH v7 13/24] virtio-scsi: Catch BDS-BB removal/insertion

On 25.11.2015 17:03, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Make use of the BDS-BB removal and insertion notifiers to remove or set >> up, respectively, virtio-scsi's op blockers. >> >> Signed-off-by: Max Reitz <mre...@redhat.com>

Re: [Qemu-block] [PATCH v2 20/21] qemu-iotests: Test cache mode option inheritance

iotests/group | 1 + > 3 files changed, 1143 insertions(+) > create mode 100755 tests/qemu-iotests/142 > create mode 100644 tests/qemu-iotests/142.out Comments below, to make it short: With %s/bs->backing_hd/bs->backing/ and a comment about why you commented 'out | grep &quo

Re: [Qemu-block] [PATCH v7 14/24] nbd: Switch from close to eject notifier

On 30.11.2015 16:36, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> The NBD code uses the BDS close notifier to determine when a medium is >> ejected. However, now it should use the BB's BDS removal notifier for >> that instead of the BDS's close n

Re: [Qemu-block] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

On 30.11.2015 10:01, Kevin Wolf wrote: > Am 27.11.2015 um 18:58 hat Max Reitz geschrieben: >> On 23.11.2015 16:59, Kevin Wolf wrote: >>> Some drivers have nested options (e.g. blkdebug rule arrays), which >>> don't belong to a child node and shouldn't be removed. D

Re: [Qemu-block] [PATCH for-2.5] blkdebug: silence warning under qtest

On 30.11.2015 12:44, Michael S. Tsirkin wrote: > make check always outputs warnings, this > is not nice. Disable blkdebug warnings under qtest. > > Signed-off-by: Michael S. Tsirkin > --- > block/blkdebug.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-)

Re: [Qemu-block] [PATCH v7 24/24] iotests: Add test for block jobs and BDS ejection

On 30.11.2015 17:23, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Suggested-by: Paolo Bonzini <pbonz...@redhat.com> >> Signed-off-by: Max Reitz <mre...@redhat.com> >> --- >> tests/qemu-iotests/141 | 166 >> ++

Re: [Qemu-block] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120

On 20.11.2015 10:35, Fam Zheng wrote: > Otherwise, a window flashes on my desktop (built with SDL). Other > iotest cases have that. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/120 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120

On 23.11.2015 04:12, tu bo wrote: > Hi Fam, Max: > > On 11/23/2015 10:33 AM, Fam Zheng wrote: >> On Mon, 11/23 10:29, tu bo wrote: >>> Hi Max: >>> >>> On 11/21/2015 12:17 AM, Max Reitz wrote: >>>> On 20.11.2015 10:35, Fam Zheng wrote:

Re: [Qemu-block] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

On 23.11.2015 03:32, Fam Zheng wrote: > Otherwise, a window flashes on my desktop (built with SDL). Add this as > other cases have it. > > Signed-off-by: Fam Zheng > > --- > v2: Fix 119 too. [Max] > --- > tests/qemu-iotests/119 | 2 +- > tests/qemu-iotests/120 | 2 +- > 2

[Qemu-block] [PATCH 2/4] blockdev: Fix 'change' for slot devices

gt; Cc: qemu-stable <qemu-sta...@nongnu.org> Signed-off-by: Max Reitz <mre...@redhat.com> --- blockdev.c | 27 +-- qapi/block-core.json | 3 +-- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 2df0c

[Qemu-block] [PATCH 1/4] block: Add blk_dev_has_tray()

Pull out the check whether a block device has a tray from blk_dev_is_tray_open() into an own function so both attributes (whether there is a tray vs. whether that tray is open) can be queried independently. Cc: qemu-stable <qemu-sta...@nongnu.org> Signed-off-by: Max Reitz <mre...@r

[Qemu-block] [PATCH 4/4] block/qapi: Emit tray_open only if there is a tray

Signed-off-by: Max Reitz <mre...@redhat.com> --- block/qapi.c | 2 +- tests/qemu-iotests/067.out | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index 58d3975..12a0f25 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -299,7

[Qemu-block] [PATCH 0/4] blockdev: Fix 'change' for slot devices

VED events, no tray_open status, and blockdev-{open,close}-tray are optional), which is why it is not CC'd to qemu-stable; and patch 4 is more of a change in behavior than a stable-worthy fix. Max Reitz (4): block: Add blk_dev_has_tray() blockdev: Fix 'change' for slot devices Revert &qu

[Qemu-block] [PATCH 3/4] Revert "hw/block/fdc: Implement tray status"

at all, and the tray_open status returned by query-block will always be false, necessitating (different) changes to tests/fdc-test.c and iotest 118, which is why this patch is not a pure revert of said commit. Signed-off-by: Max Reitz <mre...@redhat.com> --- hw/block/fdc.c

Re: [Qemu-block] [PATCH] iotests: 095: Clean up QEMU before showing image info

On 03.06.2016 11:07, Fam Zheng wrote: > Somehow in my locking series, I missed this case where concurrent access > to an image is performed, perhaps we can remove this case independently. The patch itself is good, but this commit message will not make much sense in the git log. I'd be fine with

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

On 08.06.2016 13:28, Paolo Bonzini wrote: > > > - Original Message - >> From: "Kevin Wolf" <kw...@redhat.com> >> To: "Max Reitz" <mre...@redhat.com> >> Cc: qemu-block@nongnu.org, qemu-de...@nongnu.org, "Fam Zheng"

Re: [Qemu-block] [PATCH] block: Fix bdrv_all_delete_snapshot() error handling

correct copy remains. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/snapshot.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH] iotests: 095: Clean up QEMU before showing image info

On 03.06.2016 11:07, Fam Zheng wrote: > Somehow in my locking series, I missed this case where concurrent access > to an image is performed, perhaps we can remove this case independently. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/095 | 2 ++ > 1 file changed, 2

Re: [Qemu-block] [PATCH] iotests: 095: Clean up QEMU before showing image info

On 03.06.2016 11:07, Fam Zheng wrote: > Somehow in my locking series, I missed this case where concurrent access > to an image is performed, perhaps we can remove this case independently. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/095 | 2 ++ > 1 file changed, 2

[Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

ed to drop the source's backing file. Signed-off-by: Max Reitz <mre...@redhat.com> --- block.c| 8 block/mirror.c | 21 + 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index 16463aa..792f5dd 100644 --- a/block

Re: [Qemu-block] [PATCH v6 14/22] mirror: Disable image locking on target backing chain

On 03.06.2016 10:49, Fam Zheng wrote: > In sync=none the backing image of s->target is s->common.bs, which could > be exclusively locked, the image locking wouldn't work here. > > Later we can update completion code to lock it after the replaced node > has dropped its lock. > > Signed-off-by:

[Qemu-block] [PATCH v2 1/3] block: Allow replacement of a BDS by its overlay

change_parent_backing_link() asserts that the BDS to be replaced is not used as a backing file. However, we may want to replace a BDS by its overlay in which case that very link should not be redirected. Signed-off-by: Max Reitz <mre...@redhat.com> --- block.c | 15 ++-

[Qemu-block] [PATCH v2 0/3] block/mirror: Fix target backing BDS

Fix target backing BDS' 003/3:[] [--] 'iotests: Add test for post-mirror backing chains' Max Reitz (3): block: Allow replacement of a BDS by its overlay block/mirror: Fix target backing BDS iotests: Add test for post-mirror backing chains block.c| 23 +++-- block/mirror.c

[Qemu-block] [PATCH v2 3/3] iotests: Add test for post-mirror backing chains

Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/155 | 218 + tests/qemu-iotests/155.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 224 insertions(+) create mode 100755 tests/qemu-iotests/155 creat

[Qemu-block] [PATCH v3 2/5] block/mirror: Fix target backing BDS

shares images with the source, this may lead to multiple BDSs per physical image file. But since we cannot reliably ascertain this case, there is nothing we can do about it. Signed-off-by: Max Reitz <mre...@redhat.com> --- block.c | 8 block/mirror.c

[Qemu-block] [PATCH v3 5/5] iotests: Add test for oVirt-like storage migration

Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/156 | 174 + tests/qemu-iotests/156.out | 48 + tests/qemu-iotests/group | 1 + 3 files changed, 223 insertions(+) create mode 100755 tests/qemu-iotes

[Qemu-block] [PATCH v3 1/5] block: Allow replacement of a BDS by its overlay

et <- BlockBackend base <- source Signed-off-by: Max Reitz <mre...@redhat.com> --- block.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index f54bc25..dc76c159 100644 --- a/block.c +++ b/block.c @@ -2224,9 +2224,23 @@ void bdr

[Qemu-block] [PATCH v3 3/5] block/null: Implement bdrv_refresh_filename()

Signed-off-by: Max Reitz <mre...@redhat.com> --- block/null.c | 20 1 file changed, 20 insertions(+) diff --git a/block/null.c b/block/null.c index 396500b..b511010 100644 --- a/block/null.c +++ b/block/null.c @@ -12,6 +12,8 @@ #include "qemu/osdep.h"

[Qemu-block] [PATCH v3 4/5] iotests: Add test for post-mirror backing chains

Signed-off-by: Max Reitz <mre...@redhat.com> --- tests/qemu-iotests/155 | 263 + tests/qemu-iotests/155.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 269 insertions(+) create mode 100755 tests/qemu-iotests/155 creat

[Qemu-block] [PATCH v3 0/5] block/mirror: Fix (?) target backing BDS

s, respectively 001/5:[0005] [FC] 'block: Allow replacement of a BDS by its overlay' 002/5:[0057] [FC] 'block/mirror: Fix target backing BDS' 003/5:[down] 'block/null: Implement bdrv_refresh_filename()' 004/5:[0073] [FC] 'iotests: Add test for post-mirror backing chains' 005/5:[down] 'iotest

Re: [Qemu-block] [PATCH v3 05/15] block: Convert block job core to BlockBackend

c Blake <ebl...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > --- > block/mirror.c | 3 +++ > blockjob.c | 37 - > include/block/blockjob.h | 3 ++- > 3 files changed, 25 insertions(+), 1

Re: [Qemu-block] [PATCH v3 01/15] block: Rename blk_write_zeroes()

4 +++--- > qemu-img.c | 4 ++-- > qemu-io-cmds.c | 22 +++++++--- > 6 files changed, 30 insertions(+), 30 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 15/15] blockjob: Remove BlockJob.bs

| 1 - > include/block/blockjob.h | 1 - > qemu-img.c| 2 +- > tests/test-blockjob-txn.c | 3 ++- > 4 files changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Max Reitz <mre...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 03/15] block: Cancel jobs first in bdrv_close_all()

t;kw...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > --- > block.c | 23 ++- > blockjob.c | 13 + > include/block/blockjob.h | 7 +++

<    2   3   4   5   6   7   8   9   10   11   >