From: Cornelia Huck cornelia.h...@de.ibm.com
Handle endianness conversion for virtio-1 virtqueues correctly.
Note that dataplane now needs to be built per-target.
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Michael S
On Tue, Jun 16, 2015 at 09:08:16AM -0600, Eric Blake wrote:
On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote:
We probably should just switch everyone, this is
just to demonstrate the API usage.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
block/nfs.c | 2 +-
1 file
shmulik.ladk...@ravellosystems.com
Reviewed-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/misc/ivshmem.c| 1 -
hw/net/vmxnet3.c | 9 -
hw/scsi/megasas.c| 8
hw/scsi/vmw_pvscsi.c | 8
4 files changed, 26 deletions
We probably should just switch everyone, this is
just to demonstrate the API usage.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
block/nfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nfs.c b/block/nfs.c
index ca9e24e..de4b8c3 100644
--- a/block/nfs.c
On Fri, May 29, 2015 at 09:51:20AM +0200, Gerd Hoffmann wrote:
Make features 64bit wide everywhere. Exception: command line flags
remain 32bit and are copyed into the lower 32 host_features at
initialization time.
On migration a full 64bit guest_features field is sent if one of the
high
...@redhat.com
Cc: Gerd Hoffmann kra...@redhat.com
Cc: John Snow js...@redhat.com
Cc: Gabriel L. Somlo gso...@gmail.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Laszlo Ersek ler...@redhat.com
Reviewed-by: Michael S. Tsirkin m...@redhat.com
in the config
file),
- no -drive if=floppy,... is requested.
Cc: Markus Armbruster arm...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Gerd Hoffmann kra...@redhat.com
Cc: John Snow js...@redhat.com
Cc: Gabriel L. Somlo gso...@gmail.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Kevin Wolf
pbonz...@redhat.com
Cc: Gerd Hoffmann kra...@redhat.com
Cc: John Snow js...@redhat.com
Cc: Gabriel L. Somlo gso...@gmail.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Laszlo Ersek ler...@redhat.com
Reviewed-by: Michael S. Tsirkin m
break without explicit '-device
isa-fdc' on such boards.
Cc: Markus Armbruster arm...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Gerd Hoffmann kra...@redhat.com
Cc: John Snow js...@redhat.com
Cc: Gabriel L. Somlo gso...@gmail.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Kevin Wolf kw
On Mon, Jun 01, 2015 at 09:23:28AM +0200, Gerd Hoffmann wrote:
On Fr, 2015-05-29 at 16:53 +0200, Michael S. Tsirkin wrote:
On Fri, May 29, 2015 at 09:51:20AM +0200, Gerd Hoffmann wrote:
Make features 64bit wide everywhere. Exception: command line flags
remain 32bit and are copyed
...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Jason Wang jasow...@redhat.com
Reviewed-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Paolo Bonzini pbonz...@redhat.com
---
hw/block/virtio-blk.c | 2 +-
1 file
From: Jason Wang jasow...@redhat.com
Signed-off-by: Jason Wang jasow...@redhat.com
Reviewed-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Paolo Bonzini pbonz...@redhat.com
---
include/hw/virtio/virtio.h | 4 +++-
hw/9pfs/virtio-9p-device.c
Exceptions:
- virtio-blk
- compat machine types
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
include/hw/compat.h| 22 +-
include/hw/virtio/virtio.h | 4 +++-
hw/block/virtio-blk.c | 1 +
hw/net/virtio-net.c| 2 --
hw/scsi/virtio-scsi.c
There's no need for blk to set ANY_LAYOUT, it's
done by virtio core as necessary.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/block/virtio-blk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 44f9b8e..1556c9c 100644
--- a/hw
On Fri, Jul 24, 2015 at 01:33:08PM +0100, Peter Maydell wrote:
Use the utility function pow2ceil() for rounding up to the next
largest power of 2, rather than inline calculation.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Reviewed-by: Michael S. Tsirkin m...@redhat.com
---
hw
Maydell peter.mayd...@linaro.org
Reviewed-by: Michael S. Tsirkin m...@redhat.com
---
hw/pci/msix.c | 4 +---
hw/pci/pci.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index 7716bf3..2fdada4 100644
--- a/hw/pci/msix.c
+++ b/hw
On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote:
On 27/07/2015 11:49, Jason Wang wrote:
So this patch only clear VIRTIO_F_LAYOUT for legacy device.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Jason
On Mon, Jul 27, 2015 at 03:28:51PM +0200, Cornelia Huck wrote:
On Mon, 27 Jul 2015 14:22:37 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote:
On 27/07/2015 11:49, Jason Wang wrote:
So this patch only clear
Virtio 1 requires this, and all devices are clean by now,
so let's do it!
Exceptions:
- virtio-blk
- compat machine types
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Untested - consider this pseudo-code - it just seems easier to write it
in C than try to explain it.
include
On Thu, Jul 23, 2015 at 04:14:36PM +0800, Jason Wang wrote:
On 07/22/2015 05:36 PM, Michael S. Tsirkin wrote:
Virtio 1 requires this,
I think you mean transitional not virtio 1?
and all devices are clean by now,
so let's do it!
Exceptions:
- virtio-blk
- compat
On Mon, Jul 13, 2015 at 05:00:51PM +0800, Jason Wang wrote:
On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote:
On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote:
VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc
On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote:
On Mon, 13 Jul 2015 15:22:52 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Jul 13, 2015 at 01:51:56PM +0200, Cornelia Huck wrote:
On Mon, 13 Jul 2015 11:56:51 +0200
Kevin Wolf kw...@redhat.com wrote:
Am
On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 13:59:00 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote:
Yes, and that's because as written, transitional devices must set
ANY_LAYOUT
On Wed, Jul 15, 2015 at 01:29:59PM +0800, Jason Wang wrote:
Disable scsi passthrough by default since it was incompatible with
virtio 1.0. For legacy machine types, keep this on by default.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
On Wed, Jul 15, 2015 at 05:38:53PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 17:39:18 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 17:11:57 +0300
Michael S. Tsirkin m...@redhat.com wrote
On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote:
On Mon, 13 Jul 2015 15:36:00 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote:
On Mon, 13 Jul 2015 15:22:52 +0300
Michael S. Tsirkin m...@redhat.com wrote
On Wed, Jul 15, 2015 at 03:40:22PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 16:16:07 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 15:01:01 +0300
Michael S. Tsirkin m...@redhat.com wrote
On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote:
On 15/07/2015 14:21, Michael S. Tsirkin wrote:
Disable scsi passthrough by default since it was incompatible with
virtio 1.0. For legacy machine types, keep this on by default.
Cc: Stefan Hajnoczi stefa...@redhat.com
On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 17:11:57 +0300
Michael S. Tsirkin m...@redhat.com wrote:
Fine, but revision is negotiated way before features are
probed so why does it make a practical difference?
Legacy drivers
On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 15:01:01 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote:
On Wed, 15 Jul 2015 13:59:00 +0300
Michael S. Tsirkin m...@redhat.com wrote
On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote:
VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Jason Wang jasow...@redhat.com
Interesting, I
Drop deprecated use of virtqueue_map_sg.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
hw/block/virtio-blk.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 8beb26b..3e230de 100644
--- a/hw/block/virtio
Use address_space_read to make sure we handle the case of an indirect
descriptor crossing DIMM boundary correctly.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
Warning: compile-tested only.
hw/virtio/dataplane/vring.c | 28 ++--
1 file changed, 18 inse
Should fix issues Stefan reported.
---
Built only.
hw/virtio/dataplane/vring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c
index 9ae9424..23f667e 100644
--- a/hw/virtio/dataplane/vring.c
+++
Drop deprecated use of virtqueue_map_sg.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Igor Mammedov <imamm...@redhat.com>
---
hw/block/virtio-blk.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio
On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote:
> On Sun, 18 Oct 2015 10:59:59 +0300
> "Michael S. Tsirkin" <m...@redhat.com> wrote:
>
> > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
>
> > > Lets keep t
On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> Am 16.10.2015 um 12:44 schrieb Cornelia Huck:
> > On Fri, 16 Oct 2015 12:32:52 +0200
> > Christian Borntraeger wrote:
> >
> >> Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
> >>> Devices that are
. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Stefan Hajnoczi stefa...@redhat.com
---
hw/virtio/dataplane/vring.c | 47 -
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git a/hw/virtio/dataplane/vring.c b/hw
. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Stefan Hajnoczi stefa...@redhat.com
---
hw/virtio/dataplane/vring.c | 47 -
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git a/hw/virtio/dataplane/vring.c b/hw
-by: Greg Kurz gk...@linux.vnet.ibm.com
Reviewed-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
---
hw/virtio/dataplane/vring.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw
, in particular, when dynamically building ACPI tables,
> > and will allow to properly populate the corresponding ACPI objects and
> > thus enable BIOS-less systems to access the floppy drives.
> >
> > Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
> > Cc:
On Wed, Jan 06, 2016 at 05:37:46PM +0800, Cao jin wrote:
> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com>
Acked-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> hw/scsi/megasas.c | 12 ++--
> hw/scsi/scsi-bus.c| 4 ++--
> hw/scsi/virtio-scsi.c |
On Thu, Jan 07, 2016 at 12:56:09PM +0200, Michael S. Tsirkin wrote:
> On Wed, Jan 06, 2016 at 03:04:40PM +0100, Igor Mammedov wrote:
> > On Wed, 30 Dec 2015 23:11:50 +0300
> > Roman Kagan <rka...@virtuozzo.com> wrote:
> >
> > > Windows on UEFI systems is on
expose identifying the floppy controller
> > i386/acpi: make floppy controller object dynamic
> > tests/acpi: update test data
> > expose floppy drive geometry and CMOS type
> > i386: populate floppy drive information in SSDT
> > tests/acpi: update test data
>
From: Roman Kagan <rka...@virtuozzo.com>
Factor out and expose the function to locate the floppy controller in
the system.
It will allow to dynamically populate the relevant objects in the ACPI
tables.
Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
Cc: "Michael S. Tsirkin&
make check always outputs warnings, this
is not nice. Disable blkdebug warnings under qtest.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
block/blkdebug.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 6
From: Roman Kagan <rka...@virtuozzo.com>
Factor out and expose the function to locate the floppy controller in
the system.
It will allow to dynamically populate the relevant objects in the ACPI
tables.
Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
Cc: "Michael S. Tsirkin&
qemu-devel/2016-06/msg05619.html
> >
> > 10: Named GPIO is used for gsi. The name is "gsi" with alias ICH9_GPIO_GSI.
> >
> > 12: It's a new patch. The patch introduces function isa_connect_gpio_out.
> >
> > 13 (previously 12): Use isa_connect_gpio_out instead of isa_init_irq.
>
> I have queued patches 1-13, as said before I'm not sure of patch 14 and
> I want to think about it some more. :)
>
> Paolo
You can add my
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
if you wish.
I'll comment on 14 separately.
--
MST
@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
hw/block/dataplane/virtio-blk.c | 14 +++---
hw/scsi/virtio-scsi-dataplane.c | 20 +++-
hw/virtio/vhost.c | 20
3
From: Cornelia Huck <cornelia.h...@de.ibm.com>
All users have been converted to the new ioevent callbacks.
Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Reviewed-b
a Huck <cornelia.h...@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
hw/virtio/dataplane/vring.c | 53 ++---
h more efficient algorithms.
The patch is pretty large, but changes to each device are testable
more or less independently. Splitting it would mostly add churn.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Mic
e.ibm.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
include/hw/virtio/virtio.h | 2 ++
hw/block/virtio-blk.c | 10 +++---
hw/char/virtio-serial-bus.c |
On Fri, Feb 05, 2016 at 12:52:55PM +, Peter Maydell wrote:
> On 4 February 2016 at 21:51, Michael S. Tsirkin <m...@redhat.com> wrote:
> > From: Paolo Bonzini <pbonz...@redhat.com>
> >
> > The return code of virtqueue_pop/vring_pop is unused except to check
a Huck <cornelia.h...@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
hw/virtio/dataplane/vring.c | 53 ++---
aolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
include/hw/virtio/virtio.h | 9 ++--
hw/virtio/dataplane/vring.c | 3 +-
hw/virtio/virtio.c | 110 +++
e.ibm.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
include/hw/virtio/virtio.h | 2 ++
hw/block/virtio-blk.c | 10 +++---
hw/char/virtio-serial-bus.c |
bjects and
thus enable BIOS-less systems to access the floppy drives.
Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
Signed-off-by: Igor Mammedov <imamm...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
h more efficient algorithms.
The patch is pretty large, but changes to each device are testable
more or less independently. Splitting it would mostly add churn.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Mic
he BQL (for regular BlockDriverStates) and
the AioContext (for dataplane BlockDriverStates). When the block layer
is made fully thread safe, aio_context_acquire shall go away altogether.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
he BQL (for regular BlockDriverStates) and
the AioContext (for dataplane BlockDriverStates). When the block layer
is made fully thread safe, aio_context_acquire shall go away altogether.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
From: Paolo Bonzini <pbonz...@redhat.com>
Make the API more similar to the regular virtqueue API. This will
help when modifying the code to not use vring.c anymore.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
From: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
Acked-by: Stefan Hajnoczi <s
virtio-blk.c, we have
to move s->dataplane->started inside struct VirtIOBlock.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.h...
virtio-blk.c, we have
to move s->dataplane->started inside struct VirtIOBlock.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.h...
From: Paolo Bonzini <pbonz...@redhat.com>
Make the API more similar to the regular virtqueue API. This will
help when modifying the code to not use vring.c anymore.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
From: Paolo Bonzini <pbonz...@redhat.com>
Make the API more similar to the regular virtqueue API. This will
help when modifying the code to not use vring.c anymore.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
virtio-blk.c, we have
to move s->dataplane->started inside struct VirtIOBlock.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.h...
From: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
Acked-by: Stefan Hajnoczi <s
he BQL (for regular BlockDriverStates) and
the AioContext (for dataplane BlockDriverStates). When the block layer
is made fully thread safe, aio_context_acquire shall go away altogether.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed
eturns the maximum values of c, h, s, out of
those matching the given floppy drive type.
Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
Cc: Igor Mammedov <imamm...@redhat.com>
Cc: "Michael S. Tsirkin" <m...@redhat.com>
Cc: Marcel Apfelbaum <mar...@redhat.com>
Cc:
eturns the maximum values of c, h, s, out of
those matching the given floppy drive type.
Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
Cc: Igor Mammedov <imamm...@redhat.com>
Cc: "Michael S. Tsirkin" <m...@redhat.com>
Cc: Marcel Apfelbaum <mar...@redhat.com>
Cc:
On Wed, Apr 06, 2016 at 04:56:12PM -0700, Stefano Stabellini wrote:
> On Sun, 3 Apr 2016, Michael S. Tsirkin wrote:
> > piix3_ide_xen_class_init is identical to piix3_ide_class_init
> > except it's buggy as it does not set exit and does not disable
> > hotplug prop
handlers when dataplane is active.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
include/hw/virtio/virtio-
andler, which in
fact was always called with assign=true.
Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
includ
piix3_ide_xen_class_init is identical to piix3_ide_class_init
except it's buggy as it does not set exit and does not disable
hotplug properly.
Switch to the generic one.
Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
d-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
include/hw/virtio/virtio-blk.h | 1 +
hw/block/dataplane/virtio-blk.c | 7 +++
hw/block/virtio-blk.c | 2 +-
3
egressions.
Adding a comment won't be too much work.
How about the below?
-->
msi_supported -> msi_nonbroken
Rename controller flag to make it clearer what it means.
Add some documentation as well.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
diff --git a/include/hw/pci/ms
eturns the maximum values of c, h, s, out of
those matching the given floppy drive type.
Signed-off-by: Roman Kagan <rka...@virtuozzo.com>
Cc: Igor Mammedov <imamm...@redhat.com>
Cc: "Michael S. Tsirkin" <m...@redhat.com>
Cc: Marcel Apfelbaum <mar...@redhat.com>
Cc:
On Fri, Mar 04, 2016 at 01:57:05PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <m...@redhat.com> writes:
>
> > On Fri, Mar 04, 2016 at 09:42:02AM +0100, Markus Armbruster wrote:
> >> Plugging an MSI-capable device into an MSI-incapable board wo
On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
> >>+int msi_init(struct PCIDevice *dev, uint8_t offset, unsigned int
> >>nr_vectors,
> >>+ bool msi64bit, bool msi_per_vector_mask, Error **errp)
> >> {
> >> unsigned int vectors_order;
> >>-uint16_t flags;
>
On Thu, Mar 03, 2016 at 01:19:09PM +0200, Marcel Apfelbaum wrote:
> On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
> >On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
> >>>>+int msi_init(struct PCIDevice *dev, uint8_t offset, unsign
On Thu, Mar 03, 2016 at 04:03:16PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <m...@redhat.com> writes:
>
> > On Thu, Mar 03, 2016 at 01:19:09PM +0200, Marcel Apfelbaum wrote:
> >> On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
> >> >
piix3_ide_xen_class_init is identical to piix3_ide_class_init
except it's buggy as it does not set exit and does not disable
hotplug properly.
Switch to the generic one.
Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reentrancy cannot happen while the BQL is being held,
so we should never enter this condition.
Cc: Christian Borntraeger <borntrae...@de.ibm.com>
Cc: Cornelia Huck <cornelia.h...@de.ibm.com>
Cc: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Michael S. Tsirki
On Mon, Apr 04, 2016 at 10:25:34AM +0200, Cornelia Huck wrote:
> On Mon, 4 Apr 2016 10:19:42 +0200
> Paolo Bonzini wrote:
>
> > On 04/04/2016 10:10, Cornelia Huck wrote:
> > > > This will be fixed by Cornelia's rework, and is an example of why I
> > > > think patch 1/9 is a
, and
disable regular handlers when dataplane is active.
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
include/hw/virtio/virtio-blk.h | 2 ++
hw/block/dataplane/virtio-blk.c | 13 +
hw/block/virtio-blk.c | 28 ++--
3 files changed, 33 inse
On Tue, Mar 29, 2016 at 03:56:18PM +0200, Paolo Bonzini wrote:
>
>
> On 29/03/2016 15:42, Michael S. Tsirkin wrote:
> > @@ -262,6 +274,7 @@ void virtio_blk_data_plane_stop(VirtIOBlockDataPlane *s)
> >
> > /* Stop notifications
On Tue, Mar 29, 2016 at 04:05:46PM +0200, Paolo Bonzini wrote:
>
>
> On 29/03/2016 15:42, Michael S. Tsirkin wrote:
> > +if (s->dataplane) {
> > +/* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so
> > start
> > +
On Fri, Apr 22, 2016 at 06:56:00PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> include/qemu/main-loop.h | 1 +
> iohandler.c | 6 ++
> stubs/Makefile.objs
On Fri, Apr 22, 2016 at 06:55:59PM +0800, Fam Zheng wrote:
> v2: Go along the is_external appraoch. [Kevin]
>
> I tested this series survives the "snapshot + commit" loop reproducer with
> both
> bonnie++ and RHEL installation in the guest.
>
> This supersedes the "virtio: Register host
"virtio: Register host notifier handler as external" patch
> from yesterday.
>
> The bug was initially reported by Matthew Schumacher as LaunchPad Bug 1570134,
> and nicely bisected by Max Reitz. See patch 2 for the analysis.
Patches 1-3:
Reviewed-by: Michael S. Tsirkin <m..
t;f...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> hw/usb/ccid-card-emulated.c | 2 +-
> hw/virtio/virtio.c| 8
> include/qemu/event_notifier.h | 4 +++-
> stubs/set-fd-handler.c| 10 ++
> target-i386/hyper
On Fri, Apr 22, 2016 at 06:56:02PM +0800, Fam Zheng wrote:
> The effect of this change is the block layer drained section can work,
> for example when mirror job is being completed.
>
> Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: Michael S. Tsirkin <m...@redh
On Wed, Apr 27, 2016 at 08:16:57PM +0100, David Woodhouse wrote:
> On Wed, 2016-04-27 at 21:17 +0300, Michael S. Tsirkin wrote:
> >
> > > Because it's a dirty hack in the *wrong* place.
> >
> > No one came up with a better one so far :(
>
> Seriously?
>
On Wed, Apr 27, 2016 at 04:15:35PM +0100, David Woodhouse wrote:
> On Wed, 2016-04-27 at 18:05 +0300, Michael S. Tsirkin wrote:
> >
> > I really don't get it.
> >
> > There's exactly one device that works now and needs the work-around and
> > so that we ne
On Wed, Apr 27, 2016 at 07:43:07AM -0700, Andy Lutomirski wrote:
> On Wed, Apr 27, 2016 at 7:38 AM, Michael S. Tsirkin <m...@redhat.com> wrote:
> > On Wed, Apr 27, 2016 at 07:31:43AM -0700, Andy Lutomirski wrote:
> >> On Wed, Apr 27, 2016 at 7:23 AM, Joerg Roedel
On Wed, Apr 27, 2016 at 01:18:21PM +0100, David Woodhouse wrote:
>
> > > On some systems, including Xen and any system with a physical device
> > > that speaks virtio behind a physical IOMMU, we must use the DMA API
> > > for virtio DMA to work at all.
> > >
> > > Add a feature bit to detect
On Wed, Apr 27, 2016 at 04:58:51PM +0200, Joerg Roedel wrote:
> On Wed, Apr 27, 2016 at 05:54:57PM +0300, Michael S. Tsirkin wrote:
> > Point is, QEMU is not the only virtio implementation out there.
> > So we can't know no virtio implementations have an IOMMU as long as
>
On Wed, Apr 27, 2016 at 04:56:32PM +0200, Joerg Roedel wrote:
> On Wed, Apr 27, 2016 at 05:34:30PM +0300, Michael S. Tsirkin wrote:
> > On Wed, Apr 27, 2016 at 04:23:32PM +0200, Joerg Roedel wrote:
>
> > QEMU can choose to bypass IOMMU for one device and not the other.
>
1 - 100 of 759 matches
Mail list logo