On 08/09/2016 12:19 PM, Fam Zheng wrote:
+/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */
+
+typedef struct {
+unsigned char data[16];
+} QemuUUID;
...
+void qemu_uuid_generate(QemuUUID *uuid)
+{
+int i;
+uint32_t *out = (uint32_t *)>data[0];
You can't do this cast
On 08/11/2016 05:50 AM, Fam Zheng wrote:
+void qemu_uuid_bswap(QemuUUID *uuid)
+{
+bswap32s((uint32_t *)>data[0]);
+bswap16s((uint16_t *)>data[4]);
+bswap16s((uint16_t *)>data[6]);
+}
You have alignment problems here too. Perhaps you really did want to add
uint32_t (and
On 08/12/2016 05:52 AM, Fam Zheng wrote:
+/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */
+
+typedef struct {
+union {
+unsigned char data[16];
+struct {
+/* Generated in BE endian, can be swapped with qemu_uuid_bswap. */
Nit: BE endian is redundant.
etions(-)
Reviewed-by: Richard Henderson <r...@twiddle.net>
r~
etions(-)
Reviewed-by: Richard Henderson <r...@twiddle.net>
r~
letion(-)
Reviewed-by: Richard Henderson <r...@twiddle.net>
r~
letion(-)
Reviewed-by: Richard Henderson <r...@twiddle.net>
r~
c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <r...@twiddle.net>
r~
u-sta...@nongnu.org
> Signed-off-by: Eric Blake <ebl...@redhat.com>
>
> ---
> v2: use ternary instead of addition of 0 [Laszlo], improve commit message
> ---
> include/qemu/osdep.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote:
> xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename
> \"%s\","
> - " size %" PRId64 " (%" PRId64 " MB)\n",
> + " size %" PRId64 " (%llu MB)\n",
>blkdev->type,
On 06/12/2018 11:04 AM, Eric Blake wrote:
> On 06/12/2018 03:51 PM, Richard Henderson wrote:
>> On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote:
>>> xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename
>>> \"%s\&quo
On 06/13/2018 02:13 AM, Eric Blake wrote:
> Or spell it UINT64_C(1) if you don't want a cast.
Not unsigned is what I want most.
r~
On 06/25/2018 05:41 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Stefan Weil
> ---
> block/vdi.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
ilippe Mathieu-Daudé
> ---
> hw/block/m25p80.c | 5 +++--
> hw/block/nvme.c| 3 ++-
> hw/block/tc58128.c | 3 ++-
> 3 files changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
<pbonz...@redhat.com>
> ---
> tests/test-coroutine.c | 50
> --
> 1 file changed, 48 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
Hajnoczi <stefa...@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> block/curl.c | 20
> 1 file changed, 4 insertions(+), 16 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
| 19 +--
> util/qemu-coroutine-lock.c | 10 --
> 3 files changed, 23 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
coroutine-lock.c | 12 +++-
> 2 files changed, 12 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
uiltin is such that it *must* eliminate the
other branch; otherwise the types don't even match up.
It might be worth using __attribute__((error("message"))) on the function too.
Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
On 10/29/18 1:39 PM, Mark Cave-Ayland wrote:
> You can install your own disk using debian-installer, with:
>
> ...
> -M q800 \
> -serial none -serial mon:stdio \
> -m 1000M -drive file=m68k.qcow2,format=qcow2 \
> -net nic,model=dp83932,addr=09:00:07:12:34:57 \
> -append
On 10/9/18 10:24 AM, Peter Maydell wrote:
> Peter Maydell (3):
> block/qcow2: Don't take address of fields in packed structs
> block/qcow: Don't take address of fields in packed structs
> block/qcow2-bitmap: Don't take address of fields in packed structs
Reviewed-by: Richa
On 12/13/18 4:37 PM, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
Acked-by: Richard Henderson
r~
86/pc.c: Don't use load_image()
> hw/i386/multiboot.c: Don't use load_image()
> hw/block/tc58128.c: Don't use load_image()
> device_tree.c: Don't use load_image()
> hw/core/loader.c: Remove load_image()
> include/hw/loader.h: Document load_image_size()
Reviewed-by: Richard Henders
lake
> Reviewed-by: Eric Blake
> Signed-off-by: Thomas Huth
> Message-Id: <20190502084506.8009-2-th...@redhat.com>
> Signed-off-by: Alex Bennée
> ---
> tests/qemu-iotests/005 | 9 +
> 1 file changed, 9 insertions(+)
Reviewed-by: Richard Henderson
r~
| 2 ++
> util/coroutine-asm.c | 45
> 4 files changed, 53 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
> +"ldr x30, [x1, %[SCRATCH]]\n"/* load destination PC */ \
> +"ldr x1
+
> include/qemu/cpuid.h | 5 +
> tcg/i386/tcg-target.inc.c | 19 +++
> 4 files changed, 35 insertions(+)
Reviewed-by: Richard Henderson
r~
ns(+), 2 deletions(-)
> create mode 100644 scripts/qemugdb/coroutine_asm.py
> create mode 100644 util/coroutine-asm.c
Reviewed-by: Richard Henderson
r~
On 5/4/19 5:05 AM, Paolo Bonzini wrote:
> + "bras %%r3, 1f\n"/* source PC will be after the BR */ \
> + "1: aghi %%r3, 12\n" /* 4 */ \
> + "stg %%r3, %[SCRATCH](%%r1)\n" /* 6 save switch-back PC */ \
> + "br %%r4\n"
On 8/16/19 8:38 AM, tony.ngu...@bt.com wrote:
> +static void adjust_endianness(MemoryRegion *mr, uint64_t *data, MemOp op)
> {
> +if ((op & MO_BSWAP) != mr->ops->endianness) {
> +switch (op & MO_SIZE) {
You'll want to use devend_memop() here, as previously discussed.
> @@ -2331,7
On 8/16/19 7:28 AM, tony.ngu...@bt.com wrote:
> Tony Nguyen (42):
> configure: Define TARGET_ALIGNED_ONLY in configure
> tcg: TCGMemOp is now accelerator independent MemOp
> memory: Introduce size_memop
> target/mips: Access MemoryRegion with MemOp
> hw/s390x: Access MemoryRegion with
On 8/16/19 8:38 AM, tony.ngu...@bt.com wrote:
> Preparation for collapsing the two byte swaps adjust_endianness and
> handle_bswap into the former.
>
> Call memory_region_dispatch_{read|write} with endianness encoded into
> the "MemOp op" operand.
>
> This patch does not change any behaviour as
dr, val, oi, retaddr, 1, false);
> +store_helper(env, addr, val, oi, retaddr, MO_8);
> }
MO_UB.
Otherwise,
Reviewed-by: Richard Henderson
r~
On 8/19/19 11:29 AM, Paolo Bonzini wrote:
> On 19/08/19 20:28, Paolo Bonzini wrote:
>> On 16/08/19 12:12, Thomas Huth wrote:
>>> This patch is *huge*, more than 800kB. It keeps being stuck in the the
>>> filter of the qemu-s390x list each time you send it. Please:
>>>
>>> 1) Try to break it up in
ith
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
>
> Signed-off-by: Tony Nguyen
> ---
> target/mips/op_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
ith
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
>
> Signed-off-by: Tony Nguyen
> ---
> hw/s390x/s390-pci-inst.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
ith
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
>
> Signed-off-by: Tony Nguyen
> ---
> memory_ldst.inc.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson
r~
On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote:
> @@ -1246,7 +1246,7 @@ typedef uint64_t FullLoadHelper(CPUArchState *env,
> target_ulong addr,
>
> static inline uint64_t __attribute__((always_inline))
> load_helper(CPUArchState *env, target_ulong addr, TCGMemOpIdx oi,
> -uintptr_t
On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote:
> + _mm_ops[end == DEVICE_LITTLE_ENDIAN ? 0 :
> 1],
This is of course "end != DEVICE_LITTLE_ENDIAN".
r~
On 8/7/19 8:59 AM, Richard Henderson wrote:
> On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote:
>> + _mm_ops[end == DEVICE_LITTLE_ENDIAN ? 0 :
>> 1],
>
> This is of course "end != DEVICE_LITTLE_ENDIAN".
And by that I mean drop the ?: operator.
r~
ot; operand into a "MemOp op".
> + */
> +return size;
> +}
> +
Return type should remain unsigned until patch 11.
Otherwise,
Reviewed-by: Richard Henderson
r~
9 +
> memory.c | 7 +--
> 3 files changed, 23 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson
> +/* MemOp to size in bytes. */
> +static inline unsigned memop_size(MemOp op)
> +{
> +return 1 << ((op) & MO_SIZE);
> +}
s/(op)/op/
This is no longer a macro requiring such things.
r~
cputlb.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 8/7/19 3:22 AM, Paolo Bonzini wrote:
> On 07/08/19 10:32, tony.ngu...@bt.com wrote:
>> +#if defined(HOST_WORDS_BIGENDIAN)
>> + .endianness = MO_BE,
>> +#else
>> + .endianness = MO_LE,
>> +#endif
>
> Host endianness is just 0, isn't it?
Yes. Just leaving a comment to that effect here
On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote:
> Simplify endianness comparisons with consistent use of the more
> expressive MemOp.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Tony Nguyen ---
Reviewed-by: Richard Henderson
r~
2 files changed, 13 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson
r~
On 8/7/19 1:32 AM, tony.ngu...@bt.com wrote:
> device_endian has been made redundant by MemOp.
>
> Signed-off-by: Tony Nguyen
> ---
> include/exec/cpu-common.h | 8
> 1 file changed, 8 deletions(-)
Reviewed-by: Richard Henderson
r~
On 8/7/19 11:00 AM, Paolo Bonzini wrote:
> On 07/08/19 19:49, Richard Henderson wrote:
>> On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote:
>>> @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy,
>>> hwaddr addr,
>>> /* As length is
On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote:
> @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy,
> hwaddr addr,
> /* As length is under guest control, handle illegal values. */
> return;
> }
> +/* FIXME: memory_region_dispatch_write ignores
On 10/14/19 2:36 PM, Wei Yang wrote:
> On Mon, Oct 14, 2019 at 10:15:02AM +0100, Dr. David Alan Gilbert wrote:
>> We also use sysconf(_SC_PAGESIZE) in a few places.
>
> You mean need to replace them too?
I would say so, as a separate patch.
r~
On 11/18/19 10:04 PM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (3):
> hw/block/pflash: Remove dynamic field width from trace events
> hw/mips/gt64xxx: Remove dynamic field width from trace events
> trace: Forbid dynamic field width in event format
Reviewed
On 10/12/19 10:11 PM, Wei Yang wrote:
> Use ROUND_UP() to define, which is a little bit easy to read.
>
> Signed-off-by: Wei Yang
> ---
> include/exec/cpu-all.h | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
>
r the first one we
> use two forms: qemu_real_host_page_size and getpagesize().
>
> qemu_real_host_page_size is defined to be a replacement of
> getpagesize(), so let it serve the role.
>
> [Note] Not fully tested for some arch or device.
>
> Signed-off-by: Wei Yang
> ---
Reviewed-by: Richard Henderson
r~
not t
add n, t
and mask, t
which is what I proposed here
>> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04526.html
I'm ok with your version.
Reviewed-by: Richard Henderson
r~
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused when building with CFLAG -O3:
>
> In function ‘help_oneline’,
> inlined from ‘help_all’ at qemu-io-cmds.c:2414:9,
> inlined from ‘help_f’ at qemu-io-cmds.c:2424:9:
> qemu-io-cmds.c:2389:9: error: ‘%s’ directive
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused when building with CFLAG -O3:
>
> hw/scsi/megasas.c: In function ‘megasas_scsi_realize’:
> hw/scsi/megasas.c:2387:26: error: duplicated ‘if’ condition
> [-Werror=duplicated-cond]
>2387 | } else if (s->fw_sge >= 128
On 12/18/19 7:52 AM, Philippe Mathieu-Daudé wrote:
>>> - if (s->fw_sge >= MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE) {
>>> + if (MEGASAS_MAX_SGE > 128
>>> + && s->fw_sge >= MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE) {
>>> s->fw_sge = MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE;
>>>
On 12/18/19 7:20 AM, Philippe Mathieu-Daudé wrote:
> The Chardev events are listed in the QEMUChrEvent enum.
>
> By using the enum in the IOEventHandler typedef we:
>
> - make the IOEventHandler type more explicit (this handler
> process out-of-band information, while the IOReadHandler
> is
On 12/18/19 7:45 AM, Philippe Mathieu-Daudé wrote:
> On 12/18/19 5:15 AM, Richard Henderson wrote:
>> On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
>>> GCC9 is confused when building with CFLAG -O3:
>>>
>>> In function ‘help_oneline’,
>>>
> +##
> +# zstd check
> +
> +if test "$zstd" != "no" ; then
> +if $pkg_config --exist libzstd ; then
The option is spelled --exists. This is generating an error during configure.
r~
_port = io_port;
>^~~~ ~~~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/display/qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
eported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/block/pflash_cfi02.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson
r~
eported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/qcow2-bitmap.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson
r~
rtions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 1/21/20 12:22 PM, Peter Maydell wrote:
>> This doesn't seem to work for me.
>>
>> make[1]: Leaving directory '/home/rth/qemu/qemu/slirp'
>> CONFDIR="/home/rth/qemu/run/etc/qemu" sphinx-build -W -b html -D
>> version=4.2.50 -D release="4.2.50 (rth)" -d .doctrees/devel-html
>>
bles makes the parallel between the rST handling and
> the texi handling clearer; in any case all this code will
> be deleted once we've converted entirely to rST.
>
> Signed-off-by: Peter Maydell
> ---
> scripts/hxtool | 33 -
> 1 file changed, 32 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 1/21/20 9:10 AM, Peter Maydell wrote:
> Some of our documentation includes sections which are created
> by assembling fragments of texinfo from a .hx source file into
> a .texi file, which is then included from qemu-doc.texi or
> qemu-img.texi.
>
> For Sphinx, rather than creating a file to
xp
> from "@var{\([^}]*\)}" to "\,(upcase \1))".)
>
> Signed-off-by: Peter Maydell
> ---
> qemu-img-cmds.hx | 43 ++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
Reviewed-by: Richard Henderson
r~
nnecessary CPU() cast
> various: Remove unnecessary OBJECT() cast
> hw: Remove unnecessary DEVICE() cast
Reviewed-by: Richard Henderson
r~
()
> ---
> target/rx/cpu.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson
r~
json | 42 ---
> target/i386/cpu.c | 2 +-
> target/i386/machine-stub.c | 22 +++
> target/i386/Makefile.objs | 3 ++-
> 5 files changed, 70 insertions(+), 44 deletions(-)
> create mode 100644 target/i386/machine-stub.c
Acked-by: Richard Henderson
r~
ee of local_err
> migration/ram: fix use after free of local_err
> qga/commands-posix: fix use after free of local_err
Whole series:
Reviewed-by: Richard Henderson
r~
| 2 +-
> memory.c| 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
ock/Makefile.objs | 2 +-
> 2 files changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
| 2 +-
> target/arm/helper.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
---
> stubs/fdset.c | 8 ++
> util/osdep.c | 19 ++---
> 5 files changed, 32 insertions(+), 57 deletions(-)
Reviewed-by: Richard Henderson
r~
stem does not support
> O_DIRECT"
> }
>
> Reviewed-by: Eric Blake
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Markus Armbruster
> Signed-off-by: Daniel P. Berrangé
> ---
Reviewed-by: Richard Henderson
r~
ewed-by: Markus Armbruster
> Reviewed-by: Eric Blake
> Signed-off-by: Daniel P. Berrangé
> ---
> util/osdep.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
; ---
> util/osdep.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson
r~
t; util/osdep.c | 24 +---
> 1 file changed, 17 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
r~
-by: Eric Blake
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Markus Armbruster
> Signed-off-by: Daniel P. Berrangé
> ---
Reviewed-by: Richard Henderson
r~
t; util/osdep.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
gt; Reviewed-by: Markus Armbruster
> Signed-off-by: Daniel P. Berrangé
> ---
Reviewed-by: Richard Henderson
r~
;
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/sysemu/dma.h | 15 ++-
> 1 file changed, 10 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
| 3 ++-
> hw/intc/spapr_xive.c | 3 ++-
> hw/usb/hcd-ohci.c| 10 ++
> 5 files changed, 18 insertions(+), 12 deletions(-)
Reviewed-by: Richard Henderson
r~
| 5 ++---
> hw/nvram/fw_cfg.c | 3 ++-
> 4 files changed, 8 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson
r~
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> docs/devel/loads-stores.rst | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson
r~
etion(-)
Reviewed-by: Richard Henderson
r~
| 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
gt; - dma_memory_read(E1, E2, E3, E4)
> + dma_memory_read(E1, E2, E3, E4, MEMTXATTRS_UNSPECIFIED)
> |
> - dma_memory_write(E1, E2, E3, E4)
> + dma_memory_write(E1, E2, E3, E4, MEMTXATTRS_UNSPECIFIED)
> )
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
r~
E4)
> + dma_memory_map(E1, E2, E3, E4, MEMTXATTRS_UNSPECIFIED)
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
Reviewed-by: Richard Henderson
r~
, 22 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson
r~
--
> 2 files changed, 18 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
, 18 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
tions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
nged, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
d-by: Claudio Fontana
> Reported-by: Thomas Huth
> Suggested-by: Peter Maydell
> Signed-off-by: Max Reitz
> Message-Id: <20200914145606.94620-1-mre...@redhat.com>
> Signed-off-by: Alex Bennée
> ---
> tests/qemu-iotests/check | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
---
> hw/sd/sdhci.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson
r~
On 9/1/20 7:04 AM, Philippe Mathieu-Daudé wrote:
> Add missing newline character in qemu_log_mask() format.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/sd/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
too many of them, and there is a general
>>>> kernel trend to simplify the configuration menu.
>>>>
>>>> We remove the stone age exhibits along with closing the museum,
>>>> but some of the iron age ones are transferred to the regular NAND
&g
1 - 100 of 408 matches
Mail list logo
