On 1/18/24 21:18, Kevin Wolf wrote:
Am 11.01.2024 um 17:32 hat Ari Sundholm geschrieben:
During the review of a fix for a concurrency issue in blklogwrites,
it was found that the driver needs an additional fix when enabling
multiqueue, which is a new feature introduced in QEMU 9.0
is not being written to by
multiple threads concurrently and updates are properly serialized.
Additionally, add the const qualifier to a few BDRVBlkLogWritesState
pointer targets in contexts where the driver state is not written to.
Signed-off-by: Ari Sundholm
v1->v2: Ensure that the super bl
is not being written
to by multiple threads concurrently.
Additionally, add the const qualifier to a few BDRVBlkLogWritesState
pointer targets in contexts where the driver state is not written to.
Signed-off-by: Ari Sundholm
v1->v2: Ensure that the super block is not written to concurren
On 1/11/24 16:06, Kevin Wolf wrote:
Am 10.01.2024 um 20:50 hat Ari Sundholm geschrieben:
During the review of a fix for a concurrency issue in blklogwrites,
it was found that the driver needs an additional fix when enabling
multiqueue, which is a new feature introduced in QEMU 9.0
pointer targets in contexts where the driver state is not written to.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index ba717dab4d..50f68df2a6 100644
Hi, Kevin!
On 1/10/24 15:39, Kevin Wolf wrote:
Am 09.01.2024 um 19:46 hat meg...@gmx.com geschrieben:
From: Ari Sundholm
There is a bug in the blklogwrites driver pertaining to logging "write
zeroes" operations, causing log corruption. This can be easily observed
by setting det
e=512,logical_block_size=512
Adapt as needed.
[1] Search for "BlockdevOptionsBlklogwrites" in qapi/block-core.json, or
whatever documentation may have been automagically generated from it.
Best regards,
Ari Sundholm
a...@tuxera.com
Thanks,
Stef
translation.
Fix both issues.
Signed-off-by: Ari Sundholm
Signed-off-by: Emil Karlson
Reviewed-by: Akihiko Odaki
Reviewed-by: Stefan Hajnoczi
Cc: qemu-sta...@nongnu.org
Fixes: 0dfc7af2b28 ("block/file-posix: Optimize for macOS")
---
v1 -> v2:
* Add Reviewed-by, Cc to qemu-stable an
translation.
Fix both issues.
Signed-off-by: Ari Sundholm
Signed-off-by: Emil Karlson
---
block/file-posix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 53be0bdc1b..6def2a4cba 100644
--- a/block/file-posix.c
+++ b/block/file
Hi,
On 9/11/20 11:03 AM, Markus Armbruster wrote:
Ari Sundholm writes:
Hi Vladimir!
Thank you for working on this. My comments below.
On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote:
It's simple to avoid error propagation in blk_log_writes_open(), we
just need to refactor
t = -EINVAL;
-error_propagate(errp, local_err);
goto fail_log;
}
+s->cur_log_sector = cur_log_sector;
s->nr_entries = le64_to_cpu(log_sb.nr_entries);
}
} else {
Best regards,
Ari Sundholm
a...@tuxera.com
On 07/22/2018 12:14 AM, Max Reitz wrote:
On 2018-07-19 14:47, Ari Sundholm wrote:
Hi!
On 06/28/2018 03:07 AM, Max Reitz wrote:
bdrv_refresh_filename() should invoke itself recursively on all
children, not just on file.
With that change, we can remove the manual invocations in blkverify
issue.)
I'm not Kevin, but it seems this series needs updating to accommodate
the recent addition of the blklogwrites block driver.
Best regards,
Ari Sundholm
a...@tuxera.com
On 2018-06-28 02:07, Max Reitz wrote:
Once more, I’ll spare both me and you another iteration of the cover
lett
filename(BlockDriverState *bs,
QDict *options)
int i;
for (i = 0; i < s->num_children; i++) {
-bdrv_refresh_filename(s->children[i]->bs);
if (!s->children[i]->bs->full_open_options) {
return;
}
Should blklogwrites not also receive the same treatment?
Best regards,
Ari Sundholm
a...@tuxera.com
Would there be a chance of getting this included in 3.0?
On 07/06/2018 03:00 PM, Ari Sundholm wrote:
The sector size needs to be large enough to accommodate the data
structures for the log super block and log write entries. This was
previously not properly checked, which made it possible
This was accidentally omitted. Thanks to Eric Blake for spotting this.
Signed-off-by: Ari Sundholm
---
qapi/block-core.json | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 38b3125..62a92fa 100644
--- a/qapi/block-core.json
+++ b/qapi
On 07/05/2018 07:06 PM, Eric Blake wrote:
On 07/05/2018 05:26 AM, Kevin Wolf wrote:
From: Ari Sundholm
Suggested by Kevin Wolf. May be useful when testing multiple batches
of writes or doing long-term testing involving restarts of the VM.
Signed-off-by: Ari Sundholm
Signed-off-by: Kevin
The sector size needs to be large enough to accommodate the data
structures for the log super block and log write entries. This was
previously not properly checked, which made it possible to cause
QEMU to badly misbehave.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 5 -
1 file
This is a way to ensure that the log superblock is periodically
updated. Before, this was only done on flush requests, which may
not be enough if the VM exits abnormally, omitting the final flush.
The default interval is 4096 write requests.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c
Suggested by Kevin Wolf. May be useful when testing multiple batches
of writes or doing long-term testing involving restarts of the VM.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 147 ++-
qapi/block-core.json | 3 +-
2 files changed
This was a simple oversight when working on intermediate versions
of the original patch which introduced blklogwrites.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/block/blklogwrites.c b/block/blklogwrites.c
to 0
Based-on: <1530629328-10193-1-git-send-email-...@tuxera.com>
Ari Sundholm (3):
block/blklogwrites: Change log_sector_size from int64_t to uint64_t
block/blklogwrites: Add an option for appending to an old log
block/blklogwrites: Add an option for the update interval of t
Suggested by Kevin Wolf. May be useful when testing multiple batches
of writes or doing long-term testing involving restarts of the VM.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 147 ++-
qapi/block-core.json | 3 +-
2 files changed
com>
Ari Sundholm (3):
block/blklogwrites: Change log_sector_size from int64_t to uint64_t
block/blklogwrites: Add an option for appending to an old log
block/blklogwrites: Add an option for the update interval of the log
superblock
block/blklogwrites.c
This is a way to ensure that the log superblock is periodically
updated. Before, this was only done on flush requests, which may
not be enough if the VM exits abnormally, omitting the final flush.
The default interval is 4096 write requests.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c
This was a simple oversight when working on intermediate versions
of the original patch which introduced blklogwrites.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/block/blklogwrites.c b/block/blklogwrites.c
of writes to guest block devices that have unusual
sector sizes.
The implementation is based on the blkverify and blkdebug block
drivers.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
MAINTAINERS | 6 +
block/Makefile.objs | 1 +
block/blklogwrites.c | 414
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 70a46fd
on current upstream master
v2:
- Incorporate review feedback
- Add patches to apply block configurations in more block device
drivers
Aapo Vienamo (1):
block: Add blklogwrites
Ari Sundholm (1):
block: Move two block permission constants to the relevant enum
MAINTAINERS | 6
On 07/03/2018 04:06 PM, Kevin Wolf wrote:
Am 29.06.2018 um 22:47 hat Ari Sundholm geschrieben:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 1b8147c
klogwrites in block-core.json
- Rebase on current upstream master
v3:
- Rebase on current upstream master
v2:
- Incorporate review feedback
- Add patches to apply block configurations in more block device
drivers
Aapo Vienamo (1):
block: Add blklogwrites
Ari Sundholm (1):
block: Move
of writes to guest block devices that have unusual
sector sizes.
The implementation is based on the blkverify and blkdebug block
drivers.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
MAINTAINERS | 6 +
block/Makefile.objs | 1 +
block/blklogwrites.c | 392
On 06/29/2018 01:07 PM, Kevin Wolf wrote:
Am 19.06.2018 um 15:43 hat Ari Sundholm geschrieben:
A block driver may need to know about the block configuration, most
critically the sector sizes, of a block backend for alignment purposes
or for some other reason.
It makes sense to me that you
On 06/29/2018 03:05 PM, Kevin Wolf wrote:
Am 19.06.2018 um 15:43 hat Ari Sundholm geschrieben:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file
Just a weekly ping. Any comments appreciated.
On 06/19/2018 04:43 PM, Ari Sundholm wrote:
This patch series adds a new block driver, blklogwrites, to QEMU. The
driver is given two block devices: a raw device backed by an image or a
host block device, and a log device, typically backed by a file
This allows the block driver to use the block configuration of the new
floppy device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/fdc.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/fdc.c b/hw/block
when testing drivers with block devices that have
unusual sector sizes.
The implementation is based on the blkverify and blkdebug block
drivers.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
MAINTAINERS | 6 +
block/Makefile.objs | 1 +
block/blklogwrites.c | 426
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index afe30ca
This allows the block driver to use the block configuration of the new
VirtIO block device. One use for this information is to set request
limits using this information.
Signed-off-by: Ari Sundholm
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/virtio
and the associated backend through a new callback.
Signed-off-by: Ari Sundholm
---
block/io.c| 22 ++
hw/block/block.c | 12 +++-
include/block/block.h | 10 ++
include/block/block_int.h | 9 +
include/hw/block/block.h | 1 +
5
BLURB HERE ***
Aapo Vienamo (1):
block: Add blklogwrites
Ari Sundholm (7):
block: Move two block permission constants to the relevant enum
block: Add a mechanism for passing a block driver a block
configuration
hw/scsi/scsi-disk: Always apply block configuration to block driver
hw/ide/qd
This allows the block driver to use the block configuration of the new
IDE device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/ide/qdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
This allows the block driver to use the block configuration of the new
NVMe device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
On 06/18/2018 06:36 PM, Alberto Garcia wrote:
On Fri 08 Jun 2018 02:32:28 PM CEST, Ari Sundholm wrote:
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most
ping. Any comments or suggestions would be welcome whenever you have the
time. :)
Thank you,
Ari Sundholm
a...@tuxera.com
On 06/08/2018 03:32 PM, Ari Sundholm wrote:
This patch series adds a new block driver, blklogwrites, to QEMU. The
driver is given two block devices: a raw device backed
in this series). Alternative ideas are also welcome.
Thank you,
Ari Sundholm
a...@tuxera.com
On 06/08/2018 03:32 PM, Ari Sundholm wrote:
A block driver may need to know about the block configuration, most
critically the sector sizes, of a block backend for alignment purposes
or for some other reason
This allows the block driver to use the block configuration of the new
VirtIO block device. One use for this information is to set request
limits using this information.
Signed-off-by: Ari Sundholm
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/virtio
This allows the block driver to use the block configuration of the new
NVMe device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
pply block configurations in more block device
drivers
Aapo Vienamo (1):
block: Add blklogwrites
Ari Sundholm (9):
block: Move two block permission constants to the relevant enum
block: Add a mechanism for passing a block driver a block
configuration
hw/scsi/scsi-disk: Always a
drivers.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
MAINTAINERS | 6 +
block/Makefile.objs | 1 +
block/blklogwrites.c | 389 +++
qapi/block-core.json | 30 +++-
4 files changed, 420 insertions(+), 6 deletions(-)
create
This allows the block driver to use the block configuration of the new
IDE device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/ide/qdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
the writes more faithfully for those
devices that have a non-512 logical sector size.
Note that even with this patch, blklogwrites still uses
BDRV_SECTOR_SIZE for logging. This will change in a subsequent patch
which will introduce support for non-512 sector sizes.
Signed-off-by: Ari Sundholm
and the associated backend through a new callback.
Signed-off-by: Ari Sundholm
---
block/io.c| 22 ++
hw/block/block.c | 12 +++-
include/block/block.h | 10 ++
include/block/block_int.h | 9 +
include/hw/block/block.h | 1 +
5
This allows the block driver to use the block configuration of the new
floppy device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/fdc.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/fdc.c b/hw/block
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 501b64c
On 06/07/2018 09:59 PM, Eric Blake wrote:
On 06/07/2018 01:28 PM, Ari Sundholm wrote:
On 06/07/2018 07:13 PM, no-re...@patchew.org wrote:
Hi,
This series failed build test on s390x host. Please find the details
below.
/var/tmp/patchew-tester-tmp-8bz4jnox/src/block/blklogwrites.c
On 06/07/2018 09:32 PM, Eric Blake wrote:
On 06/07/2018 09:40 AM, Ari Sundholm wrote:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file
On 06/07/2018 07:13 PM, no-re...@patchew.org wrote:
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 1528385894-19434-1-git-send-email-...@tuxera.com
Subject: [Qemu-devel] [PATCH v3 00/10] New block driver: blklogwrites
=== TEST SCRIPT
drivers.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
MAINTAINERS | 6 +
block/Makefile.objs | 1 +
block/blklogwrites.c | 383 +++
qapi/block-core.json | 29 +++-
4 files changed, 413 insertions(+), 6 deletions(-)
create
the writes more faithfully for those
devices that have a non-512 logical sector size.
Note that even with this patch, blklogwrites still uses
BDRV_SECTOR_SIZE for logging. This will change in a subsequent patch
which will introduce support for non-512 sector sizes.
Signed-off-by: Ari Sundholm
This allows the block driver to use the block configuration of the new
floppy device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/fdc.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/fdc.c b/hw/block
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 501b64c
and the associated backend through a new callback.
Signed-off-by: Ari Sundholm
---
block/io.c| 22 ++
hw/block/block.c | 12 +++-
include/block/block.h | 10 ++
include/block/block_int.h | 9 +
include/hw/block/block.h | 1 +
5
This allows the block driver to use the block configuration of the new
VirtIO block device. One use for this information is to set request
limits using this information.
Signed-off-by: Ari Sundholm
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/virtio
block configurations in more block device
drivers
Aapo Vienamo (1):
block: Add blklogwrites
Ari Sundholm (9):
block: Move two block permission constants to the relevant enum
block: Add a mechanism for passing a block driver a block
configuration
hw/scsi/scsi-disk: Always apply
This allows the block driver to use the block configuration of the new
NVMe device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
This allows the block driver to use the block configuration of the new
IDE device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/ide/qdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
for logging. This means that the
sector size in the log metadata will be set to the logical sector size,
and offsets and sizes of writes will be expressed as a multiple of that
instead of BDRV_SECTOR_SIZE.
Aapo Vienamo (1):
block: Add blklogwrites
Ari Sundholm (9):
block: Move two block permission
Oops, it seems this old patch found its way in this series somehow. My
apologies.
And sorry for this top-post.
Best regards,
Ari Sundholm
a...@tuxera.com
On 06/07/2018 05:40 PM, Ari Sundholm wrote:
The guest OS may perform writes which are aligned to the logical
sector size instead
the writes more faithfully for those
devices that have a non-512 logical sector size.
Note that even with this patch, blklogwrites still uses
BDRV_SECTOR_SIZE for logging. This will change in a subsequent patch
which will introduce support for non-512 sector sizes.
Signed-off-by: Ari Sundholm
This allows the block driver to use the block configuration of the new
NVMe device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
This allows the block driver to use the block configuration of the new
VirtIO block device. One use for this information is to set request
limits using this information.
Signed-off-by: Ari Sundholm
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/virtio
drivers.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
MAINTAINERS | 6 +
block/Makefile.objs | 1 +
block/blklogwrites.c | 383 +++
qapi/block-core.json | 29 +++-
4 files changed, 413 insertions(+), 6 deletions(-)
create
This allows the block driver to use the block configuration of the new
floppy device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/fdc.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/fdc.c b/hw/block
and the associated backend through a new callback.
Signed-off-by: Ari Sundholm
---
block/io.c| 22 ++
hw/block/block.c | 12 +++-
include/block/block.h | 10 ++
include/block/block_int.h | 9 +
include/hw/block/block.h | 1 +
5
This allows the block driver to use the block configuration of the new
IDE device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/ide/qdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 501b64c
On 06/07/2018 03:30 PM, Stefan Hajnoczi wrote:
On Mon, Jun 04, 2018 at 03:10:47PM +0300, Ari Sundholm wrote:
On 06/04/2018 12:51 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at 05:24:53PM +0300, Ari Sundholm wrote:
On 06/01/2018 04:32 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at 12
On 06/04/2018 12:51 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at 05:24:53PM +0300, Ari Sundholm wrote:
On 06/01/2018 04:32 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at 12:17:19AM +0300, Ari Sundholm wrote:
From: Aapo Vienamo
Thanks for the patch!
Implements a block device
On 06/01/2018 06:05 PM, Eric Blake wrote:
On 06/01/2018 08:31 AM, Ari Sundholm wrote:
+++ b/block/blklogwrites.c
@@ -0,0 +1,441 @@
+/*
+ * Write logging blk driver based on blkverify and blkdebug.
+ *
+ * Copyright (c) 2017 Tuomas Tynkkynen
+ * Copyright (c) 2018 Aapo Vienamo
+ * Copyright (c
On 06/01/2018 04:32 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at 12:17:19AM +0300, Ari Sundholm wrote:
From: Aapo Vienamo
Thanks for the patch!
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
On 06/01/2018 03:26 PM, Eric Blake wrote:
On 05/31/2018 04:17 PM, Ari Sundholm wrote:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
[meta-comment]
Your patch threading is awkward - you forgot a cover letter, and then
you did deep threading
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 43
the writes more faithfully for those
devices that have a non-512 logical sector size.
Note that even with this patch, blklogwrites still uses
BDRV_SECTOR_SIZE for logging. This will change in a subsequent patch
which will introduce support for non-512 sector sizes.
Signed-off-by: Ari Sundholm
.
Signed-off-by: Aapo Vienamo
Signed-off-by: Ari Sundholm
---
block.c | 6 -
block/Makefile.objs | 1 +
block/blklogwrites.c | 441 ++
include/block/block.h | 7 +
4 files changed, 449 insertions(+), 6 deletions(-)
create mode
and the associated backend through a new callback.
Signed-off-by: Ari Sundholm
---
block/io.c| 19 +++
hw/block/block.c | 11 ++-
include/block/block.h | 10 ++
include/block/block_int.h | 9 +
include/hw/block/block.h | 1 +
5 files
91 matches
Mail list logo
