Re: [Qemu-block] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard

2015-05-22 Thread Eric Blake
On 05/21/2015 09:40 PM, Fam Zheng wrote: Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that the guest sees the same data.

[Qemu-block] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard

2015-05-21 Thread Fam Zheng
Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that the guest sees the same data. Calling bdrv_reset_dirty also troubles mirror job because the