Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Eric Blake
On 06/10/2015 01:57 AM, Kevin Wolf wrote: The statistic I'm interested in is the allocation of the block device (the host offset, aka wr_highest_offset 72482304 above), and NOT the usage pattern of the guest (the qcow2 protocol, wr_highest_offset 9129332224). But bdrv_lookup_bs() finds the

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Kevin Wolf
Am 10.06.2015 um 00:35 hat Eric Blake geschrieben: On 06/06/2015 07:38 PM, Eric Blake wrote: Commit e2462113 allowed the ability to fire an event if a BDS node exceeds a threshold during a write, but limited the option to only work on node names. For convenience, expand this to allow a

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Kevin Wolf
Am 10.06.2015 um 15:07 hat Eric Blake geschrieben: On 06/10/2015 01:57 AM, Kevin Wolf wrote: The statistic I'm interested in is the allocation of the block device (the host offset, aka wr_highest_offset 72482304 above), and NOT the usage pattern of the guest (the qcow2 protocol,

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Eric Blake
On 06/10/2015 07:43 AM, Kevin Wolf wrote: Let's stay away from such magic, as much as we can. libvirt can just specify a node-name for the protocol layer and use that. Okay, I'll probably abandon this patch, then, but still work on something to make node names easier for libvirt to

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-09 Thread Eric Blake
On 06/06/2015 07:38 PM, Eric Blake wrote: Commit e2462113 allowed the ability to fire an event if a BDS node exceeds a threshold during a write, but limited the option to only work on node names. For convenience, expand this to allow a device name as a way to set the threshold on the BDS at

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-07 Thread Amos Kong
On Sun, Jun 7, 2015 at 9:38 AM, Eric Blake ebl...@redhat.com wrote: Commit e2462113 allowed the ability to fire an event if a BDS node exceeds a threshold during a write, but limited the option to only work on node names. For convenience, expand this to allow a device name as a way to set