Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/3] block: Introduce BDS.growing

| 2 ++ block/nbd.c | 2 ++ block/qcow2.c | 5 + block/quorum.c| 5 + block/raw_bsd.c | 1 + include/block/block_int.h | 3 +++ 9 files changed, 26 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [PATCH v5 05/13] block: Move BDS close notifiers into BB

| 10 ++ include/sysemu/block-backend.h | 3 +- nbd.c | 13 +++ 10 files changed, 159 insertions(+), 68 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http

Re: [Qemu-block] [PATCH v5 09/13] block: Add list of all BlockDriverStates

good enough for: Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 1/1] block: New command line option --misc format-probing=off

uniformly used. I'm okay if this topic proves too controversial to add into 2.3 at this late in the cycle, even though I'm in favor of adding it. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

), and cover all files in the repo in one go, without affecting this series. Such a patch by a copyright owner would have no problem being accepted, if it is wanted. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block/null: Support reopen

...@redhat.com --- block/null.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] qemu-img behavior for locating backing files

and create no image. Sounds like a bug fix, not a regression. Since this is a change in behavior for the pending release, is this the correct/desired behavior? Yes, I think so. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] block-commit dropping privs

A-C 1233 Bug #5 - QMP commit doesn't offer a way to rewrite chain when committing across multiple images -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v6 01/21] docs: incremental backup documentation

On 04/17/2015 05:49 PM, John Snow wrote: Signed-off-by: John Snow js...@redhat.com --- docs/bitmaps.md | 352 1 file changed, 352 insertions(+) create mode 100644 docs/bitmaps.md Reviewed-by: Eric Blake ebl...@redhat.com

Re: [Qemu-block] [PATCH 1/8] block: keep a list of block jobs

| 13 + include/block/blockjob.h | 14 ++ 3 files changed, 35 insertions(+), 11 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [PATCH v6 07/21] hbitmap: add hbitmap_merge

--- include/qemu/hbitmap.h | 13 + util/hbitmap.c | 33 + 2 files changed, 46 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PATCH v6 10/21] qmp: Add support of dirty-bitmap sync mode for drive-backup

...@redhat.com Signed-off-by: John Snow js...@redhat.com --- Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer

-core.json | 10 +++--- tests/qemu-iotests/030 | 2 +- 3 files changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

hard disk 0 Standard options: ... Signed-off-by: Don Slutz dsl...@verizon.com --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com Without this, qemu will try to probe formats. It is arguably is more convenient when using

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

On 04/30/2015 01:15 PM, Eric Blake wrote: [adding qemu-block] On 04/30/2015 12:23 PM, Don Slutz wrote: ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard usage: qemu-system-x86_64 [options] [disk_image

Re: [Qemu-block] [PATCH v4 13/17] qcow2/overlaps: Add memory limit reached event

, +data: { reference: virtio0, start: 805306368, + length: 268435456 }, s/805306368/805306368/ and likewise for length (a json-int does not use quotes). Otherwise seems okay. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [Qemu-devel] [PATCH 2/6] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty()

= 0; i c-size; i++) { -if (table_addr(c, i) == table) { -goto found; -} -} -abort(); - -found: +int i = (table - c-table_array) / c-table_size; and again. +assert(c-entries[i].offset != 0); c-entries[i].dirty = true; } -- Eric Blake

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

and change both functions. I'm not strongly opposed to keeping snprintf, but agree that if you want to clean it up to g_strdup_printf(), a separate patch hitting multiple uses would be cleaner than respinning this patch. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page

style issues. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v4 16/17] qapi: Expose new qcow2 overlap check options

', '*overlap-check': 'Qcow2OverlapChecks', +'*overlap-structures': 'Qcow2OverlapStructures', '*cache-size': 'int', '*l2-cache-size': 'int', '*refcount-cache-size': 'int' } } -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

of on your behalf. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 03/34] quorum: Use bdrv_open_image()

--- block/quorum.c | 51 +++ 1 file changed, 11 insertions(+), 40 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

On 05/08/2015 02:10 PM, Eric Blake wrote: On 05/08/2015 11:47 AM, Dimitris Aragiorgis wrote: Building the QEMU tools fails if we #define DEBUG_BLOCK inside block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y so that DEBUG_BLOCK_PRINT can be used, we substitute the latter

Re: [Qemu-block] [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

On 05/08/2015 11:21 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [Qemu-devel] [PATCH 06/34] block: Use QemuOpts in bdrv_open_common()

-coding everything. s/managable/manageable/ Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [PATCH 3/7] qcow2: use an LRU algorithm to replace entries from the L2 cache

the table some hits for the start so that it won't be replaced * immediately. The number 32 is completely arbitrary. */ -c-entries[i].cache_hits = 32; c-entries[i].offset = offset; The comment is now dead. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [Qemu-devel] [PATCH 09/34] block: Add BlockDriverState.inherits_from

--- block.c | 17 + include/block/block_int.h | 4 2 files changed, 21 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

0 #endif #define DPRINTF(fmt, ...) \ do \ if (DEBUG_BLOCK_PRINT) { \ printf(fmt, ## __VA_ARGS__); \ while (0) that way, the compiler checks that the printf format arguments are valid while still optimizing out the if(0) code. -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] qcow2/qcow: protect against uninitialized encryption key

changed, 21 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 3/5] util: allow \n to terminate password input

case we must look for \n to terminate password input. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- util/oslib-posix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH 18/34] qcow2: Fix memory leak in qcow2_update_options() error path

On 05/08/2015 11:21 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [Qemu-devel] [PATCH 15/34] qcow2: Move qcow2_update_options() call up

(). Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure

1 file changed, 32 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions

++ 1 file changed, 67 insertions(+), 34 deletions(-) In isolation, it looks like a valid conversion, so: Reviewed-by: Eric Blake ebl...@redhat.com However, given that we are having a conversation on another thread about semantics for prepare vs. commit being the action that actually

Re: [Qemu-block] [PATCH v3 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

, XFS_IOC_UNRESVSP64, fl) 0) { -DEBUG_BLOCK_PRINT(cannot punch hole (%s)\n, strerror(errno)); +DPRINTF(cannot punch hole (%s)\n, strerror(errno)); return -errno; Here too. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [Qemu-devel] [PATCH 31/34] block: Move cache options into options QDict

to see how hard it would be to modernize a bit, since I've already been touching in that area (the recent addition of qnull copied heavily from qbool). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

On 05/13/2015 03:11 AM, Kevin Wolf wrote: Am 12.05.2015 um 22:04 hat Eric Blake geschrieben: On 05/08/2015 11:21 AM, Kevin Wolf wrote: Eventually we want to be able to change options at runtime. As a first step towards that goal, separate some option handling code from the general

Re: [Qemu-block] [Qemu-devel] [PATCH 10/34] block: Fix reopen flag inheritance

. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 13 +++-- block/vmdk.c | 28 ++-- 2 files changed, 13 insertions(+), 28 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH 13/34] qemu-io: Add command 'reopen'

or upper case, so you added one of each :) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[Qemu-block] [PATCH] qemu-io: Use getopt() correctly

POSIX says getopt() returns -1 on completion. While Linux happens to define EOF as -1, this definition is not required by POSIX, and there may be platforms where checking for EOF instead of -1 would lead to an infinite loop. Signed-off-by: Eric Blake ebl...@redhat.com --- qemu-io-cmds.c | 16

Re: [Qemu-block] [Qemu-devel] [PATCH 12/34] block: Allow specifying driver-specific options to reopen

+ * (the BlockReopenQueue takes the ownership) 'takes ownership' reads a bit more idiomatically, but what you have is not wrong. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v2 01/11] qapi: Add transaction support to block-dirty-bitmap operations

-schema.json | 6 +++- 2 files changed, 105 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 04/21] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

| 56 6 files changed, 250 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 01/21] docs: incremental backup documentation

assuming that [PATCH v2 00/11] block: incremental backup transactions is incomplete, because it forgot to clean this up as part of adding transaction support. + +5. Retry the command after fixing the underlaying problem, s/underlaying/underlying/ -- Eric Blake eblake redhat com+1-919-301

Re: [Qemu-block] [PATCH v5 01/21] docs: incremental backup documentation

On 04/17/2015 09:50 AM, John Snow wrote: On 04/17/2015 11:06 AM, Eric Blake wrote: On 04/08/2015 04:19 PM, John Snow wrote: Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: John Snow js...@redhat.com --- docs/bitmaps.md | 311

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file

insertions(+), 7 deletions(-) create mode 100755 tests/qemu-iotests/130 create mode 100644 tests/qemu-iotests/130.out Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

(errp, Block format '%s' used by device '%s' + does not support internal snapshots, + bs-drv-format_name, device); but this is probably another one where node may be better. But it's already a strict improvement, so I can live with: Reviewed-by: Eric Blake ebl

Re: [Qemu-block] [Qemu-devel] [RFC] Intermediate block mirroring

something worth having. The devil may be in the details, but we can get there when you post proposed patches. Thanks, Berto -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH] MAINTAINERS: Split Block QAPI, monitor, command line off core

On 05/20/2015 05:23 AM, Markus Armbruster wrote: Kevin and Stefan asked me to take care of this part. Signed-off-by: Markus Armbruster arm...@redhat.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com diff --git a/MAINTAINERS b

Re: [Qemu-block] [PATCH v3 08/38] block: Invoke change media CB before NULLing drv

deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 13/38] block: Remove wr_highest_sector from BlockAcctStats

block/io.c | 4 +++- block/qapi.c | 4 ++-- include/block/accounting.h | 3 --- include/block/block_int.h | 3 +++ qmp-commands.hx| 4 ++-- 6 files changed, 10 insertions(+), 16 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric

Re: [Qemu-block] [PATCH v3 18/38] block: Fail requests to empty BlockBackend

++- 1 file changed, 54 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 10/38] hw/usb-storage: Check whether BB is inserted

error handling here (https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg00431.html) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 04/38] block: Make bdrv_is_inserted() return a bool

On 06/03/2015 01:43 PM, Max Reitz wrote: Make bdrv_is_inserted(), blk_is_inserted(), and the callback BlockDriver.bdrv_is_inserted() return a bool. Suggested-by: Eric Blake ebl...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- block.c| 12

Re: [Qemu-block] [PATCH v3 01/38] block: Remove host floppy support

insertions(+), 226 deletions(-) Dropping is not backwards-compatible, but that was the whole point of deprecating it to make it obvious that we planned to do it. Reviewed-by: Eric Blake ebl...@redhat.com @@ -2283,14 +2221,13 @@ static int hdev_create(const char *filename, QemuOpts *opts, int64_t

Re: [Qemu-block] [PATCH v3 02/38] blockdev: Allow creation of BDS trees without BB

+++- qapi/block-core.json | 13 + tests/qemu-iotests/087 | 2 +- tests/qemu-iotests/087.out | 4 ++-- 4 files changed, 43 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [PATCH v3 09/38] hw/block/fdc: Implement tray status

, but does not have to be this series. Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH 1/9] qapi: Rename 'dirty-bitmap' mode to 'incremental'

| 8 include/block/block_int.h | 2 +- qapi/block-core.json | 8 qmp-commands.hx | 6 +++--- tests/qemu-iotests/124| 10 +- 7 files changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [PATCH 2/9] hbitmap: add hbitmap_copy

/hbitmap.h | 9 + util/hbitmap.c | 17 + 2 files changed, 26 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [PATCH 5/9] qmp: add qmp cmd block-dirty-bitmap-copy

small enough, even if you leave it in, that I don't mind giving: Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 26/38] blockdev: Add blockdev-open-tray

On 06/03/2015 01:44 PM, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- blockdev.c | 48 qapi/block-core.json | 23 +++ qmp-commands.hx | 39

Re: [Qemu-block] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium

...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- blockdev.c| 7 --- include/sysemu/blockdev.h | 2 -- qapi-schema.json | 6 -- qapi/block-core.json | 23 +++ qmp-commands.hx | 31

Re: [Qemu-block] [PATCH v8 07/10] qcow2: Add function for refcount order amendment

| 4 + 2 files changed, 451 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 38/38] iotests: Add test for change-related QMP commands

@@ -121,6 +121,7 @@ 114 rw auto quick 115 rw auto 116 rw auto quick +118 rw auto 121 rw auto Wow - we've got several placeholders pending review :) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PATCH v3 31/38] blockdev: Implement change with basic operations

--- blockdev.c | 185 + 1 file changed, 77 insertions(+), 108 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [PATCH v8 08/10] qcow2: Invoke refcount order amendment function

(+), 9 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 14/38] block: Move BlockAcctStats into BlockBackend

On 06/05/2015 04:47 AM, Alberto Garcia wrote: On Wed 03 Jun 2015 10:52:34 PM CEST, Eric Blake wrote: As the comment above bdrv_get_stats() says, BlockAcctStats is something which belongs to the device instead of each BlockDriverState. This patch therefore moves it into the BlockBackend

Re: [Qemu-block] [Qemu-devel] [PATCH] block: record new size in bdrv_dirty_bitmap_truncate

+ 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake ebl...@redhat.com diff --git a/block.c b/block.c index 2b9ceae..2786e47 100644 --- a/block.c +++ b/block.c @@ -3224,6 +3224,7 @@ static void bdrv_dirty_bitmap_truncate(BlockDriverState *bs) continue

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

Signed-off-by: Kevin Wolf kw...@redhat.com --- block/raw-posix.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

to exclude subscribers merely based on their preference on duplicate mail receipt. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[Qemu-block] [PATCH] block: allow write-threshold on device name

-by: Eric Blake ebl...@redhat.com --- block/write-threshold.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/write-threshold.c b/block/write-threshold.c index a53c1f5..e3df419 100644 --- a/block/write-threshold.c +++ b/block/write-threshold.c @@ -1,7 +1,7 @@ /* * QEMU

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

operation to unmap); +} I think it might be better to have a tri-state enum, than to have two competing bools where only 3 of the 4 states are valid. We haven't yet committed to the 'unmap' bool, so we still have time to get the API right. -- Eric Blake eblake redhat com+1-919-301

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/3] qapi: Add detect-zeroes option to drive-mirror

of the source being fully allocated (or at least being unable to tell us about holes) 3. We want the dest to mirror the sparseness of the host, but only where that is efficient (if the source reads holes, make a hole in the dest) 4. Any other modes? -- Eric Blake eblake redhat com+1-919-301

Re: [Qemu-block] [PATCH v7 2/8] qmp: Add optional bool unmap to drive-mirror

behaviors without an explosion into multiple knobs? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] I/O accounting overhaul

. Thanks, Berto -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

of a thread). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

specify a node-name for the protocol layer and use that. Okay, I'll probably abandon this patch, then, but still work on something to make node names easier for libvirt to integrate with. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

more, the active BDS of the device is NOT the node that libvirt wants, so adding device semantics did not help libvirt), so much as capturing the state of the patch before I abandon it. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org From

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

On 06/06/2015 07:38 PM, Eric Blake wrote: Commit e2462113 allowed the ability to fire an event if a BDS node exceeds a threshold during a write, but limited the option to only work on node names. For convenience, expand this to allow a device name as a way to set the threshold on the BDS

Re: [Qemu-block] [Qemu-devel] [PATCH v7 00/11] Support streaming to an intermediate layer

message is sane). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v4 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

two source bytes, but doesn't change correctness, so: Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] NVMe volatile write cache fixes

(git format-patch/send-email --cover-letter is your friend). Also, you forgot to cc: the maintainer and the primary qemu-devel list (qemu-devel should be included in ALL patches, and scripts/get_maintainer.pl will help you learn maintainers). I've added them in cc. -- Eric Blake eblake redhat

Re: [Qemu-block] [PATCH v2 01/13] qdict: Add qdict_array_entries()

+--- 2 files changed, 75 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion

...@redhat.com --- block.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common()

-coding everything. s/managable/manageable/ Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [PATCH v2 03/13] check-qdict: Test cases for new functions

+ 1 file changed, 67 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default()

-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH RFC 3/3] block/nfs: switch to error_init_local

= error_init_local(errp); Should be a fairly mechanical patch to catch all the spots; although there are multiple spellings (not all callers name it local_err). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [PATCH v2 11/13] block: Add list of children to BlockDriverState

points to the newly swapped in BDS. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 37 + include/block/block_int.h | 8 2 files changed, 45 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [PATCH v2 09/13] block: Drain requests before swapping nodes in bdrv_swap()

to just drain the request queue of both devices in bdrv_swap() instead of relying on callers to do the right thing. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] ahci: Do not ignore memory access read size

, or even what real hardware does, but you may want to mask things at both return statements, to guarantee a stable result limited to size bytes of information rather than leaking nearby bytes from the rest of the registers being read. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/38] block/quorum: Implement bdrv_is_inserted()

On 06/04/2015 06:37 AM, Alberto Garcia wrote: On Wed 03 Jun 2015 09:43:48 PM CEST, Max Reitz wrote: bdrv_is_inserted() should be invoked recursively on the children of quorum. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- +static bool

Re: [Qemu-block] [Qemu-devel] [PATCH 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach()

On 05/28/2015 06:21 AM, Markus Armbruster wrote: Cc: Kevin Wolf kw...@redhat.com Cc: qemu-block@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com --- block/blkdebug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com

Re: [Qemu-block] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time

(as a sub-struct of BlockDeviceInfo)? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [RFC PATCH 02/12] block: Introduce bdrv_lock and bdrv_unlock API

to those more familiar with coroutines. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier

; ...like here But I'll probably let others do the technical review. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time

. But that's ugly. Yeah, I'm not sure such duplication helps. I'd still like it reported somewhere, though, as it is nice to query that a requested setting is actually working. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [PATCH v6 2/8] qmp: Add optional bool unmap to drive-mirror

, or that full allocation cannot be guaranteed, when the unmap parameter is not detected). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v4 2/8] qmp: Add optional bool unmap to drive-mirror

explanation? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard

Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- block/io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

  1   2   3   4   5   6   7   8   9   10   >