Re: [Qemu-devel] [PATCH v5 15/15] test: add image streaming test cases

2012-01-18 Thread Stefan Hajnoczi
On Tue, Jan 17, 2012 at 7:07 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: On 01/13/2012 02:49 PM, Stefan Hajnoczi wrote: Hi Lucas, The Python script below verifies the image streaming feature.  It's built on the standard library unittest module, as well as QEMU's qmp.py module.  It

Re: [Qemu-devel] [PATCH 1/6] qtest: add test framework

2012-01-18 Thread Stefan Hajnoczi
On Tue, Jan 17, 2012 at 11:13 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jan 16, 2012 at 5:08 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 01/16/2012 10:59 AM, Stefan Hajnoczi wrote: On Fri, Jan 13, 2012 at 6:32 PM, Anthony Liguorialigu...@us.ibm.com  wrote: +    if

Re: [Qemu-devel] [RFC PATCH v3 2/3] simpletrace-v2: Handle variable number/size of elements per trace record.

2012-01-18 Thread Harsh Bora
On 01/10/2012 10:11 PM, Stefan Hajnoczi wrote: On Tue, Jan 10, 2012 at 10:59 AM, Harsh Prateek Bora ha...@linux.vnet.ibm.com wrote: Advantages over existing simpletrace backend: - More than 6 elements (vitually unlimited) arguments can be traced. - This allows to trace strings (variable size

Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild event list in backend code

2012-01-18 Thread Harsh Bora
On 01/11/2012 11:35 PM, Lluís Vilanova wrote: Signed-off-by: Lluís Vilanovavilan...@ac.upc.edu --- scripts/tracetool.py | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index 6874f66..80e5684 100755 ---

[Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Chunyan Liu
Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. Add -f option to qemu-nbd to find a free nbd device for user and connect disk image to that device. syntax: qemu-nbd -f disk.img

Re: [Qemu-devel] [PATCH 3/6] trace: [ŧracetool] Do not precompute the event number

2012-01-18 Thread Harsh Bora
On 01/11/2012 11:35 PM, Lluís Vilanova wrote: This would otherwise break event numbering when actually using the disable property. IIUC, event numbering does include disabled events too, are you proposing not to include disabled events in event numbering ? That will affect interpreting

Re: [Qemu-devel] [PATCH v7 00/18] uq/master: Introduce basic irqchip support

2012-01-18 Thread Marcelo Tosatti
On Mon, Jan 16, 2012 at 04:55:34PM +0100, Jan Kiszka wrote: Changes in v7: - introduce {apic,pic,ioapic}_qdev_register and use {APIC,PIC,IOAPIC}CommonInfo to move more code into the common modules - clean up forgotten fragments of backend/frontend approach - rephrased potentially misleading

[Qemu-devel] [PATCH] grackle_pci: Clean up qdev names

2012-01-18 Thread Andreas Färber
Rename SysBus device from 'grackle' to 'grackle-pcihost' to resolve a name conflict. Also mark both devices as no_user. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Alexander Graf ag...@suse.de Cc: Anthony Liguori aligu...@us.ibm.com --- hw/grackle_pci.c | 17 - 1 files

Re: [Qemu-devel] [RFC PATCH v3 2/3] simpletrace-v2: Handle variable number/size of elements per trace record.

2012-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2012 at 9:14 AM, Harsh Bora ha...@linux.vnet.ibm.com wrote: On 01/10/2012 10:11 PM, Stefan Hajnoczi wrote: +            unused = fwrite(record, ST_V2_REC_HDR_LEN, 1, trace_fp);             writeout_idx += num_available;         }         idx = writeout_idx % TRACE_BUF_LEN; -

[Qemu-devel] [RFC PATCH 1/9] qtest: always send a response

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qtest.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qtest.c b/qtest.c index f41a9c3..abfdab9 100644 --- a/qtest.c +++ b/qtest.c @@ -241,7 +241,8 @@ static void qtest_process_command(CharDriverState *chr, gchar

[Qemu-devel] [RFC PATCH 0/9] qtest fixes and alternative IRQ intercept proposal

2012-01-18 Thread Paolo Bonzini
Anthony, here are some random qtest patches, for incorporation in your series or just as food for thought. Patch 1 makes the tests fail with an assertion failure if libqtest screws up, rather than just having them sit waiting for a response that will never come. Patch 2 makes -qtest stdio a bit

[Qemu-devel] [RFC PATCH 2/9] qtest: enable echo

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qtest.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qtest.c b/qtest.c index abfdab9..c2fbf50 100644 --- a/qtest.c +++ b/qtest.c @@ -341,6 +341,7 @@ int qtest_init(void) chr = qemu_chr_new(qtest, qtest_chrdev,

[Qemu-devel] [RFC PATCH 7/9] qtest: IRQ interception infrastructure

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/irq.c | 18 +++ hw/irq.h |3 ++ hw/pc_piix.c |2 - qtest.c | 96 - qtest.h |2 - 5 files changed, 88 insertions(+), 33 deletions(-) diff --git

[Qemu-devel] [RFC PATCH 5/9] qtest: do not use TCG CPU threads

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-exec.c |4 --- cpus.c | 62 +-- 2 files changed, 59 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index bf5a2aa..4cb079f 100644 --- a/cpu-exec.c +++

Re: [Qemu-devel] [PATCH 3/6] trace: [ŧracetool] Do not precompute the event number

2012-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2012 at 9:48 AM, Harsh Bora ha...@linux.vnet.ibm.com wrote: On 01/11/2012 11:35 PM, Lluís Vilanova wrote: This would otherwise break event numbering when actually using the disable property. IIUC, event numbering does include disabled events too, are you proposing not to

Re: [Qemu-devel] [RFC PATCH v3 2/3] simpletrace-v2: Handle variable number/size of elements per trace record.

2012-01-18 Thread Harsh Bora
On 01/18/2012 04:01 PM, Stefan Hajnoczi wrote: On Wed, Jan 18, 2012 at 9:14 AM, Harsh Boraha...@linux.vnet.ibm.com wrote: On 01/10/2012 10:11 PM, Stefan Hajnoczi wrote: +unused = fwrite(record, ST_V2_REC_HDR_LEN, 1, trace_fp); writeout_idx += num_available; }

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 09:48 AM, Chunyan Liu wrote: Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. Add -f option to qemu-nbd to find a free nbd device for user and connect disk image

[Qemu-devel] [RFC PATCH 8/9] libqtest: add IRQ intercept commands

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/libqtest.c | 12 tests/libqtest.h |6 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index dd07b07..1d1b06e 100644 --- a/tests/libqtest.c +++

Re: [Qemu-devel] [RFC PATCH v3 2/3] simpletrace-v2: Handle variable number/size of elements per trace record.

2012-01-18 Thread Harsh Bora
On 01/18/2012 04:11 PM, Harsh Bora wrote: On 01/18/2012 04:01 PM, Stefan Hajnoczi wrote: On Wed, Jan 18, 2012 at 9:14 AM, Harsh Boraha...@linux.vnet.ibm.com wrote: On 01/10/2012 10:11 PM, Stefan Hajnoczi wrote: + unused = fwrite(record, ST_V2_REC_HDR_LEN, 1, trace_fp); writeout_idx +=

Re: [Qemu-devel] [RFC PATCH 5/9] qtest: do not use TCG CPU threads

2012-01-18 Thread Andreas Färber
Am 18.01.2012 11:33, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-exec.c |4 --- cpus.c | 62 +-- 2 files changed, 59 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Michael Tokarev
On 18.01.2012 12:48, Chunyan Liu wrote: Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. There's a (trivial) fix sent against qemu-nbd which will make this patch to not

Re: [Qemu-devel] [RFC PATCH v3 2/3] simpletrace-v2: Handle variable number/size of elements per trace record.

2012-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2012 at 10:52 AM, Harsh Bora ha...@linux.vnet.ibm.com wrote: On 01/18/2012 04:11 PM, Harsh Bora wrote: On 01/18/2012 04:01 PM, Stefan Hajnoczi wrote: On Wed, Jan 18, 2012 at 9:14 AM, Harsh Boraha...@linux.vnet.ibm.com wrote: On 01/10/2012 10:11 PM, Stefan Hajnoczi wrote:

[Qemu-devel] [RFC PATCH 4/9] rtc-test: fix set_alarm_time

2012-01-18 Thread Paolo Bonzini
GCC (correctly) reports uninitialized variables. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/rtc-test.c | 22 -- 1 files changed, 4 insertions(+), 18 deletions(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 7f0b590..1645b34 100644 ---

[Qemu-devel] [RFC PATCH 6/9] pc: attach ioapic to the QOM composition tree

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc_piix.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 2aba89c..3f92bf9 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -54,7 +54,7 @@ static const int

Re: [Qemu-devel] [RFC PATCH v3 2/3] simpletrace-v2: Handle variable number/size of elements per trace record.

2012-01-18 Thread Harsh Bora
On 01/18/2012 04:29 PM, Stefan Hajnoczi wrote: On Wed, Jan 18, 2012 at 10:52 AM, Harsh Boraha...@linux.vnet.ibm.com wrote: On 01/18/2012 04:11 PM, Harsh Bora wrote: On 01/18/2012 04:01 PM, Stefan Hajnoczi wrote: On Wed, Jan 18, 2012 at 9:14 AM, Harsh Boraha...@linux.vnet.ibm.com wrote:

[Qemu-devel] [RFC PATCH 9/9] rtc-test: add IRQ intercept

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/rtc-test.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 1645b34..8280f45 100644 --- a/tests/rtc-test.c +++ b/tests/rtc-test.c @@ -249,6 +249,7 @@ int main(int argc,

Re: [Qemu-devel] [RFC PATCH 5/9] qtest: do not use TCG CPU threads

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 11:53 AM, Andreas Färber wrote: -if (kvm_enabled() !env-thread_kicked) { +if (!tcg_enabled() !env-thread_kicked) { -if (kvm_enabled()) { +if (!tcg_enabled()) { if (kvm_enabled()) { qemu_kvm_start_vcpu(env); -} else { +} else

[Qemu-devel] [RFC PATCH 3/9] qtest: fix Makefile

2012-01-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index a6b993c..6acb3e2 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -77,7 +77,7 @@ check-qtest-%: $(HW_TESTS)

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 11:56 AM, Michael Tokarev wrote: On 18.01.2012 12:48, Chunyan Liu wrote: Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. There's a (trivial) fix sent against

Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild event list in backend code

2012-01-18 Thread Lluís Vilanova
Harsh Bora writes: On 01/11/2012 11:35 PM, Lluís Vilanova wrote: Signed-off-by: Lluís Vilanovavilan...@ac.upc.edu --- scripts/tracetool.py | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index

Re: [Qemu-devel] [PATCH v7 07/10] ARM: exynos4210: MCT support.

2012-01-18 Thread Peter Maydell
On 16 January 2012 06:48, Evgeny Voevodin e.voevo...@samsung.com wrote: This doesn't compile on 32 bit hosts: CCarm-softmmu/exynos4210_mct.o cc1: warnings being treated as errors /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In function ‘exynos4210_gcomp_get_distance’:

[Qemu-devel] [PATCH] open /dev/nbd in nbd_client_thread

2012-01-18 Thread Paolo Bonzini
Commit a61c678 (qemu-nbd: use common main loop, 2011-09-12) changed code to use local variable fd in qemu-nbd.c:main() in two places: for /dev/nbd device and for control socket. The result is that qemu-nbd -c $device does not work anymore. Opening the device in the client thread fixes the bug.

Re: [Qemu-devel] [PATCH v7 09/10] hw/exynos4210.c: Add LAN support for SMDKC210.

2012-01-18 Thread Peter Maydell
On 16 January 2012 06:48, Evgeny Voevodin e.voevo...@samsung.com wrote: SMDKC210 uses lan9215 chip, but lan9118 in 16-bit mode seems to be enough. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild event list in backend code

2012-01-18 Thread Lluís Vilanova
Lluís Vilanova writes: Harsh Bora writes: Hi Lluis, This looks really nice. I can include your fixes while addressing other review comments. Shall I fold your patches with mine or do you want to keep them separate? Whatever works best for you. BTW, I did some more changes, but didn't

[Qemu-devel] [PATCH 2/4] arm: Remove incorrect comment in arm_timer

2012-01-18 Thread Peter Maydell
From: Mark Langsdorf mark.langsd...@calxeda.com The current comment says that the arm_timers are restricted to between 32 KHz and 1 MHz, but sp804 TRM does not specify those limits. Signed-off-by: Mark Langsdorf mark.langsd...@calxeda.com Reviewed-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH 1/4] vexpress, realview: Add (dummy) L2 cache controller

2012-01-18 Thread Peter Maydell
Instantiate the L2 cache controller on the ARM devboards which have one, since we have a dummy model of it now. Note that the only non-MP board with an L2x0 is the PB1176, which we don't model. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/realview.c |2 ++ hw/vexpress.c |

[Qemu-devel] [PULL 0/4] arm-devs queue

2012-01-18 Thread Peter Maydell
This is a smallish pullreq for a few arm-devs patches which have been on the list for a while. The two patches from Mark were in the highbank patchset, but I'd like to get them committed now because they're needed for other patchsets (vexpress-a15, exynos). Please pull. thanks -- PMM The

[Qemu-devel] [PATCH 3/4] hw/lan9118: Add save/load support

2012-01-18 Thread Peter Maydell
Implement save/load for the LAN9118. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Andreas Färber afaer...@suse.de --- hw/lan9118.c | 126 +++--- 1 files changed, 103 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PATCH 4/4] arm: make the number of GIC interrupts configurable

2012-01-18 Thread Peter Maydell
From: Mark Langsdorf mark.langsd...@calxeda.com Increase the maximum number of GIC interrupts for a9mp and a11mp to 1020, and create a configurable property for each defaulting to 96 and 64 (respectively) so that device modelers can set the value appropriately for their SoC. Other ARM processors

[Qemu-devel] New MIPS64R2 Target in QEMU

2012-01-18 Thread Zain Ahmed
I am trying to emulate a new MIPS64R2 based target in QEMU, which actually uses U-Boot as a bootloader. Can I skip U-Boot and and directly load the kernel as it is done in Matla Mips 64 board. If no what values or pointers are required to be passed to the kernel?? Regards, Zain

Re: [Qemu-devel] Fwd: envlist_setenv...

2012-01-18 Thread 陳韋任
On Tue, Jan 17, 2012 at 09:54:36PM +0100, Davide wrote: What does this loop in main? for (wrk = environ; *wrk != NULL; wrk++) { (void) envlist_setenv(envlist, *wrk); } Seems the return value (error code) of envlist_setenv is ignored here... -- Wei-Ren Chen (陳韋任)

Re: [Qemu-devel] Fwd: envlist_setenv...

2012-01-18 Thread 陳韋任
Hi, What does this loop in main? for (wrk = environ; *wrk != NULL; wrk++) { (void) envlist_setenv(envlist, *wrk); } You can check envlist.[ch] first. I think what the loop does is copying host environ (user environment. HOME, SHELL, PATH...etc) to struct envlist

[Qemu-devel] Network traffic stuck in QEMU IO path?

2012-01-18 Thread Fischer, Anna
Hi, I'm running qemu-kvm-0.12.1.2. I know it is an old version, but I hope people can still help me with this. I run a VIF for my virtual machine with the following settings in the qemu command: -netdev tap,ifname=vif-0-3, ,id=hostnet0 -device

[Qemu-devel] [RFC PATCH 10/9] qtest: add clock management

2012-01-18 Thread Paolo Bonzini
This patch combines qtest and -icount together to turn the vm_clock into a source that can be fully managed by the client. To this end new commands clock_step and clock_set are added. Hooking them with libqtest is left as an exercise to the reader. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v6 02/16] block: check bdrv_in_use() before blockdev operations

2012-01-18 Thread Stefan Hajnoczi
Long-running block operations like block migration and image streaming must have continual access to their block device. It is not safe to perform operations like hotplug, eject, change, resize, commit, or external snapshot while a long-running operation is in progress. This patch adds the

[Qemu-devel] [PATCH v6 00/16] block: generic image streaming

2012-01-18 Thread Stefan Hajnoczi
This series adds the 'block_stream' command which copies the contents of a backing file into the image file while the VM is running. These patches are based on Kevin Wolf's block tree. Previously this series was based on the zero detection series but Kevin pointed out there is no hard

[Qemu-devel] [PATCH v6 08/16] qmp: add block_job_set_speed command

2012-01-18 Thread Stefan Hajnoczi
Add block_job_set_speed, which sets the maximum speed for a background block operation. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- blockdev.c | 25 + hmp-commands.hx | 14 ++ hmp.c| 11 +++ hmp.h

[Qemu-devel] [PATCH v6 04/16] block: add BlockJob interface for long-running operations

2012-01-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 48 block_int.h | 40 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index edfab49..2baac95

[Qemu-devel] [PATCH v6 01/16] coroutine: add co_sleep_ns() coroutine sleep function

2012-01-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + qemu-coroutine-sleep.c | 38 ++ qemu-coroutine.h |9 + 3 files changed, 48 insertions(+), 0 deletions(-) create mode 100644

[Qemu-devel] [PATCH v6 05/16] block: add image streaming block job

2012-01-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/stream.c | 133 block_int.h|3 + trace-events |4 ++ 4 files changed, 141 insertions(+), 0 deletions(-) create mode 100644

[Qemu-devel] [PATCH v6 06/16] block: rate-limit streaming operations

2012-01-18 Thread Stefan Hajnoczi
This patch implements rate-limiting for image streaming. If we've exceeded the bandwidth quota for a 100 ms time slice we sleep the coroutine until the next slice begins. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block/stream.c | 65

[Qemu-devel] [PATCH v6 07/16] qmp: add block_stream command

2012-01-18 Thread Stefan Hajnoczi
Add the block_stream command, which starts copy backing file contents into the image file. Also add the BLOCK_JOB_COMPLETED QMP event which is emitted when image streaming completes. Later patches add control over the background copy speed, cancelation, and querying running streaming operations.

[Qemu-devel] [PATCH v6 03/16] block: make copy-on-read a per-request flag

2012-01-18 Thread Stefan Hajnoczi
Previously copy-on-read could only be enabled for all requests to a block device. This means requests coming from the guest as well as QEMU's internal requests would perform copy-on-read when enabled. For image streaming we want to support finer-grained behavior than just populating the image

[Qemu-devel] [PATCH v6 11/16] blockdev: make image streaming safe across hotplug

2012-01-18 Thread Stefan Hajnoczi
Unplugging a storage interface like virtio-blk causes the host block device to be deleted too. Long-running operations like block migration must take a DriveInfo reference to prevent the BlockDriverState from being freed. For image streaming we can do the same thing. Note that it is not

[Qemu-devel] [PATCH v6 13/16] add QERR_BASE_NOT_FOUND

2012-01-18 Thread Stefan Hajnoczi
From: Marcelo Tosatti mtosa...@redhat.com This qerror will be raised when a given streaming base (backing file) cannot be found. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qapi-schema.json |1 + qerror.c |4

[Qemu-devel] [PATCH v6 15/16] docs: describe live block operations

2012-01-18 Thread Stefan Hajnoczi
From: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- docs/live-block-ops.txt | 58 +++ 1 files changed, 58 insertions(+), 0 deletions(-) create

[Qemu-devel] [PATCH v6 14/16] block: add support for partial streaming

2012-01-18 Thread Stefan Hajnoczi
From: Marcelo Tosatti mtosa...@redhat.com Add support for streaming data from an intermediate section of the image chain (see patch and documentation for details). Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block/stream.c |

[Qemu-devel] [PATCH v6 12/16] block: add bdrv_find_backing_image

2012-01-18 Thread Stefan Hajnoczi
From: Marcelo Tosatti mtosa...@redhat.com Add bdrv_find_backing_image: given a BlockDriverState pointer, and an id, traverse the backing image chain to locate the id. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 18

[Qemu-devel] [PATCH v6 16/16] test: add image streaming test cases

2012-01-18 Thread Stefan Hajnoczi
python test-stream.py Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- test-stream.py | 208 1 files changed, 208 insertions(+), 0 deletions(-) create mode 100644 test-stream.py diff --git a/test-stream.py b/test-stream.py

[Qemu-devel] [PATCH][qtest] gitignore: ignore qtest binaries

2012-01-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Please merge into the qtest patches so git-status(1) does not display test binaries. .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 406f75f..46dafea 100644 ---

[Qemu-devel] [PATCH v6 09/16] qmp: add block_job_cancel command

2012-01-18 Thread Stefan Hajnoczi
Add block_job_cancel, which stops an active block streaming operation. When the operation has been cancelled the new BLOCK_JOB_CANCELLED event is emitted. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- QMP/qmp-events.txt | 24 blockdev.c | 19

[Qemu-devel] [PATCH v6 10/16] qmp: add query-block-jobs

2012-01-18 Thread Stefan Hajnoczi
Add query-block-jobs, which shows the progress of ongoing block device operations. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- blockdev.c | 33 + hmp.c| 36 hmp.h|1 +

Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank

2012-01-18 Thread Peter Maydell
On 18 January 2012 14:35, Mark Langsdorf mark.langsd...@calxeda.com wrote: I can set the smp_loader code so that I can boot 2 cpus and verify their existence in /proc/cpuinfo, but I can't get 3 cpus to boot at all, no matter how I hack the existing arm_boot code. Right, multiple secondary

[Qemu-devel] [PATCH v4 6/6] qemu-io: add write -z option for bdrv_co_write_zeroes

2012-01-18 Thread Stefan Hajnoczi
Extend the qemu-io write command with the -z option to call bdrv_co_write_zeroes(). Exposing the zero write interface from qemu-io allows us to write tests that exercise this new block layer interface. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qemu-io.c | 77

[Qemu-devel] [PATCH v4 4/6] qed: replace is_write with flags field

2012-01-18 Thread Stefan Hajnoczi
Per-request attributes like read/write are currently implemented as bool fields in the QEDAIOCB struct. This becomes unwiedly as the number of attributes grows. For example, the qed_aio_setup() function would have to take multiple bool arguments and at call sites it would be hard to distinguish

[Qemu-devel] [PATCH v4 0/6] block: zero writes

2012-01-18 Thread Stefan Hajnoczi
Note: This series has been rebased onto the image streaming series which is likely to get merged first. There are no significant changes to this series since v2. This series adds an interface for efficient writes when data contains all zeros. It also takes advantage of this new interface by

[Qemu-devel] [PATCH v4 5/6] qed: add .bdrv_co_write_zeroes() support

2012-01-18 Thread Stefan Hajnoczi
Zero writes are a dedicated interface for writing regions of zeroes into the image file. If clusters are not yet allocated it is possible to use an efficient metadata representation which keeps the image file compact and does not store individual zero bytes. Implementing this for the QED image

Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank

2012-01-18 Thread Mark Langsdorf
On 01/18/2012 08:53 AM, Peter Maydell wrote: On 18 January 2012 14:35, Mark Langsdorf mark.langsd...@calxeda.com wrote: Is there a good example of how to write secondary smp boot code other than arm_boot.c? Should I just expect to pull most of arm_boot.c into highbank and adjust from there? I

Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank

2012-01-18 Thread Peter Maydell
On 18 January 2012 15:04, Mark Langsdorf mark.langsd...@calxeda.com wrote: On 01/18/2012 08:53 AM, Peter Maydell wrote: Can you try something along those lines? I think so. I was worried about accessing some of the arm_boot static variables but it doesn't look like I'll need to do that.

[Qemu-devel] [PATCH v4 3/6] block: perform zero-detection during copy-on-read

2012-01-18 Thread Stefan Hajnoczi
Copy-on-Read populates the image file with data read from a backing image. In order to avoid bloating the image file when all zeroes are read we should scan the buffer and perform an optimized zero write operation. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 14

[Qemu-devel] [PATCH v4 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2012-01-18 Thread Stefan Hajnoczi
The qemu-img.c:is_not_zero() function checks if a buffer contains all zeroes. This function will come in handy for zero-detection in the block layer, so clean it up and move it to cutils.c. Note that the function now returns true if the buffer is all zeroes. This avoids the double-negatives

[Qemu-devel] Compile QEMU for android

2012-01-18 Thread Spartacus Rex
Hi there, I am trying to get a version of qemu to compile for Android. Then I would like to boot debian-armel.. or even a minimal arm buildroot fs. I have so far tried compiling with NDK toolchain and codesourcery. You can build them, but either they seg-fault when you run them on Android or

[Qemu-devel] [PATCH][RFC] arm: add secondary cpu book callbacks to arm_boot.c

2012-01-18 Thread Mark Langsdorf
Create two functions, write_secondary_boot() and secondary_cpu_reset_hook(), to allow platforms more control of how secondary CPUs are brought up. The new functions default to NULL and aren't called unless they are populated so there are no changes to existing platform models. Signed-off-by: Mark

[Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-01-18 Thread Stefan Hajnoczi
The ability to zero regions of an image file is a useful primitive for higher-level features such as image streaming or zero write detection. Image formats may support an optimized metadata representation instead of writing zeroes into the image file. This allows zero writes to be potentially

Re: [Qemu-devel] [PATCH 3/6] qtest: add C version of test infrastructure

2012-01-18 Thread Kevin Wolf
Am 13.01.2012 19:32, schrieb Anthony Liguori: This also includes a qtest wrapper script to make it easier to launch qtest tests directly. Signed-off-by: Anthony Liguori aligu...@us.ibm.com +QTestState *qtest_init(const char *extra_args) +{ +QTestState *s; +struct sockaddr_un

Re: [Qemu-devel] [PATCH 3/6] qtest: add C version of test infrastructure

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 05:00 PM, Kevin Wolf wrote: +do { +sleep(1); This is the line that takes the greatest part of the time for make check-qtest. Can we use some shorter delay if it's required at all? You can use a client socket, listen before spawning QEMU and accept afterwards.

Re: [Qemu-devel] [PATCH 3/6] qtest: add C version of test infrastructure

2012-01-18 Thread Anthony Liguori
On 01/18/2012 10:00 AM, Kevin Wolf wrote: Am 13.01.2012 19:32, schrieb Anthony Liguori: This also includes a qtest wrapper script to make it easier to launch qtest tests directly. Signed-off-by: Anthony Liguorialigu...@us.ibm.com +QTestState *qtest_init(const char *extra_args) +{ +

[Qemu-devel] [PATCH] MAINTAINERS: Add PCI-PCI bridge to New World Mac machine

2012-01-18 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f7fc2ba..87237a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -301,6 +301,7 @@ L: qemu-...@nongnu.org S: Maintained F:

[Qemu-devel] [PATCH] PPC: Pseries: Check for PCI boundaries

2012-01-18 Thread Alexander Graf
We call pci_host_config_{read,write}_common() which perform PCI config accesses. However they don't do all limit checking the way we expect it to. So let's introduce a small wrapper around them, making them behave the way we would without touching generic code. This patch is based on a patch by

Re: [Qemu-devel] [PATCH][RFC] arm: add secondary cpu book callbacks to arm_boot.c

2012-01-18 Thread Peter Maydell
On 18 January 2012 15:50, Mark Langsdorf mark.langsd...@calxeda.com wrote: Create two functions, write_secondary_boot() and secondary_cpu_reset_hook(), to allow platforms more control of how secondary CPUs are brought up. The new functions default to NULL and aren't called unless they are

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add PCI-PCI bridge to New World Mac machine

2012-01-18 Thread Alexander Graf
On 01/18/2012 05:20 PM, Andreas Färber wrote: Signed-off-by: Andreas Färberafaer...@suse.de Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH] grackle_pci: Clean up qdev names

2012-01-18 Thread Alexander Graf
On 01/18/2012 11:11 AM, Andreas Färber wrote: Rename SysBus device from 'grackle' to 'grackle-pcihost' to resolve a name conflict. Also mark both devices as no_user. Signed-off-by: Andreas Färberafaer...@suse.de Cc: Alexander Grafag...@suse.de Cc: Anthony Liguorialigu...@us.ibm.com Thanks,

Re: [Qemu-devel] [PATCH 1/2] Rewrite the way keycode conversions are performed

2012-01-18 Thread Anthony Liguori
On 01/17/2012 01:35 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The SDL video display code needs to convert between the SDL keyboard event keycodes, and QEMU's internal keycode set (a variant of the xt coding). Currently the SDL code is only able todo this when it

Re: [Qemu-devel] [PATCH 1/2] Rewrite the way keycode conversions are performed

2012-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2012 at 10:53:57AM -0600, Anthony Liguori wrote: On 01/17/2012 01:35 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The SDL video display code needs to convert between the SDL keyboard event keycodes, and QEMU's internal keycode set (a variant of

Re: [Qemu-devel] [PATCH] PPC: Pseries: Check for PCI boundaries

2012-01-18 Thread Michael S. Tsirkin
On Wed, Jan 18, 2012 at 05:24:50PM +0100, Alexander Graf wrote: We call pci_host_config_{read,write}_common() which perform PCI config accesses. However they don't do all limit checking the way we expect it to. So let's introduce a small wrapper around them, making them behave the way we

[Qemu-devel] [PATCH 02/14] qapi: Convert set_password

2012-01-18 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx |3 +- hmp.c| 11 ++ hmp.h|1 + monitor.c| 57 -- qapi-schema.json

Re: [Qemu-devel] [PATCH 1/2] Rewrite the way keycode conversions are performed

2012-01-18 Thread Anthony Liguori
On 01/18/2012 11:07 AM, Daniel P. Berrange wrote: On Wed, Jan 18, 2012 at 10:53:57AM -0600, Anthony Liguori wrote: On 01/17/2012 01:35 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The SDL video display code needs to convert between the SDL keyboard event keycodes,

[Qemu-devel] [PATCH 05/14] qapi: Convert eject

2012-01-18 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 20 +--- blockdev.h |1 - hmp-commands.hx |3 +-- hmp.c| 10 ++ hmp.h|1 + qapi-schema.json | 21

[Qemu-devel] direct usage of rt_clock instead of rtc_clock

2012-01-18 Thread Paolo Bonzini
Hi Peter and Andrzej, the following four files in hw/ are using rt_clock directly omap1.c pxa2xx.c strongarm.c twl92230.c instead of rtc_clock. This means that they're not completely deterministic when using -icount or in the future qtest. A simple search-and-replace would be okay

[Qemu-devel] [PATCH 10/14] qapi: Convert block_set_io_throttle

2012-01-18 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 47 ++- blockdev.h |2 -- hmp-commands.hx |3 +-- hmp.c| 14 ++ hmp.h|1 + qapi-schema.json | 29

[Qemu-devel] [PATCH 13/14] qerror: restore alphabetical order over qerrors

2012-01-18 Thread Luiz Capitulino
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Over time these must have gotten out of order. Put everything back in alphabetical order. This is purely a clean up. In practice nothing depends on the order. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Luiz

[Qemu-devel] [PATCH 14/14] block: use proper qerrors in qmp_block_resize

2012-01-18 Thread Luiz Capitulino
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Let's report specific errors so that management tools and users can identify the problem. Two new qerrors are needed: * QERR_DEVICE_HAS_NO_MEDIUM for ENOMEDIUM * QERR_DEVICE_IS_READ_ONLY for EACCES Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 07/14] qapi: Introduce change-vnc-password

2012-01-18 Thread Luiz Capitulino
New QMP command to change the VNC password. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qapi-schema.json | 14 ++ qmp-commands.hx |6 ++ qmp.c

[Qemu-devel] [PATCH 06/14] monitor: expose readline state

2012-01-18 Thread Luiz Capitulino
From: Anthony Liguori aligu...@us.ibm.com HMP is now implemented in terms of QMP. The monitor has a bunch of logic to deal with HMP right now like readline support. Export it from the monitor so we can consume it in hmp.c. In short time, hmp.c will take over all of the readline bits.

Re: [Qemu-devel] [PATCH 1/2] Rewrite the way keycode conversions are performed

2012-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2012 at 11:47:12AM -0600, Anthony Liguori wrote: On 01/18/2012 11:07 AM, Daniel P. Berrange wrote: On Wed, Jan 18, 2012 at 10:53:57AM -0600, Anthony Liguori wrote: On 01/17/2012 01:35 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The SDL video

[Qemu-devel] [PATCH 08/14] qerror: Extend QERR_DEVICE_ENCRYPTED

2012-01-18 Thread Luiz Capitulino
Include the name of the encrypted file. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |3 ++- qerror.h |2 +- qmp.c |3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index bd4bc4f..f85a9d2 100644 --- a/monitor.c

[Qemu-devel] [PATCH 03/14] qapi: Convert expire_password

2012-01-18 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- console.h|2 -- hmp-commands.hx |3 +-- hmp.c| 10 ++ hmp.h|1 + monitor.c| 39 ---

Re: [Qemu-devel] [PATCH 1/2] Rewrite the way keycode conversions are performed

2012-01-18 Thread Anthony Liguori
On 01/18/2012 12:31 PM, Daniel P. Berrange wrote: On Wed, Jan 18, 2012 at 11:47:12AM -0600, Anthony Liguori wrote: On 01/18/2012 11:07 AM, Daniel P. Berrange wrote: On Wed, Jan 18, 2012 at 10:53:57AM -0600, Anthony Liguori wrote: On 01/17/2012 01:35 PM, Daniel P. Berrange wrote: From: Daniel

[Qemu-devel] [PATCH 01/14] vnc: Simplify vnc_display_password()

2012-01-18 Thread Luiz Capitulino
Drop the qerror_report() call from it and let its callers set the error themselves. This also allows for dropping the 'ret' variable. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- console.h |1 - monitor.c |7 ++- ui/vnc.c | 14 -- 3 files changed, 10

[Qemu-devel] [PATCH 12/14] qerror: add check-qerror.sh to verify alphabetical order

2012-01-18 Thread Luiz Capitulino
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com We're supposed to keep qerror definitions and table entries in alphabetical order. In practice this is not checked. I haven't found a nice way to integrate this into the makefile yet but we can at least have this script which verifies that

  1   2   >