Re: [Qemu-devel] [PATCH v3] qemu-kvm/pci-assign: 64 bits bar emulation

2012-12-23 Thread Gleb Natapov
On Thu, Dec 20, 2012 at 11:07:23AM +0800, Xudong Hao wrote: Enable 64 bits bar emulation. v3 changes from v2: - Leave original error string and drop the leading 016. v2 changes from v1: - Change 0lx% to 0x%016 when print a 64 bit variable. Test pass with the current seabios which

Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2012-12-23 Thread Peter Maydell
On 22 December 2012 19:03, Christoffer Dall c.d...@virtualopensystems.com wrote: The start bit should only be set to indicate that a function call is underway, right now. When done with function, clear it. Looks plausible but I'd like a crosscheck that this is how the hardware really behaves.

Re: [Qemu-devel] [PATCH v3] qemu-kvm/pci-assign: 64 bits bar emulation

2012-12-23 Thread Andreas Färber
Am 20.12.2012 04:07, schrieb Xudong Hao: Enable 64 bits bar emulation. v3 changes from v2: - Leave original error string and drop the leading 016. v2 changes from v1: - Change 0lx% to 0x%016 when print a 64 bit variable. Test pass with the current seabios which already support 64bit

[Qemu-devel] [RFC 3/8] uhci: do not use old_portio-style callbacks

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/usb/hcd-uhci.c | 43 +-- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index d053791..cc47635 100644 --- a/hw/usb/hcd-uhci.c +++

[Qemu-devel] [RFC 0/8] Remove old_portio usage

2012-12-23 Thread Hervé Poussineau
These proposed patches aim at removing the .old_portio member of MemoryRegionOps structure, and replacing their usage by .read/.write handlers. Patches 2 to 6 are already ready to be committed. However, patches 7 and 8 depend of patch 1, where a better solution needs to be found. That way, faked

[Qemu-devel] [RFC 1/8] pc: disable bochs bios debug ports (do not apply!)

2012-12-23 Thread Hervé Poussineau
This patch must not be applied as-is. Some patches to use MemoryRegion have already been sent to mailing list, but none has been applied yet. --- hw/pc.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/pc.c b/hw/pc.c index b11e7c4..7f98955 100644 --- a/hw/pc.c +++ b/hw/pc.c @@

[Qemu-devel] [RFC 8/8] memory: remove old_portio-style callbacks support

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- memory.c | 44 memory.h |4 2 files changed, 48 deletions(-) diff --git a/memory.c b/memory.c index 7419853..ea3bb8a 100644 --- a/memory.c +++ b/memory.c @@ -365,21 +365,6 @@ static

[Qemu-devel] [RFC 6/8] isa: use memory regions instead of portio_list_* functions

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/isa-bus.c | 127 -- hw/isa.h |2 +- 2 files changed, 125 insertions(+), 4 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 144a88e..d22f432 100644 ---

[Qemu-devel] [RFC 7/8] ioport: remove now useless portio_list_* functions

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- ioport.c | 121 -- ioport.h | 19 -- 2 files changed, 140 deletions(-) diff --git a/ioport.c b/ioport.c index 6e4ca0d..05f8026 100644 --- a/ioport.c +++ b/ioport.c @@

[Qemu-devel] [RFC 4/8] acpi-piix4: do not use old_portio-style callbacks

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/acpi_piix4.c | 91 --- 1 file changed, 40 insertions(+), 51 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 0b5b0d3..22704af 100644 --- a/hw/acpi_piix4.c +++

[Qemu-devel] [RFC 2/8] xen_platform: do not use old_portio-style callbacks

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/xen_platform.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/xen_platform.c b/hw/xen_platform.c index a54e7a2..ad7cb06 100644 --- a/hw/xen_platform.c +++ b/hw/xen_platform.c @@ -280,7

[Qemu-devel] [RFC 5/8] vga/qxl: do not use portio_list_init/portio_list_add

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/qxl.c |4 +--- hw/vga.c |8 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 96887c4..7982524 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -2048,7 +2048,6 @@ static int

Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2012-12-23 Thread Christoffer Dall
On Sun, Dec 23, 2012 at 6:01 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 22 December 2012 19:03, Christoffer Dall c.d...@virtualopensystems.com wrote: The start bit should only be set to indicate that a function call is underway, right now. When done with function, clear it. Looks

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 size 8192

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote: On 12/13/12 12:36, Alon Levy wrote: This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring fields in QXLRom, which is what has actually changed, we remove some

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision 4

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: Hi, That is indeed a better solution, but it does change functionality. I think it is correct but I'd like to get some other opinions - Uri, Arnon, Yonit, Soren - any problems with dropping these? Orientation is used in

Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer

2012-12-23 Thread Anthony Liguori
Igor Mammedov imamm...@redhat.com writes: v2: * Naming changes: - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/ - use 'suffix_factor' instead of 'unit' * Added documentation to visit_type_suffixed_int() * Fixed errp check. * Style fixes This is not how visitors are

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-12-23 Thread Alon Levy
On Wed, Dec 19, 2012 at 09:33:28AM +0100, Paolo Bonzini wrote: Il 28/11/2012 10:53, Alon Levy ha scritto: Il 28/11/2012 10:16, Alon Levy ha scritto: diff --git a/roms/openbios b/roms/openbios index f095c85..d1d2787 16 --- a/roms/openbios +++ b/roms/openbios @@ -1 +1 @@

[Qemu-devel] [PATCH] usb/redirect.c: unbreak compilation due to include/char/char.h

2012-12-23 Thread Alon Levy
Broken since: commit 927d4878b0ff319ed87fed9363f314613b0a5ed9 Author: Paolo Bonzini pbonz...@redhat.com Date: Mon Dec 17 18:20:05 2012 +0100 softmmu: move remaining include files to include/ subdirectories Signed-off-by: Alon Levy al...@redhat.com --- hw/usb/redirect.c | 1 + 1 file

Re: [Qemu-devel] [PATCH] configure: allow disabling pixman if not needed

2012-12-23 Thread Anthony Liguori
Robert Schiele rschi...@gmail.com writes: When we build neither any system emulation targets nor the tools there is actually no need for pixman library. In that case do not enforce presence of that library on the system. Signed-off-by: Robert Schiele rschi...@gmail.com Applied. Thanks.

Re: [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-23 Thread Anthony Liguori
Alex Horn alex.h...@cs.ox.ac.uk writes: * Define enum for TMP105 registers * Move tmp105_set() from I2C to TMP105 header * Document units and range of temperature as preconditions Signed-off-by: Alex Horn alex.h...@cs.ox.ac.uk Applied. Thanks. Regards, Anthony Liguori --- hw/i2c.h

Re: [Qemu-devel] [PATCH v2] build: Use separate makefile for trace/

2012-12-23 Thread Anthony Liguori
Lluís Vilanova vilan...@ac.upc.edu writes: Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu -- Changes in v2: * Do not depend on qemu-timer-common.o. * Use $(obj) in rules to refer to the build sub-directory. * Remove dependencies against $(GENERATED_HEADERS). Cc: Paolo Bonzini

Re: [Qemu-devel] [PATCH] target-i386: CPUID: return highest basic leaf if eax cpuid_xlevel

2012-12-23 Thread Anthony Liguori
Eduardo Habkost ehabk...@redhat.com writes: This fixes a subtle bug. A bug that probably won't cause trouble for any existing OS, but a bug anyway: Intel SDM Volume 2, CPUID Instruction states: Two types of information are returned: basic and extended function information. If a value

Re: [Qemu-devel] [PATCH V2] qemu-char: Inherit ptys and improve output from -serial pty

2012-12-23 Thread Anthony Liguori
Lei Li li...@linux.vnet.ibm.com writes: Changes since V1: - Avoid crashing since qemu_opts_id() may return null on some systems according to Markus's suggestion. When controlling a qemu instance from another program, it's hard to know which serial port or monitor device is redirected

Re: [Qemu-devel] [PATCH] MAINTAINERS: Take over kvm maintenance

2012-12-23 Thread Anthony Liguori
Gleb Natapov g...@redhat.com writes: Replace Avi with myself as kvm maintainer. Signed-off-by: Gleb Natapov g...@redhat.com Applied. Thanks. Regards, Anthony Liguori diff --git a/MAINTAINERS b/MAINTAINERS index 2ede20d..0e574f9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -132,7

[Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2012-12-23 Thread Alon Levy
The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the server ignores. The net effect is that the mouse is

[Qemu-devel] 64bit guest hangs while migrating

2012-12-23 Thread Stefan Priebe
Hello list, i'm using qemu v1.3.0. Since upgrading from kvm qemu 1.2 my 64bit linux guests hang while online migrating. Has anybody an idea / can help? Things happing while this happens: - kvm process uses 100%CPU - human monitor does not work as the process does not respond at/on socket -

[Qemu-devel] [Bug 1093360] [NEW] files on microsoft iso images mounted to qemu VM get stripped from Version info. E.G. Microsoft UAG installation fails

2012-12-23 Thread CarstenSchnorr
Public bug reported: QEMU 0.9.0-0.14.1 KVM 60-88-0.14.1 there is a reference for a root cause, why installation of Microsoft UAG fails. http://blogs.technet.com/b/isablog/archive/2010/07/13/another-tmg-2010-installation-failure-with-error-0x80070643.aspx when checking available information on

Re: [Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2012-12-23 Thread Amit Shah
On (Sun) 23 Dec 2012 [23:35:29], Alon Levy wrote: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the