Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-11 Thread TeLeMan
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini pbonz...@redhat.com wrote: Uses the same select/WSAEventSelect scheme as main-loop.c. WSAEventSelect() is edge-triggered, so it cannot be used directly, but it is still used as a way to exit from a blocking g_poll(). Before g_poll() is called, we

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-11 Thread TeLeMan
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini pbonz...@redhat.com wrote: Uses the same select/WSAEventSelect scheme as main-loop.c. WSAEventSelect() is edge-triggered, so it cannot be used directly, but it is still used as a way to exit from a blocking g_poll(). Before g_poll() is called, we

Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-11 Thread Gu Zheng
Hi Igor, On 09/11/2014 06:12 PM, Igor Mammedov wrote: On Thu, 11 Sep 2014 11:04:10 +0800 Gu Zheng guz.f...@cn.fujitsu.com wrote: Hi Igor, On 09/10/2014 09:28 PM, Igor Mammedov wrote: On Wed, 3 Sep 2014 17:06:13 +0800 Gu Zheng guz.f...@cn.fujitsu.com wrote: Signed-off-by: Gu Zheng

Re: [Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_union

2014-09-11 Thread Eric Blake
On 09/11/2014 05:20 PM, Michael Roth wrote: In some cases an input visitor might bail out on filling out a struct for various reasons, such as missing fields when running in strict mode. In the case of a QAPI Union type, this may lead to cases where the .kind field which encodes the union type

Re: [Qemu-devel] [PATCH 2/3] qapi: dealloc visitor, implement visit_start_union

2014-09-11 Thread Eric Blake
On 09/11/2014 05:20 PM, Michael Roth wrote: If the .data field of a QAPI Union is NULL, we don't need to free any of the union fields.. intentional double dot? Make use of the new visit_start_union interface to access this information and instruct the generated code to not visit these

[Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing driver key for blockdev-add

2014-09-11 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/087 | 17 + tests/qemu-iotests/087.out | 13 + 2 files changed, 30 insertions(+) diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 index 82c56b1..d7454d1 100755 --- a/tests/qemu-iotests/087

Re: [Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types

2014-09-11 Thread Fam Zheng
On Thu, 09/11 18:20, Michael Roth wrote: This series introduces visit_start_enum and visit_end_enum as a way of allowing visitors to trigger generated code to bail out on visiting union fields if the visitor implementation deems doing so to be unsafe. See patch 1 for the circumstances that

Re: [Qemu-devel] [PATCH 1/2] virtio-net: drop assert on vm stop

2014-09-11 Thread Jason Wang
On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: On vm stop, vm_running state set to stopped before device is notified, so callbacks can get envoked with vm_running = false; and this is not an error. This is consistent with virtio-blk which also has such kinds of callbacks. This fixes the

Re: [Qemu-devel] [PATCH 2/2] Revert virtio: don't call device on !vm_running

2014-09-11 Thread Jason Wang
On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8. virtio: don't call device on !vm_running It turns out that virtio net assumes that vm_running is updated before device status callback in many places, so this change leads to

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-11 Thread Gu Zheng
Hi Igor, On 09/10/2014 09:55 PM, Igor Mammedov wrote: On Wed, 3 Sep 2014 17:06:16 +0800 Gu Zheng guz.f...@cn.fujitsu.com wrote: Add cpu hotplug handler to PC_MACHINE, which will perform the acpi cpu hotplug callback via hotplug_handler API. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com

Re: [Qemu-devel] [question] virtio-blk performance degradation happened with virito-serial

2014-09-11 Thread Zhang Haoyu
If virtio-blk and virtio-serial share an IRQ, the guest operating system has to check each virtqueue for activity. Maybe there is some inefficiency doing that. AFAIK virtio-serial registers 64 virtqueues (on 31 ports + console) even if everything is unused. That could be the

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-11 Thread Fam Zheng
On Tue, 09/09 14:28, Benoît Canet wrote: On Tue, Sep 09, 2014 at 01:56:46PM +0200, Kevin Wolf wrote: Am 22.08.2014 um 18:11 hat Benoît Canet geschrieben: Since the block layer code is starting to modify the BDS graph right in the middle of BDS chains (block-mirror's replace parameter

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
On 09/11/2014 09:02 PM, Alexey Kardashevskiy wrote: On 09/11/2014 08:38 PM, Gerd Hoffmann wrote: Hi, Another question - I noticed that XHCI migration is broken in quite recent upstream QEMU, smells like memory corruption. Is it just me or just PPC or is it known issue? 2.0 - 2.1

Re: [Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing driver key for blockdev-add

2014-09-11 Thread Eric Blake
On 09/11/2014 09:04 PM, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/087 | 17 + tests/qemu-iotests/087.out | 13 + 2 files changed, 30 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat

[Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com --- hw/misc/vfio.c| 2 +- include/exec/memory.h | 27 +++ memory.c | 16

Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Alex Williamson
On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote: The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com --- If you don't want to dump a memory region then add the

Re: [Qemu-devel] [RESEND PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-09-11 Thread zhanghailiang
On 2014/9/4 21:28, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:36 +0800 Tang Chentangc...@cn.fujitsu.com wrote: From: Hu Taohu...@cn.fujitsu.com Implement unrealize function for pc-dimm device. It delete subregion from s/delete/removes/ hotplug region, and delete ram address range from

<    1   2   3