Re: [PATCH v3 2/9] target/arm: Don't add all MIDR aliases for cores that immplement PMSA

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > Cores with PMSA have the MPUIR register which has the > same encoding as the MIDR alias with opc2=4. So we only > add that alias if we are not realizing a core that > implements PMSA. > > Signed-off-by: Tobias Röhmel > --- >

Re: [PATCH v2] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-27 Thread Eric Auger
Hi Peter, On 9/27/22 18:49, Peter Maydell wrote: > Occasionally the KVM_CREATE_VM ioctl can return EINTR, even though > there is no pending signal to be taken. In commit 94ccff13382055 > we added a retry-on-EINTR loop to the KVM_CREATE_VM call in the > generic KVM code. Adopt the same approach

Re: virtiofsd: Any reason why there's not an "openat2" sandbox mode?

2022-09-27 Thread Vivek Goyal
On Tue, Sep 27, 2022 at 12:37:15PM -0400, Vivek Goyal wrote: > On Fri, Sep 09, 2022 at 05:24:03PM -0400, Colin Walters wrote: > > We previously had a chat here > > https://lore.kernel.org/all/348d4774-bd5f-4832-bd7e-a21491fda...@www.fastmail.com/T/ > > around virtiofsd and privileges and the case

Re: [PATCH 1/1] 9pfs: avoid iterator invalidation in v9fs_mark_fids_unreclaim

2022-09-27 Thread Christian Schoenebeck
On Dienstag, 27. September 2022 15:05:13 CEST Linus Heckemann wrote: > Christian Schoenebeck writes: > > Ah, you sent this fix as a separate patch on top. I actually just meant > > that you would take my already queued patch as the latest version (just > > because I had made some minor changes on

[PATCH] arm: re-randomize rng-seed on reboot

2022-09-27 Thread Jason A. Donenfeld
When the system reboots, the rng-seed that the FDT has should be re-randomized, so that the new boot gets a new seed. Since the FDT is in the ROM region at this point, we add a hook right after the ROM has been added, so that we have a pointer to that copy of the FDT. When the reboot happens, we

[PATCH] kvm: dirty-ring: Fix race with vcpu creation

2022-09-27 Thread Peter Xu
It's possible that we want to reap a dirty ring on a vcpu that is during creation, because the vcpu is put onto list (CPU_FOREACH visible) before initialization of the structures. In this case: qemu_init_vcpu x86_cpu_realizefn cpu_exec_realizefn cpu_list_add <

Re: [PATCH v3 8/9] target/arm: Add PMSAv8r functionality

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > Add PMSAv8r translation. > > Signed-off-by: Tobias Röhmel > --- > target/arm/ptw.c | 171 +-- > 1 file changed, 150 insertions(+), 21 deletions(-) > > diff --git a/target/arm/ptw.c

[PATCH v2] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-27 Thread Peter Maydell
Occasionally the KVM_CREATE_VM ioctl can return EINTR, even though there is no pending signal to be taken. In commit 94ccff13382055 we added a retry-on-EINTR loop to the KVM_CREATE_VM call in the generic KVM code. Adopt the same approach for the use of the ioctl in the Arm-specific KVM code (where

Re: Should we maybe move Cirrus-CI jobs away from Gitlab again?

2022-09-27 Thread Stefan Hajnoczi
On Tue, 27 Sept 2022 at 05:02, Thomas Huth wrote: > now that Gitlab is giving us pressure on the amount of free CI minutes, I > wonder whether we should maybe move the Cirrus-CI jobs out of the gitlab-CI > dashboard again? We could add the jobs to our .cirrus-ci.yml file instead, > like we did it

Re: [PATCH] mem/cxl-type3: Add sn option to provide serial number for PCI ecap

2022-09-27 Thread Ben Widawsky
On 22-09-23 17:18:35, Jonathan Cameron wrote: > The Device Serial Number Extended Capability PCI r6.0 sec 7.9.3 > provides a standard way to provide a device serial number as > an IEEE defined 64-bit extended unique identifier EUI-64. > > CXL 2.0 section 8.1.12.2 Memory Device PCIe Capabilities

Re: virtiofsd: Any reason why there's not an "openat2" sandbox mode?

2022-09-27 Thread Vivek Goyal
On Fri, Sep 09, 2022 at 05:24:03PM -0400, Colin Walters wrote: > We previously had a chat here > https://lore.kernel.org/all/348d4774-bd5f-4832-bd7e-a21491fda...@www.fastmail.com/T/ > around virtiofsd and privileges and the case of trying to run virtiofsd > inside an unprivileged (Kubernetes)

Re: [PATCH v5] 9pfs: use GHashTable for fid table

2022-09-27 Thread Linus Heckemann
Linus Heckemann writes: > static void coroutine_fn virtfs_reset(V9fsPDU *pdu) > { > V9fsState *s = pdu->s; > V9fsFidState *fidp; > +GList *freeing; > +/* Get a list of all the values (fid states) in the table, which we > then... */ > +g_autoptr(GList) fids =

Re: qemu and -vga vs. -device

2022-09-27 Thread Daniel Henrique Barboza
Hi Adam, On 9/26/22 06:26, Gerd Hoffmann wrote: On Sat, Sep 24, 2022 at 12:12:45AM -0700, Adam Williamson wrote: On Mon, 2022-09-19 at 06:42 +0200, Gerd Hoffmann wrote: On Fri, Sep 16, 2022 at 10:02:17AM -0700, Adam Williamson wrote: Hi Gerd! I'm working on a patch to revise how openQA sets

Re: Should we maybe move Cirrus-CI jobs away from Gitlab again?

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 11:44:45AM -0400, Stefan Hajnoczi wrote: > On Tue, 27 Sept 2022 at 05:02, Thomas Huth wrote: > > now that Gitlab is giving us pressure on the amount of free CI minutes, I > > wonder whether we should maybe move the Cirrus-CI jobs out of the gitlab-CI > > dashboard again?

Re: [PATCH v3 0/9] Add ARM Cortex-R52 cpu

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > Thanks for the review! > Here is v3: > > v3: > PATCH 2 (Don't add all MIDR aliases for cores that immplement PMSA): > fixed the comment and changed to single element instead of array. > Also the alias is not added for all PMSA CPUs

Re: [PULL 0/1] Block patches

2022-09-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH][RESEND] hyperv: fix SynIC SINT assertion failure on guest reset

2022-09-27 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Resetting a guest that has Hyper-V VMBus support enabled triggers a QEMU assertion failure: hw/hyperv/hyperv.c:131: synic_reset: Assertion `QLIST_EMPTY(>sint_routes)' failed. This happens both on normal guest reboot or when using "system_reset" HMP command. The

Re: [PULL 00/24] Kraxel 20220927 patches

2022-09-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] update Linux headers to 6.0

2022-09-27 Thread Peter Maydell
On Tue, 27 Sept 2022 at 15:53, Paolo Bonzini wrote: > > The big change that comes in here is that several structs have been > switched to flexible array members. This is compatible with > QEMU's use of this structs in constructs such as: > > struct { > struct kvm_msrs info; >

[PATCH v4] block: Refactor get_tmp_filename()

2022-09-27 Thread Bin Meng
From: Bin Meng At present there are two callers of get_tmp_filename() and they are inconsistent. One does: /* TODO: extra byte is a hack to ensure MAX_PATH space on Windows. */ char *tmp_filename = g_malloc0(PATH_MAX + 1); ... ret = get_tmp_filename(tmp_filename, PATH_MAX + 1);

Re: [Virtio-fs] [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond

2022-09-27 Thread Stefan Hajnoczi
On Tue, 20 Sept 2022 at 19:08, Vivek Goyal wrote: > > On Wed, Aug 24, 2022 at 01:41:29PM -0400, Stefan Hajnoczi wrote: > > On Thu, Aug 18, 2022 at 02:46:19PM -0400, Yusuke Okada wrote: > > > From: Yusuke Okada > > > > > > The "%f" specifier in g_date_time_format() is only available in glib > > >

Re: [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

2022-09-27 Thread Eric Auger
Hi, On 9/27/22 13:46, Peter Maydell wrote: > On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker > wrote: >> >> The "PCI Bus Binding to: IEEE Std 1275-1994" defines the compatible >> string for a PCIe bus or endpoint as "pci," or >> similar. Since the initial binding for PCI virtio-iommu didn't

Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-27 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 07:54:05PM +0800, Bin Meng wrote: > On Thu, Sep 22, 2022 at 6:39 PM Daniel P. Berrangé > wrote: > > > > On Thu, Sep 22, 2022 at 10:47:26AM +0800, Bin Meng wrote: > > > On Thu, Sep 22, 2022 at 1:23 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Wed, Sep 21, 2022

Re: [PATCH v4 18/54] tests/qtest: vhost-user-test: Avoid using hardcoded /tmp

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 3:07 PM Bin Meng wrote: > > From: Bin Meng > > This case was written to use hardcoded /tmp directory for temporary > files. Update to use g_dir_make_tmp() for a portable implementation. > > Signed-off-by: Bin Meng > --- > > Changes in v4: > - Update error reporting > >

Re: [PATCH v4 50/54] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-27 Thread Bin Meng
On Tue, Sep 27, 2022 at 10:33 PM Marc-André Lureau wrote: > > On Tue, Sep 27, 2022 at 3:09 PM Bin Meng wrote: > > > > From: Bin Meng > > > > Some migration test cases use TLS to communicate, but they fail on > > Windows with the following error messages: > > > > qemu-system-x86_64: TLS

Re: [PATCH v9 09/10] s390x/cpu_topology: activating CPU topology

2022-09-27 Thread Cédric Le Goater
On 9/2/22 09:55, Pierre Morel wrote: Starting with a new machine, s390-virtio-ccw-7.2, the machine property topology-disable is set to false while it is kept to true for older machine. We probably need a machine class option also because we don't want this to be possible : -M

Re: [PATCH v4 15/54] tests/qtest: pflash-cfi02-test: Avoid using hardcoded /tmp

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 3:07 PM Bin Meng wrote: > > From: Bin Meng > > This case was written to use hardcoded /tmp directory for temporary > files. Update to use g_file_open_tmp() for a portable implementation. > > Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau > --- > > Changes in v4:

Re: [PATCH v4 14/54] tests/qtest: migration-test: Avoid using hardcoded /tmp

2022-09-27 Thread Marc-André Lureau
Hi On Tue, Sep 27, 2022 at 3:07 PM Bin Meng wrote: > > From: Bin Meng > > This case was written to use hardcoded /tmp directory for temporary > files. Update to use g_dir_make_tmp() for a portable implementation. > > Signed-off-by: Bin Meng > --- > > Changes in v4: > - Update the error

[PATCH v3 12/15] gdbstub: move sstep flags probing into AccelClass

2022-09-27 Thread Alex Bennée
The support of single-stepping is very much dependent on support from the accelerator we are using. To avoid special casing in gdbstub move the probing out to an AccelClass function so future accelerators can put their code there. Reviewed-by: Richard Henderson Reviewed-by: Philippe

Re: [PATCH v4 43/54] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-27 Thread Marc-André Lureau
Hi On Tue, Sep 27, 2022 at 5:21 PM Bin Meng wrote: > On Tue, Sep 27, 2022 at 9:15 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Tue, Sep 27, 2022 at 5:02 PM Bin Meng wrote: > >> > >> From: Xuzhou Cheng > >> > >> Make sure QEMU process "to" exited before launching another target > >>

[PATCH v3 15/15] accel/kvm: move kvm_update_guest_debug to inline stub

2022-09-27 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/sysemu/kvm.h | 16 accel/kvm/kvm-all.c| 6 -- accel/stubs/kvm-stub.c | 5 - 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 6e1bd01725..790d35ef78 100644 ---

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: > On Tue, Sep 27, 2022 at 5:12 PM Ani Sinha wrote: > > > > On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > > > OK

Re: [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node

2022-09-27 Thread Eric Auger
On 9/27/22 12:03, Jean-Philippe Brucker wrote: > The node name of the gpio-key devicetree node should be "key-poweroff": > > gpio-keys: 'poweroff' does not match any of the regexes: > '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', >

[PATCH v3 13/15] gdbstub: move breakpoint logic to accel ops

2022-09-27 Thread Alex Bennée
As HW virtualization requires specific support to handle breakpoints lets push out special casing out of the core gdbstub code and into AccelOpsClass. This will make it easier to add other accelerator support and reduces some of the stub shenanigans. Reviewed-by: Richard Henderson Signed-off-by:

[PATCH v3 08/15] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-27 Thread Alex Bennée
Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. As we should only be processing accesses from CPU cores we can push the CPU extraction logic out to the main access functions. If the access does not come from a CPU we

[PATCH v3 14/15] gdbstub: move guest debug support check to ops

2022-09-27 Thread Alex Bennée
This removes the final hard coding of kvm_enabled() in gdbstub and moves the check to an AccelOps. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Cc: Mads Ynddal --- accel/kvm/kvm-cpus.h | 1 + gdbstub/internals.h| 1 + include/sysemu/accel-ops.h | 1 +

[PATCH v3 05/15] target/arm: ensure ptw accesses set appropriate MemTxAttrs

2022-09-27 Thread Alex Bennée
While mapping your page table base to the GICs address space would be an "interesting" design choice the resultant loads would still be CPU initiated so should be tagged as such. Signed-off-by: Alex Bennée --- target/arm/ptw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v3 11/15] gdbstub: move into its own sub directory

2022-09-27 Thread Alex Bennée
This is in preparation of future refactoring as well as cleaning up the source tree. Aside from the minor tweaks to meson and trace.h this is pure code motion. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- meson.build| 4 +++- gdbstub/trace.h

[PATCH v3 09/15] hw/timer: convert mptimer access to attrs to derive cpu index

2022-09-27 Thread Alex Bennée
This removes the hacks to deal with empty current_cpu. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- v2 - update for new fields - bool asserts --- hw/timer/arm_mptimer.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git

[PATCH v3 10/15] configure: move detected gdb to TCG's config-host.mak

2022-09-27 Thread Alex Bennée
When tests/tcg gained it's own config-host.mak we forgot to move the GDB detection. Fixes: 544f4a2578 (tests/tcg: isolate from QEMU's config-host.mak) Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure

[PATCH v3 01/15] hw: encode accessing CPU index in MemTxAttrs

2022-09-27 Thread Alex Bennée
We currently have hacks across the hw/ to reference current_cpu to work out what the current accessing CPU is. This breaks in some cases including using gdbstub to access HW state. As we have MemTxAttrs to describe details about the access lets extend it so CPU accesses can be explicitly marked.

[PATCH v3 06/15] target/arm: ensure m-profile helpers set appropriate MemTxAttrs

2022-09-27 Thread Alex Bennée
There are a number of helpers for M-profile that deal with CPU initiated access to the vector and stack areas. While it is unlikely these coincided with memory mapped IO devices it is not inconceivable. Embedded targets tend to attract all sorts of interesting code and for completeness we should

[PATCH v3 07/15] qtest: make read/write operation appear to be from CPU

2022-09-27 Thread Alex Bennée
The point of qtest is to simulate how running code might interact with the system. However because it's not a real system we have places in the code which especially handle check qtest_enabled() before referencing current_cpu. Now we can encode these details in the MemTxAttrs lets do that so we

Re: [PULL v2 00/22] riscv-to-apply queue

2022-09-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v3 03/15] target/arm: ensure HVF traps set appropriate MemTxAttrs

2022-09-27 Thread Alex Bennée
As most HVF devices are done purely in software we need to make sure we properly encode the source CPU in MemTxAttrs. This will allow the device emulations to use those attributes rather than relying on current_cpu (although current_cpu will still be correct in this case). Acked-by: Alexander

[PATCH v3 04/15] target/arm: ensure KVM traps set appropriate MemTxAttrs

2022-09-27 Thread Alex Bennée
Although most KVM users will use the in-kernel GIC emulation it is perfectly possible not to. In this case we need to ensure the MemTxAttrs are correctly populated so the GIC can divine the source CPU of the operation. Signed-off-by: Alex Bennée --- v3 - new for v3 --- target/arm/kvm.c | 12

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Tue, Sep 27, 2022 at 5:12 PM Ani Sinha wrote: > > On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé > wrote: > > > > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > > > > > > > > >

Re: [PATCH v4 50/54] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 6:38 PM Bin Meng wrote: > > On Tue, Sep 27, 2022 at 10:33 PM Marc-André Lureau > wrote: > > > > On Tue, Sep 27, 2022 at 3:09 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > Some migration test cases use TLS to communicate, but they fail on > > > Windows with

[PATCH v3 02/15] target/arm: ensure TCG IO accesses set appropriate MemTxAttrs

2022-09-27 Thread Alex Bennée
Both arm_cpu_tlb_fill (for normal IO) and arm_cpu_get_phys_page_attrs_debug (for debug access) come through get_phys_addr which is setting the other memory attributes for the transaction. As these are all by definition CPU accesses we can also set the requested_type/index as appropriate.

Re: [PATCH v4 39/54] tests/qtest: boot-serial-test: Close the serial file before starting QEMU

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 3:08 PM Bin Meng wrote: > > From: Bin Meng > > This qtest executable created a serial chardev file to be passed to > the QEMU executable. The serial file was created by g_file_open_tmp(), > which internally opens the file with FILE_SHARE_WRITE security attribute > on

Re: [PATCH v7 2/2] i386: Add notify VM exit support

2022-09-27 Thread Paolo Bonzini
On 9/23/22 09:33, Chenyi Qiang wrote: Because there are some concerns, e.g. a notify VM exit may happen with VM_CONTEXT_INVALID set in exit qualification (no cases are anticipated that would set this bit), which means VM context is corrupted. To avoid the false positive and a well-behaved guest

Re: [PATCH v4 50/54] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 3:09 PM Bin Meng wrote: > > From: Bin Meng > > Some migration test cases use TLS to communicate, but they fail on > Windows with the following error messages: > > qemu-system-x86_64: TLS handshake failed: Insufficient credentials for that > request. >

[PATCH v7 2/5] module: rename module_load_one to module_load

2022-09-27 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé --- audio/audio.c | 2 +- block.c | 4 ++-- block/dmg.c | 4 ++-- hw/core/qdev.c| 2 +- include/qemu/module.h | 10 +- qom/object.c | 4 ++-- softmmu/qtest.c |

[PATCH v7 5/5] accel: abort if we fail to load the accelerator plugin

2022-09-27 Thread Claudio Fontana
if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson [claudio: changed

Re: [PATCH v4 16/54] tests/qtest: qmp-test: Avoid using hardcoded /tmp

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 3:07 PM Bin Meng wrote: > > From: Bin Meng > > This case was written to use hardcoded /tmp directory for temporary > files. Update to use g_dir_make_tmp() for a portable implementation. > > Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau > --- > > Changes in

Re: [PATCH v3 7/9] target/arm: Add PMSAv8r registers

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > Signed-off-by: Tobias Röhmel > --- > target/arm/cpu.h| 10 +++ > target/arm/helper.c | 171 > 2 files changed, 181 insertions(+) > > diff --git a/target/arm/cpu.h

[PATCH v7 3/5] module: add Error arguments to module_load and module_load_qom

2022-09-27 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load(const char *prefix, const char *lib_name); void module_load_qom(const char *type); to: int module_load(const char *prefix, const char *name, Error **errp); int module_load_qom(const char *type, Error **errp); where the

[PATCH v7 0/5] improve error handling for module load

2022-09-27 Thread Claudio Fontana
CHANGELOG: v6 -> v7: * changed instances of abort() to exit(1), for the CONFIG_MODULES case (Philippe). * dmg: do not use a separate local error, use the existing errp (Kevin) * block: do not use a separate local error, use the existing errp for bdrv_find_protocol (Markus) v5 -> v6: *

[PATCH v5] 9pfs: use GHashTable for fid table

2022-09-27 Thread Linus Heckemann
The previous implementation would iterate over the fid table for lookup operations, resulting in an operation with O(n) complexity on the number of open files and poor cache locality -- for every open, stat, read, write, etc operation. This change uses a hashtable for this instead, significantly

[PATCH v7 4/5] dmg: warn when opening dmg images containing blocks of unknown type

2022-09-27 Thread Claudio Fontana
From: Kevin Wolf Signed-off-by: Claudio Fontana --- block/dmg.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/dmg.c b/block/dmg.c index 837f18aa20..96f8c2d14f 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -254,6 +254,25 @@ static int

[PULL 1/1] hw/xen: set pci Atomic Ops requests for passthrough device

2022-09-27 Thread Anthony PERARD via
From: Ruili Ji Make guest os access pci device control 2 reg for passthrough device as struct XenPTRegInfo described in the file hw/xen/xen_pt.h. /* reg read only field mask (ON:RO/ROS, OFF:other) */ uint32_t ro_mask; /* reg emulate field mask (ON:emu, OFF:passthrough) */ uint32_t emu_mask;

Re: [PATCH v2 6/8] hw/arm/virt: Fix devicetree warning about the SMMU node

2022-09-27 Thread Eric Auger
Hi Jean, you may add: as opposed to SMMUv2, ... > The SMMUv3 node isn't expected to have clock properties. Fix the > corresponding dt-validate warning: > > smmuv3@905: 'clock-names', 'clocks' do not match any of the regexes: > 'pinctrl-[0-9]+' > From schema:

[PATCH v7 1/5] module: removed unused function argument "mayfail"

2022-09-27 Thread Claudio Fontana
mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé ---

[PULL 0/1] xen queue 2022-09-27

2022-09-27 Thread Anthony PERARD via
/aperard/qemu-dm.git tags/pull-xen-20220927 for you to fetch changes up to fb36fb9344c284a58f3f3ec5be6408fc51eaf3f1: hw/xen: set pci Atomic Ops requests for passthrough device (2022-09-27 14:23:23 +0100) Xen patch - Xen PCI

Re: [PATCH v4 54/54] docs/devel: testing: Document writing portable test cases

2022-09-27 Thread Thomas Huth
On 27/09/2022 13.06, Bin Meng wrote: From: Bin Meng Update the best practices of how to write portable test cases that can be built and run successfully on both Linux and Windows hosts. Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau --- Changes in v4: - Move the new text section

[PATCH v3 00/15] gdbstub/next (MemTxAttrs, re-factoring)

2022-09-27 Thread Alex Bennée
Hi, Following feedback on the MemTxAttrs updates we now: - move unspecified to requester_type - document a machine specific decoding of requester_id - update the existing users - update HVF/KVM/m-profile/page-walking access functions - fail with MEMTX_ACCESS_ERROR if non-CPU accesses

Re: [PATCH v4 53/54] tests/qtest: Enable qtest build on Windows

2022-09-27 Thread Thomas Huth
On 27/09/2022 13.06, Bin Meng wrote: From: Bin Meng Now that we have fixed various test case issues as seen when running on Windows, let's enable the qtest build on Windows. Signed-off-by: Bin Meng --- (no changes since v3) Changes in v3: - Drop the host test Changes in v2: - new patch:

Re: [PATCH v4 43/54] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-27 Thread Bin Meng
On Tue, Sep 27, 2022 at 9:15 PM Marc-André Lureau wrote: > > Hi > > On Tue, Sep 27, 2022 at 5:02 PM Bin Meng wrote: >> >> From: Xuzhou Cheng >> >> Make sure QEMU process "to" exited before launching another target >> for migration in the test_multifd_tcp_cancel case. >> >> Signed-off-by: Xuzhou

Re: [PATCH v3 6/9] target/arm: Enable TTBCR_EAE for ARMv8-R AArch32

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > ARMv8-R AArch32 CPUs behave as if TTBCR.EAE is always 1 even > tough they don't have the TTBCR register. > See ARM Architecture Reference Manual Supplement - ARMv8, for the ARMv8-R > AArch32 architecture profile Version:A.c section

Re: [PATCH v4 43/54] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-27 Thread Marc-André Lureau
Hi On Tue, Sep 27, 2022 at 5:02 PM Bin Meng wrote: > From: Xuzhou Cheng > > Make sure QEMU process "to" exited before launching another target > for migration in the test_multifd_tcp_cancel case. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > --- > > (no changes since v3) > >

Re: [PATCH v7 1/2] i386: kvm: extend kvm_{get, put}_vcpu_events to support pending triple fault

2022-09-27 Thread Paolo Bonzini
On 9/23/22 09:33, Chenyi Qiang wrote: For the direct triple faults, i.e. hardware detected and KVM morphed to VM-Exit, KVM will never lose them. But for triple faults sythesized by KVM, e.g. the RSM path, if KVM exits to userspace before the request is serviced, userspace could migrate the VM

Re: ddd

2022-09-27 Thread Bin Meng
On Tue, Sep 27, 2022 at 9:09 PM Helge Deller wrote: > > Add faccessat2() with strace output. > > Signed-off-by: Helge Deller > > --- > v2: Resending with minor commit message changes. > The commit summary makes no sense. Would you please resend? Regards, Bin

[PATCH] update Linux headers to 6.0

2022-09-27 Thread Paolo Bonzini
The big change that comes in here is that several structs have been switched to flexible array members. This is compatible with QEMU's use of this structs in constructs such as: struct { struct kvm_msrs info; struct kvm_msr_entry entries[1]; } msr_data = {

Re: [PATCH v4 5/7] tests/x86: Add 'q35' machine type to override-tests in hd-geo-test

2022-09-27 Thread Thomas Huth
On 20/09/2022 12.48, Michael Labiuk wrote: Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 105 +++--- 1 file changed, 98 insertions(+), 7 deletions(-) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index

Re: [PATCH 1/1] 9pfs: avoid iterator invalidation in v9fs_mark_fids_unreclaim

2022-09-27 Thread Linus Heckemann
Christian Schoenebeck writes: > Ah, you sent this fix as a separate patch on top. I actually just meant that > you would take my already queued patch as the latest version (just because I > had made some minor changes on my end) and adjust that patch further as v4. > > Anyway, there are still

Re: [PATCH v3 3/9] target/arm: Make RVBAR available for all ARMv8 CPUs

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > RVBAR shadows RVBAR_ELx where x is the highest exception > level if the highest EL is not EL3. This patch also allows > ARMv8 CPUs to change the reset address to be changed with > the rvbar property. > > Signed-off-by: Tobias

Re: ddd

2022-09-27 Thread Helge Deller
On 9/27/22 15:11, Bin Meng wrote: On Tue, Sep 27, 2022 at 9:09 PM Helge Deller wrote: Add faccessat2() with strace output. Signed-off-by: Helge Deller --- v2: Resending with minor commit message changes. The commit summary makes no sense. Would you please resend? Yes, sorry. "vi"

Re: [PATCH] docs: Update TPM documentation for usage of a TPM 2

2022-09-27 Thread Marc-André Lureau
On Tue, Sep 27, 2022 at 4:21 PM Stefan Berger wrote: > > Update the TPM documentation for usage of a TPM 2 rather than a TPM 1.2. > Adjust the command lines and expected outputs inside the VM accordingly. > Update the command line to start a TPM 2 with swtpm. > > Signed-off-by: Stefan Berger

Re: [PATCH v2 3/8] hw/arm/virt: Use "msi-map" devicetree property for PCI

2022-09-27 Thread Eric Auger
Hi Jean, On 9/27/22 12:03, Jean-Philippe Brucker wrote: > The "msi-parent" property can be used on the PCI node when MSIs do not > contain sideband data (device IDs) [1]. In QEMU, MSI transactions > contain the requester ID, so the PCI node should use the "msi-map" > property instead of

Re: [PATCH v3 5/9] target/arm: Add ARMCacheAttrs to the signature of pmsav8_mpu_lookup

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > Add ARMCacheAttrs to the signature of pmsav8_mpu_lookup to prepare > for the Cortex-R52 MPU which uses and combines cache attributes > of different translation levels. > > Signed-off-by: Tobias Röhmel > +bool

[PATCH v2 0/2] linux-user: handle /proc/self/exe with execve() syscall

2022-09-27 Thread Laurent Vivier
Use exec_path to re-execute the binary from /proc/self/exe Fix do_openat() that should not use execfd. v2: - don't use execfd as it can't be closed and is usable by the child Laurent Vivier (2): linux-user: handle /proc/self/exe with execve() syscall linux-user: don't use AT_EXECFD in

Re: [PATCH v3 4/9] target/arm: Make stage_2_format for cache attributes optional

2022-09-27 Thread Peter Maydell
On Sat, 20 Aug 2022 at 15:19, wrote: > > From: Tobias Röhmel > > The Cortex-R52 has a 2 stage MPU translation process but doesn't have the > FEAT_S2FWB feature. This makes it neccessary to allow for the old cache > attribut combination. This is facilitated by changing the control path > of

Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom

2022-09-27 Thread Claudio Fontana
On 9/27/22 13:53, Kevin Wolf wrote: > Am 27.09.2022 um 11:13 hat Claudio Fontana geschrieben: >> On 9/27/22 09:54, Markus Armbruster wrote: >>> Claudio Fontana writes: >>> On 9/26/22 12:38, Kevin Wolf wrote: > Am 24.09.2022 um 01:21 hat Claudio Fontana geschrieben: >> improve error

Re: [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node

2022-09-27 Thread Eric Auger
Hi jean, On 9/27/22 12:03, Jean-Philippe Brucker wrote: > The devicetree specification requires a 'model' property in the root > node. Fix the corresponding dt-validate warning: > > /: 'model' is a required property > From schema: dtschema/schemas/root-node.yaml > > Use the same name for

Re: [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node

2022-09-27 Thread Eric Auger
Hi Jean, On 9/27/22 12:03, Jean-Philippe Brucker wrote: > The GICv3 bindings requires a #msi-cells property for the ITS node. Fix > the corresponding dt-validate warning: > > interrupt-controller@800: msi-controller@808: '#msi-cells' is a > required property > From schema: >

Re: [patch v0] qapi/qmp: Add timestamps to qmp command responses.

2022-09-27 Thread Denis Plotnikov
On 27.09.2022 09:04, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Sep 26, 2022 at 12:59:40PM +0300, Denis Plotnikov wrote: Add "start" & "end" timestamps to qmp command responses. It's disabled by default, but can be enabled with 'timestamp=on' monitor's parameter, e.g.:

[PATCH v2 2/2] linux-user: don't use AT_EXECFD in do_openat()

2022-09-27 Thread Laurent Vivier
AT_EXECFD gives access to the binary file even if it is not readable (only executable). Moreover it can be opened with flags and mode that are not the ones provided by do_openat() caller. And it is not available because loader_exec() has closed it. To avoid that, use only safe_openat() with the

[PATCH v2 1/2] linux-user: handle /proc/self/exe with execve() syscall

2022-09-27 Thread Laurent Vivier
If path is /proc/self/exe, use the executable path provided by exec_path. Don't use execfd as it is closed by loader_exec() and otherwise will survive to the exec() syscall and be usable child process. Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 6 +- 1 file changed, 5

Re: [PATCH 07/12] spiceaudio: update comment

2022-09-27 Thread Marc-André Lureau
On Fri, Sep 23, 2022 at 10:55 PM Volker Rümelin wrote: > Replace a comment with a question with the answer. > > Signed-off-by: Volker Rümelin > Reviewed-by: Marc-André Lureau > --- > audio/spiceaudio.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v9 02/10] s390x/cpu topology: core_id sets s390x CPU topology

2022-09-27 Thread Cédric Le Goater
On 9/2/22 09:55, Pierre Morel wrote: In the S390x CPU topology the core_id specifies the CPU address and the position of the core withing the topology. Let's build the topology based on the core_id. Signed-off-by: Pierre Morel --- hw/s390x/cpu-topology.c | 135

Re: [PATCH 06/12] spiceaudio: add a pcm_ops buffer_get_free function

2022-09-27 Thread Marc-André Lureau
On Fri, Sep 23, 2022 at 10:58 PM Volker Rümelin wrote: > It seems there is a demand [1] for low latency playback over > SPICE. Add a pcm_ops buffer_get_free function to reduce the > playback latency. The mixing engine buffer becomes a temporary > buffer. > > [1]

[PATCH] docs: Update TPM documentation for usage of a TPM 2

2022-09-27 Thread Stefan Berger
Update the TPM documentation for usage of a TPM 2 rather than a TPM 1.2. Adjust the command lines and expected outputs inside the VM accordingly. Update the command line to start a TPM 2 with swtpm. Signed-off-by: Stefan Berger --- docs/specs/tpm.rst | 44

Re: [PATCH] target/ppc: restore powerpc_excp_booke doorbell interrupts

2022-09-27 Thread Fabiano Rosas
Nicholas Piggin writes: > This partially reverts commit 9dc20cc37db9 ("target/ppc: Simplify > powerpc_excp_booke"), which removed DOORI and DOORCI interrupts. > Without this patch, a -cpu e5500 -smp 2 machine booting Linux > crashes with: > > qemu: fatal: Invalid PowerPC exception 36. Aborting

Re: [PATCH 10/12] audio: refactor audio_get_avail()

2022-09-27 Thread Marc-André Lureau
On Fri, Sep 23, 2022 at 10:51 PM Volker Rümelin wrote: > Split out the code in audio_get_avail() that calculates the > buffer size that the audio frontend can read. This is similar > to the code changes in audio_get_free(). > > Signed-off-by: Volker Rümelin > Reviewed-by: Marc-André Lureau

Re: [PATCH v4 4/7] tests/x86: Add 'q35' machine type to drive_del-test

2022-09-27 Thread Thomas Huth
On 20/09/2022 12.48, Michael Labiuk wrote: Configure pci bridge setting to run tests on 'q35' machine type. Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/tests/qtest/drive_del-test.c

Re: [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node

2022-09-27 Thread Peter Maydell
On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker wrote: > The node name of the gpio-key devicetree node should be "key-poweroff": > > gpio-keys: 'poweroff' does not match any of the regexes: >

missing entries from docs/specs/pci-ids.txt ?

2022-09-27 Thread Peter Maydell
I noticed today that docs/specs/pci-ids.txt doesn't have an entry for the virtio-iommu, which is defined in pci.h as #define PCI_DEVICE_ID_VIRTIO_IOMMU 0x1014 There seem to be a few other virtio ID values defined in the header but not in the txt file too -- do we need to update it?

Re: [PATCH] linux-user: Add guest memory layout to exception dump

2022-09-27 Thread Helge Deller
Hi Philippe, On 9/27/22 13:13, Philippe Mathieu-Daudé wrote: On Tue, Sep 27, 2022 at 12:09 PM Helge Deller wrote: When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (for an example see /proc/self/maps) beside the CPU

Re: [PATCH v4 12/54] tests/qtest: hd-geo-test: Avoid using hardcoded /tmp

2022-09-27 Thread Thomas Huth
On 27/09/2022 13.05, Bin Meng wrote: From: Bin Meng This case was written to use hardcoded /tmp directory for temporary files. Update to use g_file_open_tmp() for a portable implementation. Signed-off-by: Bin Meng --- Changes in v4: - Do not use g_autofree and g_steal_pointer Changes in

[PATCH] target/arm: mark SP_EL1 with ARM_CP_EL3_NO_EL2_KEEP

2022-09-27 Thread Jerome Forissier
SP_EL1 must be kept when EL3 is present but EL2 is not. Therefore mark it with ARM_CP_EL3_NO_EL2_KEEP. Fixes: 696ba3771894 ("target/arm: Handle cpreg registration for missing EL") Signed-off-by: Jerome Forissier --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

<    1   2   3   4   5   >