On Wed, May 03, 2023 at 04:16:10PM +0200, David Hildenbrand wrote:
> On 20.04.23 16:28, Igor Mammedov wrote:
> > On Thu, 16 Mar 2023 16:36:55 +0100
> > David Hildenbrand wrote:
> >
> > > Following up on my previous work to make virtio-mem consume multiple
> > > memslots dynamically [1] that
On 20.04.23 16:28, Igor Mammedov wrote:
On Thu, 16 Mar 2023 16:36:55 +0100
David Hildenbrand wrote:
Following up on my previous work to make virtio-mem consume multiple
memslots dynamically [1] that requires precise accounting between used vs.
reserved memslots, I realized that vhost makes
On Wed, May 3, 2023 at 2:12 AM Alex Bennée wrote:
>
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
>
> Signed-off-by: Alex Bennée
> ---
> hw/xtensa/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Max Filippov
--
job_cancel_locked() drops the job list lock temporarily and it may call
aio_poll(). We must assume that the list has changed after this call.
Also, with unlucky timing, it can end up freeing the job during
job_completed_txn_abort_locked(), making the job pointer invalid, too.
For both reasons, we
Daniel P. Berrangé wrote:
> On Wed, May 03, 2023 at 03:18:32PM +0200, Juan Quintela wrote:
>> Helper to say if we are doing a migration over rdma.
>
> Is the "MigrationState" allocated freshly for every incoming
> or outgoing migration ? If it is reused, then something
> needs to set
On 5/3/23 11:12, Alex Bennée wrote:
From: Fabiano Rosas
The 'virt' machine uses virtio-net-pci as a fallback when no other
network driver has been selected via command line. Select VIRTIO_NET
and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n
(due to e.g.
On Wed, 3 May 2023 at 14:29, Juan Quintela wrote:
> So now we are between a rock and a hard place.
>
> We have slowed down the bandwidth for migration test because on non
> loaded machines, migration was too fast to need more than one pass.
>
> And we slowed it so much than now we hit the timer
On Tue, May 2, 2023, 5:24 AM Mads Ynddal wrote:
> From: Mads Ynddal
>
> I wanted to use simpletrace.py for an internal project, so I tried to
> update
> and polish the code. Some of the commits resolve specific issues, while
> some
> are more subjective.
>
> I've tried to divide it into commits
Am 03.05.2023 um 15:11 hat Stefan Hajnoczi geschrieben:
> On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote:
> > Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben:
> > > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote:
> > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi
On 04.04.23 00:14, Alexander Graf wrote:
Add an option for hostmem-file to start the memory object at an offset
into the target file. This is useful if multiple memory objects reside
inside the same target file, such as a device node.
In particular, it's useful to map guest memory directly into
On Wed, May 03, 2023 at 03:18:36PM +0200, Juan Quintela wrote:
> We can calculate it from the QEMUFile like the caller.
>
> Signed-off-by: Juan Quintela
> ---
> migration/rdma.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
On Wed, May 03, 2023 at 03:18:32PM +0200, Juan Quintela wrote:
> Helper to say if we are doing a migration over rdma.
>
> Signed-off-by: Juan Quintela
> ---
> migration/migration.h | 3 +++
> migration/options.c | 7 +++
> migration/options.h | 1 +
> migration/rdma.c | 4 +++-
> 4
Peter Maydell wrote:
> On Wed, 3 May 2023 at 10:17, Juan Quintela wrote:
>>
>> Peter Maydell wrote:
>> > On Tue, 2 May 2023 at 11:39, Juan Quintela wrote:
>> >> Richard, once that we are here, one of the problem that we are having is
>> >> that the test is exiting with an abort, so we have no
On Wed, 2023-05-03 at 10:43 +0200, Pierre Morel wrote:
> On 5/2/23 19:22, Nina Schoetterl-Glausch wrote:
> > On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote:
> > > On interception of STSI(15.1.x) the System Information Block
> > > (SYSIB) is built from the list of pre-ordered topology
We can calculate it from the QEMUFile like the caller.
Signed-off-by: Juan Quintela
---
migration/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index ca893c0bba..c37fcab88a 100644
--- a/migration/rdma.c
+++
Functions are long enough even without this.
Signed-off-by: Juan Quintela
---
migration/ram.c| 14 +++---
migration/rdma.c | 40 +++-
migration/rdma.h | 12 ++--
migration/trace-events | 28 ++--
4
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 22af45a5db..9b5e14a2ef 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -317,10 +317,8 @@ void
The only user was rdma, and its use is gone.
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 6 --
migration/qemu-file.h | 4
migration/rdma.c | 9 -
3 files changed, 19 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 17 -
migration/ram.c | 2 +-
migration/rdma.h | 16
3 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index 9c99914b21..5129b6f196
Signed-off-by: Juan Quintela
---
migration/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index c37fcab88a..11815d1c11 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3811,9 +3811,10 @@ out:
* the source.
*/
This could only happen if the source send
RAM_SAVE_FLAG_HOOK (i.e. rdma) and destination don't have CONFIG_RDMA.
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 8
1 file changed, 8 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index
There is only one flag called with: RAM_CONTROL_BLOCK_REG.
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 10 --
migration/qemu-file.h | 11 ---
migration/ram.c | 6 --
migration/rdma.c | 29 +
migration/rdma.h | 2 ++
Signed-off-by: Juan Quintela
---
migration/rdma.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index d6b4398620..4bc9c5cb91 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3243,10 +3243,6 @@ static
Fixes this commit, clearly a bad merge after a rebase or similar, it
should have been its own case since that point.
commit 5b0e9dd46fbda5152566a4a26fd96bc0d0452bf7
Author: Peter Lieven
Date: Tue Jun 24 11:32:36 2014 +0200
migration: catch unknown flag combinations in ram_load
Instead of going trhough ram_control_load_hook(), call
qemu_rdma_registration_handle() directly.
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 1 -
migration/ram.c | 5 -
migration/rdma.c | 9 +
migration/rdma.h | 2 ++
4 files changed, 11 insertions(+), 6
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 9d86900efe..17b3c2ea21 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -323,7 +323,7 @@ size_t
Hi
Changes in v2:
- rebased on top of migration-20230428 pull (second try)
- several of the patches on the PULL request
- make clean that we don't use rdma code when we don't use rdma
- create migrate_rdma() to check if we are in rdma migration.
There is no hope for this code. I am trying to
Helper to say if we are doing a migration over rdma.
Signed-off-by: Juan Quintela
---
migration/migration.h | 3 +++
migration/options.c | 7 +++
migration/options.h | 1 +
migration/rdma.c | 4 +++-
4 files changed, 14 insertions(+), 1 deletion(-)
diff --git
The only user of ram_control_save_page() and save_page() hook was
rdma. Just move the function to rdma.c, rename it to
rdma_control_save_page().
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 26 --
migration/qemu-file.h | 14 --
migration/ram.c
On 5/2/23 15:57, Richard Henderson wrote:
Convert away from the old interface with the implicit
MemOp argument.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 43 ++--
1 file changed, 28 insertions(+), 15 deletions(-)
Reviewed-by:
Once there:
- Remove unused data parameter
- unfold it in its callers
- change all callers to call qemu_rdma_registration_stop()
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 12
migration/qemu-file.h | 2 --
migration/ram.c | 17 ++---
Once there:
- Remove unused data parameter
- unfold it in its callers.
- change all callers to call qemu_rdma_registration_start()
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 13 +
migration/qemu-file.h | 2 --
migration/ram.c | 16 +---
On Wed, May 03, 2023 at 10:00:57AM +0200, Kevin Wolf wrote:
> Am 02.05.2023 um 20:56 hat Stefan Hajnoczi geschrieben:
> > On Tue, May 02, 2023 at 05:19:46PM +0200, Kevin Wolf wrote:
> > > Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben:
> > > > Only report a transport reset event to the
On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote:
> Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben:
> > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote:
> > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben:
> > > > vhost-user activity must be suspended during
On 5/2/23 15:57, Richard Henderson wrote:
Convert away from the old interface with the implicit
MemOp argument.
Signed-off-by: Richard Henderson
---
target/mips/tcg/translate.c | 8
target/mips/tcg/nanomips_translate.c.inc | 2 +-
2 files changed, 5 insertions(+), 5
On 5/2/23 15:57, Richard Henderson wrote:
Convert away from the old interface with the implicit
MemOp argument.
Signed-off-by: Richard Henderson
---
target/m68k/translate.c | 76 ++---
1 file changed, 25 insertions(+), 51 deletions(-)
diff --git
It's only required for the proxy helper.
Add a new option for the proxy helper rather than enabling it
implicitly.
Change-Id: I95b73fca625529e99d16b0a64e01c65c0c1d43f2
Signed-off-by: Peter Foley
---
meson.build | 12 +---
meson_options.txt | 2 ++
On Wed, May 03, 2023 at 01:40:49PM +0200, Kevin Wolf wrote:
> Am 02.05.2023 um 22:02 hat Stefan Hajnoczi geschrieben:
> > On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote:
> > > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben:
> > > > On Fri, Apr 28, 2023 at 04:22:55PM +0200,
Alex Bennée writes:
> As this is likely the most common configuration people will want once
> the --disable-tcg patches land.
I don't think sbsa-ref works with KVM, sbsa_ref_init has:
if (kvm_enabled()) {
error_report("sbsa-ref: KVM is not supported for this machine");
On Wed, 3 May 2023 at 12:54, zhenwei pi wrote:
>
> object_get_canonical_path already returns newly allocated memory, this
> means no additional g_strdup required. Remove g_strdup to avoid memory
> leak.
>
> Fixes: Coverity CID 1508074
> Fixes: f2b901098 ("cryptodev: Support query-stats QMP
On Wed, 3 May 2023 at 10:17, Juan Quintela wrote:
>
> Peter Maydell wrote:
> > On Tue, 2 May 2023 at 11:39, Juan Quintela wrote:
> >> Richard, once that we are here, one of the problem that we are having is
> >> that the test is exiting with an abort, so we have no clue what is
> >> happening.
On Wed, May 03, 2023 at 11:17:33AM +0200, Juan Quintela wrote:
> Peter Maydell wrote:
> > On Tue, 2 May 2023 at 11:39, Juan Quintela wrote:
> >> Richard, once that we are here, one of the problem that we are having is
> >> that the test is exiting with an abort, so we have no clue what is
> >>
On Tue, 2 May 2023 at 21:36, BALATON Zoltan wrote:
>
> On Tue, 2 May 2023, Peter Maydell wrote:
> > When we take a PNG screenshot the ordering of the colour channels in
> > the data is not correct, resulting in the image having weird
> > colouring compared to the actual display. (Specifically,
On 5/2/23 15:57, Richard Henderson wrote:
Convert away from the old interface with the implicit
MemOp argument. Importantly, this removes some incorrect
casts generated by idef-parser's gen_load().
Signed-off-by: Richard Henderson
---
target/hexagon/macros.h | 14
On 5/2/23 15:57, Richard Henderson wrote:
Convert away from the old interface with the implicit
MemOp argument. In this case we can fold the calls
using the size bits of MemOp.
Signed-off-by: Richard Henderson
---
target/cris/translate_v10.c.inc | 18 --
1 file changed, 4
On 5/2/23 15:57, Richard Henderson wrote:
Convert away from the old interface with the implicit
MemOp argument.
Signed-off-by: Richard Henderson
---
target/avr/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Anton Johansson
object_get_canonical_path already returns newly allocated memory, this
means no additional g_strdup required. Remove g_strdup to avoid memory
leak.
Fixes: Coverity CID 1508074
Fixes: f2b901098 ("cryptodev: Support query-stats QMP command")
Cc: Peter Maydell
Signed-off-by: zhenwei pi
---
Am 02.05.2023 um 22:02 hat Stefan Hajnoczi geschrieben:
> On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote:
> > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben:
> > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote:
> > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi
On 03.05.23 13:05, Michael S. Tsirkin wrote:
On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 03.05.23 12:20, David Hildenbrand wrote:
On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote:
On incoming migration we have the following sequence to load option
On 5/3/23 09:21, Pierre Morel wrote:
On 5/2/23 14:30, Cédric Le Goater wrote:
On 4/25/23 18:14, Pierre Morel wrote:
The topology information are attributes of the CPU and are
specified during the CPU device creation.
[...]
+
+/**
+ * s390_topology_init:
+ * @ms: the machine state where
Signed-off-by: Andreas Schwab
---
v2: dynmically compute the isa string
linux-user/syscall.c | 55 ++--
1 file changed, 53 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 69f740ff98..6df138c8b6 100644
---
On 4/27/23 10:04, Thomas Huth wrote:
On 25/04/2023 18.14, Pierre Morel wrote:
S390 adds two new SMP levels, drawers and books to the CPU
topology.
The S390 CPU have specific topology features like dedication
and entitlement to give to the guest indications on the host
vCPUs scheduling and
On Mai 02 2023, Andreas Schwab wrote:
> None of the currently defined cpus are non-GC cpus (except sifive_e, but
> that is not suitable for user-space anyway), and there doesn't appear to
> be any properties defined for changing the supported extensions.
Actually, modifying the extensions is
On Mon, May 01, 2023 at 10:21:00AM +0300, Andrew Melnychenko wrote:
> Added command "request-ebpf". This command returns
> eBPF program encoded base64. The program taken from the
> skeleton and essentially is an ELF object that can be
> loaded in the future with libbpf.
>
> Signed-off-by: Andrew
On Mon, May 01, 2023 at 10:20:57AM +0300, Andrew Melnychenko wrote:
> Changed eBPF map updates through mmaped array.
> Mmaped arrays provide direct access to map data.
> It should omit using bpf_map_update_elem() call,
> which may require capabilities that are not present.
>
> Signed-off-by:
On Mon, May 01, 2023 at 10:20:58AM +0300, Andrew Melnychenko wrote:
> eBPF RSS program and maps may now be passed during initialization.
> Initially was implemented for libvirt to launch qemu without permissions,
> and initialized eBPF program through the helper.
>
> Signed-off-by: Andrew
On Tue, 18 Apr 2023 15:21:36 -0700
Dave Jiang wrote:
> s small RFC patch series is really a hack on what I need from qemu rather
> than a proper implementation. I'm hoping to get some guidance from the list on
> how to implement this correctly for qemu upstream. Thank you!
>
> The patch series
Thomas Huth writes:
> On 03/05/2023 11.12, Alex Bennée wrote:
>> We can't assume the machine exists and should gracefully skip the test
>> if we haven't built the model. This is ostensibly fixed by
>> db2237c459 (tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI)
>> but I still hit it
Alex Bennée wrote:
> As this is likely the most common configuration people will want once
> the --disable-tcg patches land.
>
> Signed-off-by: Alex Bennée
> Cc: Fabiano Rosas
s/profoile/profile/ on $subject
> ---
> .gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml | 2 +-
> 1 file
On 5/3/23 10:12, Alex Bennée wrote:
As the cached assets have fallen out of our cache new attempts to
fetch these binaries fail hard due to certificate expirty. It's hard
to find a contact email for the domain as the root page of mipsdistros
throws up some random XML. I suspect Amazon are merely
Alex Bennée wrote:
> From: Fabiano Rosas
>
> The virt machine has IF_VIRTIO as block_default_type, which causes the
> generic code to try to create a virtio-blk-pci device pair at
> configure_blockdev()/qemu_create_cli_devices().
>
> Select VIRTIO_BLK and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid
On 5/3/23 10:12, Alex Bennée wrote:
As this is likely the most common configuration people will want once
the --disable-tcg patches land.
Signed-off-by: Alex Bennée
Cc: Fabiano Rosas
---
.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml | 2 +-
1 file changed, 1 insertion(+), 1
Alex Bennée wrote:
> This varies by accelerator. Also mention the modern bear trap that is
> ASLR.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Juan Quintela
> +Relocating code
> +---
> +
> +On modern kernels confusion can be caused by code being relocated by
> +features such as
On 5/3/23 10:12, Alex Bennée wrote:
This does a very minimal build without default devices or features. I
chose the aarch64 runner as it doesn't count towards CI minutes and is
a fairly under-utilised builder.
Signed-off-by: Alex Bennée
---
.../custom-runners/ubuntu-22.04-aarch64.yml | 22
On Tue, 18 Apr 2023 15:21:42 -0700
Dave Jiang wrote:
> The Generic Port Affinity Structure is added for the System Resource
> Affinity Table in ACPI r6.4. It provides information on the proximity
> domain that's associated with a device handle. This information in
> combination with HMAT can be
Alex Bennée wrote:
> Stretch is going out of support so things like security updates will
> fail. As the toolchain itself is binary it hopefully won't mind the
> underlying OS being updated.
>
> Signed-off-by: Alex Bennée
> Reported-by: Richard Henderson
Reviewed-by: Juan Quintela
On 5/3/23 10:12, Alex Bennée wrote:
These are needed for board creation so fail under "make check" with a
--without-default-devices build.
Signed-off-by: Alex Bennée
---
hw/xtensa/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
index
On 5/3/23 10:12, Alex Bennée wrote:
We can't just imply it as the board will fail to create otherwise.
This shows up as a "make check" failure with a
--without-default-devices build.
Signed-off-by: Alex Bennée
---
hw/sh4/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 5/3/23 10:12, Alex Bennée wrote:
These are needed for board creation so fail under "make check" with a
--without-default-devices build.
Signed-off-by: Alex Bennée
---
hw/loongarch/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson
r~
On 5/3/23 10:12, Alex Bennée wrote:
This is the fallback VGA devices needed for board creation so will
otherwise fail under "make check" with a --without-default-devices
build.
Signed-off-by: Alex Bennée
---
hw/sparc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git
On 5/3/23 10:12, Alex Bennée wrote:
We can't just imply it as the board will fail to create otherwise.
This shows up as a "make check" failure with a
--without-default-devices build.
Signed-off-by: Alex Bennée
---
hw/alpha/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 5/3/23 10:12, Alex Bennée wrote:
These are needed for board creation so fail under "make check" with a
--without-default-devices build.
Signed-off-by: Alex Bennée
---
hw/hppa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
index
Hello,
On 5/3/23 11:12, Thomas Huth wrote:
On 28/04/2023 14.35, Pierre Morel wrote:
On 4/27/23 15:38, Thomas Huth wrote:
On 25/04/2023 18.14, Pierre Morel wrote:
The topology information are attributes of the CPU and are
specified during the CPU device creation.
On hot plug we:
- calculate
On 5/3/23 10:12, Alex Bennée wrote:
From: Fabiano Rosas
The sbsa-ref machine explicitly creates a VGA PCI device, so make sure
vga-pci.c is included in the build.
Signed-off-by: Fabiano Rosas
Reviewed-by: Peter Maydell
Signed-off-by: Alex Bennée
On 5/3/23 10:12, Alex Bennée wrote:
From: Fabiano Rosas
This machine explicitly selects the e1000e network adapter if no other
option was given in the command line. Make sure e1000e is present in
the build.
Signed-off-by: Fabiano Rosas
Signed-off-by: Alex Bennée
On 5/3/23 10:12, Alex Bennée wrote:
From: Fabiano Rosas
This machine hardcodes the creation of the interrupt controller, so
make sure the dependency is explicitly described in the Kconfig.
Signed-off-by: Fabiano Rosas
Reviewed-by: Peter Maydell
Signed-off-by: Alex Bennée
On 5/3/23 10:12, Alex Bennée wrote:
From: Fabiano Rosas
This machine hardcodes initialization of the USB device, so select the
corresponding Kconfig. It is not enough to have it as "default y if
XLNX_VERSAL" at usb/Kconfig because building --without-default-devices
disables the default
On 5/3/23 10:12, Alex Bennée wrote:
From: Fabiano Rosas
The virt machine has IF_VIRTIO as block_default_type, which causes the
generic code to try to create a virtio-blk-pci device pair at
configure_blockdev()/qemu_create_cli_devices().
Select VIRTIO_BLK and VIRTIO_PCI from CONFIG_ARM_VIRT to
On 5/3/23 10:12, Alex Bennée wrote:
From: Fabiano Rosas
The 'virt' machine uses virtio-net-pci as a fallback when no other
network driver has been selected via command line. Select VIRTIO_NET
and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n
(due to e.g.
On 5/3/23 10:12, Alex Bennée wrote:
One of the main reasons to have custom runners it so we can run KVM
tests. Enable the "kvm" additional group so we can access the feature
on the kernel.
Signed-off-by: Alex Bennée
Reported-by: Peter Maydell
---
scripts/ci/setup/gitlab-runner.yml | 1 +
1
On 5/3/23 10:36, Harsh Prateek Bora wrote:
The bits in cr reg are grouped into eight 4-bit fields represented
by env->crf[8] and the related calculations should be abstracted to
keep the calling routines simpler to read. This is a step towards
cleaning up the related/calling code for better
On 5/3/23 10:17, Alex Bennée wrote:
Now we no longer have users for qemu_xxhash7 we can drop an additional
multiply and rol and make qemu_xxhash6 the implementation. Adjust the
smaller hash functions accordingly.
Message-Id: <20230420150009.1675181-11-alex.ben...@linaro.org>
Reviewed-by:
On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 03.05.23 12:20, David Hildenbrand wrote:
> > On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote:
> > > On incoming migration we have the following sequence to load option
> > > ROM:
> > >
> > > 1. On device
On 5/3/23 10:17, Alex Bennée wrote:
No need to pass zeros as we have helpers that do that for us.
Message-Id:<20230420150009.1675181-10-alex.ben...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Christian Schoenebeck
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Alex Bennée
---
On 5/3/23 10:17, Alex Bennée wrote:
Now we no longer have dynamic state affecting things we can remove the
additional fields in cpu.h and simplify the TB hash calculation.
Resolves:https://gitlab.com/qemu-project/qemu/-/issues/1358
Message-Id:<20230420150009.1675181-9-alex.ben...@linaro.org>
On 5/3/23 10:17, Alex Bennée wrote:
Now we no longer have vcpu controlled trace events we can excise the
code that allows us to query its status.
Message-Id:<20230420150009.1675181-8-alex.ben...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Alex
On 5/3/23 10:17, Alex Bennée wrote:
Now we no longer have any events that are for vcpus we can start
excising the code from the trace control. As the vcpu parameter is
encoded as part of QMP we just stub out the has_vcpu/vcpu parameters
rather than alter the API.
Message-Id:
On 5/3/23 10:17, Alex Bennée wrote:
I don't think I can remove the parameters directly but certainly mark
them as deprecated.
Message-Id:<20230420150009.1675181-6-alex.ben...@linaro.org>
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Alex Bennée
---
qapi/trace.json | 22 +++---
On 03/05/2023 11.36, Pierre Morel wrote:
On 4/27/23 10:04, Thomas Huth wrote:
On 25/04/2023 18.14, Pierre Morel wrote:
S390 adds two new SMP levels, drawers and books to the CPU
topology.
The S390 CPU have specific topology features like dedication
and entitlement to give to the guest
On 5/3/23 10:17, Alex Bennée wrote:
This makes it a little easier for developers to find where things
where being generated.
Signed-off-by: Alex Bennée
---
scripts/qapi/gen.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On 5/3/23 10:17, Alex Bennée wrote:
This does involve temporarily stubbing out some helper functions
before we excise the rest of the code.
Message-Id:<20230420150009.1675181-4-alex.ben...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Alex Bennée
On 03/05/2023 11.12, Alex Bennée wrote:
We can't assume the machine exists and should gracefully skip the test
if we haven't built the model. This is ostensibly fixed by
db2237c459 (tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI)
but I still hit it during my tests.
The problem is
On 5/3/23 10:17, Alex Bennée wrote:
While these are all in helper functions being designated vcpu events
complicates the removal of the dynamic vcpu state code. TCG plugins
allow you to instrument vcpu_[init|exit|idle].
We rename cpu_reset and make it a normal watch point.
"... normal trace
Alistair,
Patch 2 has a typo right in the commit title:
"target/riscv: add query-cpy-definitions support"
it should be 'query-cpu-definitions'. Can you amend it in the tree? Or should
I re-send?
Thanks,
Daniel
On 4/16/23 23:58, Alistair Francis wrote:
On Wed, Apr 12, 2023 at 4:36 AM
On 03.05.23 12:20, David Hildenbrand wrote:
On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote:
On incoming migration we have the following sequence to load option
ROM:
1. On device realize we do normal load ROM from the file
2. Than, on incoming migration we rewrite ROM from the incoming
On 5/3/23 10:17, Alex Bennée wrote:
This is pure duplication now. Both bsd-user and linux-user have
builtin strace support and we can also track syscalls via the plugins
system.
Message-Id:<20230420150009.1675181-2-alex.ben...@linaro.org>
Reviewed-by: Warner Losh
Reviewed-by: Stefan Hajnoczi
Hi Richard,
On Sat, Apr 29, 2023 at 10:28:03AM +0100, Richard Henderson wrote:
> On 4/27/23 03:09, Jamie Iles wrote:
> > From: Jamie Iles
> >
> > The round-robin scheduler will iterate over the CPU list with an
> > assigned budget until the next timer expiry and may exit early because
> > of a
On 03/05/2023 11.12, Alex Bennée wrote:
As the cached assets have fallen out of our cache new attempts to
fetch these binaries fail hard due to certificate expirty. It's hard
s/expirty/expiry/
With that typo fixed:
Reviewed-by: Thomas Huth
On 5/3/23 10:14, Stafford Horne wrote:
+set_default_nan_mode(1, >env.fp_status);
+set_float_detect_tininess(float_tininess_before_rounding,
+ >env.fp_status);
You don't mention the nan change in the commit message.
Right, and I am not sure I need it. Let
We can have failure with the inet type test because the port address
is not allocated atomically and can be taken by another test between its
selection and the start of QEMU. To avoid that, use an unix socket with
a path that is unique
Signed-off-by: Laurent Vivier
---
101 - 200 of 530 matches
Mail list logo
