[PATCH 01/52] migration/rdma: Clean up qemu_rdma_poll()'s return type

qemu_rdma_poll()'s return type is uint64_t, even though it returns 0, -1, or @ret, which is int. Its callers assign the return value to int variables, then check whether it's negative. Unclean. Return int instead. Signed-off-by: Markus Armbruster --- migration/rdma.c | 4 ++-- 1 file

[PATCH 28/52] migration/rdma: Check negative error values the same way everywhere

When a function returns 0 on success, negative value on error, checking for non-zero suffices, but checking for negative is clearer. So do that. Signed-off-by: Markus Armbruster --- migration/rdma.c | 82 1 file changed, 41 insertions(+), 41

[PATCH 34/52] migration/rdma: Convert qemu_rdma_exchange_recv() to Error

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

[PATCH 27/52] migration/rdma: Drop superfluous assignments to @ret

Signed-off-by: Markus Armbruster --- migration/rdma.c | 35 ++- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 85f6b274bf..62d95b7d2c 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -1514,7 +1514,7

[PATCH 29/52] migration/rdma: Plug a memory leak and improve a message

When migration capability @rdma-pin-all is true, but the server cannot honor it, qemu_rdma_connect() calls macro ERROR(), then returns success. ERROR() sets an error. Since qemu_rdma_connect() returns success, its caller rdma_start_outgoing_migration() duly assumes @errp is still clear. The

[PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set error

qemu_rdma_resolve_host() and qemu_rdma_dest_init() try addresses until they find on that works. If none works, they return the first Error set by qemu_rdma_broken_ipv6_kernel(), or else return a generic one. qemu_rdma_broken_ipv6_kernel() neglects to set an Error when ibv_open_device() fails.

[PATCH 17/52] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE()

Hiding return statements in macros is a bad idea. Use a function instead, and open code the return part. Signed-off-by: Markus Armbruster --- migration/rdma.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/migration/rdma.c

[PATCH 35/52] migration/rdma: Convert qemu_rdma_exchange_send() to Error

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

[PATCH 31/52] migration/rdma: Retire macro ERROR()

ERROR() has become "error_setg() unless an error has been set already". Hiding the conditional in the macro is in the way of further work. Replace the macro uses by their expansion, and delete the macro. Signed-off-by: Markus Armbruster --- migration/rdma.c | 168

[PATCH 50/52] migration/rdma: Silence qemu_rdma_cleanup()

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

[PATCH 41/52] migration/rdma: Convert qemu_rdma_post_send_control() to Error

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

[PATCH 00/52] migration/rdma: Error handling fixes

Oh dear, where to start. There's so much wrong, and in pretty obvious ways. This code should never have passed review. I'm refraining from saying more; see the commit messages instead. Issues remaining after this series include: * Terrible error messages * Some error message cascades remain

[PATCH 37/52] migration/rdma: Convert qemu_rdma_reg_whole_ram_blocks() to Error

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

[PATCH 14/52] migration/rdma: Use bool for two RDMAContext flags

@error_reported and @received_error are flags. The latter is even assigned bool true. Change them from int to bool. Signed-off-by: Markus Armbruster --- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index

[PATCH 02/52] migration/rdma: Clean up qemu_rdma_data_init()'s return type

qemu_rdma_data_init() return type is void *. It actually returns RDMAContext *, and all its callers assign the value to an RDMAContext *. Unclean. Return RDMAContext * instead. Signed-off-by: Markus Armbruster --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 20/52] migration/rdma: Drop dead qemu_rdma_data_init() code for !@host_port

qemu_rdma_data_init() neglects to set an Error when it fails because @host_port is null. Fortunately, no caller passes null, so this is merely a latent bug. Drop the flawed code handling null argument. Signed-off-by: Markus Armbruster --- migration/rdma.c | 29 + 1

[PATCH 47/52] migration/rdma: Don't report received completion events as error

When qemu_rdma_wait_comp_channel() receives an event from the completion channel, it reports an error "receive cm event while wait comp channel,cm event is T", where T is the numeric event type. However, the function fails only when T is a disconnect or device removal. Events other than these two

[PATCH 46/52] migration/rdma: Silence qemu_rdma_reg_control()

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

Re: QEMU migration-test CI intermittent failure

Peter Xu writes: > On Fri, Sep 15, 2023 at 12:28:36PM -0400, Peter Xu wrote: >> On Thu, Sep 14, 2023 at 10:56:23PM -0300, Fabiano Rosas wrote: >> > Peter Xu writes: >> > >> > > On Thu, Sep 14, 2023 at 07:54:17PM -0300, Fabiano Rosas wrote: >> > >> Fabiano Rosas writes: >> > >> >> > >> >

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

On Mon, Sep 18, 2023 at 7:31 PM Michael S. Tsirkin wrote: > > On Mon, Sep 18, 2023 at 07:24:48PM +0530, Ani Sinha wrote: > > 32-bit systems do not have a reserved memory for hole64 but they may have a > > reserved memory space for memory hotplug. Since, hole64 starts after the > > reserved

Re: [PATCH v4 00/10] linux-user: Detect and report host crashes

On 9/12/23 12:34, Michael Tokarev wrote: 12.09.2023 12:45, Helge Deller: /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/13/../../../../lib64/libc.a(abort.o): in function `abort': (.text.unlikely+0x0): multiple definition of `abort';

Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard

On 9/18/23 15:57, Alexander Ivanov wrote: On 9/15/23 20:41, Denis V. Lunev wrote: * Discarding with backing stores is not supported by the format. * There is no buffering/queueing of the discard operation. * Only operations aligned to the cluster are supported. Signed-off-by: Denis V. Lunev

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

On Mon, Sep 18, 2023 at 07:24:48PM +0530, Ani Sinha wrote: > 32-bit systems do not have a reserved memory for hole64 but they may have a > reserved memory space for memory hotplug. Since, hole64 starts after the > reserved hotplug memory, the unaligned hole64 start address gives us the > end

Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard

On 9/15/23 20:41, Denis V. Lunev wrote: * Discarding with backing stores is not supported by the format. * There is no buffering/queueing of the discard operation. * Only operations aligned to the cluster are supported. Signed-off-by: Denis V. Lunev --- block/parallels.c | 47

[PATCH v2 15/18] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meson.build | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/arm/Kconfig

[PATCH v2 11/18] ui/vnc: VNC requires PIXMAN

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build| 6 +- ui/meson.build | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index e870b039cc..8106ab39ac 100644 --- a/meson.build +++ b/meson.build @@ -1545,7 +1545,11

[PATCH v2 04/18] ui/console: allow to override the default VC

From: Marc-André Lureau If a display is backed by a specialized VC, allow to override the default "vc:80Cx24C". For that, set the dpy.type just before creating the default serial/parallel/monitor. (the next patch makes it create a "null" backend by default if !PIXMAN) Signed-off-by: Marc-André

[PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

32-bit systems do not have a reserved memory for hole64 but they may have a reserved memory space for memory hotplug. Since, hole64 starts after the reserved hotplug memory, the unaligned hole64 start address gives us the end address for this memory hotplug region that the processor may use. Fix

[PATCH v2 18/18] build-sys: make pixman actually optional

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 74bdfa92b7..bcf7424440 100644 --- a/meson.build +++ b/meson.build @@ -832,9 +832,6 @@ if not get_option('pixman').auto() or have_system

[PATCH v2 17/18] hw/display: make ATI_VGA depend on PIXMAN

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configs/devices/mips64el-softmmu/default.mak | 2 +- hw/display/Kconfig | 2 +- hw/display/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

From: Marc-André Lureau Drop the "x-pixman" property and use fallback path in such case. Signed-off-by: Marc-André Lureau --- hw/display/sm501.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index

[PATCH v2 14/18] ui/dbus: do not require PIXMAN

From: Marc-André Lureau Implement a fallback path for region 2D update. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 88 -- ui/meson.build | 2 +- 2 files changed, 62 insertions(+), 28 deletions(-) diff --git a/ui/dbus-listener.c

[PATCH v2 00/18] Make Pixman an optional dependency

From: Marc-André Lureau Hi, QEMU system emulators can be made to compile and work without Pixman. Only a few devices and options actually require it (VNC, Gtk, Spice for ex) and will have to be compiled out. However, most of QEMU graphics-related code is based on pixman_image_t and format. If

[PATCH v2 03/18] ui: add pixman-compat.h

From: Marc-André Lureau This is a tiny subset of PIXMAN API that is used pervasively in QEMU codebase to manage images and identify the underlying format. It doesn't seems worth to wrap this in a QEMU-specific API. Signed-off-by: Marc-André Lureau --- include/ui/pixman-compat.h | 190

[PATCH v2 12/18] ui/spice: SPICE/QXL requires PIXMAN

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build| 6 +- hw/display/Kconfig | 2 +- ui/meson.build | 10 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index 8106ab39ac..1ef57ebda2 100644 ---

[PATCH v2 07/18] virtio-gpu: replace PIXMAN for region/rect test

From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau --- include/ui/rect.h | 55 + hw/display/virtio-gpu.c | 30

[PATCH v2 10/18] ui/gl: opengl doesn't require PIXMAN

From: Marc-André Lureau The QEMU fallback covers the requirements. We still need the flags of header inclusion with CONFIG_PIXMAN. Signed-off-by: Marc-André Lureau --- ui/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index

[PATCH v2 06/18] qmp/hmp: disable screendump if PIXMAN is missing

From: Marc-André Lureau The command requires color conversion and line-by-line feeding. We could have a simple fallback for simple formats though. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- qapi/ui.json | 3 ++- ui/ui-hmp-cmds.c | 2 ++ ui/ui-qmp-cmds.c | 2

[PATCH v2 01/18] build-sys: add a "pixman" feature

From: Marc-André Lureau For now, pixman is mandatory, but we set config_host.h and Kconfig. Once compilation is fixed, "pixman" will become actually optional. Signed-off-by: Marc-André Lureau --- meson.build | 10 -- include/ui/qemu-pixman.h | 2 ++

[PATCH v2 08/18] ui/console: when PIXMAN is unavailable, don't draw placeholder msg

From: Marc-André Lureau When we can't draw text, simply show a blank display. Signed-off-by: Marc-André Lureau --- ui/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/console.c b/ui/console.c index 8b5c40ddd7..1c710a6d5e 100644 --- a/ui/console.c +++ b/ui/console.c @@ -584,6

[PATCH v2 13/18] ui/gtk: -display gtk requires PIXMAN

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1ef57ebda2..74bdfa92b7 100644 --- a/meson.build +++ b/meson.build @@ -1516,7 +1516,11 @@ gtkx11 = not_found vte =

[PATCH v2 09/18] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

From: Marc-André Lureau This simply means that 2d drawing updates won't be handled, but 3d should work. Signed-off-by: Marc-André Lureau --- hw/display/vhost-user-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index

[PATCH v2 05/18] ui/vc: console-vc requires PIXMAN

From: Marc-André Lureau Add stubs for the fallback paths. Signed-off-by: Marc-André Lureau --- ui/console-vc-stubs.c | 32 ui/console.c | 4 ui/meson.build| 2 +- 3 files changed, 37 insertions(+), 1 deletion(-) create mode 100644

[PATCH v2 02/18] ui: compile out some qemu-pixman functions when !PIXMAN

From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/ui/qemu-pixman.h

Re: [PULL 0/9] testing updates (back to green!)

On Fri, 15 Sept 2023 at 11:10, Alex Bennée wrote: > > The following changes since commit 005ad32358f12fe9313a4a01918a55e60d4f39e5: > > Merge tag 'pull-tpm-2023-09-12-3' of > https://github.com/stefanberger/qemu-tpm into staging (2023-09-13 13:41:57 > -0400) > > are available in the Git

Re: [PULL 0/3] Firmware/seabios 20230912 patches

Hi, > > I'm still seeing a CI failure: > > > > 3/61 qemu:qtest+qtest-x86_64 / qtest-x86_64/bios-tables-test ERROR > > 19.18s killed by signal 6 SIGABRT ^^ > Hmm, that's rather unhelpful - we need to get iasl added to the build > env by default. That is a

Re: [PULL 01/39] accel/tcg: mttcg remove false-negative halted assertion

"Nicholas Piggin" writes: > On Mon Sep 18, 2023 at 5:59 PM AEST, Alex Bennée wrote: >> >> "Nicholas Piggin" writes: >> >> > On Sat Sep 16, 2023 at 1:29 PM AEST, Richard Henderson wrote: >> >> From: Nicholas Piggin >> >> >> >> mttcg asserts that an execution ending with EXCP_HALTED must have

[PULL 7/8] tests/acpi: update virt/SSDT.memhp

The edk2 update caused an address change: DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) { Scope (\_SB) { Device (NVDR) { Name (_HID, "ACPI0012" /* NVDIMM Root Device */) // _HID: Hardware ID [ ... ] } } -

[PULL 8/8] tests/acpi: disallow virt/SSDT.memhp updates

Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index e569098abddc..dfb8523c8bf4 100644 ---

[PULL 0/8] Firmware/edk2 20230918 patches

The following changes since commit c5ea91da443b458352c1b629b490ee6631775cb4: Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging (2023-09-08 10:06:25 -0400) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/firmware/edk2-20230918

[PULL 5/8] edk2: update submodule to edk2-stable202308

New stable release was tagged in August 2023, update the edk2 submodule to it. Signed-off-by: Gerd Hoffmann --- roms/edk2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/edk2 b/roms/edk2 index f80f052277c8..819cfc6b42a6 16 --- a/roms/edk2 +++ b/roms/edk2 @@ -1 +1 @@

[PULL 4/8] edk2: workaround edk-stable202308 bug

Set PCD to workaround two fixes missing the release. https://github.com/tianocore/edk2/commit/8b66f9df1bb0fd5ebb743944d41cb33178cf2fdd https://github.com/tianocore/edk2/commit/020cc9e2e7053bb62247b0babbbe80cb855592e5 Signed-off-by: Gerd Hoffmann --- roms/edk2-build.config | 6 ++ 1 file

[PULL 1/8] tests/acpi: allow virt/SSDT.memhp updates

Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..e569098abddc 100644 ---

[PULL 3/8] edk2: update build config

risc-v switched to use split code/vars images like the other archs. Signed-off-by: Gerd Hoffmann --- roms/edk2-build.config | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/roms/edk2-build.config b/roms/edk2-build.config index 66ef9ffcb91f..ffe0d12d0cb7 100644 ---

[PULL 2/8] edk2: update build script

Sync with latest version from gitlab.com/kraxel/edk2-build-config Signed-off-by: Gerd Hoffmann --- roms/edk2-build.py | 202 - 1 file changed, 128 insertions(+), 74 deletions(-) diff --git a/roms/edk2-build.py b/roms/edk2-build.py index

[PATCH] target/ppc: Update gdbstub to read SPR's CFAR, DEC, HDEC, TB-L/U

SPR's CFAR, DEC, HDEC, TB-L/U are not implemented as part of CPUPPCState. Hence, gdbstub is not able to access them using (CPUPPCState *)env->spr[] array. Update gdb_get_spr_reg() method to handle these SPR's specifically. Signed-off-by: Saif Abrar --- target/ppc/gdbstub.c | 40

[PULL 0/3] ppc queue

-20230918 for you to fetch changes up to 44fa20c92811a9b88b41b4882a7e948c2fe6bd08: spapr: Remove support for NVIDIA V100 GPU with NVLink2 (2023-09-18 07:25:28 -0300) ppc patch queue for 2023-09-18: In this short queue we're making

[PULL 3/3] spapr: Remove support for NVIDIA V100 GPU with NVLink2

From: Cédric Le Goater NVLink2 support was removed from the PPC PowerNV platform and VFIO in Linux 5.13 with commits : 562d1e207d32 ("powerpc/powernv: remove the nvlink support") b392a1989170 ("vfio/pci: remove vfio_pci_nvlink2") This was 2.5 years ago. Do the same in QEMU with a revert of

[PULL 1/3] MAINTAINERS: Nick Piggin PPC maintainer, other PPC changes

Update all relevant PowerPC entries as follows: - Nick Piggin is promoted to Maintainer in all qemu-ppc subsystems. Nick has been a solid contributor for the last couple of years and has the required knowledge and motivation to drive the boat. - Greg Kurz is being removed from all qemu-ppc

[PULL 2/3] ppc/xive: Fix uint32_t overflow

From: Cédric Le Goater As reported by Coverity, "idx << xive->pc_shift" is evaluated using 32-bit arithmetic, and then used in a context expecting a "uint64_t". Add a uint64_t cast. Fixes: Coverity CID 1519049 Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs") Signed-off-by: Cédric

target/sparc: What is CPU_FEATURE_FLOAT128 for?

Hi Mark, Artyom, I'm looking at the CPU_FEATURE_FLOAT128 definition introduced in commit 64a88d5d3a ("CPU feature selection support"). Any clue how it was supposed to be used? Thanks, Phil.

Re: [PATCH 16/21] parallels: naive implementation of allocate_clusters with used bitmap

On 9/18/23 15:14, Denis V. Lunev wrote: On 9/18/23 15:09, Alexander Ivanov wrote: On 9/15/23 20:41, Denis V. Lunev wrote: The access to the bitmap is not optimized completely. Signed-off-by: Denis V. Lunev ---   block/parallels.c | 51 ---  

Re: [PATCH 17/21] parallels: improve readability of allocate_clusters

On 9/15/23 20:41, Denis V. Lunev wrote: Replace 'space' representing the amount of data to preallocate with 'bytes'. Rationale: * 'space' at each place is converted to bytes * the unit is more close to the variable name Signed-off-by: Denis V. Lunev --- block/parallels.c | 13 +

Re: [PATCH 16/21] parallels: naive implementation of allocate_clusters with used bitmap

On 9/18/23 15:09, Alexander Ivanov wrote: On 9/15/23 20:41, Denis V. Lunev wrote: The access to the bitmap is not optimized completely. Signed-off-by: Denis V. Lunev ---   block/parallels.c | 51 ---   1 file changed, 39 insertions(+), 12

Re: [PATCH 16/21] parallels: naive implementation of allocate_clusters with used bitmap

On 9/15/23 20:41, Denis V. Lunev wrote: The access to the bitmap is not optimized completely. Signed-off-by: Denis V. Lunev --- block/parallels.c | 51 --- 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/block/parallels.c

Re: [PULL 0/3] Firmware/seabios 20230912 patches

On Mon, Sep 18, 2023 at 08:52:57AM -0400, Stefan Hajnoczi wrote: > On Mon, 18 Sept 2023 at 06:00, Gerd Hoffmann wrote: > > > > > Hi Gerd, > > > I think either this pull request or your edk2 pull request causes the > > > following CI failure: > > > > > > >>>

Re: [PULL 0/3] Firmware/seabios 20230912 patches

On Mon, 18 Sept 2023 at 06:00, Gerd Hoffmann wrote: > > > Hi Gerd, > > I think either this pull request or your edk2 pull request causes the > > following CI failure: > > > > >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh > > >>>

Re: A confusion about CXL in arm virt machine

On Mon, 19 Jun 2023 at 10:58, Jonathan Cameron via wrote: > > On Fri, 16 Jun 2023 14:10:24 -0400 > Gregory Price wrote: > > > > Last I tested cxl-2023-05-25 branch of Johnathan's fork is working on x86: > > > > https://gitlab.com/jic23/qemu/-/tree/cxl-2023-05-25 > > > > I have not worked with

Re: [PATCH v3 12/16] memory-device, vhost: Support automatic decision on the number of memslots

On 17.09.23 12:46, Maciej S. Szmigiero wrote: On 8.09.2023 16:21, David Hildenbrand wrote: We want to support memory devices that can automatically decide how many memslots they will use. In the worst case, they have to use a single memslot. The target use cases are virtio-mem and the hyper-v

Re: [PATCH v2 0/5] elf2dmp: improve Win2022, Win11 and large dumps

On Fri, 15 Sept 2023 at 18:13, Akihiko Odaki wrote: > > On 2023/09/16 2:01, Viktor Prutyanov wrote: > > Windows Server 2022 and Windows 11 require more careful kernel PE image > > search and handling of PDB than previous Windows versions. > > Also, improve support of large ELF dump files, dumps

Re: [PATCH 2/4] hw/cxl: Use available size parameter to index into register arrays.

On Thu, 14 Sep 2023 15:54:54 +0300 Michael Tokarev wrote: > 13.09.2023 18:05, Jonathan Cameron via wrote: > > Indexing has to be done into an array with the right size elements. > > As such, the size parameter always matches the array element size > > and can be used in place of the longer

Re: [risu PATCH v3 0/7] Add support for s390x to RISU

On Thu, 14 Sept 2023 at 12:33, Thomas Huth wrote: > > Hi Peter! > > Here are some patches that add basic support for s390x to RISU. > It's still quite limited, e.g. no support for load/store memory > operations yet, but the basics with simple 16-bit or 32-bit > instructions work *now* already

Re: [PATCH v1 00/22] vfio: Adopt iommufd

On 9/18/23 13:51, Jason Gunthorpe wrote: On Fri, Sep 15, 2023 at 02:42:48PM +0200, Cédric Le Goater wrote: On 8/30/23 12:37, Zhenzhong Duan wrote: Hi All, As the kernel side iommufd cdev and hot reset feature have been queued, also hwpt alloc has been added in Jason's for_next branch [1], I'd

Re: [PATCH v2 qemu 0/3] Allow dump-guest-memory to output standard kdump format

On Wed, Sep 13, 2023 at 06:03:12PM -0700, Stephen Brennan wrote: > Hello all, > > This is the second version of my patch series about the kdump format, > you can see the first version here [1]. > > The current output format for dump-guest-memory's kdump compressed > format is actually the

Re: [PATCH v2 qemu 3/3] dump: Add qmp argument "reassembled"

On Wed, Sep 13, 2023 at 06:03:15PM -0700, Stephen Brennan wrote: > This can be used from QMP command line as "-R" to mirror the > corresponding flag for makedumpfile. This enables the kdump_reassembled > flag introduced in the previous patch. > > Signed-off-by: Stephen Brennan > --- >

Re: [PATCH 15/21] parallels: update used bitmap in allocate_cluster

On 9/15/23 20:41, Denis V. Lunev wrote: We should extend the bitmap ff the file is extended and set the bit in Typo: ff -> if. the image used bitmap once the cluster is allocated. Sanity check at that moment also looks like a good idea. Signed-off-by: Denis V. Lunev ---

Re: [PATCH v1 00/22] vfio: Adopt iommufd

On Fri, Sep 15, 2023 at 02:42:48PM +0200, Cédric Le Goater wrote: > On 8/30/23 12:37, Zhenzhong Duan wrote: > > Hi All, > > > > As the kernel side iommufd cdev and hot reset feature have been queued, > > also hwpt alloc has been added in Jason's for_next branch [1], I'd like > > to update a new

Re: [PATCH 14/21] parallels: accept multiple clusters in mark_used()

On 9/15/23 20:41, Denis V. Lunev wrote: This would be useful in the next patch in allocate_clusters(). This change would not imply serious performance drawbacks as usually image is full of data or are at the end of the bitmap. Signed-off-by: Denis V. Lunev --- block/parallels.c | 18

Re: [PATCH 13/21] tests: test self-cure of parallels image with duplicated clusters

On 9/15/23 20:41, Denis V. Lunev wrote: The test is quite similar with the original one for duplicated clusters. There is the only difference in the operation which should fix the image. Signed-off-by: Denis V. Lunev --- tests/qemu-iotests/tests/parallels-checks | 36 +++

Re: [PATCH 12/21] tests: fix broken deduplication check in parallels format test

On 9/15/23 20:41, Denis V. Lunev wrote: Original check is broken as supposed reading from 2 different clusters results in read from the same file offset twice. This is definitely wrong. We should be sure that * the content of both clusters is correct after repair * clusters are at the different

Re: [PATCH 0/3] accel: Factor tcg_cpu_reset_hold() out of cpu-common.c

On 18/09/23, Philippe Mathieu-Daudé wrote: > Hi, > > We want to have exec/ code agnostic to accelerators. > still we use various call to TCG and KVM. This series > factor the TCG code from cpu_common_reset_hold() to an > accel-specific handler within AccelOpsClass. > > Based-on:

Re: [PATCH] MAINTAINERS: Nick Piggin PPC maintainer, other PPC changes

On 9/18/23 12:31, Daniel Henrique Barboza wrote: On 9/18/23 02:01, Nicholas Piggin wrote: Hi Daniel, Thank you for your stwardship of ppc, I might hope to do half as good a job with it as you have. And to Greg and David for all the work over the years. I'm pretty sure you'll be great :D

Re: [PATCH 11/21] parallels: collect bitmap of used clusters at open

On 9/15/23 20:41, Denis V. Lunev wrote: If the operation is failed, we need to check image consistency if the problem is not about memory allocation. Bitmap adjustments in allocate_cluster are not performed yet. They worth to be separate. This was proven useful during debug of this series. Kept

Re: [PATCH 0/8] hw/audio/es1370: bug fix

Hi On Sun, Sep 17, 2023 at 10:55 AM Volker Rümelin wrote: > > Cc: qemu-stable. Patch 1/8 is a bug fix. > Cc: more people. The maintainer of hw/audio is busy with other projects. > > Earlier this year I was asked if I could help to debug an audio playback > speed issue with the es1370 device.

Re: [PATCH v2 qemu 3/3] dump: Add qmp argument "reassembled"

Hi On Thu, Sep 14, 2023 at 5:03 AM Stephen Brennan wrote: > > This can be used from QMP command line as "-R" to mirror the > corresponding flag for makedumpfile. This enables the kdump_reassembled > flag introduced in the previous patch. > > Signed-off-by: Stephen Brennan > --- >

Re: [PATCH v2 qemu 2/3] dump: Allow directly outputting reassembled kdumps

Hi On Thu, Sep 14, 2023 at 5:04 AM Stephen Brennan wrote: > > The flattened format (currently output by qemu) is used by makedumpfile > only when it is outputting a vmcore to a file which is not seekable. The > flattened format functions essentially as a set of instructions of the > form "seek

Re: [PATCH] ui/gtk: fix UI info precondition

Hi On Fri, Sep 15, 2023 at 4:46 PM Michael Tokarev wrote: > > 15.09.2023 14:36, marcandre.lur...@redhat.com: > > From: Marc-André Lureau > > > > dpy_get_ui_info() shouldn't be called if the underlying GPU doesn't > > support it. > > > > Before the assert() was added and the regression

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 4:32 PM David Hildenbrand wrote: > > On 18.09.23 13:00, Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: > >> > >> On 18.09.23 12:54, Ani Sinha wrote: > >>> On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand > >>> wrote: > > On

Re: [PATCH] mem/x86: add processor address space check for VM memory

On 18.09.23 13:00, Ani Sinha wrote: On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: On 18.09.23 12:54, Ani Sinha wrote: On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: On 18.09.23 12:11, Ani Sinha wrote: Ok hopefully my last question. I am still confused on

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 4:30 PM Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: > > > > On 18.09.23 12:54, Ani Sinha wrote: > > > On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand > > > wrote: > > >> > > >> On 18.09.23 12:11, Ani Sinha wrote: > > >> > > >>> > >

Re: [PATCH 1/2] hw/sd/omap_mmc: Do not reset SDCard until being fully realized

On Mon, 18 Sept 2023 at 11:17, Philippe Mathieu-Daudé wrote: > > We shouldn't call QDev DeviceReset() before DeviceRealize(). > > Since the OMAP MMC model is not QDev'ified, it has to manually > call the SDCard reset() handler. This breaks QDev assumptions > that DeviceReset() is never called

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: > > On 18.09.23 12:54, Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: > >> > >> On 18.09.23 12:11, Ani Sinha wrote: > >> > >>> > >>> Ok hopefully my last question. I am still confused on something. > >>>

Re: [PATCH] mem/x86: add processor address space check for VM memory

On 18.09.23 12:54, Ani Sinha wrote: On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: On 18.09.23 12:11, Ani Sinha wrote: Ok hopefully my last question. I am still confused on something. Does the above mean that the hole64 will actually start from an address that is

[PATCH 1/3] qga: Fix memory leak when output stream is unused

If capture-output is requested but one of the channels goes unused (eg. we attempt to capture stderr but the command never writes to stderr), we can leak memory. guest_exec_output_watch() is (from what I understand) unconditionally called for both streams if output capture is requested. The first

[PATCH 2/3] qga: Add optional stream-output argument to guest-exec

Currently, commands run through guest-exec are "silent" until they finish running. This is fine for short lived commands. But for commands that take a while, this is a bad user experience. Usually long running programs know that they will run for a while. To improve user experience, they will

[PATCH 0/3] qga: Add optional stream-output argument to guest-exec

Currently, commands run through guest-exec are "silent" until they finish running. This is fine for short lived commands. But for commands that take a while, this is a bad user experience. Usually long running programs know that they will run for a while. To improve user experience, they will

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: > > On 18.09.23 12:11, Ani Sinha wrote: > > > > > Ok hopefully my last question. I am still confused on something. > > Does the above mean that the hole64 will actually start from an > > address that is beyond maxram? Like

[PATCH 3/3] qga: test: Add test for guest-exec stream-output

Add a test that simulates a long running process (by using a named pipe to synchronize). This test ensures that full output is returned with each call to guest-exec-status. Signed-off-by: Daniel Xu --- tests/unit/test-qga.c | 77 +++ 1 file changed, 77

Re: [PULL 01/39] accel/tcg: mttcg remove false-negative halted assertion

On Mon Sep 18, 2023 at 5:59 PM AEST, Alex Bennée wrote: > > "Nicholas Piggin" writes: > > > On Sat Sep 16, 2023 at 1:29 PM AEST, Richard Henderson wrote: > >> From: Nicholas Piggin > >> > >> mttcg asserts that an execution ending with EXCP_HALTED must have > >> cpu->halted. However between the

Re: [PATCH 1/1] sbsa-ref: add non-secure EL2 virtual timer

On Wed, 13 Sept 2023 at 15:06, Marcin Juszkiewicz wrote: > > Armv8.1+ cpus have Virtual Host Extension (VHE) which added non-secure > EL2 virtual timer. > > This change adds it to fullfil Arm BSA (Base System Architecture) > requirements. > > Signed-off-by: Marcin Juszkiewicz > > --- >

<    1   2   3   4   >