Re: [PATCH v8 08/11] virtio-gpu: Handle resource blob commands

2024-04-26 Thread Akihiko Odaki
On 2024/04/24 19:30, Dmitry Osipenko wrote: On 4/19/24 12:18, Akihiko Odaki wrote: @@ -61,6 +61,10 @@ struct virtio_gpu_simple_resource {   int dmabuf_fd;   uint8_t *remapped;   +    MemoryRegion *mr; +    bool async_unmap_completed; +    bool async_unmap_in_progress; + Don't add

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-04-26 Thread Akihiko Odaki
On 2024/04/24 18:43, Dmitry Osipenko wrote: On 4/19/24 11:53, Akihiko Odaki wrote: On 2024/04/19 4:00, Dmitry Osipenko wrote: Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd processor that it should stop processing commands and retry again next time until flag is unset.

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-26 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, April 26, 2024 1:16 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: add PC alignment check and exception > > The

Re: [PATCH v2 1/1] target/riscv/kvm: fix timebase-frequency when using KVM acceleration

2024-04-26 Thread Michael Tokarev
14.03.2024 09:15, Yong-Xuan Wang: The timebase-frequency of guest OS should be the same with host machine. The timebase-frequency value in DTS should be got from hypervisor when using KVM acceleration. This change ended up in stable-8.2 (v8.2.3). Interestingly, this thing compiled not even

Re: [PATCH 6/6] target/i386/confidential-guest: Fix comment of x86_confidential_guest_kvm_type()

2024-04-26 Thread Xiaoyao Li
On 4/26/2024 6:07 PM, Zhao Liu wrote: Update the comment to match the X86ConfidentialGuestClass implementation. Suggested-by: Xiaoyao Li I think it should be "Reported-by" Signed-off-by: Zhao Liu --- target/i386/confidential-guest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2] ui/gtk: Draw guest frame at refresh cycle

2024-04-26 Thread dongwon . kim
From: Dongwon Kim Draw routine needs to be manually invoked in the next refresh if there is a scanout blob from the guest. This is to prevent a situation where there is a scheduled draw event but it won't happen bacause the window is currently in inactive state (minimized or tabified). If draw

Re: [PULL 0/2] NBD patches for 2024-04-25

2024-04-26 Thread Richard Henderson
On 4/25/24 14:43, Eric Blake wrote: The following changes since commit 5da72194df36535d773c8bdc951529ecd5e31707: Merge tag 'pull-tcg-20240424' ofhttps://gitlab.com/rth7680/qemu into staging (2024-04-24 15:51:49 -0700) are available in the Git repository at:

Re: [PATCH 1/6] target/i386/kvm: Add feature bit definitions for KVM CPUID

2024-04-26 Thread Chen, Zide
On 4/26/2024 3:07 AM, Zhao Liu wrote: > Add feature definiations for KVM_CPUID_FEATURES in CPUID ( > CPUID[4000_0001].EAX and CPUID[4000_0001].EDX), to get rid of lots of > offset calculations. > > Signed-off-by: Zhao Liu > --- > v2: Changed the prefix from CPUID_FEAT_KVM_* to CPUID_KVM_*.

Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply

2024-04-26 Thread Collin Walling
On 4/26/24 13:35, Collin Walling wrote: > On 4/26/24 04:42, Markus Armbruster wrote: >> Collin Walling writes: >> >>> Retain a list of deprecated features disjoint from any particular >>> CPU model. A query-cpu-model-expansion reply will now provide a list of >>> properties (i.e. features) that

[PULL 23/38] exec/cpu-all: Reduce 'qemu/rcu.h' header inclusion

2024-04-26 Thread Philippe Mathieu-Daudé
"exec/cpu-all.h" doesn't need definitions from "qemu/rcu.h", however "exec/ram_addr.h" does. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20231211212003.21686-17-phi...@linaro.org> --- include/exec/cpu-all.h | 1 - include/exec/ram_addr.h | 1 + 2 files

[PULL 37/38] hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h'

2024-04-26 Thread Philippe Mathieu-Daudé
Only include what is required, avoiding the full CPUState API from the huge "hw/core/cpu.h" header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240418192525.97451-4-phi...@linaro.org> --- include/hw/core/tcg-cpu-ops.h | 6 +- 1 file changed, 5

[PULL 25/38] exec/cpu-all: Remove unused tswapls() definitions

2024-04-26 Thread Philippe Mathieu-Daudé
Last use of tswapls() was removed 2 years ago in commit aee14c77f4 ("linux-user: Rewrite do_getdents, do_getdents64"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20231212123401.37493-15-phi...@linaro.org> Reviewed-by: Richard Henderson ---

[PULL 22/38] accel/hvf: Use accel-specific per-vcpu @dirty field

2024-04-26 Thread Philippe Mathieu-Daudé
HVF has a specific use of the CPUState::vcpu_dirty field (CPUState::vcpu_dirty is not used by common code). To make this field accel-specific, add and use a new @dirty variable in the AccelCPUState structure. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 03/38] exec: Include 'cpu.h' before validating CPUArchState placement

2024-04-26 Thread Philippe Mathieu-Daudé
CPUArchState 'env' field is defined within the ArchCPU structure, so we need to include each target "cpu.h" header which defines it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <20231211212003.21686-2-phi...@linaro.org> --- include/exec/cpu-all.h | 1 + 1 file

[PULL 26/38] exec: Declare target_words_bigendian() in 'exec/tswap.h'

2024-04-26 Thread Philippe Mathieu-Daudé
We usually check target endianess before swapping values, so target_words_bigendian() declaration makes sense in "exec/tswap.h" with the target swapping helpers. Remove "hw/core/cpu.h" when it was only included to get the target_words_bigendian() declaration. Signed-off-by: Philippe

[PULL 38/38] plugins: Include missing 'qemu/bitmap.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
Since commit c006147122 ("plugins: create CPUPluginState and migrate plugin_mask") "qemu/plugin.h" uses DECLARE_BITMAP(), which is declared in "qemu/bitmap.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier Message-Id:

[PULL 21/38] accel/nvmm: Use accel-specific per-vcpu @dirty field

2024-04-26 Thread Philippe Mathieu-Daudé
NVMM has a specific use of the CPUState::vcpu_dirty field (CPUState::vcpu_dirty is not used by common code). To make this field accel-specific, add and use a new @dirty variable in the AccelCPUState structure. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 24/38] exec/cpu-all: Remove unused 'qemu/thread.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
Nothing is required from "qemu/thread.h" in "exec/cpu-all.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20231212123401.37493-13-phi...@linaro.org> Reviewed-by: Richard Henderson --- include/exec/cpu-all.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PULL 28/38] exec/user: Do not include 'cpu.h' in 'abitypes.h'

2024-04-26 Thread Philippe Mathieu-Daudé
"exec/user/abitypes.h" requires: - "exec/cpu-defs.h" (TARGET_LONG_BITS) - "exec/tswap.h" (tswap32) In order to avoid "cpu.h", pick the minimum required headers. Assert this user-specific header is only included from user emulation. Signed-off-by: Philippe Mathieu-Daudé

[PULL 10/38] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
Nothing in guestfd.c requires "semihosting/uaccess.h" nor "qemu.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20231212123401.37493-8-phi...@linaro.org> Reviewed-by: Richard Henderson --- semihosting/guestfd.c | 5 + 1 file changed, 1 insertion(+), 4

[PULL 32/38] exec: Restrict TCG specific declarations of 'cputlb.h'

2024-04-26 Thread Philippe Mathieu-Daudé
Avoid TCG specific declarations being used from non-TCG accelerators. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240418192525.97451-5-phi...@linaro.org> --- include/exec/cputlb.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PULL 29/38] exec: Declare abi_ptr type in its own 'abi_ptr.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
The abi_ptr type is declared in "exec/cpu_ldst.h" with all the load/store helpers. Some source files requiring abi_ptr type don't need the load/store helpers. In order to simplify, create a new "exec/abi_ptr.h" header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[PULL 33/38] exec: Restrict 'cpu_ldst.h' to TCG accelerator

2024-04-26 Thread Philippe Mathieu-Daudé
"exec/cpu_ldst.h" is specific to TCG, do not allow its inclusion from other accelerators. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240418192525.97451-6-phi...@linaro.org> --- include/exec/cpu_ldst.h | 6 +- 1 file changed, 5 insertions(+), 1

[PULL 36/38] exec: Move CPUTLBEntry helpers to cputlb.c

2024-04-26 Thread Philippe Mathieu-Daudé
The following CPUTLBEntry helpers are only used in accel/tcg/cputlb.c: - tlb_index() - tlb_entry() - tlb_read_idx() - tlb_addr_write() Move them to this file, allowing to remove the huge "cpu.h" header inclusion from "exec/cpu_ldst.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PULL 34/38] exec: Rename 'exec/user/guest-base.h' as 'user/guest-base.h'

2024-04-26 Thread Philippe Mathieu-Daudé
The include/user/ directory contains the user-emulation specific headers. Move guest-base.h there too. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20240418192525.97451-15-phi...@linaro.org> --- include/exec/cpu-all.h | 2 +- include/{exec =>

[PULL 27/38] exec: Move [b]tswapl() declarations to 'exec/user/tswap-target.h'

2024-04-26 Thread Philippe Mathieu-Daudé
tswapl() and bswaptls() are target-dependent and only used by user emulation. Move their definitions to a new header: "exec/user/tswap-target.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20231212123401.37493-17-phi...@linaro.org> Reviewed-by: Richard

[PULL 19/38] accel/tcg: Rename helper-head.h -> helper-head.h.inc

2024-04-26 Thread Philippe Mathieu-Daudé
Since commit 139c1837db ("meson: rename included C source files to .c.inc"), QEMU standard procedure for included C files is to use *.c.inc. Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documented in the Coding Style: If you do use template header

[PULL 17/38] accel/tcg: Include missing headers in 'tb-jmp-cache.h'

2024-04-26 Thread Philippe Mathieu-Daudé
Due to missing headers, when including "tb-jmp-cache.h" we might get: accel/tcg/tb-jmp-cache.h:21:21: error: field ‘rcu’ has incomplete type 21 | struct rcu_head rcu; | ^~~ accel/tcg/tb-jmp-cache.h:24:9: error: unknown type name ‘vaddr’ 24 |

[PULL 35/38] exec: Restrict inclusion of 'user/guest-base.h'

2024-04-26 Thread Philippe Mathieu-Daudé
Declare 'have_guest_base' in "user/guest-base.h". Very few files require this header, so explicitly include it there instead of "exec/cpu-all.h" which is used in many source files. Assert this user-specific header is only included from user emulation. Signed-off-by: Philippe Mathieu-Daudé

[PULL 12/38] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation

2024-04-26 Thread Philippe Mathieu-Daudé
'abi_ptr' is a user specific type. The system emulation equivalent is 'target_ulong'. Use it in ppc_ldl_code() to emphasis this is not an user emulation function. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Nicholas Piggin Reviewed-by: Thomas Huth Message-Id:

[PULL 16/38] accel/tcg: Include missing 'hw/core/cpu.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
tcg_cpu_init_cflags() accesses CPUState fields, so requires "hw/core/cpu.h" to get its structure definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <20231212123401.37493-12-phi...@linaro.org> Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops.c

[PULL 15/38] accel/tcg: Un-inline retaddr helpers to 'user-retaddr.h'

2024-04-26 Thread Philippe Mathieu-Daudé
set_helper_retaddr() is only used in accel/tcg/user-exec.c. clear_helper_retaddr() is only used in accel/tcg/cpu-exec.c and accel/tcg/user-exec.c. No need to expose their definitions to all user-emulation files including "exec/cpu_ldst.h", move them to a new "user-retaddr.h" header (restricted

[PULL 30/38] exec: Declare MMUAccessType type in 'mmu-access-type.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
The MMUAccessType enum is declared in "hw/core/cpu.h". "hw/core/cpu.h" contains declarations related to CPUState and CPUClass. Some source files only require MMUAccessType and don't need to pull in all CPU* declarations. In order to simplify, create a new "exec/mmu-access-type.h" header.

[PULL 31/38] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
The CPUBreakpoint and CPUWatchpoint structures are declared in "hw/core/cpu.h", which contains declarations related to CPUState and CPUClass. Some source files only require the BP/WP definitions and don't need to pull in all CPU* API. In order to simplify, create a new "exec/breakpoint.h" header.

[PULL 09/38] semihosting/uaccess: Avoid including 'cpu.h'

2024-04-26 Thread Philippe Mathieu-Daudé
"semihosting/uaccess.h" only requires the following headers: - "exec/cpu-defs.h" for target_ulong, - "exec/cpu-common.h" for cpu_memory_rw_debug() - "exec/tswap.h" for tswap32() and tswap64(). Include them instead of the huge "cpu.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PULL 20/38] accel/whpx: Use accel-specific per-vcpu @dirty field

2024-04-26 Thread Philippe Mathieu-Daudé
WHPX has a specific use of the CPUState::vcpu_dirty field (CPUState::vcpu_dirty is not used by common code). To make this field accel-specific, add and use a new @dirty variable in the AccelCPUState structure. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 18/38] accel/tcg: Rename load-extract/store-insert headers using .h.inc suffix

2024-04-26 Thread Philippe Mathieu-Daudé
Since commit 139c1837db ("meson: rename included C source files to .c.inc"), QEMU standard procedure for included C files is to use *.c.inc. Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documented in the Coding Style: If you do use template header

[PULL 07/38] gdbstub: Simplify #ifdef'ry in helpers.h

2024-04-26 Thread Philippe Mathieu-Daudé
Slightly simplify by checking NEED_CPU_H definition in header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240322161439.6448-2-phi...@linaro.org> --- include/gdbstub/helpers.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PULL 06/38] gdbstub: Include missing 'hw/core/cpu.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
Functions such gdb_get_cpu_pid() dereference CPUState so require the structure declaration from "hw/core/cpu.h": static uint32_t gdb_get_cpu_pid(CPUState *cpu) { ... return cpu->cluster_index + 1; } Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id:

[PULL 00/38] Exec / accelerators patches

2024-04-26 Thread Philippe Mathieu-Daudé
The following changes since commit a118c4aff4087eafb68f7132b233ad548cf16376: Merge tag 'hw-misc-20240425' of https://github.com/philmd/qemu into staging (2024-04-25 09:43:29 -0700) are available in the Git repository at: https://github.com/philmd/qemu.git tags/accel-20240426 for you

[PULL 14/38] target/i386: Include missing 'exec/exec-all.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
The XRSTOR instruction ends calling tlb_flush(), declared in "exec/exec-all.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20231211212003.21686-13-phi...@linaro.org> --- target/i386/tcg/fpu_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PULL 04/38] exec: Expose 'target_page.h' API to user emulation

2024-04-26 Thread Philippe Mathieu-Daudé
User-only objects might benefit from the "exec/target_page.h" API, which allows to build some objects once for all targets. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20231211212003.21686-3-phi...@linaro.org> --- meson.build

[PULL 13/38] target/sparc: Replace abi_ulong by uint32_t for TARGET_ABI32

2024-04-26 Thread Philippe Mathieu-Daudé
We have abi_ulong == uint32_t for the 32-bit ABI. Use the generic type to avoid to depend on the "exec/user/abitypes.h" header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240418192525.97451-14-phi...@linaro.org> --- target/sparc/gdbstub.c | 2 +- 1 file

[PULL 11/38] target: Define TCG_GUEST_DEFAULT_MO in 'cpu-param.h'

2024-04-26 Thread Philippe Mathieu-Daudé
accel/tcg/ files requires the following definitions: - TARGET_LONG_BITS - TARGET_PAGE_BITS - TARGET_PHYS_ADDR_SPACE_BITS - TCG_GUEST_DEFAULT_MO The first 3 are defined in "cpu-param.h". The last one in "cpu.h", with a bunch of definitions irrelevant for TCG. By moving the

[PULL 08/38] gdbstub: Avoid including 'cpu.h' in 'gdbstub/helpers.h'

2024-04-26 Thread Philippe Mathieu-Daudé
We only need the "exec/tswap.h" and "cpu-param.h" headers. Only include "cpu.h" in the target gdbstub.c source files. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240418192525.97451-20-phi...@linaro.org> --- include/gdbstub/helpers.h | 3 ++-

[PULL 01/38] exec: Rename NEED_CPU_H -> COMPILING_PER_TARGET

2024-04-26 Thread Philippe Mathieu-Daudé
'NEED_CPU_H' guard target-specific code; it is defined by meson altogether with the 'CONFIG_TARGET' definition. Rename NEED_CPU_H as COMPILING_PER_TARGET to clarify its meaning. Mechanical change running: $ sed -i s/NEED_CPU_H/COMPILING_PER_TARGET/g $(git grep -l NEED_CPU_H) then manually add

[PULL 02/38] exec: Reduce tlb_set_dirty() declaration scope

2024-04-26 Thread Philippe Mathieu-Daudé
tlb_set_dirty() is only used in accel/tcg/cputlb.c, where it is defined. Declare it statically, removing the stub. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Reviewed-by: Richard Henderson Message-Id: <20240418192525.97451-11-phi...@linaro.org> ---

[PULL 05/38] accel: Include missing 'exec/cpu_ldst.h' header

2024-04-26 Thread Philippe Mathieu-Daudé
Theses files call cpu_ldl_code() which is declared in "exec/cpu_ldst.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20231211212003.21686-5-phi...@linaro.org> --- accel/tcg/translator.c| 1 + target/hexagon/translate.c| 1 +

Re: [PATCH 18/24] plugins: Include missing 'qemu/bitmap.h' header

2024-04-26 Thread Pierrick Bouvier
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote: "qemu/plugin.h" uses DECLARE_BITMAP(), which is declared in "qemu/bitmap.h". Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/plugin.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h

Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply

2024-04-26 Thread Collin Walling
On 4/26/24 13:45, David Hildenbrand wrote: > On 26.04.24 19:44, David Hildenbrand wrote: >> On 24.04.24 23:56, Collin Walling wrote: >>> Retain a list of deprecated features disjoint from any particular >>> CPU model. A query-cpu-model-expansion reply will now provide a list of >>> properties

[PATCH] Hexagon: add PC alignment check and exception

2024-04-26 Thread Matheus Tavares Bernardino
The Hexagon Programmer's Reference Manual says that the exception 0x1e should be raised upon an unaligned program counter. Let's implement that and also add tests for both the most common case as well as packets with multiple change-of-flow instructions. Signed-off-by: Matheus Tavares Bernardino

Re: [PATCH v2 03/10] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine

2024-04-26 Thread Cédric Le Goater
On 4/26/24 19:34, Aditya Gupta wrote: Hello Cédric, <...snip...> - * Multi processor support for POWER8, POWER8NVL and POWER9. + * Multi processor support for POWER8, POWER8NVL, POWER9, POWER10 and Power11. POWER10 -> Power10. Don't ask me why. Sure, got it ! * XSCOM, serial

Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply

2024-04-26 Thread David Hildenbrand
On 26.04.24 19:44, David Hildenbrand wrote: On 24.04.24 23:56, Collin Walling wrote: Retain a list of deprecated features disjoint from any particular CPU model. A query-cpu-model-expansion reply will now provide a list of properties (i.e. features) that are flagged as deprecated. Example:

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
> > Quoting lines from docs/system/ppc/powernv.rst: > > > > > Missing devices > > > --- > > > > > > A lot is missing, among which : > > > > > > * I2C controllers (yet to be merged). > > > * NPU/NPU2/NPU3 controllers. > > > * EEH support for PCIe Host bridge controllers. > > >

Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply

2024-04-26 Thread David Hildenbrand
On 24.04.24 23:56, Collin Walling wrote: Retain a list of deprecated features disjoint from any particular CPU model. A query-cpu-model-expansion reply will now provide a list of properties (i.e. features) that are flagged as deprecated. Example: { "return": { "model": {

Re: [PATCH v2 10/10] ppc/pnv: Update skiboot.lid to support Power11

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:38:13PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Skiboot/OPAL patches are in discussion upstream [1], with corresponding > > commits in github repository [2]. > > > > Update skiboot.lid, with binary built from 'upstream_power11' branch

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Cédric Le Goater
On 4/26/24 19:05, Aditya Gupta wrote: Hello Cédric, Thanks for your reviews. On Fri, Apr 26, 2024 at 04:27:04PM +0200, Cédric Le Goater wrote: Hello Aditya On 4/26/24 13:00, Aditya Gupta wrote: Add base support for "--cpu power11" in QEMU. Power11 core is same as Power10, hence reuse

Re: [PATCH v2 09/10] ppc: Make Power11 as default cpu type for 'pseries' and 'powernv'

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:32:18PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Make Power11 as default cpu type for 'pseries' and 'powernv' machine type, > > with Power11 being the newest supported Power processor in QEMU. > > This is too early. We should merge

Re: [PATCH v2 08/10] ppc/pnv: Add SBE model for Power11

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:33:33PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Power11 core is same as Power10, reuse PNV10_SBER initialisation, by > > declaring PNV11_PSI as child class of PNV10_PSI > > > > Cc: Cédric Le Goater > > Cc: Frédéric Barrat > > Cc:

Re: [PATCH v2 07/10] ppc/pnv: Add a PSI bridge model for Power11

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:33:23PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Power11 core is same as Power10, reuse PNV10_PSI initialisation, by > > declaring 'PNV11_PSI' as child class of 'PNV10_PSI' > > > > Cc: Cédric Le Goater > > Cc: Frédéric Barrat > > Cc:

Re: [PATCH v2 06/10] ppc/pnv: Add OCC for Power11

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:33:13PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Power11 core is same as Power10, reuse PNV10_OCC initialisation, > > by declaring `PNV11_OCC` as child class of `PNV10_OCC` > > Reviewed-by: Cédric Le Goater Thanks Cédric ! - Aditya

Re: [PATCH v2 05/10] ppc/pnv: Add a LPC controller for POWER11

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:32:52PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Power11 core is same as Power10 core, declare PNV11_LPC as a child > > class of PNV10_LPC, so it goes through same class init > > > > Cc: Cédric Le Goater > > Cc: Frédéric Barrat > >

Re: [PATCH v2 04/10] ppc/pnv: Add HOMER for POWER11

2024-04-26 Thread Aditya Gupta
On Fri, Apr 26, 2024 at 04:32:37PM +0200, Cédric Le Goater wrote: > On 4/26/24 13:00, Aditya Gupta wrote: > > Power11 core is same as Power10, declare PNV11_HOMER as a child > > class of PNV10_HOMER, so it goes through same class init > > > > Cc: Cédric Le Goater > > Cc: Frédéric Barrat > > Cc:

Re: [PATCH RFC 00/26] Multifd  device state transfer support with VFIO consumer

2024-04-26 Thread Maciej S. Szmigiero
On 24.04.2024 00:27, Peter Xu wrote: On Tue, Apr 23, 2024 at 06:14:18PM +0200, Maciej S. Szmigiero wrote: We don't lose any genericity since by default the transfer is done via mixed RAM / device state multifd channels from a shared pool. It's only when x-multifd-channels-device-state is set

Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply

2024-04-26 Thread Collin Walling
On 4/26/24 04:42, Markus Armbruster wrote: > Collin Walling writes: > >> Retain a list of deprecated features disjoint from any particular >> CPU model. A query-cpu-model-expansion reply will now provide a list of >> properties (i.e. features) that are flagged as deprecated. Example: >> >> {

Re: [PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

2024-04-26 Thread Philippe Mathieu-Daudé
On 26/4/24 18:23, Thomas Huth wrote: According to the comment in qga/meson.build, the test got disabled since there were problems with the fuzzing job. But instead of disabling this test completely, we should still be fine running it when fuzzing is disabled. Signed-off-by: Thomas Huth ---

Re: [PATCH v2 03/10] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine

2024-04-26 Thread Aditya Gupta
Hello Cédric, > > > > <...snip...> > > > > - * Multi processor support for POWER8, POWER8NVL and POWER9. > > + * Multi processor support for POWER8, POWER8NVL, POWER9, POWER10 and > > Power11. > > POWER10 -> Power10. Don't ask me why. Sure, got it ! > > >* XSCOM, serial communication

Re: [PATCH RFC 00/26] Multifd  device state transfer support with VFIO consumer

2024-04-26 Thread Maciej S. Szmigiero
On 24.04.2024 00:35, Peter Xu wrote: On Wed, Apr 24, 2024 at 12:25:08AM +0200, Maciej S. Szmigiero wrote: On 24.04.2024 00:20, Peter Xu wrote: On Tue, Apr 23, 2024 at 06:15:35PM +0200, Maciej S. Szmigiero wrote: On 19.04.2024 17:31, Peter Xu wrote: On Fri, Apr 19, 2024 at 11:07:21AM +0100,

Re: [PATCH v7 09/12] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-26 Thread fan
On Fri, Apr 26, 2024 at 11:12:50AM +0200, Markus Armbruster wrote: > nifan@gmail.com writes: > > > From: Fan Ni > > > > To simulate FM functionalities for initiating Dynamic Capacity Add > > (Opcode 5604h) and Dynamic Capacity Release (Opcode 5605h) as in CXL spec > > r3.1 7.6.7.6.5 and

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Cédric Le Goater
On 4/26/24 19:12, Aditya Gupta wrote: Hello Cédric, diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst index a876d897b6e4..3277564b34c2 100644 --- a/docs/system/ppc/pseries.rst +++ b/docs/system/ppc/pseries.rst @@ -15,9 +15,9 @@ Supported devices = *

Re: [PATCH v2 02/10] ppc/pnv: Introduce 'PnvChipClass::chip_type'

2024-04-26 Thread Aditya Gupta
Hello Cédric, > > > > <...snip...> > > > > diff --git a/include/hw/ppc/pnv_chip.h b/include/hw/ppc/pnv_chip.h > > index 8589f3291ed3..ebfe82b89537 100644 > > --- a/include/hw/ppc/pnv_chip.h > > +++ b/include/hw/ppc/pnv_chip.h > > @@ -17,12 +17,21 @@ > > OBJECT_DECLARE_TYPE(PnvChip,

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
Hello Cédric, > > diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst > > index a876d897b6e4..3277564b34c2 100644 > > --- a/docs/system/ppc/pseries.rst > > +++ b/docs/system/ppc/pseries.rst > > @@ -15,9 +15,9 @@ Supported devices > > = > >* Multi processor

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
Hello Cédric, Thanks for your reviews. On Fri, Apr 26, 2024 at 04:27:04PM +0200, Cédric Le Goater wrote: > Hello Aditya > > On 4/26/24 13:00, Aditya Gupta wrote: > > Add base support for "--cpu power11" in QEMU. > > > > Power11 core is same as Power10, hence reuse functions defined for > >

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-26 Thread Gregory Price
On Fri, Apr 26, 2024 at 04:55:55PM +0100, Jonathan Cameron wrote: > On Wed, 24 Apr 2024 10:33:33 -0700 > Ira Weiny wrote: > > > Markus Armbruster wrote: > > > nifan@gmail.com writes: > > > > > > > From: Fan Ni > > > > > > > > Since fabric manager emulation is not supported yet, the

[PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

2024-04-26 Thread Thomas Huth
According to the comment in qga/meson.build, the test got disabled since there were problems with the fuzzing job. But instead of disabling this test completely, we should still be fine running it when fuzzing is disabled. Signed-off-by: Thomas Huth --- qga/meson.build | 5 ++--- 1 file

Re: [PATCH v2 1/4] vfio/ap: Use g_autofree variable in vfio_ap_register_irq_notifier()

2024-04-26 Thread Anthony Krowiak
On 4/25/24 5:02 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/vfio/ap.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) LGTM Reviewed-by: Anthony Krowiak diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
On 26/04/2024 15.46, Eldon Stegall wrote: On Fri, Apr 26, 2024 at 02:47:20PM +0200, Thomas Huth wrote: With regards to NetBSD and OpenBSD, this is not a step backward since these gitlab jobs were never run anyway (they could only be triggered manually, but hardly anybody did that AFAIK). If we

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine

2024-04-26 Thread Richard Henderson
On 4/26/24 00:35, Xiong Yining wrote: From: xiongyining1480 Enable CPU cluster support on SbsaQemu platform, so that users can specify a 4-level CPU hierarchy sockets/clusters/cores/threads. And this topology can be passed to the firmware through DT cpu-map. Signed-off-by: Xiong Yining

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-26 Thread BALATON Zoltan
On Fri, 26 Apr 2024, Philippe Mathieu-Daudé wrote: On 26/4/24 14:37, Akihiko Odaki wrote: On 2024/04/24 21:32, Thomas Huth wrote: On 24/04/2024 12.41, Prasad Pandit wrote: On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote:

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-26 Thread Jonathan Cameron via
On Thu, 25 Apr 2024 10:30:51 -0700 Ira Weiny wrote: > Markus Armbruster wrote: > > fan writes: > > > > > On Wed, Apr 24, 2024 at 03:09:52PM +0200, Markus Armbruster wrote: > > >> nifan@gmail.com writes: > > >> > > >> > From: Fan Ni > > >> > > > >> > Since fabric manager emulation

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-26 Thread Jonathan Cameron via
On Wed, 24 Apr 2024 10:33:33 -0700 Ira Weiny wrote: > Markus Armbruster wrote: > > nifan@gmail.com writes: > > > > > From: Fan Ni > > > > > > Since fabric manager emulation is not supported yet, the change implements > > > the functions to add/release dynamic capacity extents as QMP

Re: [PATCH 3/3] gitlab: remove stale s390x-all-linux-static conf hacks

2024-04-26 Thread Thomas Huth
On 26/04/2024 17.39, Alex Bennée wrote: The libssh bug references 18.04 which we are no longer running. We don't need to disable glusterfs because a linux-user build shouldn't be trying to link to it anyway. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml |

Re: [PATCH 2/3] gitlab: migrate the s390x custom machine to 22.04

2024-04-26 Thread Thomas Huth
On 26/04/2024 17.39, Alex Bennée wrote: 20.04 is dead (from QEMU's point of view), long live 22.04! Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 2 +- ...20.04-s390x.yml => ubuntu-22.04-s390x.yml} | 28 +-- 2 files changed, 15

Re: [PATCH 1/3] build-environment: make some packages optional

2024-04-26 Thread Thomas Huth
On 26/04/2024 17.39, Alex Bennée wrote: Upgrading the s390x runner exposed some packages are not available for it. Add an additional optional stage we only enable for arm64/x86_64 for now. Signed-off-by: Alex Bennée --- scripts/ci/setup/build-environment.yml | 16 +--- 1 file

[PATCH 3/3] gitlab: remove stale s390x-all-linux-static conf hacks

2024-04-26 Thread Alex Bennée
The libssh bug references 18.04 which we are no longer running. We don't need to disable glusterfs because a linux-user build shouldn't be trying to link to it anyway. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 0/3] testing/next: s390x gitlab updates

2024-04-26 Thread Alex Bennée
I was asked to update the custom gitlab runner from the aging 20.04 to 22.04 which has been done. However I needed to update the provisioning scripts and clean-up some of the cruft. Sadly this doesn't seem to be passing cleanly as we have: - qtest-s390x/migration-test ERROR 98.94s

[PATCH 2/3] gitlab: migrate the s390x custom machine to 22.04

2024-04-26 Thread Alex Bennée
20.04 is dead (from QEMU's point of view), long live 22.04! Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 2 +- ...20.04-s390x.yml => ubuntu-22.04-s390x.yml} | 28 +-- 2 files changed, 15 insertions(+), 15 deletions(-) rename

[PATCH 1/3] build-environment: make some packages optional

2024-04-26 Thread Alex Bennée
Upgrading the s390x runner exposed some packages are not available for it. Add an additional optional stage we only enable for arm64/x86_64 for now. Signed-off-by: Alex Bennée --- scripts/ci/setup/build-environment.yml | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-)

Re: [PATCH] vfio/ap: Use g_autofree variable

2024-04-26 Thread Anthony Krowiak
On 4/24/24 8:54 AM, Cédric Le Goater wrote: Also change the return value of vfio_ap_register_irq_notifier() to be a bool since it takes and 'Error **' argument. See the qapi/error.h Rules section. LGTM Signed-off-by: Anthony Krowiak Signed-off-by: Cédric Le Goater --- hw/vfio/ap.c

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Eldon Stegall
On Fri, Apr 26, 2024 at 02:47:20PM +0200, Thomas Huth wrote: > With regards to NetBSD and OpenBSD, this is not a step backward since these > gitlab jobs were never run anyway (they could only be triggered manually, > but hardly anybody did that AFAIK). > > If we want to have proper support for

Re: [PATCH 0/3] accel: Add new @dirty field on HVF/NVMM/WHPX

2024-04-26 Thread Philippe Mathieu-Daudé
On 24/4/24 19:45, Philippe Mathieu-Daudé wrote: We want CPUState to only contain fields used by common code. Start using a specific @dirty field for HVF/NVMM/WHPX (TCG then KVM will follow). Philippe Mathieu-Daudé (3): accel/whpx: Use accel-specific per-vcpu @dirty field accel/nvmm: Use

Re: [PATCH v2 03/10] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Power11 core is same as Power10, use the existing functionalities to introduce a Power11 chip and machine, with Power10 chip as parent of Power11 chip, thus going through similar class_init paths Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J

Re: [PATCH v2 10/10] ppc/pnv: Update skiboot.lid to support Power11

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Skiboot/OPAL patches are in discussion upstream [1], with corresponding commits in github repository [2]. Update skiboot.lid, with binary built from 'upstream_power11' branch of skiboot repository with Power11 enablement patches [2]. --- This patch can be

Re: [PATCH v2 08/10] ppc/pnv: Add SBE model for Power11

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Power11 core is same as Power10, reuse PNV10_SBER initialisation, by declaring PNV11_PSI as child class of PNV10_PSI Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya

Re: [PATCH v2 05/10] ppc/pnv: Add a LPC controller for POWER11

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Power11 core is same as Power10 core, declare PNV11_LPC as a child class of PNV10_LPC, so it goes through same class init Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya

Re: [PATCH v2 07/10] ppc/pnv: Add a PSI bridge model for Power11

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Power11 core is same as Power10, reuse PNV10_PSI initialisation, by declaring 'PNV11_PSI' as child class of 'PNV10_PSI' Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya

Re: [PATCH v2 04/10] ppc/pnv: Add HOMER for POWER11

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Power11 core is same as Power10, declare PNV11_HOMER as a child class of PNV10_HOMER, so it goes through same class init Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya

Re: [PATCH 4/9] migration: Add direct-io parameter

2024-04-26 Thread Markus Armbruster
Fabiano Rosas writes: > Add the direct-io migration parameter that tells the migration code to > use O_DIRECT when opening the migration stream file whenever possible. > > This is currently only used with the mapped-ram migration that has a > clear window guaranteed to perform aligned writes. >

Re: [PATCH v2 06/10] ppc/pnv: Add OCC for Power11

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Power11 core is same as Power10, reuse PNV10_OCC initialisation, by declaring `PNV11_OCC` as child class of `PNV10_OCC` Reviewed-by: Cédric Le Goater Thanks, C. Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan

Re: [PATCH v2 09/10] ppc: Make Power11 as default cpu type for 'pseries' and 'powernv'

2024-04-26 Thread Cédric Le Goater
On 4/26/24 13:00, Aditya Gupta wrote: Make Power11 as default cpu type for 'pseries' and 'powernv' machine type, with Power11 being the newest supported Power processor in QEMU. This is too early. We should merge Power11 support first, possibly in 9.1, and then change default in a future

  1   2   3   >