Re: How unsubscribe

2024-05-07 Thread Thomas Huth
On 08/05/2024 00.20, Jean-Christophe wrote: Hello, How unsubscribe ? Go to https://lists.nongnu.org/mailman/listinfo/qemu-devel and look at the bottom. HTH, Thomas

[PATCH] scripts/simpletrace: Mark output with unstable timestamp as WARN

2024-05-07 Thread Zhao Liu
In some trace log, there're unstable timestamp breaking temporal ordering of trace records. For example: kvm_run_exit -0.015 pid=3289596 cpu_index=0x0 reason=0x6 kvm_vm_ioctl -0.020 pid=3289596 type=0xc008ae67 arg=0x7ffeefb5aa60 kvm_vm_ioctl -0.021 pid=3289596 type=0xc008ae67

Re: [PATCH] hw/virtio: Fix obtain the buffer id from the last descriptor

2024-05-07 Thread Jason Wang
On Mon, Apr 22, 2024 at 9:41 AM Wafer wrote: > > The virtio-1.3 specification > writes: > 2.8.6 Next Flag: Descriptor Chaining > Buffer ID is included in the last descriptor in the list. > > If the feature (_F_INDIRECT_DESC)

Re: Intention to work on GSoC project

2024-05-07 Thread Sahil
Hi, On Tuesday, May 7, 2024 12:44:33 PM IST Eugenio Perez Martin wrote: > [...] > > Shall I start by implementing a mechanism to check if the feature bit > > "VIRTIO_F_RING_PACKED" is set (using "virtio_vdev_has_feature")? And > > if it's supported, "vhost_svq_add" should call

[PATCH v4 0/5] Add migration test for loongarch64

2024-05-07 Thread Bibo Mao
Migration test case is added for loongarch64 here. Since compat machine type is required for migration test case, also compat machine qemu 9.0 is added for loongarch virt machine. Migration test case passes to run in both tcg and kvm mode with the patch, 54 migration subtests passes in 188

[PATCH v4 4/5] hw/loongarch: Set minimium memory size as 256M

2024-05-07 Thread Bibo Mao
The minimum memory size for LoongArch UEFI bios is 256M, also some test cases such as migration and qos use 256M memory by default. Here set minimum memory size for Loongarch VirtMachine with 256M rather than 1G, so that test cases with 256M memory can pass to run. Signed-off-by: Bibo Mao ---

[PATCH v4 1/5] hw/loongarch: Rename LOONGARCH_MACHINE with LOONGARCH_VIRT_MACHINE

2024-05-07 Thread Bibo Mao
On LoongArch system, there is only virt machine type now, name LOONGARCH_MACHINE is confused, rename it with LOONGARCH_VIRT_MACHINE. Machine name about Other real hw boards can be added in future. Signed-off-by: Bibo Mao --- hw/loongarch/acpi-build.c | 8 hw/loongarch/boot.c

[PATCH v4 2/5] hw/loongarch: Rename LoongArchMachineState with LoongArchVirtMachineState

2024-05-07 Thread Bibo Mao
Rename LoongArchMachineState with LoongArchVirtMachineState, and change variable name LoongArchMachineState *lams with LoongArchVirtMachineState *lvms. Rename function specific for virtmachine loongarch_xxx() with virt_xxx(). However some common functions keep unchanged such as

[PATCH v4 5/5] tests: Add migration test for loongarch64

2024-05-07 Thread Bibo Mao
This patch adds migration test support for loongarch64. The test code comes from aarch64 mostly, only that it booted as bios in qemu since kernel requires elf format and bios uses binary format. In addition to providing the binary, this patch also includes the source code and the build script in

[PATCH v4 3/5] hw/loongarch: Add compat machine for 9.0

2024-05-07 Thread Bibo Mao
Since migration test case requires compat machine type support, compat machine is added for qemu 9.0 here. Signed-off-by: Bibo Mao --- hw/loongarch/virt.c | 61 +++-- 1 file changed, 48 insertions(+), 13 deletions(-) diff --git a/hw/loongarch/virt.c

Re: [PATCH v2 10/15] hw/riscv/riscv-iommu: add ATS support

2024-05-07 Thread Frank Chang
Hi Daniel, Daniel Henrique Barboza 於 2024年3月8日 週五 上午12:06寫道: > > From: Tomasz Jeznach > > Add PCIe Address Translation Services (ATS) capabilities to the IOMMU. > This will add support for ATS translation requests in Fault/Event > queues, Page-request queue and IOATC invalidations. > >

Re: [PATCH] hw/loongarch/virt: Fix memory leak

2024-05-07 Thread gaosong
在 2024/5/7 下午5:52, Michael Tokarev 写道: 07.05.2024 05:22, Song Gao wrote:   for (i = 1; i < nb_numa_nodes; i++) {   MemoryRegion *nodemem = g_new(MemoryRegion, 1); -    ramName = g_strdup_printf("loongarch.node%d.ram", i); +    g_autofree char *ramName =

[PATCH v2] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-07 Thread Song Gao
vmstate does not save kvm_state_conter, which can cause VM recovery from disk to fail. Signed-off-by: Song Gao --- v2: - Update the version. - Link to v1: https://patchew.org/QEMU/20240430012356.2620763-1-gaos...@loongson.cn/ target/loongarch/machine.c | 6 -- 1 file changed, 4

[PATCH v2] hw/loongarch/virt: Fix memory leak

2024-05-07 Thread Song Gao
The char pointer 'ramName' point to a block of memory, but never free it. Use a small fixed-size buffer for 'ramName'. Resolves: Coverity CID 1544773 Fixes: 0cf1478d6 ("hw/loongarch: Add numa support") Signed-off-by: Song Gao --- v2: - Use a small fixed-size buffer for 'ramName'. - Link to

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

2024-05-07 Thread Jason Wang
On Tue, May 7, 2024 at 6:57 PM Eugenio Perez Martin wrote: > > On Tue, May 7, 2024 at 9:29 AM Jason Wang wrote: > > > > On Fri, Apr 12, 2024 at 3:56 PM Eugenio Perez Martin > > wrote: > > > > > > On Fri, Apr 12, 2024 at 8:47 AM Jason Wang wrote: > > > > > > > > On Wed, Apr 10, 2024 at 6:03 PM

[PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-07 Thread Yao Xingtao via
Since the kernel does not check the interleave capability, a 3-way, 6-way, 12-way or 16-way region can be create normally. Applications can access the memory of 16-way region normally because qemu can convert hpa to dpa correctly for the power of 2 interleave ways, after kernel implementing the

RE: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-07 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Jonathan Cameron > Sent: Wednesday, May 8, 2024 12:31 AM > To: Yao, Xingtao/姚 幸涛 > Cc: fan...@samsung.com; qemu-devel@nongnu.org > Subject: Re: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways > > On Tue, 7 May 2024 00:22:00 + >

Re: [RFC 1/2] iova_tree: add an id member to DMAMap

2024-05-07 Thread Si-Wei Liu
On 5/1/2024 11:44 PM, Eugenio Perez Martin wrote: On Thu, May 2, 2024 at 1:16 AM Si-Wei Liu wrote: On 4/30/2024 10:19 AM, Eugenio Perez Martin wrote: On Tue, Apr 30, 2024 at 7:55 AM Si-Wei Liu wrote: On 4/29/2024 1:14 AM, Eugenio Perez Martin wrote: On Thu, Apr 25, 2024 at 7:44 PM

[PATCH v3 31/33] target/ppc/mmu-hash32.c: Drop a local variable

2024-05-07 Thread BALATON Zoltan
In ppc_hash32_xlate() the value of need_prop is checked in two places but precalculating it does not help because when we reach the first check we always return and not reach the second place so the value will only be used once. We can drop the local variable and calculate it when needed, which

[PATCH v3 29/33] target/ppc: Remove id_tlbs flag from CPU env

2024-05-07 Thread BALATON Zoltan
This flag for split instruction/data TLBs is only set for 6xx soft TLB MMU model and not used otherwise so no need to have a separate flag for that. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- hw/ppc/pegasos2.c| 2 +- target/ppc/cpu.h | 1 -

[PATCH v3 25/33] target/ppc/mmu_common.c: Remove BookE handling from get_physical_address_wtlb()

2024-05-07 Thread BALATON Zoltan
This function is no longer called for BookE MMU model so remove parts related to it. This has uncovered a few may be used uninitialised warnings that are also fixed. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 25 + 1 file changed, 5 insertions(+), 20

[PATCH v3 13/33] target/ppc/mmu_common.c: Split out BookE cases before checking real mode

2024-05-07 Thread BALATON Zoltan
BookE does not have real mode so split off and handle it first in get_physical_address_wtlb() before checking for real mode for other MMU models. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH v3 33/33] target/ppc: Add a macro to check for page protection bit

2024-05-07 Thread BALATON Zoltan
Checking if a page protection bit is set for a given access type is a common operation. Add a macro to avoid repeating the same check at multiple places and also avoid a function call. As this relies on access type and page protection bit values having certain relation also add an assert to ensure

[PATCH v3 17/33] target/ppc/mmu_common.c: Simplify mmubooke206_get_physical_address()

2024-05-07 Thread BALATON Zoltan
This function is similar to mmubooke_get_physical_address() and can be simplified the same way. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git

[PATCH v3 10/33] target/ppc/mmu_common.c: Move else branch to avoid large if block

2024-05-07 Thread BALATON Zoltan
In mmu6xx_get_physical_address() we have a large if block with a two line else branch that effectively returns. Invert the condition and move the else there to allow deindenting the large if block to make the flow easier to follow. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 71

[PATCH v3 30/33] target/ppc: Split off common embedded TLB init

2024-05-07 Thread BALATON Zoltan
Several 4xx CPUs and e200 share the same TLB settings enclosed in an ifdef. Split it off in a common function to reduce code duplication and the number of ifdefs. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/cpu_init.c | 46

[PATCH v3 27/33] target/ppc/mmu_common.c: Simplify ppc_booke_xlate() part 2

2024-05-07 Thread BALATON Zoltan
Merge the code fetch and data access cases in a common switch. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 50 + 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index

[PATCH v3 12/33] target/ppc/mmu_common.c: Eliminate ret from mmu6xx_get_physical_address()

2024-05-07 Thread BALATON Zoltan
Return directly, which is simpler than dragging a return value through multpile if and else blocks. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 84 +++-- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/target/ppc/mmu_common.c

[PATCH v3 21/33] target/ppc/mmu_common.c: Make get_physical_address_wtlb() static

2024-05-07 Thread BALATON Zoltan
This function is not used from any other files so make it static and fix the maybe used uninitialised warnings this has uncovered. Also remove mmu_ctx_t definition from internal.h as this type is only used within this file. Signed-off-by: BALATON Zoltan --- target/ppc/internal.h | 17

[PATCH v3 23/33] target/ppc/mmu_common.c: Remove BookE from direct store handling

2024-05-07 Thread BALATON Zoltan
As BookE never returns -4 we can drop BookE from the direct store case in ppc_jumbo_xlate(). Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index

[PATCH v3 16/33] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_address()

2024-05-07 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index 7283eafe27..9793e6d282 100644 ---

[PATCH v3 15/33] target/ppc/mmu_common.c: Inline and remove check_physical()

2024-05-07 Thread BALATON Zoltan
This function just does two assignments and and unnecessary check that is always true so inline it in the only caller left and remove it. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 26 +++--- 1 file changed, 3 insertions(+), 23

[PATCH v3 06/33] target/ppc/mmu_common.c: Remove unneeded local variable

2024-05-07 Thread BALATON Zoltan
In mmubooke_check_tlb() and mmubooke206_check_tlb() we can assign the value directly the the destination, no need to have a separate local variable for it. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 30 +- 1 file

[PATCH v3 19/33] target/ppc/mmu_common.c: Deindent ppc_jumbo_xlate()

2024-05-07 Thread BALATON Zoltan
Instead of putting a large block of code in an if, invert the condition and return early to be able to deindent the code block. Signed-off-by: BALATON Zoltan Acked-by: Nicholas Piggin --- target/ppc/mmu_common.c | 319 1 file changed, 159 insertions(+),

[PATCH v3 18/33] target/ppc/mmu_common.c: Fix misindented qemu_log_mask() calls

2024-05-07 Thread BALATON Zoltan
Fix several qemu_log_mask() calls that are misindented. Signed-off-by: BALATON Zoltan Acked-by: Nicholas Piggin --- target/ppc/mmu_common.c | 42 - 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/target/ppc/mmu_common.c

[PATCH v3 09/33] target/ppc/mmu_common.c: Introduce mmu6xx_get_physical_address()

2024-05-07 Thread BALATON Zoltan
Repurpose get_segment_6xx_tlb() to do the whole address translation for POWERPC_MMU_SOFT_6xx MMU model by moving the BAT check there and renaming it to match other similar functions. These are only called once together so no need to keep these separate functions and combining them simplifies the

[PATCH v3 28/33] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-07 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 226 1 file changed, 113 insertions(+), 113 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index 04e5ad661d..a6e7b64049 100644 --- a/target/ppc/mmu_common.c +++

[PATCH v3 14/33] target/ppc/mmu_common.c: Split off real mode cases in get_physical_address_wtlb()

2024-05-07 Thread BALATON Zoltan
The real mode handling is identical in the remaining switch cases. Split off these common real mode cases into a separate conditional to leave only the else branches in the switch that are different. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 34

[PATCH v3 22/33] target/ppc: Remove pp_check() and reuse ppc_hash32_pp_prot()

2024-05-07 Thread BALATON Zoltan
The ppc_hash32_pp_prot() function in mmu-hash32.c is the same as pp_check() in mmu_common.c, merge these to remove duplicated code. Define the common function in internal.h as static lnline otherwise exporting the function from mmu-hash32.c would stop the compiler inlining it which results in

[PATCH v3 32/33] target/ppc/mmu-radix64.c: Drop a local variable

2024-05-07 Thread BALATON Zoltan
The value is only used once so no need to introduce a local variable for it. Signed-off-by: BALATON Zoltan --- target/ppc/mmu-radix64.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c index 8daf71d2db..395ce3b782

[PATCH v3 20/33] target/ppc/mmu_common.c: Replace hard coded constants in ppc_jumbo_xlate()

2024-05-07 Thread BALATON Zoltan
The "2" in booke206_update_mas_tlb_miss() call corresponds to MMU_INST_FETCH which is the value of access_type in this branch; mmubooke206_esr() only checks for MMU_DATA_STORE and it's called from code access so using MMU_DATA_LOAD here seems wrong so replace it with access_type here as well that

[PATCH v3 24/33] target/ppc/mmu_common.c: Split off BookE handling from ppc_jumbo_xlate()

2024-05-07 Thread BALATON Zoltan
Introduce ppc_booke_xlate() to handle BookE and BookE 2.06 cases to reduce ppc_jumbo_xlate() further. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 128 +--- 1 file changed, 92 insertions(+), 36 deletions(-) diff --git a/target/ppc/mmu_common.c

[PATCH v3 26/33] target/ppc/mmu_common.c: Simplify ppc_booke_xlate() part 1

2024-05-07 Thread BALATON Zoltan
Move setting error_code that appears in every case out in front and hoist the common fall through case for BOOKE206 as well which allows removing the nested switches. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 41 - 1 file changed, 12

[PATCH v3 04/33] target/ppc: Remove unused helper

2024-05-07 Thread BALATON Zoltan
The helper_rac function is defined but not used, remove it. Fixes: 005b69fdcc (target/ppc: Remove PowerPC 601 CPUs) Signed-off-by: BALATON Zoltan Reviwed-by: Nicholas Piggin --- target/ppc/helper.h | 2 -- target/ppc/mmu_helper.c | 24 2 files changed, 26

[PATCH v3 08/33] target/ppc/mmu_common.c: Drop cases for unimplemented MPC8xx MMU

2024-05-07 Thread BALATON Zoltan
The default case will catch this and abort the same way and there is still a warning about it in ppc_tlb_invalidate_all() so drop these from mmu_common.c to simplify this code. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/mmu_common.c | 9 - 1 file changed,

[PATCH v3 11/33] target/ppc/mmu_common.c: Move some debug logging

2024-05-07 Thread BALATON Zoltan
Move the debug logging within ppc6xx_tlb_check() from after its only call to simplify the caller. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 55 +++-- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/target/ppc/mmu_common.c

[PATCH v3 03/33] target/ppc: Simplify syscall exception handlers

2024-05-07 Thread BALATON Zoltan
After previous changes the hypercall handling in 7xx and 74xx exception handlers can be folded into one if statement to simplify this code. Also add "unlikely" to mark the less frequently used branch for the compiler. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora ---

[PATCH v3 02/33] target/ppc: Move patching nip from exception handler to helper_scv

2024-05-07 Thread BALATON Zoltan
From: Nicholas Piggin Unlike sc, for scv a facility unavailable interrupt must be generated if FSCR[SCV]=0 so we can't raise the exception with nip set to next instruction but we can move advancing nip if the FSCR check passes to helper_scv so the exception handler does not need to change it.

[PATCH v3 07/33] target/ppc/mmu_common.c: Simplify checking for real mode

2024-05-07 Thread BALATON Zoltan
In get_physical_address_wtlb() the real_mode flag depends on either the MSR[IR] or MSR[DR] bit depending on access_type. Extract just the needed bit in a more straight forward way instead of doing unnecessary computation. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin ---

[PATCH v3 01/33] target/ppc: Fix gen_sc to use correct nip

2024-05-07 Thread BALATON Zoltan
Most exceptions are raised with nip pointing to the faulting instruction but the sc instruction generating a syscall exception leaves nip pointing to next instruction. Fix gen_sc to not use gen_exception_err() which sets nip back but correctly set nip to pc_next so we don't have to patch this in

[PATCH v3 00/33] Misc PPC exception and BookE MMU clean ups

2024-05-07 Thread BALATON Zoltan
This series does some further clean up mostly around BookE MMU to untangle it from other MMU models. It also contains some other changes that I've come up with while working on this. The Simplify ppc_booke_xlate() part 1 and part 2 patches could be squashed together but left them separate for

[PATCH v3 05/33] target/ppc/mmu_common.c: Move calculation of a value closer to its usage

2024-05-07 Thread BALATON Zoltan
In mmubooke_check_tlb() and mmubooke206_check_tlb() prot2 is calculated first but only used after an unrelated check that can return before tha value is used. Move the calculation after the check, closer to where it is used, to keep them together and avoid computing it when not needed.

RE: [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying

2024-05-07 Thread Kim, Dongwon
Hi Marc-André, I found that the problem is actually due to scaling factor of 0.25 (VC_SCALE_MIN). static void gd_update_geometry_hints(VirtualConsole *vc) { GtkDisplayState *s = vc->s; GdkWindowHints mask = 0; GdkGeometry geo = {}; GtkWidget *geo_widget = NULL; GtkWindow

Re: [PATCH v2 24/28] target/ppc/mmu_common.c: Remove BookE handling from get_physical_address_wtlb()

2024-05-07 Thread BALATON Zoltan
On Tue, 7 May 2024, Nicholas Piggin wrote: On Thu May 2, 2024 at 9:43 AM AEST, BALATON Zoltan wrote: This function is no longer called for BookE MMU model so remove parts related to it. This has uncovered a few may be used uninitialised warnings that are also fixed. Signed-off-by: BALATON

RE: [PATCH v6] Hexagon: add PC alignment check and exception

2024-05-07 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, May 3, 2024 11:53 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com; > richard.hender...@linaro.org; Laurent Vivier > Subject: [PATCH v6] Hexagon:

Re: [PATCH v4 0/2] query-cpu-model-expansion: report deprecated features

2024-05-07 Thread Collin Walling
[...] Thanks everyone! The RFC for the analogous libvirt patches have been posted under the subject: [RFC PATCH 0/1] support deprecated-props from query-cpu-model-expansion Any and all feedback is welcome. -- Regards, Collin

How unsubscribe

2024-05-07 Thread Jean-Christophe
Hello,How unsubscribe ?Dear 

Re: [PATCH V1 08/26] migration: vmstate_info_void_ptr

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define VMSTATE_VOID_PTR so the value of a pointer (but not its target) > can be saved in the migration stream. This will be needed for CPR. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH 0/4] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 05:46:36PM -0300, Fabiano Rosas wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Hi, > > > > The aforementioned patch breaks virtio-gpu device migrations for versions > > pre-9.0/9.0, both forwards and backwards. Versioning of

RE: [PATCH 3/4] target/hexagon: idef-parser fix leak of init_list

2024-05-07 Thread ltaylorsimpson
> -Original Message- > From: 'Anton Johansson' > Sent: Tuesday, May 7, 2024 4:47 AM > To: ltaylorsimp...@gmail.com > Cc: qemu-devel@nongnu.org; a...@rev.ng; bc...@quicinc.com > Subject: Re: [PATCH 3/4] target/hexagon: idef-parser fix leak of init_list > > On 06/05/24,

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define a type for the 256 byte id string to guarantee the same length is > used and enforced everywhere. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Provide the VMStateDescription precreate field to mark objects that must > be loaded on the incoming side before devices have been created, because > they provide properties that will be needed at creation time. They will > be saved to and loaded from their own QEMUFile,

Re: [PATCH 4/4] virtio-gpu: add x-vmstate-version

2024-05-07 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Machine <= 8.2 use v1. > > Signed-off-by: Marc-André Lureau Reviewed-by: Fabiano Rosas

Re: [PATCH v2 3/4] hw/nvme: Support SR-IOV VFs more than 127

2024-05-07 Thread Minwoo Im
On 24-05-01 14:46:39, Klaus Jensen wrote: > On Apr 1 04:30, Minwoo Im wrote: > > From: Minwoo Im > > > > The number of virtual functions(VFs) supported in SR-IOV is 64k as per > > spec. To test a large number of MSI-X vectors mapping to CPU matrix in > > the QEMU system, we need much more than

Re: [PATCH 0/4] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-07 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > The aforementioned patch breaks virtio-gpu device migrations for versions > pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more > complex than it may initially appear, as evidenced in the

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-07 Thread Cord Amfmgm
On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm wrote: > On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > >> 06.02.2024 10:13, Cord Amfmgm wrote: >> > This changes the ohci validation to not assert if invalid >> > data is fed to the ohci controller. The poc suggested in >> >

Re: [PATCH v10 0/7] Support message-based DMA in vfio-user server

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 07:34:24AM -0700, Mattias Nissler wrote: > This series adds basic support for message-based DMA in qemu's vfio-user > server. This is useful for cases where the client does not provide file > descriptors for accessing system memory via memory mappings. My motivating use >

Re: [PATCH v10 1/7] system/physmem: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 07:34:25AM -0700, Mattias Nissler wrote: > From: Philippe Mathieu-Daudé > > From: Philippe Mathieu-Daudé > > Simplify cpu_[un]register_map_client() and cpu_notify_map_clients() > by replacing the pair of qemu_mutex_lock/qemu_mutex_unlock calls by > the

Re: [PATCH v10 4/7] softmmu: Support concurrent bounce buffers

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 07:34:28AM -0700, Mattias Nissler wrote: > When DMA memory can't be directly accessed, as is the case when > running the device model in a separate process without shareable DMA > file descriptors, bounce buffering is used. > > It is not uncommon for device models to

Re: [PATCH 3/4] virtio-gpu: use a VMState variant for the scanout field

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 03:19:19PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Depending on the version, use v1 or v2 of the scanout VM state. > > Signed-off-by: Marc-André Lureau > --- > hw/display/virtio-gpu.c | 22 +- > 1 file changed, 17

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-07 Thread Halil Pasic
On Mon, 29 Apr 2024 13:33:34 +0200 Halil Pasic wrote: > Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the > vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED > but the in QEMU device is configured to try to use the packed layout > (the virtio property

[PATCH 3/4] hw/char: Add QOM property for STM32L4x5 USART clock frequency

2024-05-07 Thread Inès Varhol
This QOM property will be used to check the clock frequency from QTests. Signed-off-by: Inès Varhol --- hw/char/stm32l4x5_usart.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c index

[PATCH 4/4] tests/qtest: Check STM32L4x5 clock connections

2024-05-07 Thread Inès Varhol
For USART, GPIO and SYSCFG devices, check that clock frequency before and after enabling the peripheral clock in RCC is correct. Signed-off-by: Inès Varhol --- tests/qtest/stm32l4x5.h | 40 + tests/qtest/stm32l4x5_gpio-test.c | 23 +

[PATCH 0/4] Check clock connection between STM32L4x5 RCC and peripherals

2024-05-07 Thread Inès Varhol
Among implemented STM32L4x5 devices, USART, GPIO and SYSCFG have a clock source, but none has a corresponding test in QEMU. This patch makes sure that all 3 devices create a clock, have a QOM property to access the clock frequency, and adds QTests checking that clock enable in RCC has the

[PATCH 2/4] hw/gpio: Handle clock migration in STM32L4x5 gpios

2024-05-07 Thread Inès Varhol
STM32L4x5 GPIO wasn't migrating its clock. Signed-off-by: Inès Varhol --- hw/gpio/stm32l4x5_gpio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/gpio/stm32l4x5_gpio.c b/hw/gpio/stm32l4x5_gpio.c index 71bf5fddb2..30d8d6cba4 100644 --- a/hw/gpio/stm32l4x5_gpio.c +++

[PATCH 1/4] hw/misc: Create STM32L4x5 SYSCFG clock

2024-05-07 Thread Inès Varhol
This commit creates a clock in STM32L4x5 SYSCFG and wires it up to the corresponding clock from STM32L4x5 RCC. A read-only QOM property allowing to read the clock frequency is added (it will be used in a QTest). Signed-off-by: Inès Varhol --- Hello, Several people noticed that replicating the

[PATCH v13 1/6] ui/gtk: Check if fence_fd is equal to or greater than 0

2024-05-07 Thread dongwon . kim
From: Dongwon Kim 'fence_fd' needs to be validated always before being referenced And the passing condition should include '== 0' as 0 is a valid value for the file descriptor. Suggested-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Cc: Philippe Mathieu-Daudé Cc: Daniel P. Berrangé

[PATCH v13 4/6] ui/console: Use qemu_dmabuf_set_..() helpers instead

2024-05-07 Thread dongwon . kim
From: Dongwon Kim This commit updates all occurrences where these fields were set directly have been updated to utilize helper functions. v7: removed prefix, "dpy_gl_" from all helpers v8: Introduction of helpers was removed as those were already added by the previous commit Suggested-by:

[PATCH v13 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-05-07 Thread dongwon . kim
From: Dongwon Kim New header and source files are added for containing QemuDmaBuf struct definition and newly introduced helpers for creating/freeing the struct and accessing its data. v10: Change the license type for both dmabuf.h and dmabuf.c from MIT to GPL to be in line with QEMU's

[PATCH v13 5/6] ui/console: Use qemu_dmabuf_new() and free() helpers instead

2024-05-07 Thread dongwon . kim
From: Dongwon Kim This commit introduces utility functions for the creation and deallocation of QemuDmaBuf instances. Additionally, it updates all relevant sections of the codebase to utilize these new utility functions. v7: remove prefix, "dpy_gl_" from all helpers qemu_dmabuf_free()

[PATCH v13 6/6] ui/console: move QemuDmaBuf struct def to dmabuf.c

2024-05-07 Thread dongwon . kim
From: Dongwon Kim To complete privatizing process of QemuDmaBuf, QemuDmaBuf struct def is moved to dmabuf.c Suggested-by: Marc-André Lureau Reviewed-by: Marc-André Lureau Cc: Philippe Mathieu-Daudé Cc: Daniel P. Berrangé Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim ---

[PATCH v13 3/6] ui/console: Use qemu_dmabuf_get_..() helpers instead

2024-05-07 Thread dongwon . kim
From: Dongwon Kim This commit updates all instances where fields within the QemuDmaBuf struct are directly accessed, replacing them with calls to these new helper functions. v6: fix typos in helper names in ui/spice-display.c v7: removed prefix, "dpy_gl_" from all helpers v8: Introduction of

[PATCH v13 0/6] ui/console: Private QemuDmaBuf struct

2024-05-07 Thread dongwon . kim
From: Your Name This series introduces privacy enhancements to the QemuDmaBuf struct and its contained data to bolster security. it accomplishes this by introducing of helper functions for allocating, deallocating, and accessing individual fields within the struct and replacing all direct

Re: [PULL 00/26] target/i386 changes for 2024-05-07

2024-05-07 Thread Richard Henderson
On 5/7/24 03:55, Paolo Bonzini wrote: The following changes since commit e116b92d01c2cd75957a9f8ad1d4932292867b81: Merge tag 'qemu-sparc-20240506' ofhttps://github.com/mcayland/qemu into staging (2024-05-06 10:19:56 -0700) are available in the Git repository at:

Re: [PATCH] qemu-io: add cvtnum() error handling for zone commands

2024-05-07 Thread Sam Li
Stefan Hajnoczi 于2024年5月7日周二 20:06写道: > > cvtnum() parses positive int64_t values and returns a negative errno on > failure. Print errors and return early when cvtnum() fails. > > While we're at it, also reject nr_zones values greater or equal to 2^32 > since they cannot be represented. > >

[PATCH] qemu-io: add cvtnum() error handling for zone commands

2024-05-07 Thread Stefan Hajnoczi
cvtnum() parses positive int64_t values and returns a negative errno on failure. Print errors and return early when cvtnum() fails. While we're at it, also reject nr_zones values greater or equal to 2^32 since they cannot be represented. Reported-by: Peter Maydell Cc: Sam Li Signed-off-by:

[PATCH] gitlab: Update msys2-64bit runner tags

2024-05-07 Thread Richard Henderson
Gitlab has deprecated and removed support for windows-1809 and shared-windows. Update to saas-windows-medium-amd64 per https://about.gitlab.com/blog/2024/01/22/windows-2022-support-for-gitlab-saas-runners/ Signed-off-by: Richard Henderson --- .gitlab-ci.d/windows.yml | 4 +--- 1 file changed,

Re: [PATCH 1/4] hw/misc: Create STM32L4x5 SYSCFG clock

2024-05-07 Thread Inès Varhol
- Le 7 Mai 24, à 11:50, peter maydell peter.mayd...@linaro.org a écrit : > On Sun, 5 May 2024 at 15:06, Inès Varhol wrote: >> >> Signed-off-by: Inès Varhol > > In general you should try to avoid commits with no commit message. > Sometimes there really isn't anything to say beyond what

Re: [PATCH RFC 00/26] Multifd  device state transfer support with VFIO consumer

2024-05-07 Thread Avihai Horon
On 07/05/2024 19:13, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, May 07, 2024 at 11:41:05AM +0300, Avihai Horon wrote: Yes, I was working on parallel VFIO migration, but in a different approach (not over multifd) which I'm not sure is relevant to this

Re: [PATCH v4 15/17] xen: mapcache: Remove assumption of RAMBlock with 0 offset

2024-05-07 Thread Edgar E. Iglesias
On Thu, May 2, 2024 at 10:02 PM Stefano Stabellini wrote: > > On Thu, 2 May 2024, Edgar E. Iglesias wrote: > > On Thu, May 2, 2024 at 8:53 PM Stefano Stabellini > > wrote: > > > > > > +Xenia > > > > > > On Thu, 2 May 2024, Edgar E. Iglesias wrote: > > > > On Wed, May 1, 2024 at 11:24 PM Stefano

Re: [PATCH v6 0/9] TCG plugins new inline operations

2024-05-07 Thread Pierrick Bouvier
On 5/7/24 09:07, Alex Bennée wrote: Pierrick Bouvier writes: This series implement two new operations for plugins: - Store inline allows to write a specific value to a scoreboard. - Conditional callback executes a callback only when a given condition is true. The condition is evaluated

Re: [PATCH v2 04/33] accel/tcg: Reorg translator_ld*

2024-05-07 Thread Richard Henderson
On 5/6/24 15:47, Philippe Mathieu-Daudé wrote: On 25/4/24 01:31, Richard Henderson wrote: Reorg translator_access into translator_ld, with a more memcpy-ish interface.  If both pages are in ram, do not go through the caller's slow path. Assert that the access is within the two pages that we

Re: [PATCH 1/3] system/physmem: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD

2024-05-07 Thread Richard Henderson
On 5/7/24 05:30, Philippe Mathieu-Daudé wrote: Simplify cpu_[un]register_map_client() and cpu_notify_map_clients() by replacing the pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD() macro. Signed-off-by: Philippe Mathieu-Daudé --- system/physmem.c | 9 +++-- 1

Re: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-07 Thread Jonathan Cameron via
On Tue, 7 May 2024 00:22:00 + "Xingtao Yao (Fujitsu)" wrote: > > -Original Message- > > From: Jonathan Cameron > > Sent: Tuesday, April 30, 2024 10:43 PM > > To: Yao, Xingtao/姚 幸涛 > > Cc: fan...@samsung.com; qemu-devel@nongnu.org > > Subject: Re: [PATCH v2] mem/cxl_type3: support

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 01:50:43AM +, Gonglei (Arei) wrote: > Hello, > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Monday, May 6, 2024 11:18 PM > > To: Gonglei (Arei) > > Cc: Daniel P. Berrangé ; Markus Armbruster > > ; Michael Galaxy ; Yu Zhang > >

Re: [PATCH 2/3] vfio/migration: Emit VFIO device migration state change QAPI event

2024-05-07 Thread Avihai Horon
On 07/05/2024 18:51, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, May 07, 2024 at 10:47:13AM +0300, Avihai Horon wrote: While at it, another trivial comment is maybe it's nice to have a helper to both update the vfio migration state, plus emitting events

Re: [PULL 0/9] tcg + misc patch queue

2024-05-07 Thread Richard Henderson
/qemu.git tags/pull-tcg-20240507 for you to fetch changes up to f578b66e8c70ddea71d44db6e2c7abbcd757d684: gitlab: Streamline ubuntu-22.04-s390x (2024-05-06 23:40:36 -0700) tcg: Add write_aofs to GVecGen3i tcg/i386: Simplify

Re: [PATCH] loongarch64: move memory map to boot.c

2024-05-07 Thread Richard Henderson
On 5/7/24 07:51, Paolo Bonzini wrote: Ensure that it can be used even if virt.c is not included in the build, as is the case for --without-default-devices. Signed-off-by: Paolo Bonzini --- include/hw/loongarch/boot.h | 10 ++ include/hw/loongarch/virt.h | 10 --

Re: [PATCH] misc: Use QEMU header path relative to include/ directory

2024-05-07 Thread Richard Henderson
On 5/7/24 07:27, Philippe Mathieu-Daudé wrote: QEMU headers are relative to the include/ directory, not to the project root directory. Remove "include/". See also: https://www.qemu.org/docs/master/devel/style.html#include-directives Signed-off-by: Philippe Mathieu-Daudé ---

Re: [RFC PATCH v3 3/5] KVM: x86: Add notifications for Heki policy configuration and violation

2024-05-07 Thread Sean Christopherson
On Tue, May 07, 2024, Mickaël Salaün wrote: > > Actually, potential bad/crazy idea. Why does the _host_ need to define > > policy? > > Linux already knows what assets it wants to (un)protect and when. What's > > missing > > is a way for the guest kernel to effectively deprivilege and

  1   2   3   4   >