Privoznik
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 31.05.24 10:12, Philippe Mathieu-Daudé wrote:
On 31/5/24 10:01, David Hildenbrand wrote:
On 31.05.24 09:57, Philippe Mathieu-Daudé wrote:
Hi Michal,
On 31/5/24 09:28, Michal Privoznik wrote:
The unspoken premise of qemu_madvise() is that errno is set on
error. And it is mostly the case
On 31.05.24 09:57, Philippe Mathieu-Daudé wrote:
Hi Michal,
On 31/5/24 09:28, Michal Privoznik wrote:
The unspoken premise of qemu_madvise() is that errno is set on
error. And it is mostly the case except for posix_madvise() which
is documented to return either zero (on success) or a positive
to
configuration).
Yes and no. According to the man page
" EINVAL advice is not a valid."
if a particular MADV_* call is not implemented, we would get EINVAL,
which is really unfortunate ... to detect what is actually supported :(
For the patch here ENOSYS makes sense:
Reviewed
On 29.05.24 08:48, Michal Prívozník wrote:
On 5/28/24 18:47, David Hildenbrand wrote:
Am 28.05.24 um 18:15 schrieb Michal Privoznik:
./build/qemu-system-x86_64 \ -m
size=8389632k,slots=16,maxmem=2560k \ -object
'{"qom-type":"memory-backend-file","id":"
, advice);
+if (rc) {
+errno = rc;
+return -1;
+}
+return 0;
#else
errno = EINVAL;
return -1;
Interesting, seems to be correct
Reviewed-by: David Hildenbrand
--
Thanks,
David / dhildenb
uot;size":8590983168,"host-nodes":[0],"policy":"bind"}' \ -numa node,nodeid=0,cpus=0,memdev=ram-node0
For DIMMs and friends we now (again) enforce that the size must be aligned to
the page size:
commit 540a1abbf0b243e4cfb4333c5d30a041f7080ba4
Author: Davi
I wonder if we should forbid users from removing memory that is 'out of place',
i.e. users
should always remove pc-dimms in LIFO order. Usually this kind of control is
done by
management, e.g. libvirt, but if we're not sure we'll keep consistency during
memory
unplugs ...
I really don't
Am 26.05.24 um 21:44 schrieb Richard Henderson:
On 5/26/24 08:53, David Hildenbrand wrote:
Am 25.05.24 um 15:12 schrieb Nicholas Piggin:
The flic pending state is not migrated, so if the machine is migrated
while an interrupt is pending, it can be lost. This shows up in
qtest migration test
Am 25.05.24 um 15:12 schrieb Nicholas Piggin:
The flic pending state is not migrated, so if the machine is migrated
while an interrupt is pending, it can be lost. This shows up in
qtest migration test, an extint is pending (due to console writes?)
and the CPU waits via s390_cpu_set_psw and
On 24.05.24 15:14, Daniel Henrique Barboza wrote:
On 5/21/24 07:56, Björn Töpel wrote:
From: Björn Töpel
Virtio-based memory devices (virtio-mem/virtio-pmem) allows for
dynamic resizing of virtual machine memory, and requires proper
hotplugging (add/remove) support to work.
Add device
On 23.05.24 16:55, Stefano Garzarella wrote:
`memory-backend-shm` can be used with vhost-user devices, so let's
add a new test case for it.
Acked-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
,
-" -object memory-backend-memfd,id=mem,size=256M,share=on "
+" -object memory-backend-shm,id=mem,size=256M,share=on "
Can we simplifya nd drop the share=on?
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Acked-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
-off-by: Stefano Garzarella
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
. Berrangé
Acked-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
, addrlen can be specified as
sizeof(struct sockaddr_un).
So let's follow the last advice and simplify the code as well.
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Acked-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
Reviewed-by: David
, let's mask
that feature if the backend is not able to properly handle these
messages.
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Acked-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
Signed-off-by: Stefano Garzarella
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 19.05.24 11:24, Daniel Henrique Barboza wrote:
On 5/18/24 16:50, David Hildenbrand wrote:
Hi,
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 4fdb66052587..16c2bdbfe6b6 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -53,6 +53,8 @@
#include "hw/pci-host/g
I got your comment right, but virtio-mem was never supposed
to be a virtio-balloon replacement (especially of the
free-page-reporting and memory stats part).
I see that David Hildenbrand is also CCed in the patch so he'll let us know if
I'm out of line with what I'm asking.
Supporting PC-DIMMs might be required at some point when dealing with
OSes that don't support virtio-mem and friends.
--
Cheers,
David / dhildenb
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
r existing machines.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
y: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
, noreturn, env, i32)
DEF_HELPER_FLAGS_1(stfl, TCG_CALL_NO_RWG, void, env)
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
t;offset == 0) {
+if (xen_mr_is_memory(block->mr)) {
return xen_map_cache(block->mr, addr, len, lock, lock,
is_write);
}
I'd have moved that into a separate patch, because this is not a simple
abstraction here.
Acked-by
On 30.04.24 18:49, Edgar E. Iglesias wrote:
From: "Edgar E. Iglesias"
Propagate MR and is_write to xen_map_cache().
I'm pretty sure the patch subject is missing a "to" :)
This is in preparation for adding support for grant mappings.
No functional change.
Reviewed-b
-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
Reviewed-by: Alex Bennée
Reviewed-by: Edgar E. Iglesias
---
Acked-by: David Hildenbrand
--
Cheers,
David / dhildenb
(MachineState *machine)
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
true,
...a lot more props...
"skey": false,
"vxpdeh2": false
}
}
}
}
It is recommended that s390 guests operate with these features
explicitly disabled to ensure compatability with future hardware.
Signed-off-by: Collin Walling
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
*/
S390_FEAT_CONDITIONAL_SSKE,
S390_FEAT_BPB,
+ /* Deprecated on z16 */
+ S390_FEAT_CONSTRAINT_TRANSACTIONAL_EXE,
+ S390_FEAT_TRANSACTIONAL_EXE
};
int i;
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 30.04.24 10:04, Thomas Huth wrote:
The sclpconsole currently does not have a proper parent in the QOM
tree, so it shows up under /machine/unattached - which is somewhat
ugly. Let's attach it to /machine/sclp instead.
IIRC, this should not affect migration
Reviewed-by: David Hildenbrand
On 26.04.24 19:44, David Hildenbrand wrote:
On 24.04.24 23:56, Collin Walling wrote:
Retain a list of deprecated features disjoint from any particular
CPU model. A query-cpu-model-expansion reply will now provide a list of
properties (i.e. features) that are flagged as deprecated. Example
On 24.04.24 23:56, Collin Walling wrote:
Retain a list of deprecated features disjoint from any particular
CPU model. A query-cpu-model-expansion reply will now provide a list of
properties (i.e. features) that are flagged as deprecated. Example:
{
"return": {
"model": {
On 24.04.24 20:33, Collin Walling wrote:
On 4/24/24 03:24, David Hildenbrand wrote:
On 23.04.24 23:06, Collin Walling wrote:
Retain a list of deprecated features disjoint from any particular
CPU model. When a query-cpu-model-expansion is provided with the
"disable-deprecated-feats"
On 23.04.24 23:06, Collin Walling wrote:
Retain a list of deprecated features disjoint from any particular
CPU model. When a query-cpu-model-expansion is provided with the
"disable-deprecated-feats" option set, the resulting properties list
will include all deprecated features paired with false.
On 20.04.24 07:46, Thomas Huth wrote:
Printing an architecture prefix in front of each CPU name is not helpful
at all: It is confusing for the users since they don't know whether they
have to specify these letters for the "-cpu" parameter, too, and it also
takes some precious space in the dense
size" property.
Let's simply avoid talking about the "size" property and spell out that
some device memory is still plugged.
Cc: Liang Cong
Cc: Mario Casquero
Cc: "Michael S. Tsirkin"
Signed-off-by: David Hildenbrand
---
hw/virtio/virtio-mem.c | 4 ++--
1 file changed, 2
On 08.04.24 09:58, Stefano Garzarella wrote:
On Thu, Apr 04, 2024 at 04:09:34PM +0200, David Hildenbrand wrote:
On 04.04.24 14:23, Stefano Garzarella wrote:
shm_open() creates and opens a new POSIX shared memory object.
A POSIX shared memory object allows creating memory backend
+##
+{ 'struct': 'MemoryBackendShmProperties',
+ 'base': 'MemoryBackendProperties',
+ 'data': { } }
+
Acked-by: David Hildenbrand
One comment: we should maybe just forbid setting share=off. it doesn't
make any sense and it can even result in an unexpected double memory
consumption. We missed doing
So I thought that for now we only support the "anonymous" mode, and if
in the future we have a use case where the user wants to specify the
name, we can add it later.
Okay, so for now you really only want an anonymous fd that behaves like
a memfd, got it.
Likely we should somehow fail if the
On 27.03.24 11:23, Stefano Garzarella wrote:
On Tue, Mar 26, 2024 at 03:45:52PM +0100, David Hildenbrand wrote:
+mode = 0;
+oflag = O_RDWR | O_CREAT | O_EXCL;
+backend_name = host_memory_backend_get_name(backend);
+
+/*
+ * Some operating systems allow creating anonymous
endent on another one.
Please make sure to CC people you CC on patches to also CC on the cover
letter.
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
NULL : , align,
memory_region_size(mr), _err);
Very nice!
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
I was wondering if we could see some partial sendmsg()/write
succeeding. Meaning, we transferred some bytes but not all, and we'd
actually need to loop ...
Yep, true, but I would fix it in another patch/series if you agree.
Absolutely.
--
Cheers,
David / dhildenb
+mode = 0;
+oflag = O_RDWR | O_CREAT | O_EXCL;
+backend_name = host_memory_backend_get_name(backend);
+
+/*
+ * Some operating systems allow creating anonymous POSIX shared memory
+ * objects (e.g. FreeBSD provides the SHM_ANON constant), but this is not
+ * defined by
On 26.03.24 15:34, Eric Blake wrote:
On Tue, Mar 26, 2024 at 02:39:27PM +0100, Stefano Garzarella wrote:
In vu_message_write() we use sendmsg() to send the message header,
then a write() to send the payload.
If sendmsg() fails we should avoid sending the payload, since we
were unable to send
(VuDev *dev, int conn_fd, VhostUserMsg
*vmsg)
memcpy(CMSG_DATA(cmsg), vmsg->fds, fdsize);
} else {
msg.msg_controllen = 0;
+msg.msg_control = NULL;
}
do {
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
#
# Usually, a CPU model is compared against the maximum possible CPU
# model of a certain configuration (e.g. the "host" model for KVM).
@@ -154,7 +155,14 @@
# Some architectures may not support comparing CPU models. s390x
# supports comparing CPU models.
#
-# Returns: a
arkus Armbruster
Cc: Eric Blake
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: "Philippe Mathieu-Daudé"
Cc: Yanan Wang
Signed-off-by: David Hildenbrand
---
qapi/machine-target.json | 46 +++-
qapi/pragma.json | 3 ---
2 files changed,
On 25.03.24 15:13, David Hildenbrand wrote:
On 25.03.24 10:36, Markus Armbruster wrote:
If you're cc'ed, I have a bit of doc work for you. Search for your
name to find it.
The QAPI generator forces you to document your stuff. Except for
commands, events, enum and object types listed
On 25.03.24 10:36, Markus Armbruster wrote:
If you're cc'ed, I have a bit of doc work for you. Search for your
name to find it.
The QAPI generator forces you to document your stuff. Except for
commands, events, enum and object types listed in pragma
documentation-exceptions, the generator
On 20.03.24 18:38, Michael Roth wrote:
On Wed, Mar 20, 2024 at 10:37:14AM +0100, David Hildenbrand wrote:
On 20.03.24 09:39, Michael Roth wrote:
From: Xiaoyao Li
When memory page is converted from private to shared, the original
private memory is back'ed by guest_memfd. Introduce
first VCPU (all VCPUS on x86) (since 2.4)
While we can select a particular CPU on HMP, the guest behavior
is expected to be the same if using CPU #N or CPU #0. Since
always using CPU#0 simplifies API maintainance, update s390_nmi()
to deliver NMI to the first CPU.
Signed-off-by: Philippe Mathieu-D
On 20.03.24 13:43, Xiaoyao Li wrote:
On 3/20/2024 5:37 PM, David Hildenbrand wrote:
On 20.03.24 09:39, Michael Roth wrote:
From: Xiaoyao Li
When memory page is converted from private to shared, the original
private memory is back'ed by guest_memfd. Introduce
Codeveloped-by: Xiaoyao Li
"Co-developed-by"
Signed-off-by: Xiaoyao Li
Reviewed-by: David Hildenbrand
Your SOB should go here.
---
Changes in v5:
- Collect Reviewed-by from David;
Changes in in v4:
- Drop ram_block_convert_range() and open code its implementation in the
next Patch.
On 19.03.24 15:23, Peter Maydell wrote:
On Tue, 19 Mar 2024 at 09:24, David Hildenbrand wrote:
I spotted new pause_all_vcpus() / resume_all_vcpus() calls in
hw/intc/arm_gicv3_kvm.c and
thought they would be the problematic bit.
Yeah, that's going to be problematic. Further note that a lot
On 19.03.24 10:24, David Hildenbrand wrote:
On 19.03.24 06:06, zhukeqian wrote:
Hi David,
Thanks for reviewing.
On 17.03.24 09:37, Keqian Zhu via wrote:
Both main loop thread and vCPU thread are allowed to call
pause_all_vcpus(), and in general resume_all_vcpus() is called after
it. Two
On 19.03.24 06:11, zhukeqian wrote:
Hi David,
On 17.03.24 09:37, Keqian Zhu via wrote:
For vCPU being hotplugged, qemu_init_vcpu() is called. In this
function, we set vcpu state as stopped, and then wait vcpu thread to
be created.
As the vcpu state is stopped, it will inform us it has been
:)
Finding ways to avoid pause_all_vcpus() on the ARM reset code would be
preferable.
I guess you simply want to do something similar to what KVM does to avoid
messing
with pause_all_vcpus(): inhibiting certain IOCTLs.
commit f39b7d2b96e3e73c01bb678cd096f7baf0b9ab39
Author: David Hildenbrand
)
Reviewed-by: Ilya Leoshkevich
Reviewed-by: Richard Henderson
[iii: Adjust a newline and capitalization, add tags]
Signed-off-by: Ido Plat
Signed-off-by: Ilya Leoshkevich
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 17.03.24 09:37, Keqian Zhu via wrote:
For vCPU being hotplugged, qemu_init_vcpu() is called. In this
function, we set vcpu state as stopped, and then wait vcpu thread
to be created.
As the vcpu state is stopped, it will inform us it has been created
and then wait on halt_cond. After we has
On 17.03.24 09:37, Keqian Zhu via wrote:
Both main loop thread and vCPU thread are allowed to call
pause_all_vcpus(), and in general resume_all_vcpus() is called
after it. Two issues live in pause_all_vcpus():
In general, calling pause_all_vcpus() from VCPU threads is quite dangerous.
Do we
On 11.03.24 21:03, Mario Casquero wrote:
This series has been successfully tested by QE. Start the
qemu-storage-daemon in the background with a rhel 9.5 image and
vhost-user-blk. After that, boot up a VM with virtio-mem and
vhost-user-blk-pci. Check with the HMP command 'info mtree' that
On 08.03.24 08:36, Peter Xu wrote:
On Thu, Mar 07, 2024 at 03:37:06PM +, Jonathan Cameron wrote:
v2: (Thanks to Peter Xu for reviewing!)
- New patch 1 to rename addr1 to mr_addr in the interests of meaningful naming.
- Take advantage of a cached address space only allow for a single MR to
at least the
level of confusion this creates is consistent with the other code.
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
unused addr parameter.
- Carry through new mr_addr parameter name.
- RB not picked up as not sure what Peter will think wrt to
resulting parameter ordering.
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 07.03.24 16:37, Jonathan Cameron wrote:
Precursor to factoring out the inner loops for reuse.
Reviewed-by: Peter Xu
Signed-off-by: Jonathan Cameron
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
by flatview_translate().
Similarly rename the parameter in address_space_read/write_cached_slow()
Suggested-by: Peter Xu
Signed-off-by: Jonathan Cameron
Much cleaner indeed!
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
e, we need writable RAM instead of
+# ROM, and want to set this property to 'off'. (default: auto,
+# since 8.2)
#
# Since: 2.1
##
Ideally, we'd have a format checker that complains like checkpatch
usually would.
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 28.02.24 12:47, Stefano Garzarella wrote:
Add a new `shm` bool option for `-object memory-backend-file`.
When this option is set to true, the POSIX shm_open(3) is used instead
of open(2).
So a file will not be created in the filesystem, but a "POSIX shared
memory object" will be
On 29.01.24 03:18, Xiaoyao Li wrote:
On 1/26/2024 10:58 PM, David Hildenbrand wrote:
On 25.01.24 04:22, Xiaoyao Li wrote:
By default (due to the recent UPM change), restricted memory attribute is
shared. Convert the memory region from shared to private at the memory
slot creation time.
add
ock;
if (*size == 0) {
return NULL;
}
base-commit: 5767815218efd3cbfd409505ed824d5f356044ae
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
We never add a memory region if mmap() failed. Therefore, no need to check
for NULL.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff
Let's reduce some code duplication and prepare for further changes.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 119 +++---
1 file changed, 39 insertions(+), 80 deletions(-)
diff
GPA can belong to at most one memory region, and
everything else doesn't make sense. Let's factor out our search to prepare
for further changes.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 79 +
dev->nregions always covers only valid entries. Stop zeroing out other
array elements that are unused.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 7 +--
1 file changed, 1 insertion(+)
ano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 11 +++
subprojects/libvhost-user/libvhost-user.h | 2 +-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-u
ave many memslots.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 49 +--
1 file changed, 45 insertions(+), 4 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
the ring again when required.
Acked-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 107 --
1 file changed, 78 insertions(+), 29 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost
dev->nregions if anything went
wrong.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 168 --
1 file changed, 60 insertions(+), 108 deletions(-)
diff --git a/subprojects/libvhost-user/li
We cannot have duplicate memory regions, something would be deeply
flawed elsewhere. Let's just stop the search once we found an entry.
We'll add more sanity checks when adding memory regions later.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
/
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost-user.h
b/subprojects/libvhost-user/libvhost
an vary depending on the architecture.
"unsigned int" is sufficient here.
-> Updated patch description
* Added RBs+ACKs
* Did a Gitlab CI run, seems to be happy reagrding libvhost-user
Cc: Michael S. Tsirkin
Cc: Jason Wang
Cc: Stefan Hajnoczi
Cc: Stefano Garzarella
Cc: Germano
Let's factor it out to prepare for further changes.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 24 +++
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
. If ever required for debugging purposes, we could mark only
the mapped rings MADV_DODUMP.
Ignore errors during madvise() for now.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 6 ++
1 file changed
space_addr: 0x7fb77bffe000
old mmap_offset: 0xc000
fd_offset: 0xc000
new mmap_offset: 0x
mmap_addr: 0x7f028400
Successfully added new region
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David H
Let's factor it out. Note that the check for MAP_FAILED was wrong as
we never set mmap_addr if mmap() failed. We'll remove the NULL check
separately.
Reviewed-by: Raphael Norwitz
Acked-by: Stefano Garzarella
Signed-off-by: David Hildenbrand
---
subprojects/libvhost-user/libvhost-user.c | 34
On 13.02.24 19:55, Michael S. Tsirkin wrote:
On Tue, Feb 13, 2024 at 07:27:44PM +0100, David Hildenbrand wrote:
On 13.02.24 18:33, Michael S. Tsirkin wrote:
On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote:
This series adds support for more memslots (509) to libvhost-user
On 13.02.24 18:33, Michael S. Tsirkin wrote:
On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote:
This series adds support for more memslots (509) to libvhost-user, to
make it fully compatible with virtio-mem that uses up to 256 memslots
accross all memory devices in "dy
On 13.02.24 18:32, Michael S. Tsirkin wrote:
On Fri, Feb 02, 2024 at 10:53:18PM +0100, David Hildenbrand wrote:
We barely had mmap_offset set in the past. With virtio-mem and
dynamic-memslots that will change.
In vu_add_mem_reg() and vu_set_mem_table_exec_postcopy(), we are
performing pointer
On 08.02.24 19:54, Steve Sistare wrote:
Check the status returned by migration notifiers and report errors.
If notifiers fail, call the notifiers again so they can clean up.
IIUC, if any of the notifiers will actually start to fail, say, during
MIG_EVENT_PRECOPY_SETUP, you will call
On 08.02.24 19:54, Steve Sistare wrote:
Move common code for the error path in migrate_fd_connect to a shared
fail label. No functional change.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 08.02.24 19:54, Steve Sistare wrote:
Keep a separate list of migration notifiers for each migration mode.
Suggested-by: Peter Xu
Signed-off-by: Steve Sistare
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 08.02.24 19:53, Steve Sistare wrote:
Define MigrationNotifyFunc to improve type safety and simplify migration
notifiers.
Signed-off-by: Steve Sistare
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
.
Suggested-by: Peter Xu
Signed-off-by: Steve Sistare
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
Xu
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 08.02.24 19:53, Steve Sistare wrote:
Remove the error object from opaque data passed to notifiers.
Use the new error parameter passed to the notifier instead.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
Would have squashed #1 and #2.
Reviewed-by: David Hildenbrand
--
Cheers
: Peter Xu
---
Reviewed-by: David Hildenbrand
--
Cheers,
David / dhildenb
On 07.02.24 12:40, Stefano Garzarella wrote:
On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote:
This series adds support for more memslots (509) to libvhost-user, to
make it fully compatible with virtio-mem that uses up to 256 memslots
accross all memory devices in "dy
1 - 100 of 6974 matches
Mail list logo
