On Mon, Jun 10, 2024 at 03:20:53PM GMT, Michael Tokarev wrote:
> 10.06.2024 15:17, Eric Blake wrote:
> > > 01* 690ceb71936f Philippe Mathieu-Daudé:
> > > gitlab-ci: Remove job building EDK2 firmware binaries
> > > 02* 7bc1286b81d4 Palmer Dabbelt:
> > >
still an active client, and make sure we don't have any other NULL
derefs. I'll respond again once I've studied the code a bit more.
> > nbd_server->connections--;
> > nbd_update_server_watch(nbd_server);
>
> --
> Best regards,
> Alexander Ivanov
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
On Mon, Jun 10, 2024 at 07:17:53AM GMT, Eric Blake wrote:
> On Fri, Jun 07, 2024 at 10:12:02PM GMT, Michael Tokarev wrote:
> > The following patches are queued for QEMU stable v7.2.12:
> >
> > https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2
> >
> > P
> 03* 04f6fb897a5a Michael Tokarev:
>linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY
> 04* ae6d91a7e9b7 Zhu Yangyang:
>nbd/server: do not poll within a coroutine context
> 05* 4fa333e08dd9 Eric Blake:
>nbd/server: Mark negotiation functions as coroutine_fn
In addition t
relicensing from 2-clause BSD to GPLv2.
CC: qemu-sta...@nongnu.org
CC: "Richard W.M. Jones"
Signed-off-by: Eric Blake
Message-ID: <20240531180639.1392905-6-ebl...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
tests/qemu-iotests/tests/nbd-tls-iothread | 168 ++
Eric Blake (2):
qio: Inherit follow_coroutine_ctx across TLS
iotests: test NBD+TLS+iothread
io/channel-tls.c | 26 ++--
io/channel-websock.c | 1 +
tests/qemu-iotests/tests/nbd-tls-iothread
that they
inherit feature bits.
CC: Stefan Hajnoczi
CC: Daniel P. Berrangé
CC: qemu-sta...@nongnu.org
Fixes: https://issues.redhat.com/browse/RHEL-34786
Fixes: 06e0f098 ("io: follow coroutine AioContext in qio_channel_yield()",
v8.2.0)
Signed-off-by: Eric Blake
Reviewed-by: Stefa
that they
inherit feature bits.
CC: Stefan Hajnoczi
CC: Daniel P. Berrangé
CC: qemu-sta...@nongnu.org
Fixes: https://issues.redhat.com/browse/RHEL-34786
Fixes: 06e0f098 ("io: follow coroutine AioContext in qio_channel_yield()",
v8.2.0)
Signed-off-by: Eric Blake
Reviewed-by: Stefa
In v3:
- 2/2: fix iotest filtering [kwolf]
v2 was here:
https://lists.gnu.org/archive/html/qemu-devel/2024-05/msg03517.html
and this time, I'll wait for R-b before sending my v2 pull request:
https://lists.gnu.org/archive/html/qemu-devel/2024-05/msg06206.html
Eric Blake (2):
qio: Inherit
relicensing from 2-clause BSD to GPLv2.
CC: qemu-sta...@nongnu.org
CC: "Richard W.M. Jones"
Signed-off-by: Eric Blake
---
tests/qemu-iotests/tests/nbd-tls-iothread | 168 ++
tests/qemu-iotests/tests/nbd-tls-iothread.out | 54 ++
2 files changed, 222 insertions(
On Thu, May 30, 2024 at 07:22:16AM GMT, Eric Blake wrote:
> The following changes since commit 3b2fe44bb7f605f179e5e7feb2c13c2eb3abbb80:
>
> Merge tag 'pull-request-2024-05-29' of https://gitlab.com/thuth/qemu into
> staging (2024-05-29 08:38:20 -0700)
>
> are available in
On Fri, May 31, 2024 at 04:36:20PM GMT, Kevin Wolf wrote:
> Am 18.05.2024 um 04:50 hat Eric Blake geschrieben:
> > Prevent regressions when using NBD with TLS in the presence of
> > iothreads, adding coverage the fix to qio channels made in the
> > previous patch.
ark/allow marking/
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/qom/object.h | 1 +
> qom/qom-qmp-cmds.c| 4
> system/qdev-monitor.c | 5 +
> qapi/qom.json | 4 +++-
> 4 files changed, 13 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake
Eric Blake (2):
qio: Inherit follow_coroutine_ctx across TLS
iotests: test NBD+TLS+iothread
io/channel-tls.c | 26 ++--
io/channel-websock.c | 1 +
tests/qemu-iotests/tests/nbd-tls-iothread
relicensing from 2-clause BSD to GPLv2.
CC: qemu-sta...@nongnu.org
CC: "Richard W.M. Jones"
Signed-off-by: Eric Blake
Message-ID: <20240518025246.791593-6-ebl...@redhat.com>
---
tests/qemu-iotests/tests/nbd-tls-iothread | 168 ++
tests/qemu-iotests/tests/nbd-
that they
inherit feature bits.
CC: Stefan Hajnoczi
CC: Daniel P. Berrangé
CC: qemu-sta...@nongnu.org
Fixes: https://issues.redhat.com/browse/RHEL-34786
Fixes: 06e0f098 ("io: follow coroutine AioContext in qio_channel_yield()",
v8.2.0)
Signed-off-by: Eric Blake
Reviewed-by: Stefa
Adding a bit of self-review (in case you want to amend this before
pushing, instead of waiting for me to get back online),
On Fri, May 17, 2024 at 09:50:15PM GMT, Eric Blake wrote:
> Prevent regressions when using NBD with TLS in the presence of
> iothreads, adding coverage the fix
On Fri, May 17, 2024 at 09:50:13PM GMT, Eric Blake wrote:
> In v2:
> - correct list email address
> - add iotest
> - add R-b
>
> I'm offline next week, and have been communicating with Stefan who may
> want to push this through his block tree instead of waiting for me to
>
that they
inherit feature bits.
CC: Stefan Hajnoczi
CC: Daniel P. Berrangé
CC: qemu-sta...@nongnu.org
Fixes: https://issues.redhat.com/browse/RHEL-34786
Fixes: 06e0f098 ("io: follow coroutine AioContext in qio_channel_yield()",
v8.2.0)
Signed-off-by: Eric Blake
Reviewed-by: Stefa
Prevent regressions when using NBD with TLS in the presence of
iothreads, adding coverage the fix to qio channels made in the
previous patch.
CC: qemu-sta...@nongnu.org
Signed-off-by: Eric Blake
---
tests/qemu-iotests/tests/nbd-tls-iothread | 170 ++
tests/qemu-iotests/tests
In v2:
- correct list email address
- add iotest
- add R-b
I'm offline next week, and have been communicating with Stefan who may
want to push this through his block tree instead of waiting for me to
get back.
Eric Blake (2):
qio: Inherit follow_coroutine_ctx across TLS
iotests: test NBD+TLS
* _MACHINE_VER_PICK(__VA_ARGS__, \
*MACRO_FOR_5_ARGS, \
*MACRO_FOR_4_ARGS, \
*MACRO_FOR_3_ARGS, \
*MACRO_FOR_2_ARGS)(optional prefix args, __VA_ARGS__)
*/
But once understood, I see it comes in handy in several places below.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
option negotiation as also being
coroutine_fn.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Eric Blake
Message-ID: <20240408160214.1200629-6-ebl...@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy
[eblake: drop one spurious coroutine_fn marking]
Signed-off-by: Eric Blake
--
the callback, whether or not it
required a yield or main loop.
Fixes: f95910f ("nbd: implement TLS support in the protocol negotiation")
Signed-off-by: Zhu Yangyang
[eblake: move callbacks to their use point, add assertions]
Signed-off-by: Eric Blake
Message-ID: <20240408160214.
Eric Blake (1):
nbd/server: Mark negotiation functions as coroutine_fn
Zhu Yangyang (1):
nbd/server: do not poll within a coroutine context
nbd/nbd-internal.h | 10 -
nbd/client.c | 28 ++--
nbd/common.c
need to
> tweak the parameter of parse_volume_options() (where we use the
> result of g_uri_get_path() as input).
>
> Reviewed-by: Eric Blake
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Thomas Huth
> ---
> block/gluster.c | 71
CentOS Stream 8 will be archived
>and no further updates will be provided."
>
> Thus upgrade our CentOS Stream container to major version 9 now.
>
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Thomas Huth
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
6164
> < io_poll_ready
> 88/100 qemu:unit / test-nested-aio-pollOK
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/unit/test-nested-aio-poll.c | 7 ---
> 1 file changed, 7 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
gt; Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Thomas Huth
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
es, where
the last email I found from Peter was
https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg00574.html,
which asked to update MAINTAINERS to his new address, and that has not
made it in so far...
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
e '& (dbs->align -
1)' to avoid a hardware division, to match the original code; bug
QEMU_IS_ALIGNED does not require a power of two, so your choice of '%
dbs->align' seems reasonable.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
--
> include/qemu/uri.h | 99 ---
> util/uri.c | 1466
> util/meson.build |2 +-
> 3 files changed, 1 insertion(+), 1566 deletions(-)
> delete mode 100644 include/qemu/uri.h
> delete mode 100644 util/uri.c
Nice.
Revi
equal(qp_name, "host_key_check")) {
> +qdict_put_str(options, "host_key_check", qp_value);
> +} else {
> +warn_report("Unsupported parameter '%s' in URI.", qp_name);
Do we want the trailing '.' in warn_report?
}
> +if (parse_uint_full(qp_value, 0, )) {
> +error_setg(errp, "Illegal value for NFS parameter: %s",
...but since we're touching it, I prefer 'Invalid' over 'Illegal' (any
error message implying that you broke a law when you passed in bad
data is a bit aggressive). Not a show-stopper to leave it alone.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
mp() here
to match the RFC; again, worth a separate patch.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
On Fri, Apr 12, 2024 at 09:40:18AM -0500, Eric Blake wrote:
> > @@ -364,57 +363,57 @@ static int
> > qemu_gluster_parse_uri(BlockdevOptionsGluster *gconf,
> > QAPI_LIST_PREPEND(gconf->server, gsconf);
> >
> > /* transport */
> > -if (!uri-&
luster")) {
> +uri_scheme = g_uri_get_scheme(uri);
> +if (!uri_scheme || !strcmp(uri_scheme, "gluster")) {
Pre-existing, but per RFC 3986, we should probably be using strcasecmp
for scheme comparisons (I'm not sure if g_uri_parse guarantees a
lower-case return, even when the user passed in upper case). That can
be a separate patch.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
to those). So on that grounds, it is
okay for a function marked coroutine_fn to call another function not
marked coroutine_fn - it just makes the auditing harder to ensure that
you aren't violating your promise of no non-blocking calls.
It's too close to 9.0-rc3 for my comfort to include this patch series.
Even though this bug can cause wedged migrations, I'd feel more
comfortable with preparing the pull request for this series (including
your fix for dropping this one annotation) for 9.1 and for qemu-stable
once the release is complete.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
On Tue, Apr 09, 2024 at 09:30:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 08.04.24 19:00, Eric Blake wrote:
> > nbd_negotiate() is already marked coroutine_fn. And given the fix in
> > the previous patch to have nbd_negotiate_handle_starttls not create
> > and
option negotiation as also being
coroutine_fn.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Eric Blake
---
nbd/server.c | 102 +--
1 file changed, 59 insertions(+), 43 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c
index
the callback, whether or not it
required a yield or main loop.
Fixes: f95910f ("nbd: implement TLS support in the protocol negotiation")
Signed-off-by: Zhu Yangyang
[eblake: move callbacks to their use point, add assertions]
Signed-off-by: Eric Blake
---
nbd/nbd-internal.h | 10 -
v4 was here:
https://lists.gnu.org/archive/html/qemu-devel/2024-04/msg00624.html
Since then: add some asserts [Vladimir], add second patch with more
coroutine_fn annotations [Vladimir]
Eric Blake (1):
nbd/server: Mark negotiation functions as coroutine_fn
Zhu Yangyang (1):
nbd/server: do
On Mon, Apr 08, 2024 at 11:46:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 05.04.24 20:44, Eric Blake wrote:
> > From: Zhu Yangyang
> >
> > Coroutines are not supposed to block. Instead, they should yield.
> >
> > The client performs TLS upgrade
g
[eblake: move callbacks to their use point]
Signed-off-by: Eric Blake
---
v3: https://lists.gnu.org/archive/html/qemu-devel/2024-04/msg00375.html
in v4, factor even the struct to the .c files, avoiding a union [Vladimir]
nbd/nbd-internal.h | 10 --
nbd/client.c
On Fri, Apr 05, 2024 at 05:10:16PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 04.04.24 04:42, Eric Blake wrote:
> > From: Zhu Yangyang
> >
> > Coroutines are not supposed to block. Instead, they should yield.
> >
> > The client performs TLS upgrade
g
[eblake: move callbacks to their use point]
Signed-off-by: Eric Blake
---
After looking at this more, I'm less convinced that there is enough
common code here to even be worth trying to share in common.c. This
takes the essence of the v2 patch, but refactors it a bit.
v2: https://lists.gnu.o
t for an unconditional one time through the for loop body.
What's worse, different compiler versions will change behavior over
time. Making the code ugly to pacify a particular compiler, when that
compiler might improve in the future, is a form of chasing windmills.
>
> All in all, I
nlock(var), var2 = NULL)
>
>
> probably, it would be simpler for compiler to understand the logic this way.
> Could you check?
Wouldn't that attach __attribute__((cleanup(xxx))) to var2, at which
point we could cause the compiler to call xxx((void*)(true)) if the
user does an earl
nbd_server_tls_handshake,
>,
>NULL,
>NULL);
>
> - if (!data.complete) {
> -g_main_loop_run(data.loop);
> +while (!data.complete) {
> +qemu_coroutine_yield();
> }
> -g_main_loop_unref(data.loop);
> +
> if (data.error) {
> object_unref(OBJECT(tioc));
> error_propagate(errp, data.error);
> --
> 2.33.0
>
Thanks for the updated patch - it looks like we are heading in a good direction.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
t;socket". Maybe it is worth an explicit addition to the NBD URI spec
to mention that we intend to be case-sensitive (in the parts where it
can be; I'm not sure if the schema part must be handled
case-insensitively without re-reading the RFCs), and therefore that
'Socket=' does NOT have the same meaning as 'socket='.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
intentional change? No one
actually passes an explicit ":0" port on purpose, but we do have to
worry about malicious URIs.
> g_free(port_str);
> }
>
> out:
> if (qp) {
> -query_params_free(qp);
> +g_hash_table_destroy(qp);
> }
> -uri_free(uri);
> +g_uri_unref(uri);
> return ret;
It may be possible to eliminate the out label altogether, if
GHashTable has the appropriate auto-free magic.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
e-positive
> tests: fix -Werror=maybe-uninitialized
> hw/nvme: fix -Werror=maybe-uninitialized
> hw/virtio: fix -Werror=maybe-uninitialized
> RFC: hw/virtio: a potential leak fix
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
/client-connection.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
>
> diff --git a/nbd/client-connection.c b/nbd/client-connection.c
> index f9da67c87e..b11e266807 100644
> --- a/nbd/client-connection.c
> +++ b/nbd/client-connection.c
> @@
work has no spaces does not mean that your
S-o-b has to follow suit). It is also permissible to list your name
in native characters alongside or in place of the Anglicized version;
for example, 'git log --author="Stefano Dong"' shows this technique.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
`self != co' failed.
so I obviously got something wrong.
It may be possible to use block_gen_c to turn nbd_receive_negotiate
and nbd_receive_export_list into co_wrapper functions, if I can audit
that all of their code goes through qio (and is therefore
coroutine-safe), but that work is still ongoing.
At a
}
This now ignores all errors even on pre-existing fds where we NEED
non-blocking, rather than just the specific (expected) error we are
seeing on MacOS. Should this code be a bit more precise about
checking that -ret == EXXX for the expected errno value we are
ignoring for the specific fds
advertised, instead
of panicking?
> vmsg_set_reply_u64(vmsg, features);
> return true;
> }
> --
> 2.44.0
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
kay, although I might have used < instead of <=.
> +vu_panic(dev, "Error while writing: %s", strerror(errno));
> +return false;
> +}
At any rate, noticing the error is the correct thing to do.
> +
> if (vmsg->size) {
> do {
>
subprojects/libvhost-user/libvhost-user.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake
>
> diff --git a/subprojects/libvhost-user/libvhost-user.c
> b/subprojects/libvhost-user/libvhost-user.c
> index a879149fef..22bea0c775 100644
> --- a/subproject
;b...
s/b>->/b->/
> + */
> +if (!co->co_queue_next.sqe_next &&
> +self->co_queue_wakeup.sqh_last != >co_queue_next.sqe_next) {
> +QSIMPLEQ_INSERT_TAIL(>co_queue_wakeup, co, co_queue_next);
> + }
> } else {
&g
0 ++
> 2 files changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
gt; their beginning.
>
> [1]: Issue description in the commit message of commit ae7c80a7bd73
> ("error: New macro ERRP_GUARD()").
>
> Cc: Kevin Wolf
> Cc: Hanna Reitz
> Signed-off-by: Zhao Liu
> ---
> block/qcow2.c | 2 ++
> 1 file changed, 2 insertions
) at their beginning.
>
> [1]: Issue description in the commit message of commit ae7c80a7bd73
> ("error: New macro ERRP_GUARD()").
>
> Cc: Kevin Wolf
> Cc: Hanna Reitz
> Signed-off-by: Zhao Liu
> ---
> block.c | 4
> 1 file changed, 4 insertions
ropriate "the" here
> and there.
>
> Signed-off-by: Markus Armbruster
> ---
> docs/devel/writing-monitor-commands.rst | 32 -
> 1 file changed, 15 insertions(+), 17 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
gt; +struct with a string member. It is intended to be used for all
> +commands that are returning unstructured text targeted at
> +humans. These should all have feature 'unstable'. Note that the
> +feature's documentation states why the command is unstable. WE
We
> +commonly use a ``x-`` command name prefix to make lack of stability
> +obvious to human users.
>
Cleanups are trivial enough that I'm fine with you making them before
including:
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
.
>
> Signed-off-by: Markus Armbruster
> ---
> docs/about/deprecated.rst | 8
> qapi/char.json| 8 +---
> 2 files changed, 13 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
a.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/char.json | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
-char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
Might be worth amending the commit message of 1/4 where you called out
this bug to mention it will be fixed in the next patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
e
# if defined(__linux__) ... defined(__APPLE__)
# define HAVE_CHARDEV_SERIAL 1
# endif
# if defined(__linux__) ... defined(__DragonFly__)
# define HAVE_CHARDEV_PARALLEL 1
# endif
#endif
> +++ b/chardev/meson.build
> @@ -21,11 +21,9 @@ if host_os == 'windows'
> else
> chardev
ferent. But that's a
bigger task for gcc, and not one for this group.
>
> Signed-off-by: Richard W.M. Jones
> ---
> block/blkio.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
ame redundant in commit 901a34a400a (qapi: add 'If:'
> section to generated documentation) added the latter. Drop the
> former.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/misc-target.json | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Eric Blake
--
E
type" is ""event""
> Additional members depend on the value of "meta-type".
>
> The last line became redundant when commit 88f63467c57 (qapi2texi:
> Generate reference to base type members) added the lines preceding it.
> Drop it.
>
> Blockdev
I've made up my
> mind.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/block-export.json | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
ort makes sense.
>
> Signed-off-by: Andrey Drobyshev
> ---
> tests/qemu-iotests/271 | 1 +
> tests/qemu-iotests/308 | 2 ++
> tests/qemu-iotests/common.rc | 7 +++
> tests/qemu-iotests/tests/file-io-error | 1 +
> 4 files changed,
gt; This commit basically aligns iotests/264 with the rest of iotests.
>
> Signed-off-by: Andrey Drobyshev
> ---
> tests/qemu-iotests/264 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
>
> diff --git a/tests/qemu-iotests/264 b/tests
code-gen.txt
> docs/interop/bitmaps: Clean up a reference to qemu-qmp-ref
> qapi: Fix mangled "Returns" sections in documentation
> qapi: Indent tagged doc comment sections properly
> qapi: Fix malformed "Since:" section tags (again)
For the series:
Reviewe
gt; This commit basically aligns iotests/277 with the rest of iotests.
>
> Signed-off-by: Andrey Drobyshev
> ---
> tests/qemu-iotests/277 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
>
> diff --git a/tests/qemu-iotests/277 b/tests
defines SIZE_MAX with
> > * the wrong type. Our replacement isn't usable in preprocessor
> > * expressions, but it is sufficient for our needs. */
>
> Ccing some people who know more about portability concerns
> than I do...
>
> thanks
> -- PMM
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
ps of traceable binaries, with the obvious difference being the
generation of command:[] in a way that uses the correct prefixes per
tracable item.
And since I hit the problem of not being able to see trace output via
qemu-trace-stap on qemu-io, this makes sense.
Reviewed-by: Eric Blake
--
Eric B
make NBDClient->refcount atomic.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> nbd/server.c | 23 ++++++++---
> 1 file changed, 20 insertions(+), 3 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
ssion that
could lead to a bug; so I'm okay with your action there.
>
> Signed-off-by: Stefan Hajnoczi
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
On Wed, Nov 29, 2023 at 02:55:52PM -0500, Stefan Hajnoczi wrote:
> The AioContext lock no longer exists.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> include/qemu/job.h | 20
> 1 file changed, 20 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blak
> lock is unnecessary.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/scsi/scsi-disk.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
-
> 1 file changed, 15 insertions(+), 30 deletions(-)
>
> diff --git a/docs/devel/multiple-iothreads.txt
> b/docs/devel/multiple-iothreads.txt
> index a3e949f6b3..4865196bde 100644
> --- a/docs/devel/multiple-iothreads.txt
Reviewed-by: Eric Blake
--
Eric Blake,
the compiler to
> check whether the graph lock is being used correctly.
>
> And me, well, I'm just here to add some pizzazz to the QEMU multi-queue
> block layer :). Thank you to everyone who helped with this effort,
> including Eric Blake, code reviewer extraordinaire, and others who I'v
> ---
> include/block/aio-wait.h | 16
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
hw/scsi/scsi-disk.c | 28
> hw/scsi/virtio-scsi.c | 18 --
> 4 files changed, 4 insertions(+), 58 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
nless user opts in via environment variable.
> - */
> -if (getenv("QEMU_TEST_FLAKY_TESTS")) {
> -g_test_add_func("/blockjob/complete_in_standby",
> test_complete_in_standby);
> -}
Looks like you ripped out this entire test, because it is no longer
viable. I might have mentioned it in the commit message, or squashed
the removal of this test into the earlier 02/12 patch.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
apper.
Same long name as in 1/2; if we come up with a nicer name (my proposal
in 1/2 was backing-mask-protocol; but I'm open to others), we should
keep the two patches consistent.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
even when no image header
will be updated (default false; since 9.0).
or s/mask/hide/ if that sounds better.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
lock_ctx() becomes meaningless and they can be collapsed
> into one function.
>
> Signed-off-by: Stefan Hajnoczi
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
qemu_rec_mutex_unlock(>lock);
> +/* TODO remove this function */
> }
>
> QEMU_DEFINE_STATIC_CO_TLS(AioContext *, my_aiocontext)
> --
> 2.42.0
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
t; 1 file changed, 1 insertion(+), 66 deletions(-)
The rest of this series should not hold up 8.2.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
/virtio-scsi.h | 3 +-
> hw/scsi/virtio-scsi.c | 62 ++---
> 2 files changed, 43 insertions(+), 22 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
rs.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
--
> hw/scsi/scsi-generic.c | 20 +++-
> 2 files changed, 3 insertions(+), 40 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
text lock
> before.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/scsi/virtio-scsi-dataplane.c | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
26 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake
Are we trying to get this into 8.2, since it is a data corruption?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
s are executed from a single AioContext. Leave
> that as future work.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> include/hw/scsi/scsi.h | 7 +-
> hw/scsi/scsi-bus.c | 174 -
> 2 files changed, 124 insertions(+), 57 deletions(-)
>
amp; cond2)' for purposes of eliding the code for
cond2, that seems like a blatant missed optimization that we should be
reporting to the clang folks.
While this patch may solve the immediate issue, it does not scale - if
we ever have two separate guards that can both be independently
hard-coded to 0 based on configure-time decisions, but which are both
used as guards in the same expression, it will become impossible to
avoid a '(cond1 && 0 && cond2)' scenario across all 4 possible
configurations of those two guards.
I have no objection to the patch, but it would be nice if the commit
message could point to a clang bug report, if one has been filed.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
1 - 100 of 23025 matches
Mail list logo
