Re: [PULL v2 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-06-09 Thread Jeuk Kim
On 6/8/2024 12:02 AM, Peter Maydell wrote: On Mon, 3 Jun 2024 at 09:38, Jeuk Kim wrote: From: Minwoo Im This patch adds support for MCQ defined in UFSHCI 4.0. This patch utilized the legacy I/O codes as much as possible to support MCQ. MCQ operation & runtime register is placed at 0x

[PULL v2 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-06-03 Thread Jeuk Kim
(48B): UfsMcqSqReg, UfsMcqSqIntReg, UfsMcqCqReg, UfsMcqCqIntReg The maxinum number of queue is 32 as per spec, and the default MAC(Multiple Active Commands) are 32 in the device. Example: -device ufs,serial=foo,id=ufs0,mcq=true,mcq-maxq=8 Signed-off-by: Minwoo Im Reviewed-by: Jeuk Kim Mes

[PULL v2 0/2] ufs queue

2024-06-03 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit 74abb45dac6979e7ff76172b7f0a24e869405184: Merge tag 'pull-target-arm-20240531' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-05-31 11:10:10 -0700) are available in the Git repository at: https://gitlab.com/jeuk20

[PULL v2 1/2] hw/ufs: Update MCQ-related fields to block/ufs.h

2024-06-03 Thread Jeuk Kim
From: Minwoo Im This patch is a prep patch for the following MCQ support patch for hw/ufs. This patch updated minimal mandatory fields to support MCQ based on UFSHCI 4.0. Signed-off-by: Minwoo Im Reviewed-by: Jeuk Kim Message-Id: <20240528023106.856777-2-minwoo...@samsung.com> Sign

Re: [PULL 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-05-28 Thread Jeuk Kim
On 5/29/2024 2:06 AM, Richard Henderson wrote: On 5/27/24 23:12, Jeuk Kim wrote: From: Minwoo Im This patch adds support for MCQ defined in UFSHCI 4.0.  This patch utilized the legacy I/O codes as much as possible to support MCQ. MCQ operation & runtime register is placed at 0x1000 of

[PULL 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-05-28 Thread Jeuk Kim
(48B): UfsMcqSqReg, UfsMcqSqIntReg, UfsMcqCqReg, UfsMcqCqIntReg The maxinum number of queue is 32 as per spec, and the default MAC(Multiple Active Commands) are 32 in the device. Example: -device ufs,serial=foo,id=ufs0,mcq=true,mcq-maxq=8 Signed-off-by: Minwoo Im Reviewed-by: Jeuk Kim Mes

[PULL 1/2] hw/ufs: Update MCQ-related fields to block/ufs.h

2024-05-28 Thread Jeuk Kim
From: Minwoo Im This patch is a prep patch for the following MCQ support patch for hw/ufs. This patch updated minimal mandatory fields to support MCQ based on UFSHCI 4.0. Signed-off-by: Minwoo Im Reviewed-by: Jeuk Kim Message-Id: <20240528023106.856777-2-minwoo...@samsung.com> Sign

[PULL 0/2] ufs queue

2024-05-28 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit ad10b4badc1dd5b28305f9b9f1168cf0aa3ae946: Merge tag 'pull-error-2024-05-27' of https://repo.or.cz/qemu/armbru into staging (2024-05-27 06:40:42 -0700) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags

Re: [PATCH v2 0/2] hw/ufs: Add support MCQ

2024-05-27 Thread Jeuk Kim
++-- hw/ufs/ufs.h| 98 - include/block/ufs.h | 131 +++- 4 files changed, 702 insertions(+), 22 deletions(-) Thank you for the patch. Reviewed-by: Jeuk Kim

Re: [PATCH 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-05-27 Thread Jeuk Kim
Thanks for your contribution! There are only two minor comments. Please check it and send patch v2. Thank you! On 5/21/2024 8:05 PM, Minwoo Im wrote: @@ -1288,12 +1717,21 @@ static void ufs_exit(PCIDevice *pci_dev) ufs_clear_req(>req_list[i]); } g_free(u->req_list); +

[PULL 0/1] ufs queue

2024-04-28 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit fd87be1dada5672f877e03c2ca8504458292c479: Merge tag 'accel-20240426' of https://github.com/philmd/qemu into staging (2024-04-26 15:28:13 -0700) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs

[PULL 1/1] hw/ufs: Fix buffer overflow bug

2024-04-28 Thread Jeuk Kim
From: Jeuk Kim It fixes the buffer overflow vulnerability in the ufs device. The bug was detected by sanitizers. You can reproduce it by: cat << EOF |\ qemu-system-x86_64 \ -display none -machine accel=qtest -m 512M -M q35 -nodefaults -drive \ file=null-co://,if=none,id=disk0 -device

[PATCH] hw/ufs: Fix buffer overflow bug

2024-04-21 Thread Jeuk Kim
u Ma Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c index eccdb852a0..bac78a32bb 100644 --- a/hw/ufs/ufs.c +++ b/hw/ufs/ufs.c @@ -126,6 +126,10 @@ static MemTxResult ufs_dma_read_req_upiu(UfsRequest *req) co

[PATCH] hw/ufs: Raise interrupt on UIC power mode change

2024-01-21 Thread Jeuk Kim
This patch allows the qemu ufs to raise an interrupt on the DME_SET (PA_PWRMODE) command. Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c| 15 ++- include/block/ufs.h | 65 + 2 files changed, 79 insertions(+), 1 deletion(-) diff --git a/hw

Re: [PATCH 0/3] Support for Zoned UFS

2023-12-11 Thread Jeuk Kim
I've already done all the ufs related review. If the SCSI maintainers approve this patchset, I'll put it in my tree and create a pull request. Thank you, Jeuk On 12/8/2023 3:09 PM, Daejun Park wrote: This patch enables zoned support for UFS devices. By applying this patch, a QEMU run

Re: [PATCH 1/3] hw/ufs: Support for Zoned UFS

2023-12-11 Thread Jeuk Kim
commands for Zoned LUs. Signed-off-by: Daejun Park Reviewed-by: Jeuk Kim

Re: [PATCH 3/3] tests/qtest: Add tests for Zoned UFS

2023-12-11 Thread Jeuk Kim
On 12/8/2023 3:22 PM, Daejun Park wrote: This patch includes the following tests Test VPD page and report zones Test write and unaligned write error Signed-off-by: Daejun Park Reviewed-by: Jeuk Kim

[PULL 0/1] ufs fix for 2023-12-05

2023-12-04 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit 1664d74c50739401c8b40e8b514d12b5fc250067: tests/avocado: Update yamon-bin-02.22.zip URL (2023-12-04 08:17:35 -0500) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20231205 for you to fetch

[PULL 1/1] hw/ufs: avoid generating the same ID string for different LU devices

2023-12-04 Thread Jeuk Kim
34fea13a ("hw/ufs: Modify lu.c to share codes with SCSI subsystem") Signed-off-by: Akinobu Mita Reviewed-by: Jeuk Kim Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20231204150543.48252-1-akinobu.m...@gmail.com> Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 8 1 file changed

Re: [PATCH-for-8.2?] hw/ufs: avoid generating the same ID string for different LU devices

2023-12-04 Thread Jeuk Kim
Hi Philippe, Thank you for informing me. I want this issue is fixed for the 8.2 release. I created an issue like you said, but I couldn't assign the milestone (I'm guessing it's a permission problem). https://gitlab.com/qemu-project/qemu/-/issues/2018 Could you help me with this? Regardless,

Re: [PATCH-for-8.2?] hw/ufs: avoid generating the same ID string for different LU devices

2023-12-04 Thread Jeuk Kim
/scsi-disk" and ":00:04.0/0:0:0/scsi-disk") > > Fixes: 096434fea13a ("hw/ufs: Modify lu.c to share codes with SCSI subsystem") > Signed-off-by: Akinobu Mita Reviewed-by: Jeuk Kim Thank you!

Re: [PATCH trivial 19/21] tests/qtest/ufs-test.c: spelling fix: tranfer

2023-11-14 Thread Jeuk Kim
On 14/11/2023 17.58, Michael Tokarev wrote: > Fixes: 631c872614ac "tests/qtest: Introduce tests for UFS" > Cc: Jeuk Kim > Signed-off-by: Michael Tokarev > --- >   tests/qtest/ufs-test.c | 2 +- >   1 file changed, 1 insertion(+), 1 deletion(-) >  > diff --gi

Re: [PATCH trivial 14/21] include/block/ufs.h: spelling fix: setted

2023-11-14 Thread Jeuk Kim
On 14/11/2023 17.58, Michael Tokarev wrote: > Fixes: bc4e68d362ec "hw/ufs: Initial commit for emulated > Universal-Flash-Storage" > Cc: Jeuk Kim > Signed-off-by: Michael Tokarev > --- >  include/block/ufs.h | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] hw/ufs: Modify lu.c to share codes with SCSI subsystem

2023-10-30 Thread Jeuk Kim
On 10/30/2023 1:11 PM, Philippe Mathieu-Daudé wrote: Hi Jeuk, On 20/10/23 03:51, Jeuk Kim wrote: This patch removes the code that ufs-lu was duplicating from scsi-hd and allows them to share code. It makes ufs-lu have a virtual scsi-bus and scsi-hd internally. This allows scsi related

[PULL 1/1] hw/ufs: Modify lu.c to share codes with SCSI subsystem

2023-10-29 Thread Jeuk Kim
From: Jeuk Kim This patch removes the code that ufs-lu was duplicating from scsi-hd and allows them to share code. It makes ufs-lu have a virtual scsi-bus and scsi-hd internally. This allows scsi related commands to be passed thorugh to the scsi-hd. The query request and nop command work

[PULL 0/1] ufs queue

2023-10-29 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit c60be6e3e38cb36dc66129e757ec4b34152232be: Merge tag 'pull-sp-20231025' of https://gitlab.com/rth7680/qemu into staging (2023-10-27 09:43:53 +0900) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags/pull

[PATCH] hw/ufs: Modify lu.c to share codes with SCSI subsystem

2023-10-19 Thread Jeuk Kim
as the existing logic. Well-known lus do not have a virtual scsi-bus and scsi-hd, and handle the necessary scsi commands by emulating them directly. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c| 1473 +++- hw/ufs/trace-events| 25 - hw/ufs/ufs.c

[PULL v2 0/2] hw/ufs: fixes

2023-10-13 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: Merge tag 'pull-riscv-to-apply-20231012-1' of https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400) are available in the Git repository at: https://gitlab.com/jeuk20.kim

[PULL v2 1/2] hw/ufs: Fix code coverity issues

2023-10-13 Thread Jeuk Kim
From: Jeuk Kim Fixed four ufs-related coverity issues. The coverity issues and fixes are as follows 1. CID 1519042: Security issue with the rand() function Changed to use a fixed value (0xab) instead of rand() as the value for testing 2. CID 1519043: Dereference after null check Removed

[PULL v2 2/2] hw/ufs: Fix incorrect register fields

2023-10-12 Thread Jeuk Kim
From: Jeuk Kim This patch fixes invalid ufs register fields. This fixes an issue reported by Bin Meng that caused ufs to fail over riscv. Fixes: bc4e68d362ec ("hw/ufs: Initial commit for emulated Universal-Flash-Storage") Signed-off-by: Jeuk Kim Reported-by: Bin Meng Reviewed-by

[PULL 1/2] hw/ufs: Fix code coverity issues

2023-10-12 Thread Jeuk Kim
From: Jeuk Kim Fixed four ufs-related coverity issues. The coverity issues and fixes are as follows 1. CID 1519042: Security issue with the rand() function Changed to use a fixed value (0xab) instead of rand() as the value for testing 2. CID 1519043: Dereference after null check Removed

[PULL 0/2] hw/ufs: fixes

2023-10-12 Thread Jeuk Kim
From: Jeuk Kim The following changes since commit a51e5124a655b3dad80b36b18547cb1eca2c5eb2: Merge tag 'pull-omnibus-111023-1' of https://gitlab.com/stsquad/qemu into staging (2023-10-11 09:43:10 -0400) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags

[PULL 2/2] hw/ufs: Fix incorrect register fields

2023-10-12 Thread Jeuk Kim
From: Jeuk Kim This patch fixes invalid ufs register fields. This fixes an issue reported by Bin Meng that caused ufs to fail over riscv. Fixes: bc4e68d362ec ("hw/ufs: Initial commit for emulated Universal-Flash-Storage") Signed-off-by: Jeuk Kim Reported-by: Bin Meng Reviewed-by

[PATCH] hw/ufs: Fix incorrect register fields

2023-10-09 Thread Jeuk Kim
From: Jeuk Kim This patch fixes invalid ufs register fields. This fixes an issue reported by Bin Meng that caused ufs to fail over riscv. Signed-off-by: Jeuk Kim --- include/block/ufs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/ufs.h b/include/block

Ping: Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

2023-10-03 Thread Jeuk Kim
Dear Paolo This is a ping for the following. If you don't mind, could you give me some feedback? Thank you very much. Jeuk On 23. 9. 21. 17:38, Jeuk Kim wrote: Dear Paolo Hi. I've been looking into how ufs-lu can share code with scsi-hd. I have verified that ufs-lu can use scsi-hd's code

Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

2023-09-21 Thread Jeuk Kim
On 2023-09-15 4:59 PM, Paolo Bonzini wrote: On 9/15/23 00:19, Jeuk Kim wrote: First, ufs-lu has a feature called "unit descriptor". This feature shows the status of the ufs-lu and only works with UFS-specific "query request" commands, not SCSI commands. This looks lik

Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

2023-09-17 Thread Jeuk Kim
On 2023-09-18 오후 1:41, Jeuk Kim wrote: On 2023-09-15 16:59, Paolo Bonzini wrote: On 9/15/23 00:19, Jeuk Kim wrote: First, ufs-lu has a feature called "unit descriptor". This feature shows the status of the ufs-lu and only works with UFS-specific "query request" commands

Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

2023-09-17 Thread Jeuk Kim
On 2023-09-15 16:59, Paolo Bonzini wrote: On 9/15/23 00:19, Jeuk Kim wrote: First, ufs-lu has a feature called "unit descriptor". This feature shows the status of the ufs-lu and only works with UFS-specific "query request" commands, not SCSI commands. This looks lik

[PATCH] hw/ufs: Fix code coverity issues

2023-09-17 Thread Jeuk Kim
From: Jeuk Kim Fixed four ufs-related coverity issues. The coverity issues and fixes are as follows 1. CID 1519042: Security issue with the rand() function Changed to use a fixed value (0xab) instead of rand() as the value for testing 2. CID 1519043: Dereference after null check Removed

Re: [PULL 3/5] hw/ufs: Support for Query Transfer Requests

2023-09-14 Thread Jeuk Kim
On 23. 9. 14. 23:40, Peter Maydell wrote: On Thu, 7 Sept 2023 at 19:17, Stefan Hajnoczi wrote: From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off

Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

2023-09-14 Thread Jeuk Kim
On 23. 9. 15. 02:31, Paolo Bonzini wrote: On 9/7/23 20:16, Stefan Hajnoczi wrote: From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed

[PATCH v10 4/4] tests/qtest: Introduce tests for UFS

2023-09-06 Thread Jeuk Kim
From: Jeuk Kim This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi --- MAINTAINERS

[PATCH v10 2/4] hw/ufs: Support for Query Transfer Requests

2023-09-06 Thread Jeuk Kim
From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c

[PATCH v10 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-09-06 Thread Jeuk Kim
From: Jeuk Kim Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches

[PATCH v10 3/4] hw/ufs: Support for UFS logical unit

2023-09-06 Thread Jeuk Kim
From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/lu.c | 1445

[PATCH v10 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-09-06 Thread Jeuk Kim
ind_first_bit() function on big endian host pc. This fixes https://gitlab.com/qemu-project/qemu/-/jobs/4977256030 which is qos-test failure on s390x hosts. Please let me know if there are any problems. Thank you very much! Jeuk Jeuk Kim (4): hw/ufs: Initial commit for emulated Universal-Flash-Sto

Re: [PATCH v9 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-08-31 Thread Jeuk Kim
On 23. 8. 30. 20:38, Stefan Hajnoczi wrote: On Thu, 3 Aug 2023 at 07:49, Jeuk Kim wrote: Dear Stefan, I'm really sorry, but could you please put this patch series instead of v8, which was previously merged into block-next? The fixes from v8 are below. Please let me know if you have any

[PATCH v9 3/4] hw/ufs: Support for UFS logical unit

2023-08-03 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/lu.c | 1445

[PATCH v9 2/4] hw/ufs: Support for Query Transfer Requests

2023-08-03 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c| 980

[PATCH v9 4/4] tests/qtest: Introduce tests for UFS

2023-08-03 Thread Jeuk Kim
This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + tests

[PATCH v9 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-08-03 Thread Jeuk Kim
systems, I just skip the test for now, and leave it as a TODO. Jeuk Kim (4): hw/ufs: Initial commit for emulated Universal-Flash-Storage hw/ufs: Support for Query Transfer Requests hw/ufs: Support for UFS logical unit tests/qtest: Introduce tests for UFS MAINTAINERS |7

[PATCH v9 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-08-03 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- MAINTAINERS |6 + docs/specs/pci-ids.rst |2 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build

Re: [PATCH 0/3] hw/ufs: fix compilation warnings

2023-08-01 Thread Jeuk Kim
On 8/2/2023 6:03 AM, Philippe Mathieu-Daudé wrote: Hi Mike, On 28/7/23 01:34, Mike Maslenkin wrote: This patchset contains a trivial compilation fixes for UFS support applied to block-next tree. Since the series isn't merged, it would be clearer to send a v9 of "hw/ufs: Add Universal Flash

RE: [PATCH 0/3] hw/ufs: fix compilation warnings

2023-07-31 Thread Jeuk Kim
On 7/28/2023, Mike Maslenkin wrote: > This patchset contains a trivial compilation fixes for UFS support > applied to block-next tree. > > Cc: Jeuk Kim > Cc: Stefan Hajnoczi > Signed-off-by: Mike Maslenkin Thanks for letting me know. Reviewed-by: Jeuk Kim To Stefan, Co

[PATCH v8 2/4] hw/ufs: Support for Query Transfer Requests

2023-07-27 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c| 980

[PATCH v8 4/4] tests/qtest: Introduce tests for UFS

2023-07-27 Thread Jeuk Kim
This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + tests

[PATCH v8 3/4] hw/ufs: Support for UFS logical unit

2023-07-27 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/lu.c | 1445

[PATCH v8 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-07-27 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- MAINTAINERS |6 + docs/specs/pci-ids.rst |2 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build

[PATCH v8 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-27 Thread Jeuk Kim
new PCI-based UFS device. The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered in the Linux kernel yet, so it does not work right away, but I confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that it works with Windows 10. Jeuk Kim (4): hw/ufs: Initial com

Re: [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-26 Thread Jeuk Kim
On 7/27/2023 4:36 AM, Stefan Hajnoczi wrote: On Wed, Jul 26, 2023 at 02:30:49PM +0900, Jeuk Kim wrote: Since v6: - Add tests/qtest/ufs-test.c to test ufs initialisation and I/O - Add struct UtpTaskReqDesc to include/block/ufs.h - Fix ufs_log2() logic - Fix ufs-lu to use 4K as default block size

Re: [PATCH v7 4/4] tests/qtest: Introduce tests for UFS

2023-07-26 Thread Jeuk Kim
On 7/26/2023 4:21 PM, Thomas Huth wrote:  Hi! On 26/07/2023 07.30, Jeuk Kim wrote: This patch includes the following tests    Test mmio read    Test ufs device initialization and ufs-lu recognition    Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim

[PATCH v7 4/4] tests/qtest: Introduce tests for UFS

2023-07-25 Thread Jeuk Kim
This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim --- MAINTAINERS | 1 + tests/qtest/meson.build | 1 + tests/qtest/ufs-test.c | 575

[PATCH v7 2/4] hw/ufs: Support for Query Transfer Requests

2023-07-25 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c| 980

[PATCH v7 3/4] hw/ufs: Support for UFS logical unit

2023-07-25 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1445 ++ hw/ufs

[PATCH v7 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-07-25 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim --- MAINTAINERS |6 + docs/specs/pci-ids.rst |2 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build |1 + hw/ufs/trace-events

[PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-25 Thread Jeuk Kim
a new PCI-based UFS device. The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered in the Linux kernel yet, so it does not work right away, but I confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that it works with Windows 10. Jeuk Kim (4)

Re: [PATCH v6 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-22 Thread Jeuk Kim
On 7/21/2023 8:01 PM, Stefan Hajnoczi wrote: Is there a test case along the lines of tests/qtest/ahci-test.c that exercises this new code? It's important to have at least a basic test that initializes the device and performs a write followed by a read to verify that I/O is working. This will

[PATCH v6 3/3] hw/ufs: Support for UFS logical unit

2023-07-20 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1439 ++ hw/ufs

[PATCH v6 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-07-20 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim --- MAINTAINERS |6 + docs/specs/pci-ids.rst |2 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build |1 + hw/ufs/trace-events

[PATCH v6 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-20 Thread Jeuk Kim
evice. The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered in the Linux kernel yet, so it does not work right away, but I confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that it works with Windows 10. Jeuk Kim (3): hw/

[PATCH v6 2/3] hw/ufs: Support for Query Transfer Requests

2023-07-20 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c| 980

Re: [PATCH v5 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-20 Thread Jeuk Kim
On 7/21/2023 3:49 AM, Stefan Hajnoczi wrote: Hi, I'm ready to merge this but encountered a bug when testing: $ qemu-system-x86_64 --device ufs --device ufs-lu Segmentation fault (core dumped) Please ensure there is an error message like with SCSI disks: $ qemu-system-x86_64 --device

[PATCH v5 3/3] hw/ufs: Support for UFS logical unit

2023-07-18 Thread Jeuk Kim
From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1439

[PATCH v5 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-07-18 Thread Jeuk Kim
From: Jeuk Kim Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches

[PATCH v5 2/3] hw/ufs: Support for Query Transfer Requests

2023-07-18 Thread Jeuk Kim
From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c| 980

[PATCH v5 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-18 Thread Jeuk Kim
ay, but I confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that it works with Windows 10. Jeuk Kim (3): hw/ufs: Initial commit for emulated Universal-Flash-Storage hw/ufs: Support for Query Transfer Requests hw/ufs: Support for UFS logical

Re: PING: [PATCH v4 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-18 Thread Jeuk Kim
On 2023-07-19 오전 3:56, Stefan Hajnoczi wrote: On Tue, Jul 11, 2023 at 07:31:02PM +0900, Jeuk Kim wrote: Hi, Any more reviews...? Dear Stefan If you don't mind, Could you give it "reviewed-by"? And is there anything else I should do...? Sorry for the late reply. I was on vacat

PING: [PATCH v4 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-11 Thread Jeuk Kim
Hi, Any more reviews...? Dear Stefan If you don't mind, Could you give it "reviewed-by"? And is there anything else I should do...? Thanks, Jeuk On 2023-07-04 오후 5:33, Jeuk Kim wrote: From: Jeuk Kim Since v3: - Replace softmmu_ss -> system_ss in meson Since v2: Addressed r

[PATCH v4 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches

[PATCH v4 2/3] hw/ufs: Support for Query Transfer Requests

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events |1 + hw/ufs/ufs.c| 1005

[PATCH v4 3/3] hw/ufs: Support for UFS logical unit

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441

[PATCH v4 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim Since v3: - Replace softmmu_ss -> system_ss in meson Since v2: Addressed review comment from Stefan Hajnoczi. The main fixes are as follows. - Use of SPDX licence identifiers - fixed endianness error - removed memory leak - fixed DMA error handling logic Since v1: - use mac

[PATCH v3 3/3] hw/ufs: Support for UFS logical unit

2023-06-21 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441 ++ hw/ufs

[PATCH v3 2/3] hw/ufs: Support for Query Transfer Requests

2023-06-21 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events |1 + hw/ufs/ufs.c| 1005

[PATCH v3 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-06-21 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim --- MAINTAINERS |6 + docs/specs/pci-ids.rst |2 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build |1 + hw/ufs/trace-events

[PATCH v3 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-06-21 Thread Jeuk Kim
(PCI_DEVICE_ID_REDHAT_UFS) is not registered in the Linux kernel yet, so it does not work right away, but I confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that it works with Windows 10. Jeuk Kim (3): hw/ufs: Initial commit for emulated Universal-Flash

Re: [PATCH v2 3/3] hw/ufs: Support for UFS logical unit

2023-06-19 Thread Jeuk Kim
On Fri, Jun 19, 2023, Stefan Hajnoczi wrote: >On Fri, Jun 16, 2023 at 03:58:27PM +0900, Jeuk Kim wrote: >> This commit adds support for ufs logical unit. >> The LU handles processing for the SCSI command, >> unit descriptor query request. >> >> This commit enable

Re: [PATCH v2 2/3] hw/ufs: Support for Query Transfer Requests

2023-06-19 Thread Jeuk Kim
On Fri, Jun 19, 2023, Stefan Hajnoczi wrote: >On Fri, Jun 16, 2023 at 03:58:25PM +0900, Jeuk Kim wrote: >> This commit makes the UFS device support query >> and nop out transfer requests. >> >> The next patch would be support for UFS logical >> unit

Re: [PATCH v2 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-06-19 Thread Jeuk Kim
On Fri, Jun 16, 2023, Stefan Hajnoczi wrote: >On Fri, Jun 16, 2023 at 03:58:21PM +0900, Jeuk Kim wrote: >> Universal Flash Storage (UFS) is a high-performance mass storage device >> with a serial interface. It is primarily used as a high-performance >> data storage device for

[PATCH v2 2/3] hw/ufs: Support for Query Transfer Requests

2023-06-16 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 968 ++- hw/ufs/ufs.h | 45 +++ 2

[PATCH v2 3/3] hw/ufs: Support for UFS logical unit

2023-06-16 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441 ++ hw/ufs

[PATCH v2 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-06-16 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim --- MAINTAINERS |6 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build |1 + hw/ufs/trace-events | 33 ++ hw/ufs/trace.h

[PATCH v2 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-06-16 Thread Jeuk Kim
confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that it works with Windows 10. Jeuk Kim (3): hw/ufs: Initial commit for emulated Universal-Flash-Storage hw/ufs: Support for Query Transfer Requests hw/ufs: Support for UFS logical unit M

Re: [PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-31 Thread Jeuk Kim
Hi Philippe, >Hi Jeuk, > >[+Alistair] > >On 26/5/23 07:05, Jeuk Kim wrote: >> Universal Flash Storage (UFS) is a high-performance mass storage device >> with a serial interface. It is primarily used as a high-performance >> data storage device for embedded

Re: [PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-29 Thread Jeuk Kim
On 26/05/2023 15:37, Thomas Huth wrote: >On 26/05/2023 07.05, Jeuk Kim wrote: >> Universal Flash Storage (UFS) is a high-performance mass storage device >> with a serial interface. It is primarily used as a high-performance >> data storage device for embedded application

[PATCH 3/3] hw/ufs: Support for UFS logical unit

2023-05-25 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441 ++ hw/ufs

[PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-25 Thread Jeuk Kim
unit and Transfer Request will follow. Signed-off-by: Jeuk Kim --- MAINTAINERS |6 + hw/Kconfig |1 + hw/meson.build |1 + hw/ufs/Kconfig |4 + hw/ufs/meson.build |1 + hw/ufs/trace-events | 33 + hw/ufs/trace.h

[PATCH 2/3] hw/ufs: Support for Query Transfer Requests

2023-05-25 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 967 ++- hw/ufs/ufs.h | 45 +++ 2

[PATCH 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-05-25 Thread Jeuk Kim
that it works with Windows 10. Jeuk Kim (3): hw/ufs: Initial commit for emulated Universal-Flash-Storage hw/ufs: Support for Query Transfer Requests hw/ufs: Support for UFS logical unit MAINTAINERS |6 + hw/Kconfig |1 + hw/meson.build |1 + hw