Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

de" folder is obviously missing here - no clue how this could > have worked before? > > Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import > list") > Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Paolo you merged the of

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

t; a new set of target headers into it. > > Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin who's merging this? > --- > scripts/update-linux-headers.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-li

Re: [PATCH for 9.1 v9 00/11] hw/pci: SR-IOV related fixes and improvements

cial hacks like on/off/auto. > [1]: https://patchew.org/QEMU/20231210-sriov-v2-0-b959e8a6d...@daynix.com/ > > Signed-off-by: Akihiko Odaki > --- > Changes in v9: > - Rebased. > - Restored '#include "qapi/error.h"' (Michael S. Tsirkin) > - Added patch "p

Re: [PATCH] intel_iommu: Use the latest fault reasons defined by spec

: [PATCH] intel_iommu: Use the latest fault reasons > >defined > >>by > >>> >> >spec > >>> >> > > >>> >> >On Mon, May 20, 2024 at 12:15 PM Liu, Yi L > >>wrote: > >>> >> >> > >>> >> >

Re: [PATCH] intel_iommu: Use the latest fault reasons defined by spec

On Mon, May 27, 2024 at 02:32:46PM +0800, Yi Liu wrote: > Folks, looks like it's not necessary to be aligned with spec version. > e.g. I can see something like below. This is an old machine which is > not possible to be built according to vt-d spec 4.0. Let me check more > machines as well to

Re: [PATCH] intel_iommu: Use the latest fault reasons defined by spec

On Mon, May 27, 2024 at 06:04:42AM +, Duan, Zhenzhong wrote: > But I'm not sure if there is a real scenario migrating to old qemu, > why not just update qemu on destination? Because you can not just update a huge cluster atomically. -- MST

Re: [RFC PATCH] docs: Enhance documentation for iommu bypass

On Wed, May 22, 2024 at 03:40:08PM +0800, Aaron Lu wrote: > When Intel vIOMMU is used and irq remapping is enabled, using > bypass_iommu will cause following two callstacks dumped during kernel > boot and all PCI devices attached to root bridge lose their MSI > capabilities and fall back to using

Re: [PATCH v3 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region

.flash0 0002-0003 > >memory-region: smram > 000a-000b (prio 0, ram): alias smram-low > @pc.ram 000a-000b > > Note that in both cases the "system" memory region contains the entry >

Re: [PATCH v2 0/3] docs: define policy forbidding use of "AI" / LLM code generators

On Thu, May 16, 2024 at 06:34:13PM +0100, Peter Maydell wrote: > On Thu, 16 May 2024 at 18:20, Michael S. Tsirkin wrote: > > > > On Thu, May 16, 2024 at 05:22:27PM +0100, Daniel P. Berrangé wrote: > > > AFAICT at its current state of (im)maturity the question of li

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

On Thu, May 16, 2024 at 06:29:39PM +0100, Peter Maydell wrote: > On Thu, 16 May 2024 at 17:22, Daniel P. Berrangé wrote: > > > > Currently we have a short paragraph saying that patches must include > > a Signed-off-by line, and merely link to the kernel documentation. > > The linked kernel docs

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

On Thu, May 16, 2024 at 05:22:28PM +0100, Daniel P. Berrangé wrote: > Currently we have a short paragraph saying that patches must include > a Signed-off-by line, and merely link to the kernel documentation. > The linked kernel docs have a lot of content beyond the part about > sign-off an thus

Re: [PATCH v2 0/3] docs: define policy forbidding use of "AI" / LLM code generators

On Thu, May 16, 2024 at 05:22:27PM +0100, Daniel P. Berrangé wrote: > This patch kicks the hornet's nest of AI / LLM code generators. > > With the increasing interest in code generators in recent times, > it is inevitable that QEMU contributions will include AI generated > code. Thus far we have

Re: [PATCH v2 3/3] docs: define policy forbidding use of AI code generators

On Thu, May 16, 2024 at 05:22:30PM +0100, Daniel P. Berrangé wrote: > There has been an explosion of interest in so called AI code generators > in the past year or two. Thus far though, this is has not been matched > by a broadly accepted legal interpretation of the licensing implications > for

Re: [PATCH v2 2/3] docs: define policy limiting the inclusion of generated files

On Thu, May 16, 2024 at 05:22:29PM +0100, Daniel P. Berrangé wrote: > Files contributed to QEMU are generally expected to be provided in the > preferred format for manipulation. IOW, we generally don't expect to > have generated / compiled code included in the tree, rather, we expect > to run the

Re: [PATCH v3 5/5] virtio-gpu: fix v2 migration

On Wed, May 15, 2024 at 10:31:32AM -0600, Peter Xu wrote: > On Wed, May 15, 2024 at 12:02:49PM -0400, Michael S. Tsirkin wrote: > > On Wed, May 15, 2024 at 06:15:56PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Commi

Re: [PATCH v3 4/5] Set major/minor for PC and arm machines

On Wed, May 15, 2024 at 06:15:55PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau I would much rather compat machinery was in one place as opposed to being spread all over the codebase as this new API would encourage. > --- >

Re: [PATCH v3 5/5] virtio-gpu: fix v2 migration

On Wed, May 15, 2024 at 06:15:56PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Commit dfcf74fa ("virtio-gpu: fix scanout migration post-load") broke > forward/backward version migration. Versioning of nested VMSD structures > is not straightforward, as the wire format

Re: [PATCH 00/11] maintainer updates (plugins, testing) pre-PR

On Tue, May 14, 2024 at 06:42:42PM +0100, Alex Bennée wrote: > This is mostly plugin related stuff which is all ready to go however > I have a few miscellaneous testing updates which would appreciate the > review. Reviewed-by: Michael S. Tsirkin > Thanks. > > Alex Bennée

Re: [PATCH v2 1/2] Revert "vhost-user: fix lost reconnect"

On Mon, May 13, 2024 at 03:10:47PM +0800, Li Feng wrote: > This reverts commit f02a4b8e6431598612466f76aac64ab492849abf. > include subject of reverted commit and motivation for the revert pls. > Signed-off-by: Li Feng > --- > hw/block/vhost-user-blk.c | 2 +- >

Re: [PATCH v2 1/3] qtest: allow SPCR acpi table changes

On Mon, May 13, 2024 at 01:55:50PM +1000, Alistair Francis wrote: > On Tue, May 7, 2024 at 3:24 PM Sia Jee Heng > wrote: > > Can you describe why you are doing this and that it will be reverted > in the commit message? > > Alistair What motivation are you asking? This follows the normal acpi

Re: [PATCH v2 2/3] hw/acpi: Upgrade ACPI SPCR table to support SPCR table version 4 format

On Mon, May 06, 2024 at 10:22:11PM -0700, Sia Jee Heng wrote: > Update the SPCR table to accommodate the SPCR Table version 4 [1]. > The SPCR table has been modified to adhere to the version 4 format [2]. > > [1]: >

Re: [PATCH 3/4] virtio-gpu: use a VMState variant for the scanout field

On Tue, May 07, 2024 at 03:19:19PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Depending on the version, use v1 or v2 of the scanout VM state. > > Signed-off-by: Marc-André Lureau > --- > hw/display/virtio-gpu.c | 22 +- > 1 file changed, 17

Re: [RFC QEMU PATCH v9 1/2] virtio-pci: only reset pm state during resetting

On Tue, Apr 16, 2024 at 03:01:26PM +0800, Jiqian Chen wrote: > Fix bug imported by 27ce0f3afc9dd25d21b43bbce505157afd93d111 > (fix Power Management Control Register for PCI Express virtio devices) should be: 27ce0f3afc9dd ("fix Power Management Control Register for PCI Express virtio devices"

Re: [PATCH] hw/virtio: Fix obtain the buffer id from the last descriptor

On Wed, May 08, 2024 at 02:56:11PM +0200, Eugenio Perez Martin wrote: > On Mon, Apr 22, 2024 at 3:41 AM Wafer wrote: > > > > The virtio-1.3 specification > > writes: > > 2.8.6 Next Flag: Descriptor Chaining > > Buffer ID is

Re: [PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto

On Sun, Apr 28, 2024 at 04:21:06PM +0900, Akihiko Odaki wrote: > Based-on: <20240428-rss-v10-0-73cbaa91a...@daynix.com> > ("[PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements") > > Some features are not always available, and virtio-net used to disable > them when not available

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

On Thu, Apr 25, 2024 at 01:15:43PM +0200, Philippe Mathieu-Daudé wrote: > On 25/4/24 12:40, Mark Cave-Ayland wrote: > > On 25/04/2024 11:26, Manos Pitsidianakis wrote: > > > > > On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: > > > > > > &g

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

On Thu, Apr 25, 2024 at 01:26:38PM +0300, Manos Pitsidianakis wrote: > On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: > > > > On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote: > > > On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland > > >

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

gt; > >> > > >> On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: > > >> > > >>> On 23/4/24 11:18, Manos Pitsidianakis wrote: > > >>>> On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis > > >>>> wrote: > >

Re: [PATCH 0/4] X86: Alias isa-bios area and clean up

On Mon, Apr 22, 2024 at 10:06:21PM +0200, Bernhard Beschow wrote: > This series changes the "isa-bios" MemoryRegion to be an alias rather than a > copy in the pflash case. This fixes issuing pflash commands in the isa-bios > region which matches real hardware and which some real-world legacy

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: > On 22/4/24 23:02, Michael S. Tsirkin wrote: > > On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: > > > Since VirtIO devices can change endianness at runtime, > > > we need t

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: > Since VirtIO devices can change endianness at runtime, > we need to use the device endianness, not the target > one. > > Cc: qemu-sta...@nongnu.org > Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams") >

Re: [PATCH] vhost-user-test: no set non-blocking for cal fd less than 0.

On Thu, Apr 11, 2024 at 03:35:55PM +0800, Yuxue Liu yuxue@jaguarmicro.com wrote: > From: Yuxue Liu > > In the scenario where vhost-user sets eventfd to -1, > qemu_chr_fe_get_msgfds retrieves fd as -1. When vhost_user_read > receives, it does not perform blocking operations on the descriptor

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

On Tue, Apr 16, 2024 at 02:14:57PM +0100, Peter Maydell wrote: > On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > > wrote: > > > > > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > > > > > In function kvm_virtio_pci_vector_use_one(),

[PULL 1/1] virtio-pci: fix use of a released vector

-ID: <2321ade5f601367efe7380c04e3f61379c59b48f.1713173550.git@redhat.com> Cc: Lei Yang Cc: Jason Wang Signed-off-by: Michael S. Tsirkin Tested-by: Cindy Lu --- hw/virtio/virtio-pci.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff

[PULL 0/1] virtio: bugfix

changes up to 2ce6cff94df2650c460f809e5ad263f1d22507c0: virtio-pci: fix use of a released vector (2024-04-15 06:50:44 -0400) virtio: bugfix A last minute fix for a use of a vector after it's released. Signed-off-by: Michael S

Re: [PATCH v2] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

On Mon, Apr 15, 2024 at 05:51:56AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 15, 2024 at 11:44:50AM +0200, Paolo Bonzini wrote: > > Queued, thanks. > > > > Paolo > > I actually had it queued too - it's not 9.0 material though. > If you queue it don't forget to

Re: [PATCH v2] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

On Mon, Apr 15, 2024 at 11:44:50AM +0200, Paolo Bonzini wrote: > Queued, thanks. > > Paolo I actually had it queued too - it's not 9.0 material though. If you queue it don't forget to tweak the commit log manually. -- MST

[PATCH v8] virtio-pci: fix use of a released vector

start_thread (arg=) at pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 (gdb) MST: coding style and typo fixups Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") Cc: qemu-sta...@nongnu.org Signed-off-by: Cindy Lu Message

Re: [PATCH v7] virtio-pci: Fix the crash that the vector was used after released.

On Mon, Apr 15, 2024 at 11:23:46AM +0200, Philippe Mathieu-Daudé wrote: > On 15/4/24 11:19, Michael S. Tsirkin wrote: > > From: Cindy Lu > > > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows:

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

On Mon, Apr 15, 2024 at 05:11:05PM +0800, Cindy Lu wrote: > On Mon, Apr 15, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > > > On Fri, Apr 12, 2024 at 02:26:55PM +0800, Cindy Lu wrote: > > > During the booting process of the non-standard image, the behavior of the >

[PATCH v7] virtio-pci: Fix the crash that the vector was used after released.

start_thread (arg=) at pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 (gdb) MST: coding style and typo fixups Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") Cc: qemu-sta...@nongnu.org Signed-off-by: Cindy Lu Message

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

42f205e0) at > ../accel/kvm/kvm-accel-ops.c:51 > 21 0x5606411949f4 in qemu_thread_start (args=0x560642f292b0) at > ../util/qemu-thread-posix.c:541 > 22 0x00007fc87148cdcd in start_thread (arg=) at > pthread_create.c:442 > 23 0x7fc871512630 in clone3 () at > ../sysdeps/uni

Re: Discrepancy between mmap call on DPDK/libvduse and rust vm-memory crate

On Fri, Apr 12, 2024 at 12:15:40PM +0200, Eugenio Perez Martin wrote: > Hi! > > I'm building a bridge to expose vhost-user devices through VDUSE. The > code is still immature but I'm able to forward packets using > dpdk-l2fwd through VDUSE to VM. I'm now developing exposing virtiofsd, > but I've

Re: [PATCH v4] virtio-pci: Fix the crash that the vector was used after released.

On Thu, Apr 11, 2024 at 12:11:30PM +0800, Cindy Lu wrote: > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function > virtio_pci_set_guest_notifiers() with

Re: [PATCH v3] virtio-pci: Fix the crash that the vector was used after released.

On Thu, Apr 11, 2024 at 12:12:00AM +0800, Cindy Lu wrote: > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function > virtio_pci_set_guest_notifiers() with

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

On Wed, Apr 10, 2024 at 12:35:13PM +0200, Gerd Hoffmann wrote: > On Wed, Apr 10, 2024 at 03:26:29AM -0400, Michael S. Tsirkin wrote: > > On Wed, Apr 10, 2024 at 09:21:26AM +0200, Gerd Hoffmann wrote: > > > If the binary loaded via -kernel is *not* a linux kernel (in which > &

Re: [PATCH] x86/loader: only patch linux kernels

On Wed, Apr 10, 2024 at 09:21:26AM +0200, Gerd Hoffmann wrote: > If the binary loaded via -kernel is *not* a linux kernel (in which > case protocol == 0), do not patch the linux kernel header fields. > > It's (a) pointless and (b) might break binaries by random patching > and (c) changes the

Re: [PATCH 1/1] virtio-net: fix bug 1451 aka "assert(!virtio_net_get_subqueue(nc)->async_tx.elem);"

On Tue, Apr 09, 2024 at 07:37:04PM +0300, Alexey Dobriyan wrote: > On Tue, Apr 09, 2024 at 02:51:38AM -0400, Michael S. Tsirkin wrote: > > On Fri, Apr 05, 2024 at 02:20:15PM +0300, Alexey Dobriyan wrote: > > > Don't send zero length packets in virtio_net_flush_tx(). > >

Re: [PATCH-for-9.0 v2 0/4] hw/virtio: Protect from more DMA re-entrancy bugs

> works seamlessly with CCW devices (actually the original > code from Gerd). > - Build and test :> > > I'll send a PR with these patches later today. I reviewed these too now Reviewed-by: Michael S. Tsirkin > Regards, > > Phil. > > Philippe Mathieu-Daudé (4): &

Re: [PATCH v2] vhost: don't set vring call if guest notifiers is not enabled

On Mon, Apr 08, 2024 at 03:33:11PM +0800, lyx634449800 wrote: > When conducting performance testing using testpmd in the guest os, > it was observed that the performance was lower compared to the > scenario of direct vfio-pci usage. > > In the commit 96a3d98d2cdbd897ff5ab33427aa4cfb94077665, the

Re: [PATCH] vhost: don't set vring call if no enabled msix

On Mon, Apr 08, 2024 at 02:08:42PM +0800, lyx634449800 wrote: > When conducting performance testing using testpmd in the guest os, > it was observed that the performance was lower compared to the > scenario of direct vfio-pci usage. > > In the virtual machine operating system, even if the virtio

[PULL 6/7] vhost-user-blk: simplify and fix vhost_user_blk_handle_config_change

e guest unconditionally. So, no reason to create extra branches in the logic. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Raphael Norwitz Message-Id: <20240329183758.3360733-2-vsement...@yandex-team.ru> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- h

[PULL 3/7] virtio-snd: rewrite invalid tx/rx message handling

ied before the handler returns, so the queue must be empty at any other point of the device's lifetime. Signed-off-by: Manos Pitsidianakis Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/audio/virtio-snd.h | 16 +++- hw/audio/virtio-sn

[PULL 5/7] vdpa-dev: Fix the issue of device status not updating when configuration interruption is triggered

xue@jaguarmicro.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vdpa-dev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c index 13e87f06f6..64b96b226c 100644 --- a/hw/virtio/vdpa-dev.c +++ b/hw/virtio/vdpa

[PULL 4/7] hw/virtio: Fix packed virtqueue flush used_idx

uld be the value of 'vq->used_idx' plus 'ndescs'. Fixes: 86044b24e8 ("virtio: basic packed virtqueue support") Acked-by: Eugenio Pérez Signed-off-by: Wafer Message-Id: <20240407015451.5228-2-wa...@jaguarmicro.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- h

[PULL 2/7] virtio-snd: Enhance error handling for invalid transfers

yum...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/audio/virtio-snd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index e604d8f30c..30493f06a8 100644 --- a/hw/audio/virtio

[PULL 7/7] qdev-monitor: fix error message in find_device_state()

758.3360733-3-vsement...@yandex-team.ru> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- system/qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index c1243891c3..840177d19f 100644 --- a/system/qdev

[PULL 1/7] Revert "hw/virtio: Add support for VDPA network simulation devices"

This reverts commit cd341fd1ffded978b2aa0b5309b00be7c42e347c. The patch adds non-upstream code in include/standard-headers/linux/virtio_pci.h which would make maintainance harder. Revert for now. Suggested-by: Jason Wang Message-Id: Acked-by: Jason Wang Signed-off-by: Michael S. Tsirkin

[PULL 0/7] virtio,pc,pci: bugfixes

ones. Revert VDPA network sim for this release as there are questions around it's maintainatiblity. Signed-off-by: Michael S. Tsirkin Manos Pitsidianakis (1): virtio-snd: rewrite invalid tx/rx message handling Michael S

Re: [PATCH 1/1] virtio-net: fix bug 1451 aka "assert(!virtio_net_get_subqueue(nc)->async_tx.elem);"

On Fri, Apr 05, 2024 at 02:20:15PM +0300, Alexey Dobriyan wrote: > Don't send zero length packets in virtio_net_flush_tx(). > > Reproducer from https://gitlab.com/qemu-project/qemu/-/issues/1451 > creates small packet (1 segment, len = 10 == n->guest_hdr_len), > destroys queue. > > "if

Re: [PATCH 1/1] virtio-net: fix bug 1451 aka "assert(!virtio_net_get_subqueue(nc)->async_tx.elem);"

On Fri, Apr 05, 2024 at 02:20:15PM +0300, Alexey Dobriyan wrote: > Don't send zero length packets in virtio_net_flush_tx(). > > Reproducer from https://gitlab.com/qemu-project/qemu/-/issues/1451 > creates small packet (1 segment, len = 10 == n->guest_hdr_len), > destroys queue. > > "if

Re: [PATCH] virtio-iommu: Do not process commands with bad size

On Thu, Apr 04, 2024 at 02:45:05PM +0200, Zheyu Ma wrote: > The device should not handle the commands which have bad request/reply > size, it should just report the error instead of raising an assertation. > > Signed-off-by: Zheyu Ma This fails test for cross-i686-tci

Re: [PATCH] Revert "hw/virtio: Add support for VDPA network simulation devices"

On Mon, Apr 08, 2024 at 10:11:18PM +0200, Paolo Bonzini wrote: > > > Il lun 8 apr 2024, 12:18 Michael S. Tsirkin ha scritto: > > On Mon, Apr 08, 2024 at 10:51:57AM +0100, Peter Maydell wrote: > > On Mon, 8 Apr 2024 at 10:48, Michael S. Tsirkin wrote: > &g

Re: [PATCH-for-9.0 3/4] hw/char/virtio-serial-bus: Protect from DMA re-entrancy bugs

On Mon, Apr 08, 2024 at 01:04:11PM +0200, Philippe Mathieu-Daudé wrote: > On 8/4/24 12:08, Michael S. Tsirkin wrote: > > On Mon, Apr 08, 2024 at 09:14:39AM +0200, Philippe Mathieu-Daudé wrote: > > > On 4/4/24 21:13, Philippe Mathieu-Daudé wrote: > > > &g

Re: [PATCH] Revert "hw/virtio: Add support for VDPA network simulation devices"

On Mon, Apr 08, 2024 at 10:51:57AM +0100, Peter Maydell wrote: > On Mon, 8 Apr 2024 at 10:48, Michael S. Tsirkin wrote: > > > > This reverts commit cd341fd1ffded978b2aa0b5309b00be7c42e347c. > > > > The patch adds non-upstream code in > > include/standard-headers/l

Re: [PATCH 1/2] virtio-net: Fix vhost virtqueue notifiers for RSS

is set to true either of VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS is > enabled. > > Fixes: 68b0a6395f36 ("virtio-net: align ctrl_vq index for non-mq guest for > vhost_vdpa") > Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin Jason, are you merging this? &g

Re: [PATCH-for-9.0 3/4] hw/char/virtio-serial-bus: Protect from DMA re-entrancy bugs

On Mon, Apr 08, 2024 at 09:14:39AM +0200, Philippe Mathieu-Daudé wrote: > On 4/4/24 21:13, Philippe Mathieu-Daudé wrote: > > Replace qemu_bh_new_guarded() by virtio_bh_new_guarded() > > so the bus and device use the same guard. Otherwise the > > DMA-reentrancy protection can be bypassed. > > > >

[PATCH] Revert "hw/virtio: Add support for VDPA network simulation devices"

This reverts commit cd341fd1ffded978b2aa0b5309b00be7c42e347c. The patch adds non-upstream code in include/standard-headers/linux/virtio_pci.h which would make maintainance harder. Revert for now. Suggested-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-pci.h

Re: [PATCH 1/1] virtio-pci: Fix the crash when the vector changes back from VIRTIO_NO_VECTOR

On Sun, Apr 07, 2024 at 12:19:57PM +0800, Jason Wang wrote: > On Tue, Apr 2, 2024 at 11:02 PM Cindy Lu wrote: > > > > When the guest calls virtio_stop and then virtio_reset, > > Guests could not call those functions directly, it is triggered by for > example writing to some of the registers like

Re: [RFC QEMU PATCH v8 2/2] virtio-pci: implement No_Soft_Reset bit

On Sun, Apr 07, 2024 at 11:20:57AM +0800, Jason Wang wrote: > On Tue, Apr 2, 2024 at 11:03 AM Chen, Jiqian wrote: > > > > On 2024/3/29 18:44, Michael S. Tsirkin wrote: > > > On Fri, Mar 29, 2024 at 03:20:59PM +0800, Jason Wang wrote: > > >> On Fri, Mar 29,

Re: [PATCH v1 0/1] virtio-snd: fix invalid tx/rx message handling logic

On Fri, Apr 05, 2024 at 01:54:46PM +0300, Manos Pitsidianakis wrote: > ping confused at this point. Do you mind sending a patchset with everything in the correct order? Tag it PATCH repost so people know nothing changed. Thanks! -- MST

Re: [PATCH] virtio-iommu: Do not process commands with bad size

On Thu, Apr 04, 2024 at 02:45:05PM +0200, Zheyu Ma wrote: > The device should not handle the commands which have bad request/reply > size, it should just report the error instead of raising an assertation. > > Signed-off-by: Zheyu Ma I do not get what problem you are trying to solve here. Can

Re: [PATCH] hw/virtio: Fix packed virtqueue flush used_idx

On Wed, Mar 27, 2024 at 02:15:18PM +0800, Wafer wrote: > For indirect descriptors the elelm->ndescs was one, > For direct descriptors the elele->ndesc was the numbe of entries. > elem->ndescs = (desc_cache == _desc_cache) ? 1 : elem_entries; > > When flushing multiple elemes, > the used_idx

Re: [PATCH] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

On Tue, Apr 02, 2024 at 09:18:44PM +0800, Xiaoyao Li wrote: > On 4/2/2024 6:02 PM, Michael S. Tsirkin wrote: > > On Tue, Apr 02, 2024 at 04:25:16AM -0400, Xiaoyao Li wrote: > > > Set MADT.FLAGS[bit 0].PCAT_COMPAT based on x86ms->pic. > > > > > > Signed-off-

Re: [PATCH] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

On Tue, Apr 02, 2024 at 04:25:16AM -0400, Xiaoyao Li wrote: > Set MADT.FLAGS[bit 0].PCAT_COMPAT based on x86ms->pic. > > Signed-off-by: Xiaoyao Li Please include more info in the commit log: what is the behaviour you observe, why it is wrong, how does the patch fix it, what is guest behaviour

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

ses guest kernel stop kicking device and traffic stop. > > Add vhost_started check in virtio_net_handle_tx_bh to fix this wrong > VRING_USED_F_NO_NOTIFY set. > > Signed-off-by: Yajun Wu > Reviewed-by: Jiri Pirko Acked-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c

Re: vhost-user-blk reconnect issue

On Mon, Apr 01, 2024 at 10:08:10AM +0800, Yajun Wu wrote: > > On 3/27/2024 6:47 PM, Stefano Garzarella wrote: > > External email: Use caution opening links or attachments > > > > > > Hi Yajun, > > > > On Mon, Mar 25, 2024 at 10:54:13AM +, Yajun Wu wrote: > > > Hi experts, > > > > > > With

Re: [PATCH net v3] virtio_net: Do not send RSS key if it is not supported

On Fri, Mar 29, 2024 at 10:16:41AM -0700, Breno Leitao wrote: > There is a bug when setting the RSS options in virtio_net that can break > the whole machine, getting the kernel into an infinite loop. > > Running the following command in any QEMU virtual machine with virtionet > will reproduce

Re: [RFC QEMU PATCH v8 2/2] virtio-pci: implement No_Soft_Reset bit

On Fri, Mar 29, 2024 at 03:20:59PM +0800, Jason Wang wrote: > On Fri, Mar 29, 2024 at 3:07 PM Chen, Jiqian wrote: > > > > On 2024/3/28 20:36, Michael S. Tsirkin wrote: > > >>>> +} > > >>>> + > > >>>> static void virtio_pci

Re: [PATCH-for-9.1 v2 0/3] rdma: Remove RDMA subsystem and pvrdma device

On Thu, Mar 28, 2024 at 02:02:52PM +0100, Philippe Mathieu-Daudé wrote: > Since v1: > - split in 3 (Thomas) > - justify gluster removal Reviewed-by: Michael S. Tsirkin > Philippe Mathieu-Daudé (3): > hw/rdma: Remove pvrdma device and rdmacm-mux helper > migration: Re

Re: [RFC QEMU PATCH v8 2/2] virtio-pci: implement No_Soft_Reset bit

On Thu, Mar 28, 2024 at 11:08:58AM +, Chen, Jiqian wrote: > On 2024/3/28 18:57, Michael S. Tsirkin wrote: > > On Thu, Mar 28, 2024 at 06:39:03PM +0800, Jiqian Chen wrote: > >> In current code, when guest does S3, virtio devices are reset due to > >> the bit No_S

Re: [RFC QEMU PATCH v8 2/2] virtio-pci: implement No_Soft_Reset bit

On Thu, Mar 28, 2024 at 06:39:03PM +0800, Jiqian Chen wrote: > In current code, when guest does S3, virtio devices are reset due to > the bit No_Soft_Reset is not set. After resetting, the display resources > of virtio-gpu are destroyed, then the display can't come back and only > show blank after

Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

On Thu, Mar 28, 2024 at 07:43:06AM +0100, Thomas Huth wrote: > On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote: > > The whole RDMA subsystem was deprecated in commit e9a54265f5 > > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") > > released in v8.2. Time to remove it. > > > >

Re: [RFC QEMU PATCH v7 1/1] virtio-pci: implement No_Soft_Reset bit

On Thu, Mar 28, 2024 at 09:02:28AM +, Chen, Jiqian wrote: > > On 2024/3/28 16:11, Michael S. Tsirkin wrote: > > > >> +VirtIOPCIProxy *proxy = VIRTIO_PCI(dev); > >> + > >> pcie_cap_deverr_reset(dev); > >> pcie_cap_lnkc

Re: [RFC QEMU PATCH v7 1/1] virtio-pci: implement No_Soft_Reset bit

On Mon, Mar 25, 2024 at 03:07:24PM +0800, Jiqian Chen wrote: > In current code, when guest does S3, virtio devices are reset due to > the bit No_Soft_Reset is not set. After resetting, the display resources > of virtio-gpu are destroyed, then the display can't come back and only > show blank after

Re: [PATCH v1 3/6] intel_iommu: Add a framework to check and sync host IOMMU cap/ecap

On Mon, Mar 18, 2024 at 02:20:50PM +0100, Eric Auger wrote: > Hi Michael, > > On 3/13/24 12:17, Michael S. Tsirkin wrote: > > On Wed, Mar 13, 2024 at 07:54:11AM +, Duan, Zhenzhong wrote: > >> > >>> -----Original Message- > >>> From: Mich

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

onfig space check skipped only for Vendor Specific Info in VSC, > > check is > > still enforced for 3 byte VSC header. > > - Updated commit description with live migration failure scenario. > > v1->v2: > > - Limited scope of change to vfio-pci devices in

Re: [PULL 32/68] hw/virtio: Add support for VDPA network simulation devices

On Wed, Mar 20, 2024 at 09:58:40AM +0100, Paolo Bonzini wrote: > On 3/12/24 23:27, Michael S. Tsirkin wrote: > > diff --git a/include/standard-headers/linux/virtio_pci.h > > b/include/standard-headers/linux/virtio_pci.h > > index 3e2bc2c97e..86733278ba 100644 > > ---

[PULL 21/24] tests: acpi/smbios: whitelist expected blobs

From: Igor Mammedov Signed-off-by: Igor Mammedov Acked-by: Ani Sinha Message-Id: <20240314152302.2324164-19-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+)

[PULL 19/24] smbios: in case of entry point is 'auto' try to build v2 tables 1st

Message-Id: <20240314152302.2324164-17-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/smbios/smbios.c | 52 +++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/

[PULL 11/24] smbios: don't check type4 structures in legacy mode

: <20240314152302.2324164-9-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/firmware/smbios.h | 2 +- hw/i386/fw_cfg.c | 3 +-- hw/smbios/smbios.c | 18 ++ 3 files changed, 16 insertions(+), 7 deletions(-) diff

[PULL 02/24] qapi: document PCIe Gen5/Gen6 speeds since 9.0

Document that PCIe Gen5/Gen6 speeds are only in QAPI since 9.0 - the rest is since 4.0. Cc: Lukas Stockner Cc: Marcel Apfelbaum Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds") Suggested-by: Markus Armbruster Signed-off-by: Michael S. Tsirkin Reviewed-by: Philippe Mat

[PULL 17/24] smbios: clear smbios_type4_count before building tables

From: Igor Mammedov it will help to keep type 4 tables accounting correct in case SMBIOS tables are built multiple times. Signed-off-by: Igor Mammedov Tested-by: Fiona Ebner Message-Id: <20240314152302.2324164-15-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Mic

[PULL 22/24] pc/q35: set SMBIOS entry point type to 'auto' by default

: <20240314152302.2324164-20-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c | 4 hw/i386/pc_q35.c | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 44eb

[PULL 20/24] smbios: error out when building type 4 table is not possible

when smbios-entry-point-type='auto' Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha Tested-by: Fiona Ebner Message-Id: <20240314152302.2324164-18-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/smbios/smbios.c | 14 --

[PULL 05/24] tests: smbios: add test for -smbios type=11 option

From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha Tested-by: Fiona Ebner Message-Id: <20240314152302.2324164-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 17 + test

[PULL 12/24] smbios: add smbios_add_usr_blob_size() helper

From: Igor Mammedov it will be used by follow up patch when legacy handling is moved out into a separate file. Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha Message-Id: <20240314152302.2324164-10-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. T

[PULL 24/24] smbios: add extra comments to smbios_get_table_legacy()

From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20240314152302.2324164-22-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/smbios/smbios_legacy.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/smbios/smbios_lega

[PULL 10/24] smbios: avoid mangling user provided tables

Message-Id: <20240314152302.2324164-8-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/smbios/smbios.c | 187 +++-- 1 file changed, 96 insertions(+), 91 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/

[PULL 01/24] SMBIOS: fix long lines

Break up long lines to fit under 80/90 char limit. Fixes: 04f143d828 ("Implement SMBIOS type 9 v2.6") Fixes: 735eee07d1 ("Implement base of SMBIOS type 9 descriptor.") Cc: "Felix Wu" Cc: Nabih Estefan Reviewed-by: Ani Sinha Signed-off-by: Michael S. Tsirki

  1   2   3   4   5   6   7   8   9   10   >