Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-08 Thread Owen Smith
I'd imagine this would be merged via the Xen queue, as it primarily deals with the xen backend Owen > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: 08 November 2017 10:21 > To: Owen Smith <owen.sm...@citrix.com> > Cc: sstabell...@kerne

[Qemu-devel] [PATCH v5 1/4] ui: generate qcode to linux mappings

2017-11-03 Thread Owen Smith
Use keycodedb to generate a qcode to linux mapping Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- Makefile | 1 + include/ui/input.h | 3 +++ ui/input-keymap.c | 1 + 3 files changed, 5 insertions(+) diff --git a/Makefile b/Makefile index ec73acfa9a..42a9030734

[Qemu-devel] [PATCH v5 2/4] xenfb: Use Input Handlers directly

2017-11-03 Thread Owen Smith
, and supporting documention. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 274 ++--- 1 file changed, 137 insertions(+), 137 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 8e2547ac05..0cf8b3aff7

[Qemu-devel] [PATCH v5 3/4] xenfb: Add [feature|request]-raw-pointer

2017-11-03 Thread Owen Smith
uot; is only valid if "request-abs-pointer" is also set. Raw unscaled pointer values are in the range [0, 0x7fff] "feature-raw-pointer" and "request-raw-pointer" added to Xen header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e Signed-off-by: Owe

[Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-03 Thread Owen Smith
for raw_pointer devices Owen Smith (3): ui: generate qcode to linux mappings xenfb: Use Input Handlers directly xenfb: Add [feature|request]-raw-pointer xenfb: activate input handlers for raw pointer devices Makefile | 1 + hw/display/xenfb.c | 294

[Qemu-devel] [PATCH v5 4/4] xenfb: activate input handlers for raw pointer devices

2017-11-03 Thread Owen Smith
can incorrectly scale absolute coordinates when the display resolution is not 800x600. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 3cbc248c34..c070c84f5b

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-19 Thread Owen Smith
ny Perard <anthony.per...@citrix.com>; > qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Owen Smith > <owen.sm...@citrix.com> > Subject: RE: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw- > pointer > > On Thu, 12 Oct 2017, Paul Durrant wrote: >

[Qemu-devel] [PATCH 2/3 v4] xenfb: Use Input Handlers directly

2017-09-26 Thread Owen Smith
, and supporting documention. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 289 - 1 file changed, 133 insertions(+), 156 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index df8b78f..33361b4 100644 --

[Qemu-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend

2017-09-26 Thread Owen Smith
reported. Owen Smith (3): ui/input: add qemu_input_qcode_to_linux xenfb: Use Input Handlers directly xenfb: Add [feature|request]-raw-pointer hw/display/xenfb.c | 300 + include/ui/input.h | 1 + ui/input-keymap.c | 16 +++ 3 files

[Qemu-devel] [PATCH 1/3 v4] ui/input: add qemu_input_qcode_to_linux

2017-09-26 Thread Owen Smith
Build a reverse mapping on first call that converts qcodes to linux KEY_* identifiers. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- include/ui/input.h | 1 + ui/input-keymap.c | 16 2 files changed, 17 insertions(+) diff --git a/include/ui/input.h b/incl

[Qemu-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-09-26 Thread Owen Smith
uot; is only valid if "request-abs-pointer" is also set. Raw unscaled pointer values are in the range [0, 0x7fff] Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-)

Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-08-23 Thread Owen Smith
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 22 August 2017 00:12 > To: Owen Smith <owen.sm...@citrix.com> > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; > sstabell...@kernel.org; Anthony Perard <anthony.p

[Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-07-26 Thread Owen Smith
mapping, and supporting documention. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 401 + 1 file changed, 247 insertions(+), 154 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index df8b78f..e

[Qemu-devel] [PATCH 0/2 v3] xenfb: rework xen vkbd backend

2017-07-26 Thread Owen Smith
or report constant dimmensions. (1) git://xenbits.xen.org/pvdrivers/win/xenvkbd.git Fixes since v2: Rebased to master Reworked the input handler callbacks, simplifying the state tracking and input event mapping. Owen Smith (2): xenfb: Use Input Handlers directly xenfb: Add [feature

[Qemu-devel] [PATCH 2/2 v3] xenfb: Add [feature|request]-raw-pointer

2017-07-26 Thread Owen Smith
uot; is only valid if "request-abs-pointer" is also set. Raw unscaled pointer values are in the range [0, 0x7fff] "feature-raw-pointer" and "request-raw-pointer" added to Xen header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e Signed-off-by: Owe

[Qemu-devel] [PATCH 0/2 v2] xenfb: Fix protocol for HVM guests

2017-07-03 Thread Owen Smith
name better reflects the intended use-case (raw pointer vs backend requires vfb device) Owen Smith (2): xenfb: Use qemu_input_handler_* calls directly xenfb: Allow vkbd to connect without a DisplayState hw/display/xenfb.c | 157 +++-- 1 file cha

[Qemu-devel] [PATCH 2/2 v2] xenfb: Allow vkbd to connect without a DisplayState

2017-07-03 Thread Owen Smith
o indicate that the backend supports reporting absolute position without rescaling. The frontend uses "request-raw-pointer" to request raw unscaled pointer values. If there is no DisplayState, the absolute values are always raw unscaled values. Signed-off-by: Owen Smith <owen.sm...@citr

[Qemu-devel] [PATCH 1/2 v2] xenfb: Use qemu_input_handler_* calls directly

2017-07-03 Thread Owen Smith
into the XenInput struct. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 121 + 1 file changed, 113 insertions(+), 8 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index e76c0d8..88815df

Re: [Qemu-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers

2017-06-13 Thread Owen Smith
Noted, I have had a look at porting the xenfb input handlers to the qemu_input_handler_*() functions, and will post an update that combines patch 3 and 4 of this series. From: Gerd Hoffmann<mailto:kra...@redhat.com> Sent: 08 June 2017 14:39 To: Owen Smith<mailto:owen.sm...@citrix.co

[Qemu-devel] [PATCH 4/4] xenfb: Fix leak by adding/removing keyboard handler

2017-06-08 Thread Owen Smith
Calls qemu_remove_kbd_event_handler that frees its memory, instead of adding (and allocating some memory) a new NULL handler. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/d

[Qemu-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers

2017-06-08 Thread Owen Smith
Adds missing functions to activate and remove keyboard handlers * qemu_activate_kbd_event_handler * qemu_remove_kbd_event_handler Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- include/ui/console.h | 2 ++ ui/input-legacy.c| 12 2 files changed, 14 insertions(+)

[Qemu-devel] [PATCH 1/4] xenfb: Add feature-vkbd-standalone

2017-06-08 Thread Owen Smith
e coordinates cannot be scaled to the non-existent QemuConsole's sizes, and remain unscaled, in the range [0, 0x7FFF]. Signed-off-by: Owen Smith <owen.sm...@citrix.com> --- hw/display/xenfb.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/hw/di

[Qemu-devel] [PATCH 2/4] xenfb: Activate mouse handler

2017-06-08 Thread Owen Smith
Mouse events are only delivered to the first handler in the chain. Activating the xenfb mouse event handler so that mouse events can be passed over the shared ring protocol. Note: The keyboard handler is activated internally by the add call. Signed-off-by: Owen Smith <owen.sm...@citrix.

[Qemu-devel] [PATCH 0/4] xenfb: Add vkbd-only option

2017-06-08 Thread Owen Smith
e a leak in the vkbd device model. Owen Smith (4): xenfb: Add feature-vkbd-standalone xenfb: Activate mouse handler ui/input: Add activate/remove for keyboard handlers xenfb: Fix leak by adding/removing keyboard handler hw/display/xenfb.c | 44

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation

2014-09-26 Thread Owen Smith
-Original Message- From: David Vrabel Sent: 22 September 2014 11:16 To: Owen Smith; xen-de...@lists.xen.org Cc: Stefano Stabellini; qemu-devel@nongnu.org; Ian Campbell Subject: Re: [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation On 22/09/14 10:04, Owen smith wrote: Add

[Qemu-devel] [PATCH 2/2] xenfb: Add comment documentation

2014-09-22 Thread Owen smith
Add documentation for page-ref, page-gref and event-channel. Signed-off-by: Owen smith owen.sm...@citrix.com --- xen/include/public/io/fbif.h | 25 + 1 file changed, 25 insertions(+) diff --git a/xen/include/public/io/fbif.h b/xen/include/public/io/fbif.h index cc25aab

[Qemu-devel] [PATCH 1/2] xenfb: Add comment documentation

2014-09-22 Thread Owen smith
Add documentation for feature-abs-pointer, feature-no-abs-rescale, feature-no-console, page-ref, page-gref and event-channel Signed-off-by: Owen smith owen.sm...@citrix.com --- xen/include/public/io/kbdif.h | 74 +++ 1 file changed, 74 insertions(+) diff

[Qemu-devel] [PATCH 0/2] xenfb: Document public headers

2014-09-22 Thread Owen smith
Add comments documenting the xenstore nodes used by the vfb and vkbd devices. Documents changes in qemu patch series posted here http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg03472.html Owen smith (2): xenfb: Add comment documentation xenfb: Add comment documentation xen/include

[Qemu-devel] [PATCH v2 2/5] xenfb: Activate mouse event handler

2014-09-17 Thread Owen smith
the keyboard handler, where qemu_add_mouse_event_handler does not activate the mouse handler. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 9dcf9b6..69471e9 100644 --- a/hw

[Qemu-devel] [PATCH v2 1/5] xenfb: Unregister keyboard event handler correctly

2014-09-17 Thread Owen smith
The keyboard event handler was not being removed, a NULL-callback entry was being added to intercept events. Use the unregister call to remove the keyboard event handler when appropriate. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 12 ++-- 1 file changed, 10

[Qemu-devel] [PATCH v2 4/5] xenfb: Add feature-no-abs-rescale

2014-09-17 Thread Owen smith
-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 44 ++-- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 829036f..0794075 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -61,6

[Qemu-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page

2014-09-17 Thread Owen smith
ring. Only used if page-ref is not set. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 44 ++-- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 69471e9..829036f

[Qemu-devel] [PATCH v2 0/5] xenfb: Add support for Windows PV frontend

2014-09-17 Thread Owen smith
frontend sets request-no-console, backend will not wait for a console before vkbd device transitions to connected Owen smith (5): xenfb: Unregister keyboard event handler correctly xenfb: Activate mouse event handler xenfb: Add option to use a grant ref for shared page xenfb: Add feature

[Qemu-devel] [PATCH v2 5/5] xenfb: Add feature-no-console

2014-09-17 Thread Owen smith
A frontend sets a value of 1 to prevent the backend waiting for the vfb device to become available and attach to a console. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/display

Re: [Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-11 Thread Owen Smith
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 11 September 2014 01:33 To: Owen Smith Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini Subject: Re: [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-11 Thread Owen Smith
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 11 September 2014 02:01 To: Owen Smith Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini Subject: Re: [PATCH 2/3] xenfb: Add option to use grant ref for shared page

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add feature-no-abs-rescale for Windows PV frontend

2014-09-11 Thread Owen Smith
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 11 September 2014 02:23 To: Owen Smith Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini Subject: Re: [PATCH 3/3] xenfb: Add feature-no-abs-rescale for Windows PV

[Qemu-devel] [PATCH 3/3] xenfb: Add feature-no-abs-rescale for Windows PV frontend

2014-09-10 Thread Owen smith
. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 52 +--- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index c4375c8..65c373b 100644 --- a/hw/display/xenfb.c +++ b/hw

[Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-10 Thread Owen smith
Keyboard event handler was replaced with a new handler on disconnect. Use the unregister function to remove keyboard handler. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/display

[Qemu-devel] [PATCH 0/3] xenfb: Add support for Windows PV frontend

2014-09-10 Thread Owen smith
contains the following patches 1-2) Fixes to the vkbd device model 3) Adds a feature to not scale axes to DisplaySurface size Owen smith (3): xenfb: Unregister keyboard event handler correctly xenfb: Add option to use grant ref instead of mfn for shared page. xenfb: Add feature-no-abs-rescale

[Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-10 Thread Owen smith
The vkbd device should be able to use a grant reference to map the shared page. Signed-off-by: Owen smith owen.sm...@citrix.com --- hw/display/xenfb.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display