Re: [PATCH 2/2] scsi-disk: Fix crash for VM configured with USB CDROM after live migration

2024-05-24 Thread Yong Huang
On Fri, May 24, 2024 at 6:01 PM Prasad Pandit wrote: > Hello Hyman, > > * Is this the same patch series as sent before..? > -> > https://lists.nongnu.org/archive/html/qemu-devel/2024-04/msg00816.html Yes, exactly the same, I just refine the comment > > > On Fri, 24 May 2024 at 12:02, Hyman

Re: [PATCH RESEND 0/2] Fix crash of VMs configured with the CDROM device

2024-05-08 Thread Yong Huang
Ping2 Make sure that this patchset is not overlooked. Yong On Tue, Apr 23, 2024 at 9:45 AM Yong Huang wrote: > Ping. > I would appreciate comments on this series. Thanks, > > Yong > > On Mon, Apr 8, 2024 at 8:08 PM Hyman Huang wrote: > >> This patchset fixes

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-28 Thread Yong Huang
On Wed, Apr 24, 2024 at 3:17 PM Zhijian Li (Fujitsu) wrote: > > > On 24/04/2024 12:52, mii wrote: > > > > On 2024/04/24 10:28, Yong Huang wrote: > >> > >> > >> On Tue, Apr 23, 2024 at 9:35 PM Peter Xu wrote: > >> > >&g

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Yong Huang
On Tue, Apr 23, 2024 at 9:35 PM Peter Xu wrote: > On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: > > When the KVM acceleration parameter is not set, executing calc_dirty_rate > > with the -r or -b option results in a segmentation fault due to accessing > > a null kvm_state pointer

Re: [PATCH] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Yong Huang
On Tue, Apr 23, 2024 at 2:19 PM Masato Imai wrote: > When the KVM acceleration parameter is not set, executing calc_dirty_rate > with the -r option results in a segmentation fault due to accessing a > null kvm_state pointer in the kvm_dirty_rate_enabled function. >

Re: [PATCH RESEND 0/2] Fix crash of VMs configured with the CDROM device

2024-04-22 Thread Yong Huang
Ping. I would appreciate comments on this series. Thanks, Yong On Mon, Apr 8, 2024 at 8:08 PM Hyman Huang wrote: > This patchset fixes the crash of VMs configured with the CDROM device > on the destination during live migration. See the commit message for > details. > > The previous patchset

Re: [PATCH RESEND 2/2] scsi-disk: Fix crash of VMs configured with the CDROM device

2024-04-14 Thread Yong Huang
Ping On Mon, Apr 8, 2024 at 8:08 PM Hyman Huang wrote: > When configuring VMs with the CDROM device using the USB bus > in Libvirt, do as follows: > > > > > > > > > > > The destination Qemu process crashed, causing the VM migration > to fail; the backtrace reveals the

Re: [PATCH 12/19] migration: fix -Werror=maybe-uninitialized false-positives

2024-03-28 Thread Yong Huang
On Thu, Mar 28, 2024 at 6:23 PM wrote: > From: Marc-André Lureau > > ../migration/dirtyrate.c:186:5: error: ‘records’ may be used uninitialized > [-Werror=maybe-uninitialized] > ../migration/dirtyrate.c:168:12: error: ‘gen_id’ may be used uninitialized > [-Werror=maybe-uninitialized] >

Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines

2024-03-21 Thread Yong Huang
On Wed, Mar 20, 2024 at 11:19 PM Peter Xu wrote: > On Wed, Mar 20, 2024 at 07:49:07AM +0100, Cédric Le Goater wrote: > > Now that the log_global*() handlers take an Error** parameter and > > return a bool, do the same for memory_global_dirty_log_start() and > > memory_global_dirty_log_stop().

Re: [PATCH v4 14/25] memory: Add Error** argument to the global_dirty_log routines

2024-03-15 Thread Yong Huang
On Wed, Mar 6, 2024 at 9:35 PM Cédric Le Goater wrote: > Now that the log_global*() handlers take an Error** parameter and > return a bool, do the same for memory_global_dirty_log_start() and > memory_global_dirty_log_stop(). The error is reported in the callers > for now and it will be

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-15 Thread Yong Huang
On Fri, Mar 15, 2024 at 3:51 PM Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Mar 13, 2024 at 10:40:21AM +0100, Markus Armbruster wrote: > >> I could be awkward for the use case described in PATCH 1's commit > >> message: > >> > >> However, we sometimes want to

Re: [PATCH v3 15/26] memory: Add Error** argument to the global_dirty_log routines

2024-03-04 Thread Yong Huang
On Mon, Mar 4, 2024 at 8:29 PM Cédric Le Goater wrote: > Now that the log_global*() handlers take an Error** parameter and > return a bool, do the same for memory_global_dirty_log_start() and > memory_global_dirty_log_stop(). The error is reported in the callers > for now and it will be

Re: [PATCH RFC 0/3] Support GM/T 0018-2012 cryptographic standard

2024-02-29 Thread Yong Huang
On Thu, Feb 29, 2024 at 5:04 PM Daniel P. Berrangé wrote: > On Sat, Feb 24, 2024 at 10:34:55PM +0800, Hyman Huang wrote: > > This patchset introduce GM/T 0018-2012 as a crypto backend driver, > > which is applied for block encryption. Currently, we support SM4 > > cipher algorithm only. > > > >

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Yong Huang
On Wed, Feb 28, 2024 at 7:58 PM Kevin Wolf wrote: > Am 28.02.2024 um 12:30 hat Daniel P. Berrangé geschrieben: > > On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > > > Until now, @size has been mandatory for creating images with every > > > driver. Maybe we should even have put it

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-21 Thread Yong Huang
On Wed, Feb 21, 2024 at 4:26 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster > wrote: > > > >> Hyman Huang writes: > >> > >> > Add comment in detail for commit 4339

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-20 Thread Yong Huang
On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster wrote: > Hyman Huang writes: > > > Add comment in detail for commit 433957bb7f (qapi: > > Make parameter 'file' optional for > > BlockdevCreateOptionsLUKS). > > > > Signed-off-by: Hyman Huang > > --- > > qapi/block-core.json | 20

Re: [PATCH v3 2/3] virtio: Declare the decoding functions to static

2024-02-20 Thread Yong Huang
On Mon, Feb 19, 2024 at 11:38 PM Markus Armbruster wrote: > Hyman Huang writes: > > > qmp_decode_protocols(), qmp_decode_status(), and qmp_decode_features() > > are now only used in virtio-hmp-cmds.c. So move them into there, > > redeclare them to static, and replace the qmp_ prefix with hmp_.

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-20 Thread Yong Huang
On Tue, Feb 20, 2024 at 5:47 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster > wrote: > > > >> Yong Huang writes: > >> > >> > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster >

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-20 Thread Yong Huang
On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster > wrote: > > > >> yong.hu...@smartx.com writes: > >> > >> > From: Hyman Huang > >> > > >

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-19 Thread Yong Huang
On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster wrote: > yong.hu...@smartx.com writes: > > > From: Hyman Huang > > > > To support detached LUKS header creation, make the existing 'file' > > field in BlockdevCreateOptionsLUKS optional. > > > > Signed-off-by: Hyman Huang > > Reviewed-by:

Re: [PATCH v3 1/3] qmp: Switch x-query-virtio-status back to numeric encoding

2024-02-19 Thread Yong Huang
On Mon, Feb 19, 2024 at 11:32 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 13, 2024 at 6:26 PM Michael S. Tsirkin > wrote: > > > >> On Fri, Feb 02, 2024 at 10:32:15PM +0800, Hyman Huang wrote: > >> > x-query-virtio-sta

Re: [PATCH v3 1/3] qmp: Switch x-query-virtio-status back to numeric encoding

2024-02-15 Thread Yong Huang
On Tue, Feb 13, 2024 at 6:26 PM Michael S. Tsirkin wrote: > On Fri, Feb 02, 2024 at 10:32:15PM +0800, Hyman Huang wrote: > > x-query-virtio-status returns several sets of virtio feature and > > status flags. It goes back to v7.2.0. > > > > In the initial commit 90c066cd682 (qmp: add QMP command

[PATCH v4 3/7] crypto: Modify the qcrypto_block_create to support creation flags

2024-01-29 Thread yong . huang
From: Hyman Huang Expand the signature of qcrypto_block_create to enable the formation of LUKS volumes with detachable headers. To accomplish that, introduce QCryptoBlockCreateFlags to instruct the creation process to set the payload_offset_sector to 0. Signed-off-by: Hyman Huang ---

[PATCH v4 0/7] Support generic Luks encryption

2024-01-29 Thread yong . huang
From: Hyman Huang Sorry for the late post of version 4. The modifications are as follows: v4: - Rebase on master - squash [PATCH v3 02/10] to [PATCH v3 01/10] - refactor the logic of block_crypto_open_generic in [PATCH v3 02/10] as Daniel suggestted: a. drop the invalid parameter check

[PATCH v4 6/7] crypto: Introduce 'detached-header' field in QCryptoBlockInfoLUKS

2024-01-29 Thread yong . huang
From: Hyman Huang When querying the LUKS disk with the qemu-img tool or other APIs, add information about whether the LUKS header is detached. Additionally, update the test case with the appropriate modification. Signed-off-by: Hyman Huang --- crypto/block-luks.c| 2 ++

[PATCH v4 1/7] crypto: Support LUKS volume with detached header

2024-01-29 Thread yong . huang
From: Hyman Huang By enhancing the LUKS driver, it is possible to implement the LUKS volume with a detached header. Normally a LUKS volume has a layout: disk: | header | key material | disk payload data | With a detached LUKS header, you need 2 disks so getting: disk1: | header | key

[PATCH v4 7/7] tests: Add case for LUKS volume with detached header

2024-01-29 Thread yong . huang
From: Hyman Huang Also, add a section to the MAINTAINERS file for detached LUKS header, it only has a test case in it currently. Signed-off-by: Hyman Huang --- MAINTAINERS | 5 + tests/qemu-iotests/tests/luks-detached-header | 218 ++

[PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

2024-01-29 Thread yong . huang
From: Hyman Huang Firstly, enable the ability to choose the block device containing a detachable LUKS header by adding the 'header' parameter to BlockdevCreateOptionsLUKS. Secondly, when formatting the LUKS volume with a detachable header, truncate the payload volume to length without a header

[PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-01-29 Thread yong . huang
From: Hyman Huang To support detached LUKS header creation, make the existing 'file' field in BlockdevCreateOptionsLUKS optional. Signed-off-by: Hyman Huang Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 21 ++--- qapi/block-core.json | 5 +++-- 2 files changed,

[PATCH v4 5/7] block: Support detached LUKS header creation using qemu-img

2024-01-29 Thread yong . huang
From: Hyman Huang Even though a LUKS header might be created with cryptsetup, qemu-img should be enhanced to accommodate it as well. Add the 'detached-header' option to specify the creation of a detached LUKS header. This is how it is used: $ qemu-img create --object secret,id=sec0,data=abc123

Re: [PATCH v2 0/2] Nitpick at the error message's output

2024-01-14 Thread Yong Huang
Ping On Sun, Jan 7, 2024 at 7:53 PM Hyman Huang wrote: > v2: > - rebase on master > - add a commit to sort the error message so that an explanation > error number can be returned on all failure paths > > Hyman Huang (2): > i386/sev: Sort the error message > i386/sev: Nitpick at the error

Re: [PATCH v2 1/2] qapi/virtio: Keep feature and status bits in the QMP output

2024-01-12 Thread Yong Huang
On Fri, Jan 12, 2024 at 10:10 PM Markus Armbruster wrote: > Hyman Huang writes: > > > Maintain the feature and status bits in the x-query-virtio-status > > output and, as usual, add human-readable output only in HMP. > > > > Applications may find it useful to compare features and status > >

Re: [PATCH v2 2/2] hmp: Drop unknown feature and status bits

2024-01-12 Thread Yong Huang
On Fri, Jan 12, 2024 at 10:04 PM Markus Armbruster wrote: > Hyman Huang writes: > > > The QMP command "x-query-virtio-status" outputs the full > > feature and status bit information, so there is no need > > to maintain it in the HMP output; drop it. > > > > Signed-off-by: Hyman Huang > > I'm

Re: [PATCH RESEND v3 01/10] crypto: Introduce option and structure for detached LUKS header

2024-01-11 Thread Yong Huang
On Thu, Jan 11, 2024 at 10:58 PM Daniel P. Berrangé wrote: > On Thu, Jan 11, 2024 at 03:35:10PM +0100, Markus Armbruster wrote: > > Hyman Huang writes: > > > > > Add the "header" option for the LUKS format. This field would be > > > used to identify the blockdev's position where a detachable

Re: [PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create

2024-01-11 Thread Yong Huang
On Thu, Jan 11, 2024 at 10:05 PM Markus Armbruster wrote: > Fails to compile for me: > > ../block/crypto.c: In function ‘block_crypto_co_create_luks’: > ../block/crypto.c:784:1: error: control reaches end of non-void function > [-Werror=return-type] > 784 | } > | ^ > > Ok, I'll check it

Re: [PATCH RESEND v3 04/10] crypto: Introduce creation option and structure for detached LUKS header

2024-01-07 Thread Yong Huang
On Thu, Jan 4, 2024 at 10:51 PM Daniel P. Berrangé wrote: > On Mon, Dec 25, 2023 at 01:45:06PM +0800, Hyman Huang wrote: > > Introduce 'header' field in BlockdevCreateOptionsLUKS to support > > detached LUKS header creation. Meanwhile, introduce header-related > > field in QCryptoBlock. > > > >

Re: [PATCH RESEND v3 02/10] crypto: Support generic LUKS encryption

2024-01-07 Thread Yong Huang
On Thu, Jan 4, 2024 at 10:40 PM Daniel P. Berrangé wrote: > On Mon, Dec 25, 2023 at 01:45:04PM +0800, Hyman Huang wrote: > > By enhancing the LUKS driver, it is possible to enable > > the detachable LUKS header and, as a result, achieve > > general encryption for any disk format that QEMU has >

Re: [PATCH] i386/sev: Nitpick at the error message's output

2024-01-07 Thread Yong Huang
On Sat, Jan 6, 2024 at 12:43 AM Alex Bennée wrote: > Hyman Huang writes: > > > The incorrect error message was produced as a result of > > the return number being disregarded on the sev_kvm_init > > failure path. > > > > For instance, when a user's failure to launch a SEV guest > > is caused by

Re: [PATCH 1/2] qapi/virtio: Keep feature and status bits in the QMP output

2024-01-02 Thread Yong Huang
Thanks, I'll fix that in the next version. On Fri, Dec 29, 2023 at 5:31 PM Philippe Mathieu-Daudé wrote: > Hi, > > On 28/12/23 19:52, Hyman Huang wrote: > > Maintain the feature and status bits in the x-query-virtio-status > > output and, as usual, add human-readable output only in HMP. > > > >

Re: [v2 1/2] qapi/virtio: Add feature and status bits for x-query-virtio-status

2023-12-22 Thread Yong Huang
Sure. of course. I'll do that next week. While v3 would be a single patch that only contains the first commit. Thanks, Yong On Fri, Dec 22, 2023 at 5:54 PM Markus Armbruster wrote: > Hyman Huang writes: > > > This patch allows to display feature and status bits in > > virtio-status. > > > >

Re: [v2 4/4] block: Support detached LUKS header creation for blockdev-create

2023-12-18 Thread Yong Huang
On Mon, Dec 18, 2023 at 7:19 PM Daniel P. Berrangé wrote: > On Thu, Dec 07, 2023 at 12:37:45AM +0800, Hyman Huang wrote: > > Provide the "detached-mode" option for detached LUKS header > > formatting. > > > > To format the LUKS header on the pre-creating disk, example > > as follows: > > > > 1.

Re: [v2 3/4] crypto: Support generic LUKS encryption

2023-12-18 Thread Yong Huang
On Mon, Dec 18, 2023 at 7:16 PM Daniel P. Berrangé wrote: > On Thu, Dec 07, 2023 at 12:37:44AM +0800, Hyman Huang wrote: > > By enhancing the LUKS driver, it is possible to enable > > the detachable LUKS header and, as a result, achieve > > general encryption for any disk format that QEMU has >

Re: [v2 0/4] Support generic Luks encryption

2023-12-18 Thread Yong Huang
On Mon, Dec 18, 2023 at 7:21 PM Daniel P. Berrangé wrote: > On Thu, Dec 07, 2023 at 12:37:41AM +0800, Hyman Huang wrote: > > v2: > > - Simplify the design by reusing the LUKS driver to implement > > the generic Luks encryption, thank Daniel for the insightful > > advice. > > - rebase on

Re: [RFC 1/2] qapi/virtio: introduce the "show-bits" argument for x-query-virtio-status

2023-12-08 Thread Yong Huang
On Fri, Dec 1, 2023 at 11:37 PM Laurent Vivier wrote: > On 12/1/23 16:21, Markus Armbruster wrote: > > Laurent Vivier writes: > > > >> On 11/21/23 08:58, Markus Armbruster wrote: > >>> Laurent, there's a question for you at the end. > >>> >

Re: [PATCH v6] crypto: Introduce SM4 symmetric cipher algorithm

2023-12-07 Thread Yong Huang
I'll post the changelog between versions in the next version if needed. :) v6: - modify the comment about how to enable sm4 crypto feature v5: - drop the crypto-sm4 option in build system v4 - refactor the error report info, change "sm4"->"libsm4" On Fri, Dec 8, 2023 at 12:02 AM Philippe

Re: [PATCH v3] crypto: Introduce SM4 symmetric cipher algorithm

2023-12-06 Thread Yong Huang
On Thu, Dec 7, 2023 at 1:41 AM Daniel P. Berrangé wrote: > On Wed, Nov 29, 2023 at 11:17:49PM +0800, Hyman Huang wrote: > > Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). > > > > SM4 (GBT.32907-2016) is a cryptographic standard issued by the > > Organization of State Commercial

Re: [RFC 0/8] Support generic Luks encryption

2023-12-04 Thread Yong Huang
On Tue, Dec 5, 2023 at 1:44 AM Daniel P. Berrangé wrote: > On Tue, Dec 05, 2023 at 01:32:51AM +0800, Yong Huang wrote: > > On Tue, Dec 5, 2023 at 12:51 AM Daniel P. Berrangé > > wrote: > > > > > On Tue, Dec 05, 2023 at 12:41:16AM +0800, Yong Huang wrote: > >

Re: [RFC 0/8] Support generic Luks encryption

2023-12-04 Thread Yong Huang
On Tue, Dec 5, 2023 at 12:51 AM Daniel P. Berrangé wrote: > On Tue, Dec 05, 2023 at 12:41:16AM +0800, Yong Huang wrote: > > On Tue, Dec 5, 2023 at 12:24 AM Daniel P. Berrangé > > wrote: > > > > > On Tue, Dec 05, 2023 at 12:06:17AM +0800, Hyman Huang wro

Re: [RFC 0/8] Support generic Luks encryption

2023-12-04 Thread Yong Huang
On Tue, Dec 5, 2023 at 12:24 AM Daniel P. Berrangé wrote: > On Tue, Dec 05, 2023 at 12:06:17AM +0800, Hyman Huang wrote: > > This functionality was motivated by the following to-do list seen > > in crypto documents: > > https://wiki.qemu.org/Features/Block/Crypto > > > > The last chapter says we

Re: [RFC 0/8] Support generic Luks encryption

2023-12-04 Thread Yong Huang
On Tue, Dec 5, 2023 at 12:24 AM Daniel P. Berrangé wrote: > On Tue, Dec 05, 2023 at 12:06:17AM +0800, Hyman Huang wrote: > > This functionality was motivated by the following to-do list seen > > in crypto documents: > > https://wiki.qemu.org/Features/Block/Crypto > > > > The last chapter says we

Re: [PATCH] migration/dirtyrate: Remove an extra parameter

2023-12-03 Thread Yong Huang
On Mon, Dec 4, 2023 at 9:23 AM Wafer wrote: > vcpu_dirty_stat_collect() has an unused parameter so remove it. > > Signed-off-by: Wafer > --- > migration/dirtyrate.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c >

Re: [PATCH v2] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-28 Thread Yong Huang
On Tue, Nov 28, 2023 at 11:57 PM Philippe Mathieu-Daudé wrote: > Hi Hyman, > > On 28/11/23 16:24, Hyman Huang wrote: > > Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). > > > > SM4 (GBT.32907-2016) is a cryptographic standard issued by the > > Organization of State Commercial

Re: [PATCH v2] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-28 Thread Yong Huang
I'll try to understand the comment, if i misunderstood, please point out. On Wed, Nov 29, 2023 at 12:20 AM Daniel P. Berrangé wrote: > On Tue, Nov 28, 2023 at 04:57:20PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Hyman, > > > > On 28/11/23 16:24, Hyman Huang wrote: > > > Introduce the SM4

Re: [PATCH] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-27 Thread Yong Huang
On Tue, Nov 28, 2023 at 12:11 AM Daniel P. Berrangé wrote: > On Mon, Nov 27, 2023 at 11:55:34PM +0800, Hyman Huang wrote: > > Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). > > > > SM4 (GBT.32907-2016) is a cryptographic standard issued by the > > Organization of State Commercial

Re: [RFC 1/2] qapi/virtio: introduce the "show-bits" argument for x-query-virtio-status

2023-11-21 Thread Yong Huang
On Tue, Nov 21, 2023 at 3:58 PM Markus Armbruster wrote: > Laurent, there's a question for you at the end. > > Yong Huang writes: > > > On Thu, Nov 16, 2023 at 10:44 PM Markus Armbruster > > wrote: > > > >> Hyman Huang writes: > >> > >&g

Re: [RFC 0/2] vhost-user-test: Add negotiated features check

2023-11-17 Thread Yong Huang
On Fri, Nov 17, 2023 at 6:29 PM Michael S. Tsirkin wrote: > On Thu, Nov 16, 2023 at 09:01:28AM +0800, Yong Huang wrote: > > ping > > Sit tight pls it's only been a couple of days. > But if you want to, address comments by Markus pls. > > I'm happy to do that, of co

Re: [RFC 1/2] qapi/virtio: introduce the "show-bits" argument for x-query-virtio-status

2023-11-17 Thread Yong Huang
On Thu, Nov 16, 2023 at 10:44 PM Markus Armbruster wrote: > Hyman Huang writes: > > > This patch allows to display feature and status bits in virtio-status. > > > > An optional argument is introduced: show-bits. For example: > > {"execute": "x-query-virtio-status", > > "arguments": {"path": >

Re: [RFC 0/2] vhost-user-test: Add negotiated features check

2023-11-15 Thread Yong Huang
ping On Sun, Nov 12, 2023 at 9:03 PM Hyman Huang wrote: > The patchset "Fix the virtio features negotiation flaw" fix a > vhost-user negotiation flaw: > c9bdc449f9 vhost-user: Fix the virtio features negotiation flaw > bebcac052a vhost-user: Refactor the chr_closed_bh > 937b7d96e4 vhost-user:

Re: [v2 4/6] tests/migration: Introduce dirty-ring-size option into guestperf

2023-10-22 Thread Yong Huang
ping. Regarding the performance of the live migration, Guestperf could provide us with a clear response. IMHO, by just adding a few metrics, it might be developed into a more user-friendly metrics system in the future. We may still enrich it prior to that. On Fri, Oct 20, 2023 at 11:24 PM Hyman

Re: [PATCH] migration/dirtyrate: use QEMU_CLOCK_HOST to report start-time

2023-09-24 Thread Yong Huang
On Tue, Sep 5, 2023 at 5:19 PM Andrei Gudkov wrote: > Currently query-dirty-rate uses QEMU_CLOCK_REALTIME as > the source for start-time field. This translates to > clock_gettime(CLOCK_MONOTONIC), i.e. number of seconds > since host boot. This is not very useful. The only > reasonable use case

Re: [PATCH v3] migration/calc-dirty-rate: millisecond-granularity period

2023-09-10 Thread Yong Huang
On Tue, Sep 5, 2023 at 3:06 PM Andrei Gudkov wrote: > This patch allows to measure dirty page rate for > sub-second intervals of time. An optional argument is > introduced -- calc-time-unit. For example: > {"execute": "calc-dirty-rate", "arguments": > {"calc-time": 500, "calc-time-unit":

Re: [PATCH] softmmu/dirtylimit: Fix usleep early return on signal

2023-09-04 Thread Yong Huang
On Fri, Sep 1, 2023 at 10:19 AM wrote: > From: alloc > > Timeout functions like usleep can return early on signal, which reduces > more dirty pages than expected. In dirtylimit case, dirtyrate meter > thread needs to kick all vcpus out to sync. The callchain: > > vcpu_calculate_dirtyrate >

Re: [PULL 1/3] softmmu: Fix dirtylimit memory leak

2023-08-30 Thread Yong Huang
On Thu, Aug 31, 2023 at 12:55 AM Michael Tokarev wrote: > 29.08.2023 18:29, Hyman Huang wrote: > > From: "alloc.young" > > > > Fix memory leak in hmp_info_vcpu_dirty_limit,use g_autoptr > > to handle memory deallocation. > > It does not feel like -stable-worthy, or am I wrong and it should be >

Re: [PULL 0/3] Dirty page rate and dirty page limit 20230828 patches

2023-08-29 Thread Yong Huang
On Wed, Aug 30, 2023 at 1:31 AM Stefan Hajnoczi wrote: > On Tue, 29 Aug 2023 at 12:30, Yong Huang wrote: > > On Tue, Aug 29, 2023 at 4:01 AM Stefan Hajnoczi > wrote: > >> > >> On Mon, 28 Aug 2023 at 10:36, Hyman Huang > wrote: > >> > > >&

Re: [PULL 0/3] Dirty page rate and dirty page limit 20230828 patches

2023-08-29 Thread Yong Huang
On Tue, Aug 29, 2023 at 4:01 AM Stefan Hajnoczi wrote: > On Mon, 28 Aug 2023 at 10:36, Hyman Huang wrote: > > > > From: Hyman > > > > The following changes since commit > 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > > > > Merge tag 'pull-target-arm-20230824' of >

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-26 Thread Yong Huang
ove on top at your leisure, Would that work for you? On Wed, Aug 9, 2023 at 11:03 PM wrote: > On Sun, Aug 06, 2023 at 02:16:34PM +0800, Yong Huang wrote: > > On Fri, Aug 4, 2023 at 11:03 PM Andrei Gudkov > > wrote: > > > > > Introduces alternative argument calc-time-ms,

Re: [PATCH v2 2/2] softmmu/dirtylimit: Convert free to g_free

2023-08-24 Thread Yong Huang
On Fri, Aug 25, 2023 at 10:33 AM wrote: > From: alloc > > Convert free to g_free to match g_new and g_malloc functions. > > Signed-off-by: alloc > --- > softmmu/dirtylimit.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/softmmu/dirtylimit.c

Re: [PATCH] softmmu: Fix dirtylimit memory leak

2023-08-23 Thread Yong Huang
On Wed, Aug 23, 2023 at 3:48 PM wrote: > From: "alloc.young" > > Fix memory leak in hmp_info_vcpu_dirty_limit,use g_autoptr > handle memory deallocation, alse use g_free to match g_malloc > && g_new functions. > > Signed-off-by: alloc.young > --- > softmmu/dirtylimit.c | 26

Re: [PATCH QEMU v2 0/3] provide a smooth upgrade solution for multi-queues disk

2023-08-14 Thread Yong Huang
On Tue, Aug 15, 2023 at 12:28 AM Stefan Hajnoczi wrote: > On Fri, Aug 11, 2023 at 10:31:51AM +0800, Yong Huang wrote: > > Hi, Stefan, thank you for your interest in this series. > > I'm trying to explain my point, if you think my explanation > > doesn't stand u

Re: [PATCH QEMU v2 0/3] provide a smooth upgrade solution for multi-queues disk

2023-08-10 Thread Yong Huang
Hi, Stefan, thank you for your interest in this series. I'm trying to explain my point, if you think my explanation doesn't stand up, please let me know. On Fri, Aug 11, 2023 at 2:33 AM Stefan Hajnoczi wrote: > On Thu, Aug 10, 2023 at 07:07:09AM +, ~hyman wrote: > > Ping, > > > > This

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-10 Thread Yong Huang
On Wed, Aug 9, 2023 at 11:03 PM wrote: > On Sun, Aug 06, 2023 at 02:16:34PM +0800, Yong Huang wrote: > > On Fri, Aug 4, 2023 at 11:03 PM Andrei Gudkov > > wrote: > > > > > Introduces alternative argument calc-time-ms, which is the > > > the same as

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-10 Thread Yong Huang
On Wed, Aug 9, 2023 at 9:59 PM wrote: > On Sun, Aug 06, 2023 at 02:31:43PM +0800, Yong Huang wrote: > > On Sat, Aug 5, 2023 at 2:05 AM Markus Armbruster > wrote: > > > > > Andrei Gudkov writes: > > > > > > > Introduces alternative argument cal

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-06 Thread Yong Huang
On Sat, Aug 5, 2023 at 2:05 AM Markus Armbruster wrote: > Andrei Gudkov writes: > > > Introduces alternative argument calc-time-ms, which is the > > the same as calc-time but accepts millisecond value. > > Millisecond granularity allows to make predictions whether > > migration will succeed or

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-06 Thread Yong Huang
On Fri, Aug 4, 2023 at 11:03 PM Andrei Gudkov wrote: > Introduces alternative argument calc-time-ms, which is the > the same as calc-time but accepts millisecond value. > Millisecond granularity allows to make predictions whether > migration will succeed or not. To do this, calculate dirty >

Re: [PATCH QEMU 1/2] qapi: Reformat and craft the migration doc comments

2023-08-01 Thread Yong Huang
On Tue, Aug 1, 2023 at 8:33 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Fri, Jul 28, 2023 at 3:49 PM Markus Armbruster > wrote: > > > >> ~hyman writes: > >> > >> > From: Hyman Huang(黄勇) > >> > > >

Re: [PATCH QEMU v3 1/3] qapi: Reformat the dirty-limit migration doc comments

2023-08-01 Thread Yong Huang
On Tue, Aug 1, 2023 at 8:34 PM Markus Armbruster wrote: > ~hyman writes: > > > From: Hyman Huang(黄勇) > > > > Reformat the dirty-limit migration doc comments to conform > > to current conventions as commit a937b6aa739 (qapi: Reformat > > doc comments to conform to current conventions). > > > >

Re: [PATCH QEMU 1/2] qapi: Reformat and craft the migration doc comments

2023-07-28 Thread Yong Huang
On Fri, Jul 28, 2023 at 3:49 PM Markus Armbruster wrote: > ~hyman writes: > > > From: Hyman Huang(黄勇) > > > > Reformat migration doc comments to conform to current conventions > > as commit a937b6aa739 (qapi: Reformat doc comments to conform to > > current conventions). > > > > Also, craft the

Re: [PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-19 Thread Yong Huang
On Wed, Jul 19, 2023 at 5:03 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Wed, Jul 19, 2023 at 1:26 PM Markus Armbruster > wrote: > > > >> Yong Huang writes: > >> > >> > On Tue, Jul 18, 2023 at 7:04 PM Markus Armbru

Re: [PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-19 Thread Yong Huang
On Wed, Jul 19, 2023 at 1:26 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Jul 18, 2023 at 7:04 PM Markus Armbruster > wrote: > > > >> Yong Huang writes: > >> > >> > On Thu, Jul 13, 2023 at 8:44 PM Markus Ar

Re: [PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-18 Thread Yong Huang
On Tue, Jul 18, 2023 at 7:04 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Thu, Jul 13, 2023 at 8:44 PM Markus Armbruster > wrote: > > > >> ~hyman writes: > >> > >> > From: Hyman Huang(黄勇) > >> > > >>

Re: [PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-17 Thread Yong Huang
On Thu, Jul 13, 2023 at 8:44 PM Markus Armbruster wrote: > ~hyman writes: > > > From: Hyman Huang(黄勇) > > > > Introduce migration dirty-limit capability, which can > > be turned on before live migration and limit dirty > > page rate durty live migration. > > > > Introduce migrate_dirty_limit

Re: [PATCH QEMU v7 4/9] migration: Introduce dirty-limit capability

2023-07-06 Thread Yong Huang
On Thu, Jul 6, 2023 at 10:59 PM Markus Armbruster wrote: > ~hyman writes: > > > From: Hyman Huang(黄勇) > > > > Introduce migration dirty-limit capability, which can > > be turned on before live migration and limit dirty > > page rate durty live migration. > > > > Introduce migrate_dirty_limit

Re: [PATCH QEMU v5 6/8] migration: Implement dirty-limit convergence algo

2023-06-15 Thread Yong Huang
On Wed, Jun 14, 2023 at 1:50 AM Juan Quintela wrote: > ~hyman wrote: > > From: Hyman Huang(黄勇) > > To speed thinkng up, 1-5 are included on next Migration PULL request. > OK, I'll post the next version only contain the last 3 commits. > > Implement dirty-limit convergence algo for live