Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-19 Thread Ani Sinha
On Tue, Sep 19, 2023 at 1:13 PM David Hildenbrand wrote: > > On 19.09.23 08:18, Ani Sinha wrote: > > On Tue, Sep 19, 2023 at 9:53 AM Ani Sinha wrote: > >> > >> On Tue, Sep 19, 2023 at 9:20 AM Ani Sinha wrote: > >>> > >>> On Mon, Sep 18, 2023 at 9:28 PM David Hildenbrand > >>> wrote: > >

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-19 Thread Ani Sinha
On Tue, Sep 19, 2023 at 1:38 PM Gerd Hoffmann wrote: > > Hi, > > > Anything above 4 GiB is beyond 32 bits. > > It's not that simple. Physical address space is 64G on processors with > PAE support. yeah I sent a patch previously to fix that as well.

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-19 Thread Gerd Hoffmann
Hi, > Anything above 4 GiB is beyond 32 bits. It's not that simple. Physical address space is 64G on processors with PAE support. take care, Gerd

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-19 Thread David Hildenbrand
On 19.09.23 08:18, Ani Sinha wrote: On Tue, Sep 19, 2023 at 9:53 AM Ani Sinha wrote: On Tue, Sep 19, 2023 at 9:20 AM Ani Sinha wrote: On Mon, Sep 18, 2023 at 9:28 PM David Hildenbrand wrote: On 18.09.23 17:56, Ani Sinha wrote: On Mon, Sep 18, 2023 at 8:59 PM David Hildenbrand wrote:

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-19 Thread Ani Sinha
On Tue, Sep 19, 2023 at 9:53 AM Ani Sinha wrote: > > On Tue, Sep 19, 2023 at 9:20 AM Ani Sinha wrote: > > > > On Mon, Sep 18, 2023 at 9:28 PM David Hildenbrand wrote: > > > > > > On 18.09.23 17:56, Ani Sinha wrote: > > > > On Mon, Sep 18, 2023 at 8:59 PM David Hildenbrand > > > > wrote: > > >

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Ani Sinha
On Tue, Sep 19, 2023 at 9:20 AM Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 9:28 PM David Hildenbrand wrote: > > > > On 18.09.23 17:56, Ani Sinha wrote: > > > On Mon, Sep 18, 2023 at 8:59 PM David Hildenbrand > > > wrote: > > >> > > >> On 18.09.23 17:22, Ani Sinha wrote: > > >>> On Mon, Sep

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Ani Sinha
On Mon, Sep 18, 2023 at 9:28 PM David Hildenbrand wrote: > > On 18.09.23 17:56, Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 8:59 PM David Hildenbrand wrote: > >> > >> On 18.09.23 17:22, Ani Sinha wrote: > >>> On Mon, Sep 18, 2023 at 7:25 PM Ani Sinha wrote: > > 32-bit systems do not

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 07:40:45PM +0530, Ani Sinha wrote: > On Mon, Sep 18, 2023 at 7:31 PM Michael S. Tsirkin wrote: > > > > On Mon, Sep 18, 2023 at 07:24:48PM +0530, Ani Sinha wrote: > > > 32-bit systems do not have a reserved memory for hole64 but they may have > > > a > > > reserved memory

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread David Hildenbrand
On 18.09.23 17:56, Ani Sinha wrote: On Mon, Sep 18, 2023 at 8:59 PM David Hildenbrand wrote: On 18.09.23 17:22, Ani Sinha wrote: On Mon, Sep 18, 2023 at 7:25 PM Ani Sinha wrote: 32-bit systems do not have a reserved memory for hole64 but they may have a reserved memory space for memory

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Ani Sinha
On Mon, Sep 18, 2023 at 8:59 PM David Hildenbrand wrote: > > On 18.09.23 17:22, Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 7:25 PM Ani Sinha wrote: > >> > >> 32-bit systems do not have a reserved memory for hole64 but they may have a > >> reserved memory space for memory hotplug. Since, hole64

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread David Hildenbrand
On 18.09.23 17:22, Ani Sinha wrote: On Mon, Sep 18, 2023 at 7:25 PM Ani Sinha wrote: 32-bit systems do not have a reserved memory for hole64 but they may have a reserved memory space for memory hotplug. Since, hole64 starts after the reserved hotplug memory, the unaligned hole64 start address

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Ani Sinha
On Mon, Sep 18, 2023 at 7:25 PM Ani Sinha wrote: > > 32-bit systems do not have a reserved memory for hole64 but they may have a > reserved memory space for memory hotplug. Since, hole64 starts after the > reserved hotplug memory, the unaligned hole64 start address gives us the > end address for

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Ani Sinha
On Mon, Sep 18, 2023 at 7:31 PM Michael S. Tsirkin wrote: > > On Mon, Sep 18, 2023 at 07:24:48PM +0530, Ani Sinha wrote: > > 32-bit systems do not have a reserved memory for hole64 but they may have a > > reserved memory space for memory hotplug. Since, hole64 starts after the > > reserved

Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 07:24:48PM +0530, Ani Sinha wrote: > 32-bit systems do not have a reserved memory for hole64 but they may have a > reserved memory space for memory hotplug. Since, hole64 starts after the > reserved hotplug memory, the unaligned hole64 start address gives us the > end

[PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems

2023-09-18 Thread Ani Sinha
32-bit systems do not have a reserved memory for hole64 but they may have a reserved memory space for memory hotplug. Since, hole64 starts after the reserved hotplug memory, the unaligned hole64 start address gives us the end address for this memory hotplug region that the processor may use. Fix