Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-18 Thread Alistair Francis
On Tue, Jul 18, 2023 at 1:42 AM Daniel Henrique Barboza wrote: > > Commit bd30559568 made changes in how we're checking and disabling > extensions based on env->priv_ver. One of the changes was to move the > extension disablement code to the end of realize(), being able to > disable extensions

Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-18 Thread Alistair Francis
On Tue, Jul 18, 2023 at 7:50 PM Daniel Henrique Barboza wrote: > > > > On 7/17/23 22:36, LIU Zhiwei wrote: > > > > On 2023/7/17 23:41, Daniel Henrique Barboza wrote: > >> Commit bd30559568 made changes in how we're checking and disabling > >> extensions based on env->priv_ver. One of the changes

Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-18 Thread Alistair Francis
On Tue, Jul 18, 2023 at 1:42 AM Daniel Henrique Barboza wrote: > > Commit bd30559568 made changes in how we're checking and disabling > extensions based on env->priv_ver. One of the changes was to move the > extension disablement code to the end of realize(), being able to > disable extensions

Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-18 Thread Daniel Henrique Barboza
On 7/17/23 22:36, LIU Zhiwei wrote: On 2023/7/17 23:41, Daniel Henrique Barboza wrote: Commit bd30559568 made changes in how we're checking and disabling extensions based on env->priv_ver. One of the changes was to move the extension disablement code to the end of realize(), being able to

Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-17 Thread LIU Zhiwei
On 2023/7/17 23:41, Daniel Henrique Barboza wrote: Commit bd30559568 made changes in how we're checking and disabling extensions based on env->priv_ver. One of the changes was to move the extension disablement code to the end of realize(), being able to disable extensions after we've

Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-17 Thread Weiwei Li
On 2023/7/17 23:41, Daniel Henrique Barboza wrote: Commit bd30559568 made changes in how we're checking and disabling extensions based on env->priv_ver. One of the changes was to move the extension disablement code to the end of realize(), being able to disable extensions after we've

Re: [PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-17 Thread Conor Dooley
On Mon, Jul 17, 2023 at 12:41:41PM -0300, Daniel Henrique Barboza wrote: > Commit bd30559568 made changes in how we're checking and disabling > extensions based on env->priv_ver. One of the changes was to move the > extension disablement code to the end of realize(), being able to > disable

[PATCH] target/riscv/cpu.c: check priv_ver before auto-enable zca/zcd/zcf

2023-07-17 Thread Daniel Henrique Barboza
Commit bd30559568 made changes in how we're checking and disabling extensions based on env->priv_ver. One of the changes was to move the extension disablement code to the end of realize(), being able to disable extensions after we've auto-enabled some of them. An unfortunate side effect of this