Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-05 Thread Paolo Bonzini
On 5/4/23 15:01, Fabiano Rosas wrote: ... # This config exists just so we can make SEMIHOSTING default when TCG # is selected without also changing it for other architectures. config ARM_SEMIHOSTING bool default y if TCG && ARM select ARM_COMPATIBLE_SEMIHOSTING This can be

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Alex Bennée
Paolo Bonzini writes: > On 5/3/23 21:38, Fabiano Rosas wrote: >> When building --without-default-devices, the semihosting code will not >> be available, so check the proper config. > > Acked-by: Paolo Bonzini > > for this change; however, there are two more related issues: > > 1) you still

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Fabiano Rosas
Paolo Bonzini writes: > Il gio 4 mag 2023, 10:59 Peter Maydell ha > scritto: > >> On Thu, 4 May 2023 at 08:33, Paolo Bonzini wrote: >> > >> > On 5/3/23 21:38, Fabiano Rosas wrote: >> > > When building --without-default-devices, the semihosting code will not >> > > be available, so check the

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Paolo Bonzini
Il gio 4 mag 2023, 10:59 Peter Maydell ha scritto: > On Thu, 4 May 2023 at 08:33, Paolo Bonzini wrote: > > > > On 5/3/23 21:38, Fabiano Rosas wrote: > > > When building --without-default-devices, the semihosting code will not > > > be available, so check the proper config. > > I think the

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Peter Maydell
On Thu, 4 May 2023 at 08:33, Paolo Bonzini wrote: > > On 5/3/23 21:38, Fabiano Rosas wrote: > > When building --without-default-devices, the semihosting code will not > > be available, so check the proper config. I think the changes to the ifdeffery are conceptually fine (only do semihosting if

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Paolo Bonzini
On 5/3/23 21:38, Fabiano Rosas wrote: When building --without-default-devices, the semihosting code will not be available, so check the proper config. Acked-by: Paolo Bonzini for this change; however, there are two more related issues: 1) you still want to leave out the code if !TCG,

[PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-03 Thread Fabiano Rosas
When building --without-default-devices, the semihosting code will not be available, so check the proper config. Fixes: 29d9efca16 ("arm/Kconfig: Do not build TCG-only boards on a KVM-only build") Signed-off-by: Fabiano Rosas --- target/arm/helper.c | 4 ++-- target/arm/tcg/m_helper.c |