Re: [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:39AM -0300, Fabiano Rosas wrote: > The tests are only allowed to run in systems that know about the > O_DIRECT flag and in filesystems which support it. > > Signed-off-by: Fabiano Rosas > --- > tests/qtest/migration-helpers.c | 42 +

Re: [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-05-03 Thread Peter Xu
On Fri, May 03, 2024 at 06:05:19PM -0300, Fabiano Rosas wrote: > >> +#ifdef O_DIRECT > >> +static void *migrate_mapped_ram_dio_start(QTestState *from, > >> + QTestState *to) > >> +{ > >> +migrate_mapped_ram_start(from, to); > > > > This line

Re: [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:39AM -0300, Fabiano Rosas wrote: >> The tests are only allowed to run in systems that know about the >> O_DIRECT flag and in filesystems which support it. >> >> Signed-off-by: Fabiano Rosas > > Mostly: > > Reviewed-by: Peter Xu > > Two trivial

Re: [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-05-03 Thread Peter Xu
On Fri, Apr 26, 2024 at 11:20:39AM -0300, Fabiano Rosas wrote: > The tests are only allowed to run in systems that know about the > O_DIRECT flag and in filesystems which support it. > > Signed-off-by: Fabiano Rosas Mostly: Reviewed-by: Peter Xu Two trivial comments below. > --- >

[PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-04-26 Thread Fabiano Rosas
The tests are only allowed to run in systems that know about the O_DIRECT flag and in filesystems which support it. Signed-off-by: Fabiano Rosas --- tests/qtest/migration-helpers.c | 42 + tests/qtest/migration-helpers.h | 1 + tests/qtest/migration-test.c|