Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-08-30 Thread Matt Borgerson
Thanks Alex On Wed, Aug 30, 2023, 14:47 Alex Bennée wrote: > > Matt Borgerson writes: > > > Translation logic may partially decode an instruction, then abort and > > remove the instruction from the TB. This can happen for example when an > > instruction spans two pages. In this case, plugins

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-08-30 Thread Alex Bennée
Matt Borgerson writes: > Translation logic may partially decode an instruction, then abort and > remove the instruction from the TB. This can happen for example when an > instruction spans two pages. In this case, plugins may get an incorrect > result when calling qemu_plugin_tb_n_insns to

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-08-24 Thread Philippe Mathieu-Daudé
On 19/7/23 00:05, Alex Bennée wrote: Matt Borgerson writes: Thanks Alex! On Mon, Jul 17, 2023 at 8:34 AM Alex Bennée wrote: Alex Bennée writes: Matt Borgerson writes: Translation logic may partially decode an instruction, then abort and remove the instruction from the TB. This

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-18 Thread Alex Bennée
Matt Borgerson writes: > Thanks Alex! > > > On Mon, Jul 17, 2023 at 8:34 AM Alex Bennée wrote: >> >> >> Alex Bennée writes: >> >> > Matt Borgerson writes: >> > >> >> Translation logic may partially decode an instruction, then abort and >> >> remove the instruction from the TB. This can

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-17 Thread Matt Borgerson
Thanks Alex! On Mon, Jul 17, 2023 at 8:34 AM Alex Bennée wrote: > > > Alex Bennée writes: > > > Matt Borgerson writes: > > > >> Translation logic may partially decode an instruction, then abort and > >> remove the instruction from the TB. This can happen for example when an > >> instruction

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-17 Thread Alex Bennée
Alex Bennée writes: > Matt Borgerson writes: > >> Translation logic may partially decode an instruction, then abort and >> remove the instruction from the TB. This can happen for example when an >> instruction spans two pages. In this case, plugins may get an incorrect >> result when calling

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-17 Thread Alex Bennée
Matt Borgerson writes: > Translation logic may partially decode an instruction, then abort and > remove the instruction from the TB. This can happen for example when an > instruction spans two pages. In this case, plugins may get an incorrect > result when calling qemu_plugin_tb_n_insns to

[PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-14 Thread Matt Borgerson
Translation logic may partially decode an instruction, then abort and remove the instruction from the TB. This can happen for example when an instruction spans two pages. In this case, plugins may get an incorrect result when calling qemu_plugin_tb_n_insns to query for the number of instructions