Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-05-01 Thread Aditya Gupta
Hi Cédric, Skiboot reports : [    0.121234172,6] P11 DD1.00 detected It is a DD2.0, with major revision = 0x2, and minor revision = 0. Might need some change in skiboot. Will post a v3 series with changes. The issue was in QEMU, not skiboot. QEMU sets CFAM id for Power10 as DD1.0

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-05-01 Thread Aditya Gupta
Hi Cédric, > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h index 0229ef3a9a5c..a1b540c3aa9e 100644 --- a/target/ppc/cpu-models.h +++ b/target/ppc/cpu-models.h @@ -354,6 +354,7 @@ enum {    CPU_POWERPC_POWER10_BASE   = 0x0080,    CPU_POWERPC_POWER10_DD1    =

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
> > Quoting lines from docs/system/ppc/powernv.rst: > > > > > Missing devices > > > --- > > > > > > A lot is missing, among which : > > > > > > * I2C controllers (yet to be merged). > > > * NPU/NPU2/NPU3 controllers. > > > * EEH support for PCIe Host bridge controllers. > > >

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Cédric Le Goater
On 4/26/24 19:05, Aditya Gupta wrote: Hello Cédric, Thanks for your reviews. On Fri, Apr 26, 2024 at 04:27:04PM +0200, Cédric Le Goater wrote: Hello Aditya On 4/26/24 13:00, Aditya Gupta wrote: Add base support for "--cpu power11" in QEMU. Power11 core is same as Power10, hence reuse

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Cédric Le Goater
On 4/26/24 19:12, Aditya Gupta wrote: Hello Cédric, diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst index a876d897b6e4..3277564b34c2 100644 --- a/docs/system/ppc/pseries.rst +++ b/docs/system/ppc/pseries.rst @@ -15,9 +15,9 @@ Supported devices = *

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
Hello Cédric, > > diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst > > index a876d897b6e4..3277564b34c2 100644 > > --- a/docs/system/ppc/pseries.rst > > +++ b/docs/system/ppc/pseries.rst > > @@ -15,9 +15,9 @@ Supported devices > > = > >* Multi processor

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
Hello Cédric, Thanks for your reviews. On Fri, Apr 26, 2024 at 04:27:04PM +0200, Cédric Le Goater wrote: > Hello Aditya > > On 4/26/24 13:00, Aditya Gupta wrote: > > Add base support for "--cpu power11" in QEMU. > > > > Power11 core is same as Power10, hence reuse functions defined for > >

Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Cédric Le Goater
Hello Aditya On 4/26/24 13:00, Aditya Gupta wrote: Add base support for "--cpu power11" in QEMU. Power11 core is same as Power10, hence reuse functions defined for Power10. Power11 uses the same ISA it seems. What's the value then ? Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc:

[PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

2024-04-26 Thread Aditya Gupta
Add base support for "--cpu power11" in QEMU. Power11 core is same as Power10, hence reuse functions defined for Power10. Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: David Gibson Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin