Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-09 Thread Ani Sinha
On Wed, Sep 28, 2022 at 1:14 PM Thomas Huth wrote: > > > > > Do not do any of this stuff, it is irrelevant to QEMU's needs. > > A developer using Avocado with QEMU does nothing more than: > > > > make check-avocado > > Right. And if you want to run individual tests, you can also do it like

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-09 Thread Ani Sinha
On Sun, Oct 9, 2022 at 10:51 AM Ani Sinha wrote: > > On Wed, Sep 28, 2022 at 1:14 PM Thomas Huth wrote: > > > > > > > Do not do any of this stuff, it is irrelevant to QEMU's needs. > > > A developer using Avocado with QEMU does nothing more than: > > > > > > make check-avocado > > > >

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-08 Thread Ani Sinha
On Wed, Sep 28, 2022 at 1:14 PM Thomas Huth wrote: > > On 28/09/2022 09.06, Daniel P. Berrangé wrote: > > On Tue, Sep 27, 2022 at 06:09:22PM -0400, Michael S. Tsirkin wrote: > >> On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote: > >>> I also second the idea of using avocado instead

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 11:36:51AM +0530, Ani Sinha wrote: > On Wed, Sep 28, 2022 at 9:28 AM Michael S. Tsirkin wrote: > > > > On Wed, Sep 28, 2022 at 08:38:54AM +0530, Ani Sinha wrote: > > > > I don't really care where we upload them but only having the > > > > latest version is just going to

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Ani Sinha
On Thu, 6 Oct 2022, Ani Sinha wrote: > > > On Thu, 6 Oct 2022, Ani Sinha wrote: > > > > > > > On Wed, 28 Sep 2022, Michael S. Tsirkin wrote: > > > > > On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > > > > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > > > > On Wed, Sep 28,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Ani Sinha
On Thu, 6 Oct 2022, Ani Sinha wrote: > > > On Wed, 28 Sep 2022, Michael S. Tsirkin wrote: > > > On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > > > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > > > On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > > > > > On

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Ani Sinha
On Wed, 28 Sep 2022, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > > On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > > > > On 27/09/2022 23.21, Michael S. Tsirkin wrote: > > > > > On

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > > > On 27/09/2022 23.21, Michael S. Tsirkin wrote: > > > > On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > On 27/09/2022 23.21, Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: > ... > > > > Alright, .gitlab-ci.yml is produced

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Thomas Huth
On 27/09/2022 23.21, Michael S. Tsirkin wrote: On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé wrote: On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: ... Alright, .gitlab-ci.yml is produced and the pipeline succeeds. However, the question still remains, where do we

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Daniel P . Berrangé
On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > On 27/09/2022 23.21, Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: > ... > > > > Alright, .gitlab-ci.yml is produced

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 09:35:59AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > > On 27/09/2022 23.21, Michael S. Tsirkin wrote: > > > On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Sep 27, 2022 at 07:35:13PM

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Thomas Huth
On 28/09/2022 11.35, Michael S. Tsirkin wrote: On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: On 27/09/2022 23.21, Michael S. Tsirkin wrote: On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé wrote: On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: ...

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 07:58:46AM +0100, Daniel P. Berrangé wrote: > biosbits isn't tied to QEMU versions, it is an entirely separate 3rd > party project. This binary is just providing the test env, and IIUC, > control over what executes in this env is still done by the QEMU side > test scripts.

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Daniel P . Berrangé
On Wed, Sep 28, 2022 at 12:45:46PM +0530, Ani Sinha wrote: > On Wed, Sep 28, 2022 at 12:28 PM Daniel P. Berrangé > wrote: > > > > On Tue, Sep 27, 2022 at 05:18:10PM -0400, Michael S. Tsirkin wrote: > > > On Tue, Sep 27, 2022 at 09:33:27AM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Sep 27,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Thomas Huth
On 28/09/2022 09.06, Daniel P. Berrangé wrote: On Tue, Sep 27, 2022 at 06:09:22PM -0400, Michael S. Tsirkin wrote: On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote: I also second the idea of using avocado instead of pytest, by the way. snip Problem is I don't think avocado is

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 06:09:22PM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote: > > I also second the idea of using avocado instead of pytest, by the way. snip > Problem is I don't think avocado is yet at the level where I can > ask random

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 05:18:10PM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 27, 2022 at 09:33:27AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 27, 2022 at 01:43:15PM +0530, Ani Sinha wrote: > > > On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Ani Sinha
On Wed, Sep 28, 2022 at 12:28 PM Daniel P. Berrangé wrote: > > On Tue, Sep 27, 2022 at 05:18:10PM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2022 at 09:33:27AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Sep 27, 2022 at 01:43:15PM +0530, Ani Sinha wrote: > > > > On Sun, Sep 18, 2022

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-28 Thread Ani Sinha
On Wed, Sep 28, 2022 at 9:28 AM Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 08:38:54AM +0530, Ani Sinha wrote: > > > I don't really care where we upload them but only having the > > > latest version is just going to break anything expecting > > > the old binary. > > > > In fairness, I

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 01:10:15AM +0200, Paolo Bonzini wrote: > > > Il mer 28 set 2022, 00:09 Michael S. Tsirkin ha scritto: > > On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote: > > I also second the idea of using avocado instead of pytest, by the way. > > > >

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 08:38:54AM +0530, Ani Sinha wrote: > > I don't really care where we upload them but only having the > > latest version is just going to break anything expecting > > the old binary. > > In fairness, I am not entirely certain if there is a tight coupling > between the qemu

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Wed, Sep 28, 2022 at 2:48 AM Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2022 at 09:33:27AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 27, 2022 at 01:43:15PM +0530, Ani Sinha wrote: > > > On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Sep 16,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Paolo Bonzini
Il mer 28 set 2022, 00:09 Michael S. Tsirkin ha scritto: > On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote: > > I also second the idea of using avocado instead of pytest, by the way. > > > > Paolo > > I do not think this is a good fit for bios tests. > bios tests are intended for a

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2022 at 11:44:56PM +0200, Paolo Bonzini wrote: > I also second the idea of using avocado instead of pytest, by the way. > > Paolo I do not think this is a good fit for bios tests. bios tests are intended for a wide audience of ACPI developers across a variety of host systems.

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Paolo Bonzini
Il dom 10 lug 2022, 19:01 Ani Sinha ha scritto: > This change adds python based test environment that can be used to run > pytest > from within a virtual environment. A bash script sets up a virtual > environment > and then runs the python based tests from within that environment. > All

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > > > > > > > git.qemu.org and > > > > > > > the binaries in some other repo first. Everything else hinges on > > > > > > > that. We > > > > > > > can

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2022 at 04:45:09PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: > > On Tue, Sep 27, 2022 at 5:12 PM Ani Sinha wrote: > > > > > > On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé > > > wrote: > > > > > > > > On Tue, Sep 27, 2022

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2022 at 09:33:27AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 27, 2022 at 01:43:15PM +0530, Ani Sinha wrote: > > On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin wrote: > > > > > > On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote: > > > > On Thu, Jul 28, 2022 at

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: > On Tue, Sep 27, 2022 at 5:12 PM Ani Sinha wrote: > > > > On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > > > OK

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Tue, Sep 27, 2022 at 5:12 PM Ani Sinha wrote: > > On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé > wrote: > > > > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > > > > > > > > >

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé wrote: > > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > > > > > > > > git.qemu.org and > > > > > > > > the binaries in some other repo first.

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Tue, Sep 27, 2022 at 15:48 Daniel P. Berrangé wrote: > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > git.qemu.org and > > > > > > > > the binaries in some other repo first. Everything else >

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > > > > > > > git.qemu.org and > > > > > > > the binaries in some other repo first. Everything else hinges on > > > > > > > that. We > > > > > > > can

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
> > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in > > > > > > git.qemu.org and > > > > > > the binaries in some other repo first. Everything else hinges on > > > > > > that. We > > > > > > can fix the rest of the bits later incrementally. > > > > > > > > > > DanPB,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 01:43:15PM +0530, Ani Sinha wrote: > On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin wrote: > > > > On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote: > > > On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > > > > > > > > > > > > > On Mon, 25 Jul 2022,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin wrote: > > On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote: > > On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > > > > > > > > > On Mon, 25 Jul 2022, Ani Sinha wrote: > > > > > > > > > > > > > > > On Sat, 16 Jul 2022, Michael

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-17 Thread Michael S. Tsirkin
On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote: > On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > > > > > On Mon, 25 Jul 2022, Ani Sinha wrote: > > > > > > > > > > > On Sat, 16 Jul 2022, Michael S. Tsirkin wrote: > > > > > > > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-16 Thread Ani Sinha
On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > On Mon, 25 Jul 2022, Ani Sinha wrote: > > > > > > > On Sat, 16 Jul 2022, Michael S. Tsirkin wrote: > > > > > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Fri, Jul 15, 2022 at 11:20 Michael S.

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-06 Thread Daniel P . Berrangé
On Tue, Jul 12, 2022 at 12:45:59PM +0530, Ani Sinha wrote: > > > On Mon, 11 Jul 2022, John Snow wrote: > > > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > > > > > This change adds python based test environment that can be used to run > > > pytest > > > from within a virtual

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-27 Thread Ani Sinha
On Mon, 25 Jul 2022, Ani Sinha wrote: > > > On Sat, 16 Jul 2022, Michael S. Tsirkin wrote: > > > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > > > > > > > On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-25 Thread Ani Sinha
On Sat, 16 Jul 2022, Michael S. Tsirkin wrote: > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > > > > On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin wrote: > > > > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote: > > > > Instead of all this mess, can't we

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-16 Thread Michael S. Tsirkin
On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin wrote: > > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote: > > > Instead of all this mess, can't we just spawn e.g. "git clone --depth > 1"? > > > And if

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-16 Thread Ani Sinha
On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin wrote: > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote: > > > Instead of all this mess, can't we just spawn e.g. "git clone --depth > 1"? > > > And if the directory exists I would fetch and checkout. > > > > There are two reasons I can

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-15 Thread Michael S. Tsirkin
On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote: > > Instead of all this mess, can't we just spawn e.g. "git clone --depth 1"? > > And if the directory exists I would fetch and checkout. > > There are two reasons I can think of why I do not like this idea: > > (a) a git clone of a

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Ani Sinha
On Thu, 14 Jul 2022, Michael S. Tsirkin wrote: > On Sun, Jul 10, 2022 at 10:30:10PM +0530, Ani Sinha wrote: > > This change adds python based test environment that can be used to run > > pytest > > from within a virtual environment. A bash script sets up a virtual > > environment > > and

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Michael S. Tsirkin
On Thu, Jul 14, 2022 at 07:49:36PM +0530, Ani Sinha wrote: > > so you skip downlaod if it already exists locally. IIUC it is looking > > in the CWD, which is presumably the directory the QEMU build is > > performed in ? > > Yes, build/test/pytest/bits-test > > > So if dev cleans their build

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Michael S. Tsirkin
On Sun, Jul 10, 2022 at 10:30:10PM +0530, Ani Sinha wrote: > This change adds python based test environment that can be used to run pytest > from within a virtual environment. A bash script sets up a virtual environment > and then runs the python based tests from within that environment. > All

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Ani Sinha
On Thu, Jul 14, 2022 at 19:49 Ani Sinha wrote: > > > On Thu, 14 Jul 2022, Daniel P. Berrangé wrote: > > > On Sun, Jul 10, 2022 at 10:30:10PM +0530, Ani Sinha wrote: > > > This change adds python based test environment that can be used to run > pytest > > > from within a virtual environment. A

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Ani Sinha
On Thu, 14 Jul 2022, Daniel P. Berrangé wrote: > On Sun, Jul 10, 2022 at 10:30:10PM +0530, Ani Sinha wrote: > > This change adds python based test environment that can be used to run > > pytest > > from within a virtual environment. A bash script sets up a virtual > > environment > > and then

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Daniel P . Berrangé
On Sun, Jul 10, 2022 at 10:30:10PM +0530, Ani Sinha wrote: > This change adds python based test environment that can be used to run pytest > from within a virtual environment. A bash script sets up a virtual environment > and then runs the python based tests from within that environment. > All

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-12 Thread Ani Sinha
On Mon, 11 Jul 2022, John Snow wrote: > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > > > This change adds python based test environment that can be used to run > > pytest > > from within a virtual environment. A bash script sets up a virtual > > environment > > and then runs the

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-11 Thread John Snow
On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > This change adds python based test environment that can be used to run pytest > from within a virtual environment. A bash script sets up a virtual environment > and then runs the python based tests from within that environment. > All dependent

[PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-10 Thread Ani Sinha
This change adds python based test environment that can be used to run pytest from within a virtual environment. A bash script sets up a virtual environment and then runs the python based tests from within that environment. All dependent python packages are installed in the virtual environment