Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-06 Thread Suthikulpanit, Suravee
Igor, On 6/6/2023 3:11 PM, Igor Mammedov wrote: On Tue, 6 Jun 2023 09:35:41 +0200 Igor Mammedov wrote: On Mon, 5 Jun 2023 16:39:05 -0500 Suravee Suthikulpanit wrote: [...] +/* For pc-i44fx-8.0 and older, use SMBIOS 2.8 by default */ +pcmc->default_smbios_ep_type =

Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-06 Thread Suthikulpanit, Suravee
On 6/6/2023 2:35 PM, Igor Mammedov wrote: On Mon, 5 Jun 2023 16:39:05 -0500 Suravee Suthikulpanit wrote: Currently, pc-q35 and pc-i44fx machine models are default to use SMBIOS 2.8 (32-bit entry point). Since SMBIOS 3.0 (64-bit entry point) is now fully supported since QEMU 7.0, default to

Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-06 Thread Igor Mammedov
On Tue, 6 Jun 2023 09:35:41 +0200 Igor Mammedov wrote: > On Mon, 5 Jun 2023 16:39:05 -0500 > Suravee Suthikulpanit wrote: [...] > > +/* For pc-i44fx-8.0 and older, use SMBIOS 2.8 by default */ > > +pcmc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_32; > > } [...] > > static void

Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-06 Thread Igor Mammedov
On Mon, 5 Jun 2023 16:39:05 -0500 Suravee Suthikulpanit wrote: > Currently, pc-q35 and pc-i44fx machine models are default to use SMBIOS 2.8 > (32-bit entry point). Since SMBIOS 3.0 (64-bit entry point) is now fully > supported since QEMU 7.0, default to use SMBIOS 3.0 for newer machine >

[PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-05 Thread Suravee Suthikulpanit
Currently, pc-q35 and pc-i44fx machine models are default to use SMBIOS 2.8 (32-bit entry point). Since SMBIOS 3.0 (64-bit entry point) is now fully supported since QEMU 7.0, default to use SMBIOS 3.0 for newer machine models. This is necessary to avoid the following message when launching a VM