[Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path

2014-09-11 Thread Stefan Hajnoczi
Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc (block: Replace in_use with operation blocker) broke the error path because it consumed local_err instead of propagating it. The caller has no way to know that the function failed. This caused virtio-blk to start successfully even though there was

Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path

2014-09-11 Thread Eric Blake
On 09/11/2014 06:49 AM, Stefan Hajnoczi wrote: Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc (block: Replace in_use with operation blocker) broke the error path because it consumed local_err instead of propagating it. The caller has no way to know that the function failed. This caused

Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path

2014-09-11 Thread Kevin Wolf
Am 11.09.2014 um 14:49 hat Stefan Hajnoczi geschrieben: Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc (block: Replace in_use with operation blocker) broke the error path because it consumed local_err instead of propagating it. The caller has no way to know that the function failed. This