Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Wednesday 10 Sep 2014 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer.

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer.

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Wednesday 10 Sep 2014 à 14:40:42 (+0200), Benoît Canet wrote : The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : [...] diff --git a/qemu-img.c b/qemu-img.c index 4490a22..bad3f64 100644 --- a/qemu-img.c +++

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Kevin Wolf kw...@redhat.com writes: [...] diff --git a/qemu-img.c b/qemu-img.c index 4490a22..bad3f64 100644 --- a/qemu-img.c +++ b/qemu-img.c Won't comment on each hunk in qemu-img, but in many cases, on bdrv_new_open() failure, blk is leaked.

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Kevin Wolf kw...@redhat.com writes: [...] diff --git a/blockdev.c b/blockdev.c index 9fbd888..86596bc 100644 --- a/blockdev.c +++ b/blockdev.c [...] @@ -1770,7 +1778,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data)

[Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Markus Armbruster
A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a single abstraction BlockDriverState both for tree nodes and the backend as a whole. Drawbacks: * Its

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Kevin Wolf
Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a single abstraction BlockDriverState both

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a single abstraction

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Kevin Wolf
Am 10.09.2014 um 13:34 hat Benoît Canet geschrieben: The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 13:44:17 (+0200), Kevin Wolf wrote : Am 10.09.2014 um 13:34 hat Benoît Canet geschrieben: The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a single abstraction

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 14:40:42 (+0200), Benoît Canet wrote : The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is