[Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
In preperation for supporting a larger framebuffer for multiple monitors on a single card, add a property to qxl fb_size_mb, and corresponding byte sized fb_size, and use instead of VGA_RAM_SIZE. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 31 ---

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Gerd Hoffmann
Hi, +if (d-fb_size fb) { +d-fb_size = fb; +} +if (fb = d-fb_size) { This check doesn't make sense, it will always be true. +if (qxl-fb_size_mb != -1 +qxl-fb_size_mb * 1024 * 1024 qxl-vga.vram_size) { +qxl-fb_size =

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 09:42:28AM +0200, Gerd Hoffmann wrote: Hi, +if (d-fb_size fb) { +d-fb_size = fb; +} +if (fb = d-fb_size) { This check doesn't make sense, it will always be true. My mistake. Will remove the first three lines, so fb_size

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Gerd Hoffmann
Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ... Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1 It probably makes sense to base this on top. So I can rebase on top and send the patches, with the

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ... Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1 It probably makes sense to base

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ... Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1 It probably makes sense to base

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Gerd Hoffmann
On 06/11/12 11:33, Alon Levy wrote: On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ... Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1 It

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 12:18:14PM +0200, Gerd Hoffmann wrote: On 06/11/12 11:33, Alon Levy wrote: On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ...