Eric Blake ebl...@redhat.com writes:
On 09/11/2014 01:34 PM, Benoît Canet wrote:
The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote :
Benoît Canet benoit.ca...@irqsave.net writes:
+ blk_bs(blk_by_legacy_dinfo(dinfo)));
This seems to be a
The Wednesday 10 Sep 2014 à 10:13:39 (+0200), Markus Armbruster wrote :
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 3 +--
hw/arm/collie.c | 9 +
hw/arm/gumstix.c | 5 +++--
+ blk_bs(blk_by_legacy_dinfo(dinfo)));
This seems to be a fairly common pattern: blk_bs(blk_by_legacy_dinfo()).
How about a helper function ?
Benoît Canet benoit.ca...@irqsave.net writes:
+ blk_bs(blk_by_legacy_dinfo(dinfo)));
This seems to be a fairly common pattern: blk_bs(blk_by_legacy_dinfo()).
How about a helper function ?
Yes, except the pattern is going to evaporate in patch 14 :)
Benoît Canet benoit.ca...@irqsave.net writes:
I have trouble to review this as I don't understand the qdevs parts.
Maybe someone else could have a look at it.
The patch is big, but all it really does is replacing
dinfo-bdrv
by
blk_bs(blk_legacy_dinfo(dinfo))
Line wrapping muddies
The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote :
Benoît Canet benoit.ca...@irqsave.net writes:
+ blk_bs(blk_by_legacy_dinfo(dinfo)));
This seems to be a fairly common pattern: blk_bs(blk_by_legacy_dinfo()).
How about a helper
On 09/11/2014 01:34 PM, Benoît Canet wrote:
The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote :
Benoît Canet benoit.ca...@irqsave.net writes:
+ blk_bs(blk_by_legacy_dinfo(dinfo)));
This seems to be a fairly common pattern:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 3 +--
hw/arm/collie.c | 9 +
hw/arm/gumstix.c | 5 +++--
hw/arm/mainstone.c | 8
hw/arm/musicpal.c