Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-12 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 09/11/2014 01:34 PM, Benoît Canet wrote: The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:39 (+0200), Markus Armbruster wrote : Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c | 3 +-- hw/arm/collie.c | 9 + hw/arm/gumstix.c | 5 +++--

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Benoît Canet
+ blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common pattern: blk_bs(blk_by_legacy_dinfo()). How about a helper function ?

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common pattern: blk_bs(blk_by_legacy_dinfo()). How about a helper function ? Yes, except the pattern is going to evaporate in patch 14 :)

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: I have trouble to review this as I don't understand the qdevs parts. Maybe someone else could have a look at it. The patch is big, but all it really does is replacing dinfo-bdrv by blk_bs(blk_legacy_dinfo(dinfo)) Line wrapping muddies

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Benoît Canet
The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common pattern: blk_bs(blk_by_legacy_dinfo()). How about a helper

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Eric Blake
On 09/11/2014 01:34 PM, Benoît Canet wrote: The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common pattern:

[Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c | 3 +-- hw/arm/collie.c | 9 + hw/arm/gumstix.c | 5 +++-- hw/arm/mainstone.c | 8 hw/arm/musicpal.c