Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-28 Thread Stefan Hajnoczi
On Thu, Mar 27, 2014 at 08:58:38PM +0100, Stefan Weil wrote: Am 27.03.2014 19:52, schrieb Jeff Cody: Do we need this patch for QEMU 2.0? For 32 bit systems, the image size limit is 1000 TB, and that image would need 4 GB for the block cache in memory. Are such image sizes used anywhere? For

Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-28 Thread Jeff Cody
On Fri, Mar 28, 2014 at 10:07:22AM +0100, Stefan Hajnoczi wrote: On Thu, Mar 27, 2014 at 08:58:38PM +0100, Stefan Weil wrote: Am 27.03.2014 19:52, schrieb Jeff Cody: Do we need this patch for QEMU 2.0? For 32 bit systems, the image size limit is 1000 TB, and that image would need 4 GB for

Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-27 Thread Jeff Cody
On Wed, Mar 26, 2014 at 07:21:29PM +0100, Stefan Weil wrote: Hi Stefan, hi Jeff, please cc me for future block/vdi.c related patches. See more comments below. Am 26.03.2014 13:05, schrieb Stefan Hajnoczi: From: Jeff Cody jc...@redhat.com The maximum blocks_in_image is 0x /

Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-27 Thread Stefan Weil
Am 27.03.2014 19:52, schrieb Jeff Cody: [...] I looked around, and I could not find a definitive source for a VDI specification. Do you know if there is a specified max size for a VDI image? I used the reference which I also mentioned in the header comment of block/vdi.c:

[Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-26 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com The maximum blocks_in_image is 0x / 4, which also limits the maximum disk_size for a VDI image. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vdi.c | 28 +--- 1 file changed, 25

Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-26 Thread Stefan Weil
Hi Stefan, hi Jeff, please cc me for future block/vdi.c related patches. See more comments below. Am 26.03.2014 13:05, schrieb Stefan Hajnoczi: From: Jeff Cody jc...@redhat.com The maximum blocks_in_image is 0x / 4, which also limits the maximum disk_size for a VDI image.