Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-23 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 08:30:19AM -0400, Jeff Cody wrote: On Thu, Jun 19, 2014 at 04:55:02PM +0800, Stefan Hajnoczi wrote: On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: It seems like neither type of user will get much mileage out of this feature. Is it really necessary or did

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If node_names are automatically generated when not specified, that means that all

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-19 Thread Jeff Cody
On Thu, Jun 19, 2014 at 04:55:02PM +0800, Stefan Hajnoczi wrote: On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-19 Thread Eric Blake
On 06/19/2014 06:30 AM, Jeff Cody wrote: If node_names are automatically generated when not specified, that means that all block job operations can be done by reference to the unique node_name field. This eliminates ambiguity in resolving filenames (relative filenames, or file descriptors,

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-19 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 08:30:19AM -0400, Jeff Cody wrote: On Thu, Jun 19, 2014 at 04:55:02PM +0800, Stefan Hajnoczi wrote: On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified,

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-18 Thread Benoît Canet
The Tuesday 17 Jun 2014 à 17:53:49 (-0400), Jeff Cody wrote : Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If node_names are automatically generated when not specified, that means that

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-18 Thread Jeff Cody
On Wed, Jun 18, 2014 at 02:53:15PM +0200, Benoît Canet wrote: The Tuesday 17 Jun 2014 à 17:53:49 (-0400), Jeff Cody wrote : Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-18 Thread Benoît Canet
The Wednesday 18 Jun 2014 à 09:13:28 (-0400), Jeff Cody wrote : On Wed, Jun 18, 2014 at 02:53:15PM +0200, Benoît Canet wrote: The Tuesday 17 Jun 2014 à 17:53:49 (-0400), Jeff Cody wrote : Currently, node_name is only filled in when done so explicitly by the user. If no node_name is

[Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-17 Thread Jeff Cody
Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If node_names are automatically generated when not specified, that means that all block job operations can be done by reference to the unique