Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 08.01.2014 04:07, schrieb Peter Crosthwaite: On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/01/2014 16:12, Markus Armbruster ha scritto: aarch64 akita info qtree crashes aarch64 borzoi

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/01/2014 16:12, Markus Armbruster ha scritto: aarch64 akita info qtree crashes aarch64 borzoi info qtree crashes aarch64

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-08 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 5:27 PM, Li Guang lig.f...@cn.fujitsu.com wrote: Beniamino Galvani wrote: On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote: Hi, please use prefix AwA10 for names instead of Aw, also PATCH 1/2. Hi, I agree with you that there is an inconsistency in the

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-08 Thread Loic Dachary
On 08/01/2014 05:33, Stefan Hajnoczi wrote: On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote: On 06/01/2014 03:23, Stefan Hajnoczi wrote: On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 6:13 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/01/2014 16:12, Markus Armbruster ha scritto: aarch64 akita

[Qemu-devel] [PATCH 2/6] qemu-bridge-helper: replace send_fd with qemu_send_with_fd

2014-01-08 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile |2 +- qemu-bridge-helper.c | 31 +++ 2 files changed, 4 insertions(+), 29 deletions(-) diff --git a/Makefile b/Makefile index bdff4e4..6850f35 100644 --- a/Makefile +++ b/Makefile @@ -195,7

[Qemu-devel] [PATCH resend 0/6 RFC] Provide common methods for exchange FD

2014-01-08 Thread Lei Li
This patch series tries to refactor the functions used for exchange of FD in current code, provide common methods for it. The series is based on the localhost migration with side channel for ram series as it was already a good shape. But if you want to merge this first, I'll get rid of the

[Qemu-devel] [PATCH 4/6] virtfs-proxy-helper: replace send_fd with qemu_send_with_fd

2014-01-08 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- fsdev/virtfs-proxy-helper.c | 51 ++ hw/9pfs/virtio-9p-proxy.h |5 2 files changed, 8 insertions(+), 48 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c

[Qemu-devel] [PATCHv4 0/6] ui/vnc: update optimizations

2014-01-08 Thread Peter Lieven
this series includes several optimizations for the ui/vnc guest to server and server to client update cycles. comments/reviews appreciated. v3-v4: - patch 1,4,6 unchanged - patch 2: fix 2 missing changes from 16 - VNC_DIRTY_PIXELS_PER_BIT [Wenchao] - patch 3: fixed missing

[Qemu-devel] [PATCH 5/6] virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd

2014-01-08 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-proxy.c | 60 ++-- 1 files changed, 3 insertions(+), 57 deletions(-) diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c index 5f44bb7..f34b845 100644 ---

[Qemu-devel] [PATCHv4 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT

2014-01-08 Thread Peter Lieven
this allows for setting VNC_DIRTY_PIXELS_PER_BIT to different values than 16 if desired. Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index

[Qemu-devel] [PATCH 6/6] migration-local: replace send_pipefd with qemu_send_with_fd

2014-01-08 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration-local.c | 52 +++- 1 files changed, 3 insertions(+), 49 deletions(-) diff --git a/migration-local.c b/migration-local.c index ce4c070..c01ba06 100644 --- a/migration-local.c +++

[Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-08 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/qemu/fd-exchange.h | 25 +++ util/Makefile.objs |1 + util/qemu-fd-exchange.c| 97 3 files changed, 123 insertions(+), 0 deletions(-) create mode 100644

[Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed

2014-01-08 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c |9 + 1 file changed, 9 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index da552fe..a742d32 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3170,7 +3170,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Peter Maydell
On 8 January 2014 04:24, Andreas Färber afaer...@suse.de wrote: P.S. PMM, reading aarch64 above in the context of machines, I don't see a single check-qtest-aarch64-y line in tests/Makefile! Please enable qom-test if qemu-system-aarch64 is already available. Thought you just said it would be

[Qemu-devel] [PATCH v11 03/11] block: Replace in_use with operation blocker

2014-01-08 Thread Fam Zheng
This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g. in place of

[Qemu-devel] [PATCH v11 11/11] block: Allow backup on referenced named BlockDriverState

2014-01-08 Thread Fam Zheng
Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng f...@redhat.com

[Qemu-devel] [PATCH v11 07/11] block: Parse backing option to reference existing BDS

2014-01-08 Thread Fam Zheng
Now it's safe to allow reference for backing_hd in the interface. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 2ccc006..ca4e362 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH v11 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-08 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD server. The steps are as below: 1. (SHELL)

[Qemu-devel] [PATCH v11 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images

2014-01-08 Thread Fam Zheng
This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng f...@redhat.com --- block/stream.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/block/stream.c b/block/stream.c index 46bec7d..9cdcf0e 100644 --- a/block/stream.c +++

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, 2013-06-18). Should probably be reverted. Prefer not, under no reasonable definition is NAND a sysbus device. Whats the real problem here? What is

[Qemu-devel] [PATCHv4 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height()

2014-01-08 Thread Peter Lieven
The following artifical test (just the bitmap operation part) running vnc_update_client 65536 times on a 2560x2048 surface illustrates the performance difference: All bits clean - vnc_update_client_new: 0.07 secs vnc_update_client_new2: 0.07 secs

[Qemu-devel] [PATCHv4 5/6] ui/vnc: optimize setting in vnc_dpy_update()

2014-01-08 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 4117230..da552fe 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -430,30 +430,24 @@ static int vnc_refresh_server_surface(VncDisplay

[Qemu-devel] [PATCH v11 02/11] block: Introduce op_blockers to BlockDriverState

2014-01-08 Thread Fam Zheng
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage is: * BDS user

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2014-01-08 Thread Amos Kong
On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote: Markus Armbruster arm...@redhat.com writes: Amos Kong ak...@redhat.com writes: Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 We have a requests queue to cache the random data, but the second will come in

[Qemu-devel] [PATCH v11 06/11] block: Add backing_blocker in BlockDriverState

2014-01-08 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState-backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not

[Qemu-devel] [PATCH v11 08/11] block: Support dropping active in bdrv_drop_intermediate

2014-01-08 Thread Fam Zheng
Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs to work with op blockers. Signed-off-by: Fam Zheng f...@redhat.com --- block.c| 145 ++---

[Qemu-devel] [PATCH v11 04/11] block: Move op_blocker check from block_job_create to its caller

2014-01-08 Thread Fam Zheng
It makes no sense to check for any blocker on bs, we are here only because of the mechanical conversion from in_use to op_blockers. Remove it now, and let the callers check specific operation types. Backup and mirror already have it, add checker to stream and commit. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCHv4 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro

2014-01-08 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c | 65 +++--- ui/vnc.h |6 +- 2 files changed, 46 insertions(+), 25 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..0925bf2 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@

[Qemu-devel] [PATCH v11 10/11] qmp: Add command 'blockdev-backup'

2014-01-08 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Signed-off-by: Fam Zheng f...@redhat.com --- block/backup.c | 21 + blockdev.c

[Qemu-devel] [PATCHv4 3/6] ui/vnc: optimize dirty bitmap tracking

2014-01-08 Thread Peter Lieven
vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty. vnc_refresh_server_surface does almost the same. this patch optimizes both by utilizing the heavily optimized function find_next_bit to find the offset of the next

[Qemu-devel] [PATCH v11 01/11] block: Add BlockOpType enum

2014-01-08 Thread Fam Zheng
This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng f...@redhat.com --- include/block/block.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 36efaea..2bc39fe 100644

[Qemu-devel] [PATCH 3/6] net/tap: replace recv_fd with qemu_recv_with_fd

2014-01-08 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- net/tap.c | 40 +++- 1 files changed, 3 insertions(+), 37 deletions(-) diff --git a/net/tap.c b/net/tap.c index 39c1cda..97ee2e8 100644 --- a/net/tap.c +++ b/net/tap.c @@ -39,6 +39,7 @@ #include

Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

2014-01-08 Thread Peter Maydell
On 8 January 2014 06:55, Stefan Weil s...@weilnetz.de wrote: Am 08.01.2014 00:00, schrieb Peter Maydell: Some experimentation suggests it would also be possible to just do extern C { #include disas/bfd.h } in the C++ file. If that doesn't have any hidden gotchas I don't know about it

[Qemu-devel] [PATCH v11 05/11] block: Add bdrv_set_backing_hd()

2014-01-08 Thread Fam Zheng
This is the common but non-trivial steps to assign or change the backing_hd of BDS. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 34 -- include/block/block.h | 1 + 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/block.c

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Andreas Färber
Am 08.01.2014 09:13, schrieb Markus Armbruster: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/01/2014 16:12, Markus Armbruster ha scritto: aarch64 akita info qtree crashes aarch64

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 14:40, Andreas Färber ha scritto: Either you fix info qtree to cope with your change to the device graph, or the change needs to be reverted until somebody fixes it or it goes away. Sharing a backtrace would be a start, rather than just throwing around the word crash to

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Andreas Färber
Am 08.01.2014 12:02, schrieb Paolo Bonzini: Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, 2013-06-18). Should probably be reverted. Prefer not, under no reasonable definition is NAND a sysbus device. Whats the

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Leaving only those that will be affected by the patch: Il 07/01/2014 18:34, Markus Armbruster ha scritto: target machine bus id times aarch64 n800i2c-bus.0 2 aarch64 n810i2c-bus.0 2 arm n800

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 14:53, Andreas Färber ha scritto: Am 08.01.2014 12:02, schrieb Paolo Bonzini: Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, 2013-06-18). Should probably be reverted. Prefer not, under no reasonable

[Qemu-devel] [RFC PATCH 0/0] binfmt script patches

2014-01-08 Thread alex . bennee
Hi, While working on my aarch64 work I found setting up binfmt was more of a pain than it could have been. Specifically: * hard-coded for /usr/local installs * no help * no error checking Tellingly the script doesn't seem to be used by the distros who have rolled their own binfmt_misc stuff

[Qemu-devel] [PATCH 1/2] scripts/qemu-binfmt-conf.sh: re-factor and clean-up

2014-01-08 Thread alex . bennee
From: Alex Bennée alex.ben...@linaro.org I was looking to set-up for development but found the script made some hard-coded assumptions. It doesn't seem the script is used by the distros but if it had a little more love maybe it would be ;-) * Add usage() instructions * Move all registering to a

[Qemu-devel] [PATCH 2/2] scripts/qemu-binfmt-check.py: a binfmt checker

2014-01-08 Thread alex . bennee
From: Alex Bennée alex.ben...@linaro.org This script allows you to check if a given binary will match against any of the currently registered binfmts on the system. --- v2 (ajb): - cleaned up whitespace and checkpatch fixes --- scripts/qemu-binfmt-check.py | 109

Re: [Qemu-devel] [PATCH] vmdk: Fix big flat extent IO

2014-01-08 Thread Kevin Wolf
Am 08.01.2014 um 02:42 hat Fam Zheng geschrieben: Local variable n as int64_t avoids overflow with large sector number calculation. See test case change for failure case. Signed-off-by: Fam Zheng f...@redhat.com Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Leaving only those that will be affected by the patch: You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz, terrier, tosa, verdex, z2, s390-virtio. Why won't they be affected? You also omitted the machines that I can't get to start,

Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

2014-01-08 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 7 January 2014 16:51, Peter Maydell peter.mayd...@linaro.org wrote: snip Another option we could consider here is only pulling in the set of source files we compile plus the headers they require, not the whole library. That's snip for about 6600 lines

Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

2014-01-08 Thread Alex Bennée
s...@weilnetz.de writes: Am 07.01.2014 17:51, schrieb Peter Maydell: Hi. This is a rebased and mildly cleaned up version of Claudio's RFC patchset from last year to add libvixl to QEMU and use it for A64 disassembly. NOTE NOTE NOTE * we now link with g++, not gcc (even if the target

Re: [Qemu-devel] [PATCH v2] linux-user: Support the accept4 socketcall

2014-01-08 Thread Riku Voipio
Hi, On Mon, Jan 06, 2014 at 05:15:50PM +0100, André Hentschel wrote: From: André Hentschel n...@dawncrow.de Cc: Riku Voipio riku.voi...@iki.fi Signed-off-by: André Hentschel n...@dawncrow.de --- See

Re: [Qemu-devel] [PATCH 1/2] scripts/qemu-binfmt-conf.sh: re-factor and clean-up

2014-01-08 Thread Andreas Färber
Hi, Am 08.01.2014 15:25, schrieb alex.ben...@linaro.org: From: Alex Bennée alex.ben...@linaro.org I was looking to set-up for development but found the script made some hard-coded assumptions. It doesn't seem the script is used by the distros but if it had a little more love maybe it would

Re: [Qemu-devel] [PATCH 1/2] scripts/qemu-binfmt-conf.sh: re-factor and clean-up

2014-01-08 Thread Alex Bennée
afaer...@suse.de writes: Hi, Am 08.01.2014 15:25, schrieb alex.ben...@linaro.org: From: Alex Bennée alex.ben...@linaro.org I was looking to set-up for development but found the script made some hard-coded assumptions. It doesn't seem the script is used by the distros but if it had a

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-08 Thread Yan Vugenfirer
On Jan 7, 2014, at 4:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/01/2014 16:04, Miki Mishael ha scritto: Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 15:35, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Leaving only those that will be affected by the patch: You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz, terrier, tosa, verdex, z2, s390-virtio. Why won't they be affected?

Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

2014-01-08 Thread Peter Maydell
On 8 January 2014 14:51, Alex Bennée alex.ben...@linaro.org wrote: Is there an argument for making this an optional component. It would be useful to know how many users care about having access to the target assembly. Certainly I'm only looking at it while developing TCG code. If you really

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 16:07, Yan Vugenfirer ha scritto: +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1, PCI\VEN_1B36DEV_0002SUBSYS_11001AF4REV_01 +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2, PCI\VEN_1B36DEV_0003SUBSYS_11001AF4REV_01 +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4,

[Qemu-devel] [PATCH 1/5] object_add: consolidate error handling

2014-01-08 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- qmp.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qmp.c b/qmp.c index 0f46171..a67e0c4 100644 --- a/qmp.c +++ b/qmp.c @@ -549,15 +549,17 @@ void object_add(const char *type, const char *id, const QDict

[Qemu-devel] [PATCH 3/5] virtio_rng: use object_realize interface instead of calling backend API

2014-01-08 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- backends/rng.c | 17 +++-- hw/virtio/virtio-rng.c | 15 +-- include/sysemu/rng.h | 11 --- 3 files changed, 24 insertions(+), 19 deletions(-) diff --git a/backends/rng.c b/backends/rng.c index

[Qemu-devel] [PATCH 5/5] -object/object-add: use custom default object location if provided

2014-01-08 Thread Igor Mammedov
Add a optional OBJECT_PATH_INTERFACE, that will allow to set custom container path if object's type implements this interface. Signed-off-by: Igor Mammedov imamm...@redhat.com --- it will be used for memdev backend to so that -object membackendX,id=memdevY could create object with path

[Qemu-devel] [PATCH 2/5] add optional 2nd stage initialization to -object/object-add/object_add commands

2014-01-08 Thread Igor Mammedov
Provides an ability to do an optional second stage initialization of an object created with -object/object-add/object_add commands. Patch adds interface that provides realize() callback, which is called after the object properties were set upon completion of -object/object-add/object_add command,

[Qemu-devel] [PATCH 4/5] vl.c: -object: handle duplicate 'id' properly

2014-01-08 Thread Igor Mammedov
object_property_add_child() may fail if 'id' matches already existing object. Which means incorrect command line, so instead of silently ignoring error, report it and go to error path (i.e. terminate QEMU). Signed-off-by: Igor Mammedov imamm...@redhat.com --- vl.c |2 +- 1 files changed, 1

Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

2014-01-08 Thread Alexander Graf
On 01/08/2014 04:31 PM, Peter Maydell wrote: On 8 January 2014 14:51, Alex Bennée alex.ben...@linaro.org wrote: Is there an argument for making this an optional component. It would be useful to know how many users care about having access to the target assembly. Certainly I'm only looking at it

[Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization

2014-01-08 Thread Igor Mammedov
Adds optional interfaces that objects could implement if they need to: 1. perform an additional initialization after object properties are set 2. be placed not in '/objects' container Series depends on 2 PULL requests in flight from Andreas Luiz with fixes for QOM interfaces and object-add

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2014-01-08 Thread Amit Shah
On (Wed) 08 Jan 2014 [17:14:41], Amos Kong wrote: On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote: Markus Armbruster arm...@redhat.com writes: Amos Kong ak...@redhat.com writes: Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 We have a requests queue

Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 17:09, Igor Mammedov ha scritto: Adds optional interfaces that objects could implement if they need to: 1. perform an additional initialization after object properties are set 2. be placed not in '/objects' container Series depends on 2 PULL requests in flight from Andreas

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-08 Thread Michael S. Tsirkin
On Wed, Jan 08, 2014 at 05:11:48PM +0100, Paolo Bonzini wrote: Il 08/01/2014 16:07, Yan Vugenfirer ha scritto: +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1, PCI\VEN_1B36DEV_0002SUBSYS_11001AF4REV_01 +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2, PCI\VEN_1B36DEV_0003SUBSYS_11001AF4REV_01

Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization

2014-01-08 Thread Andreas Färber
Am 08.01.2014 17:24, schrieb Paolo Bonzini: Il 08/01/2014 17:09, Igor Mammedov ha scritto: Adds optional interfaces that objects could implement if they need to: 1. perform an additional initialization after object properties are set 2. be placed not in '/objects' container Series

Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization

2014-01-08 Thread Igor Mammedov
On Wed, 08 Jan 2014 17:24:31 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 08/01/2014 17:09, Igor Mammedov ha scritto: Adds optional interfaces that objects could implement if they need to: 1. perform an additional initialization after object properties are set 2. be placed not

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 08/01/2014 15:35, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Leaving only those that will be affected by the patch: You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz, terrier, tosa, verdex, z2,

Re: [Qemu-devel] [PATCH 7/9] pc: ACPI: expose PRST IO range via _CRS

2014-01-08 Thread Michael S. Tsirkin
On Sat, Dec 28, 2013 at 11:30:50PM +0100, Igor Mammedov wrote: .. so OSPM could notice resource conflict if there is any. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 5/9] pc: PIIX DSDT: exclude CPU/PCI hotplug GPE0 IO range from PCI bus resources

2014-01-08 Thread Michael S. Tsirkin
On Sat, Dec 28, 2013 at 11:30:48PM +0100, Igor Mammedov wrote: .. so that they might not be used by PCI devices. Note: Resort to concatenating templates with preprocessor help, because 1.0b spec isn't supporting ConcatenateResTemplate, as result Windows XP fails to execute PCI0._CRS method

Re: [Qemu-devel] [PATCH 8/9] pc: ACPI: unify source of CPU hotplug IO base/len

2014-01-08 Thread Michael S. Tsirkin
On Sat, Dec 28, 2013 at 11:30:51PM +0100, Igor Mammedov wrote: use C headers defines as source of IO base/len for respective values in ASL code. Signed-off-by: Igor Mammedov imamm...@redhat.com That's cool. It's a bit confusing that you add macro in one patch, then drop it in another. Could

Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.

2014-01-08 Thread Hani Benhabiles
On Wed, Jan 08, 2014 at 08:36:06AM +0100, Markus Armbruster wrote: Hani Benhabiles kroo...@gmail.com writes: This would allow a user to be able to refer to the device when using commands like device_del. Signed-off-by: Hani Benhabiles kroo...@gmail.com No. Device IDs belong to

Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 17:51, Igor Mammedov ha scritto: Thanks Igor! I like very much patches 1-4 (though I'm thinking that we need some style conventions for interfaces). I think patch 5 adds more complexity than we need, but I'm open to discussion. I'm sorry that it took so long. The reason

Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 18:17, Hani Benhabiles ha scritto: For this reason, the loop in assign_device_name() specifically check that the ID doesn't exist already and uses the next value if it does. How would something like: (qemu) device_add virtio-net-pci == ID: virtio-net-pci.0 Be more

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2014 at 11:26:28AM +0530, kausik pal wrote: If this message should go elsewhere, my apologies. It would be great if QEMU have the capability of detachable overlay or union mount. So administrators can keep each software as separate individual qcow2/qed disks and can put

Re: [Qemu-devel] [PATCH 3/9] pc: rebuild ACPI hex files if included *.dsl are touched

2014-01-08 Thread Michael S. Tsirkin
On Sat, Dec 28, 2013 at 11:30:46PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/Makefile.objs | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs index 09ac433..edf5256 100644

Re: [Qemu-devel] [PATCH 0/9 v2] pc: CPU hotplug support for Q35

2014-01-08 Thread Michael S. Tsirkin
On Sat, Dec 28, 2013 at 11:30:43PM +0100, Igor Mammedov wrote: Changes since v1: * renamed hotplug.c/.h to cpu_hotplug.c/.h * make all prefixes acpi_cpu_hotplug and AcpiCpuHotplug * updated docs/specs/acpi_cpu_hotplug.txt with Q35's IO port range * exclude CPU/PCI/GPE IO ranges from

Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization

2014-01-08 Thread Igor Mammedov
On Wed, 08 Jan 2014 17:45:25 +0100 Andreas Färber afaer...@suse.de wrote: Am 08.01.2014 17:24, schrieb Paolo Bonzini: Il 08/01/2014 17:09, Igor Mammedov ha scritto: Adds optional interfaces that objects could implement if they need to: 1. perform an additional initialization after

Re: [Qemu-devel] [PATCH] qemu-ga: isa-serial support on Windows

2014-01-08 Thread Michael Roth
Quoting Miki Mishael (2014-01-05 11:18:51) Add support for isa-serial method for qemu-ga on Windows, Added -p command line parameter for serial port name specification, e.g. -p COM15. Signed-off-by: Miki Mishael mmish...@redhat.com Signed-off-by: Dmitry Fleytman dfley...@redhat.com ---

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-08 Thread kausik pal
Hi rich, Thanks for the answer. I was wondering how unidesk has solved the problem using disk layering. They have the solution for VMware, so if similar feature can be built on qemu for KVM hypervisor then we will have a great solution for application management from VDI perspective. Please let

Re: [Qemu-devel] [PATCH 07/13] mxs/imx23: Implements the pin mux, GPIOs

2014-01-08 Thread M P
All noted, and thanks for all the bits you reviewed so far, I'll do the changes and resubmit. M On 6 January 2014 15:52, Peter Maydell peter.mayd...@linaro.org wrote: On 11 December 2013 13:56, Michel Pollet buser...@gmail.com wrote: Implements the pinctrl and GPIO block for the imx23 It

Re: [Qemu-devel] [V4 PATCH 02/22] target-ppc: Add Flag for ISA2.06 Divide Extended Instructions

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:05 AM, Tom Musta wrote: This patch adds a flag for the Divide Extended instructions that were introduced in Power ISA V2.06B. The flag is added to the Power7 and Power8 models. Signed-off-by: Tom Musta tommu...@gmail.com --- V4: Split into new and separate patch. Added

Re: [Qemu-devel] [V4 PATCH 05/22] target-ppc: Add ISA 2.06 divweu[o] Instructions

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:05 AM, Tom Musta wrote: This patch addes the Unsigned Divide Word Extended instructions which were introduced in Power ISA 2.06B. Signed-off-by: Tom Musta tommu...@gmail.com --- V2: Eliminating extraneous code in the overflow case per comments from Richard Henderson.

Re: [Qemu-devel] [V4 PATCH 06/22] target-ppc: Add ISA 2.06 divwe[o] Instructions

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:05 AM, Tom Musta wrote: This patch addes the signed Divide Word Extended instructions which were introduced in Power ISA 2.06B. Signed-off-by: Tom Musta tommu...@gmail.com --- V2: Eliminating extraneous code in the overflow case per comments from Richard Henderson. Fixed

Re: [Qemu-devel] [PATCH v7 00/24] blkdebug/blkverify: Allow QMP configuration

2014-01-08 Thread Kevin Wolf
Am 20.12.2013 um 19:28 hat Max Reitz geschrieben: Currently, the configuration of blkdebug and blkverify is done through the filename alone. There is now way of manually choosing blkdebug or blkverify as a driver and using a normal image filename. In the case of blkdebug, the filename starts

Re: [Qemu-devel] [V4 PATCH 07/22] target-ppc: Add Flag for ISA2.06 Atomic Instructions

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:05 AM, Tom Musta wrote: This patch adds a flag for the atomic instructions introduced in Power ISA V2.06B. Signed-off-by: Tom Musta tommu...@gmail.com --- V4: Split into new and separate patch. Added to Power7+ model. target-ppc/cpu.h|5 -

Re: [Qemu-devel] [V4 PATCH 10/22] target-ppc: Add Flag for ISA V2.06 Floating Point Conversion

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:05 AM, Tom Musta wrote: This patch adds a flag for the floating point conversion instructions introduced in Power ISA 2.06B. Signed-off-by: Tom Musta tommu...@gmail.com --- V4: Split single flag into multiple flags per discussion with Alex Graf and Scott Wood. Added to

Re: [Qemu-devel] [V4 PATCH 18/22] target-ppc: Add Flag for Power ISA V2.06 Floating Point Test Instructions

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:06 AM, Tom Musta wrote: This patch adds a flag for Floating Point Test instructions that were introduced in Power ISA V2.06B. Signed-off-by: Tom Musta tommu...@gmail.com --- V4: Split single flag into multiple flags per discussion with Alex Graf and Scott Wood. Added flag

Re: [Qemu-devel] [V4 PATCH 12/22] target-ppc: Add ISA 2.06 fcfid[u][s] Instructions

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:06 AM, Tom Musta wrote: This patch adds the fcfids, fcfidu and fcfidus instructions which were introduced in Power ISA 2.06B. A common macro is provided to eliminate repetitious code, and the existing fcfid instruction is refactored to use this macro. Signed-off-by: Tom

Re: [Qemu-devel] [PULL 16/76] target-arm: Widen thread-local register state fields to 64 bits

2014-01-08 Thread Peter Maydell
On 7 January 2014 20:03, Peter Maydell peter.mayd...@linaro.org wrote: +#ifdef HOST_WORDS_BIGENDIAN +#define offsetoflow32(S, M) (offsetof(S, M + sizeof(uint32_t)) Mismatched brackets, won't build on bigendian hosts. (I happened to randomly run cppcheck, or I'd not have spotted that.) Reroll

Re: [Qemu-devel] [V4 PATCH 17/22] target-ppc: Fix and enable fri[mnpz]

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:06 AM, Tom Musta wrote: The fri* series of instructions was introduced prior to ISA 2.06 and is supported on Power7 and Power8 hardware. However, the instruction is still considered illegal in the P7 and P8 QEMU emulation models. This patch enables these instructions for the

Re: [Qemu-devel] [V4 PATCH 19/22] target-ppc: Add ISA 2.06 ftdiv Instruction

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:06 AM, Tom Musta wrote: This patch adds the Floating Point Test for Divide instruction which was introduced in Power ISA 2.06B. Signed-off-by: Tom Musta tommu...@gmail.com --- V4: Using the newly added PPC2_FP_TST_ISA206 flag. Modified helper signature per Richard

Re: [Qemu-devel] [V4 PATCH 20/22] target-ppc: Add ISA 2.06 ftsqrt

2014-01-08 Thread Richard Henderson
On 01/07/2014 08:06 AM, Tom Musta wrote: This patch adds the Floating Point Test for Square Root instruction which was introduced in Power ISA 2.06. Signed-off-by: Tom Musta tommu...@gmail.com --- V4: Using the newly added PPC2_FP_TST_ISA206 flag. Modified helper signature per Richard

Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver

2014-01-08 Thread M P
On 6 January 2014 15:46, Peter Maydell peter.mayd...@linaro.org wrote: On 11 December 2013 13:56, Michel Pollet buser...@gmail.com wrote: This implements just enough of the digctl IO block to allow linux to believe it's running on (currently only) an imx23. Signed-off-by: Michel Pollet

Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver

2014-01-08 Thread Peter Maydell
On 8 January 2014 18:39, M P buser...@gmail.com wrote: I will re-add the trace for both write and read and see if I can narrow the range down; it will be linux specific, tho, that's why I thought a 'catchall' block was more appropriate. Well, we should be implementing what the hardware does,

[Qemu-devel] [PULL 00/76] target-arm queue (v3)

2014-01-08 Thread Peter Maydell
) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20140108 for you to fetch changes up to 8900aad218f8f2348bcd688eacf06d6c1f66bc69: target-arm: A64: Add support for FCVT between half, single and double (2014-01-08 19:07:23 +

[Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-08 Thread Peter Feiner
When a backing file is opened such that (1) a protocol is directly used as the block driver and (2) the block driver has bdrv_file_open, bdrv_open_backing_file segfaults. The problem arises because bdrv_open_common returns without setting bd-backing_hd-file. To effect (1), you seem to have to use

[Qemu-devel] QEMU-KVM Guest TLB flush IPI emulation questions

2014-01-08 Thread Hu Yaohui
Hi All, I have a question regarding Guest TLB flush IPI. Suppose we get two vcpus 0 and 1. When vcpu#0 wants to invalidate the tlb entry on vcpu#1. An IPI will be generated by lapic on vcpu#0 by writing to ICR which will cause a vmexit.

[Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-08 Thread Gabriel L. Somlo
Add i386 command line option -no-fdc, which allows guests to omit the configuration of a floppy controller. Applies on top of my previous patch titled Add DSDT node for AppleSMC Signed-off-by: Gabriel Somlo so...@cmu.edu --- On Sun, Dec 22, 2013 at 11:21:00PM +0100, Laszlo Ersek wrote: I guess

[Qemu-devel] [PATCH v2] discard rbd error output when not relevant in qemu-iotests

2014-01-08 Thread Loic Dachary
Suppress rbd progress messages with --no-progress so they are not confused with an error output when comparing test results ( progress is displayed on stderr ). Signed-off-by: Loic Dachary l...@dachary.org --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-08 Thread Michael S. Tsirkin
On Wed, Jan 08, 2014 at 03:02:17PM -0500, Gabriel L. Somlo wrote: Add i386 command line option -no-fdc, which allows guests to omit the configuration of a floppy controller. Applies on top of my previous patch titled Add DSDT node for AppleSMC Signed-off-by: Gabriel Somlo so...@cmu.edu ---

  1   2   >