Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-24 Thread Markus Armbruster
Collin Walling writes: > This optional parameter for query-cpu-model-expansion enables CPU > model features flagged as deprecated to appear in the resulting > list of properties. > > This commit does not add support beyond adding a new argument > to the query. All queries with this option

Re: [PATCH 2/2] checkpatch.pl: forbid strerrorname_np()

2024-04-24 Thread Thomas Huth
On 24/04/2024 11.47, Daniel Henrique Barboza wrote: Commit d424db2354 removed an instance of strerrorname_np() because it was breaking building with musl libc. A recent RISC-V patch ended up re-introducing it again by accident. Put this function in the baddies list in checkpatch.pl to avoid

Re: [PATCH 1/2] target/riscv/kvm: remove sneaky strerrorname_np() instance

2024-04-24 Thread Thomas Huth
On 24/04/2024 11.46, Daniel Henrique Barboza wrote: Commit d424db2354 excluded some strerrorname_np() instances because they break musl libc builds. Another instance happened to slip by via commit d4ff3da8f4. Remove it before it causes trouble again. Fixes: d4ff3da8f4 (target/riscv/kvm:

Re: [PATCH 2/2] checkpatch.pl: forbid strerrorname_np()

2024-04-24 Thread Philippe Mathieu-Daudé
On 24/4/24 11:47, Daniel Henrique Barboza wrote: Commit d424db2354 removed an instance of strerrorname_np() because it was breaking building with musl libc. A recent RISC-V patch ended up re-introducing it again by accident. Put this function in the baddies list in checkpatch.pl to avoid this

Re: [PATCH 0/2] riscv,kvm: remove another strerrorname_np()

2024-04-24 Thread Philippe Mathieu-Daudé
On 24/4/24 11:46, Daniel Henrique Barboza wrote: Daniel Henrique Barboza (2): target/riscv/kvm: remove sneaky strerrorname_np() instance checkpatch.pl: forbid strerrorname_np() Modulo my nitpicking comments, series: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH-for-9.1 v2 2/3] target/nios2: Remove the deprecated Nios II target

2024-04-24 Thread Marek Vasut
On 4/24/24 10:50 AM, Philippe Mathieu-Daudé wrote: Hi Marek, On 18/4/24 14:04, Marek Vasut wrote: On 4/18/24 1:10 PM, Philippe Mathieu-Daudé wrote: On 27/3/24 15:48, Philippe Mathieu-Daudé wrote: The Nios II target is deprecated since v8.2 in commit 9997771bc1 ("target/nios2: Deprecate the

Re: [PATCH] vfio/ccw: Use g_autofree variable

2024-04-24 Thread Thomas Huth
On 24/04/2024 14.54, Cédric Le Goater wrote: Also change the return value of vfio_ccw_register_irq_notifier() to be a bool since it takes and 'Error **' argument. See the qapi/error.h Rules section. Signed-off-by: Cédric Le Goater --- hw/vfio/ccw.c | 25 +++-- 1 file

Re: [PATCH] vfio/ccw: Use g_autofree variable

2024-04-24 Thread Markus Armbruster
Cédric Le Goater writes: > Also change the return value of vfio_ccw_register_irq_notifier() to be > a bool since it takes and 'Error **' argument. See the qapi/error.h > Rules section. > > Signed-off-by: Cédric Le Goater My comments on "[PATCH] vfio/ap: Use g_autofree variable" apply. More

[PULL 1/5] MAINTAINERS: Update Sriram Yagnaraman mail address

2024-04-24 Thread Philippe Mathieu-Daudé
From: Sriram Yagnaraman Due to company policies, I have changed my mail address. Updating MAINTAINERS and .mailmap to show my latest mail address. Signed-off-by: Sriram Yagnaraman Message-ID: <20240228080625.2412372-1-sriram.yagnara...@ericsson.com> Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Philippe Mathieu-Daudé
Hi, On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packet to a device. In preparation for such a change, add MemReentrancyGuard * as a

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-24 Thread Mark Cave-Ayland
On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: On 23/4/24 11:18, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: On

Re: [PATCH v8 08/11] virtio-gpu: Handle resource blob commands

2024-04-24 Thread Dmitry Osipenko
On 4/19/24 12:18, Akihiko Odaki wrote: >> @@ -61,6 +61,10 @@ struct virtio_gpu_simple_resource { >>   int dmabuf_fd; >>   uint8_t *remapped; >>   +    MemoryRegion *mr; >> +    bool async_unmap_completed; >> +    bool async_unmap_in_progress; >> + > > Don't add fields to

Re: [PATCH v4] linux-aio: add IO_CMD_FDSYNC command support

2024-04-24 Thread Kevin Wolf
Am 14.03.2024 um 12:16 hat Prasad Pandit geschrieben: > From: Prasad Pandit > > Libaio defines IO_CMD_FDSYNC command to sync all outstanding > asynchronous I/O operations, by flushing out file data to the > disk storage. > > Enable linux-aio to submit such aio request. This helps to > reduce

[PULL 3/5] hw/timer: Remove the ALTERA_TIMER model

2024-04-24 Thread Philippe Mathieu-Daudé
The ALTERA_TIMER was only used by Nios II machines, which have been removed. Since it has no direct user, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240327144806.11319-4-phi...@linaro.org> --- hw/timer/altera_timer.c | 244

[PULL 5/5] block/gluster: Remove deprecated RDMA protocol handling

2024-04-24 Thread Philippe Mathieu-Daudé
GlusterFS+RDMA has been deprecated 8 years ago in commit 0552ff2465 ("block/gluster: deprecate rdma support"): gluster volfile server fetch happens through unix and/or tcp, it doesn't support volfile fetch over rdma. The rdma code may actually mislead, so to make sure things do not break,

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Thomas Huth
On 24/04/2024 12.41, Prasad Pandit wrote: On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to

Re: [PATCH] vfio/ap: Use g_autofree variable

2024-04-24 Thread Markus Armbruster
Cédric Le Goater writes: > Also change the return value of vfio_ap_register_irq_notifier() to be > a bool since it takes and 'Error **' argument. See the qapi/error.h > Rules section. > > Signed-off-by: Cédric Le Goater Split the patch? If not, the bigger part by far is the return value

[PATCH v9 0/2] Implement SSH commands in QEMU GA for Windows

2024-04-24 Thread aidan_leuck
From: Aidan Leuck This patch aims to implement guest-ssh-add-authorized-keys, guest-ssh-remove-authorized-keys, and guest-ssh-get-authorized-keys for Windows. This PR is based on Microsoft's OpenSSH implementation https://github.com/PowerShell/Win32-OpenSSH. The guest agents will support

[PATCH v9 2/2] Implement SSH commands in QEMU GA for Windows

2024-04-24 Thread aidan_leuck
From: aidaleuc Signed-off-by: Aidan Leuck --- qga/commands-windows-ssh.c | 712 + qga/commands-windows-ssh.h | 26 ++ qga/meson.build| 5 +- qga/qapi-schema.json | 17 +- 4 files changed, 749 insertions(+), 11 deletions(-) create mode

[PATCH v9 1/2] Refactor common functions between POSIX and Windows implementation

2024-04-24 Thread aidan_leuck
From: aidaleuc Signed-off-by: Aidan Leuck --- qga/commands-common-ssh.c | 50 +++ qga/commands-common-ssh.h | 10 qga/commands-posix-ssh.c | 47 +--- qga/meson.build | 1 + 4 files changed, 62

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-04-24 Thread Dmitry Osipenko
On 4/19/24 11:53, Akihiko Odaki wrote: > On 2024/04/19 4:00, Dmitry Osipenko wrote: >> Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd >> processor that it should stop processing commands and retry again >> next time until flag is unset. >> >> Signed-off-by: Dmitry Osipenko > >

Re: [PATCH 1/2] target/riscv/kvm: remove sneaky strerrorname_np() instance

2024-04-24 Thread Philippe Mathieu-Daudé
On 24/4/24 11:46, Daniel Henrique Barboza wrote: Commit d424db2354 excluded some strerrorname_np() instances because they break musl libc builds. Another instance happened to slip by via commit d4ff3da8f4. Remove it before it causes trouble again. Fixes: d4ff3da8f4 (target/riscv/kvm:

Re: [PATCH v3 4/5] qapi: introduce device-sync-config

2024-04-24 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add command to sync config from vhost-user backend to the device. It > may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not > triggered interrupt to the guest or just not available (not supported > by vhost-user server). > > Command result

Re: [PATCH v3 4/5] qapi: introduce device-sync-config

2024-04-24 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add command to sync config from vhost-user backend to the device. It > may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not > triggered interrupt to the guest or just not available (not supported > by vhost-user server). > > Command result

Re: [PATCH] ppc/pnv: Introduce pnv_chip_foreach_cpu()

2024-04-24 Thread Philippe Mathieu-Daudé
On 24/4/24 11:30, Cédric Le Goater wrote: This helper routine uses the machine definition, sockets, cores and threads, to loop on all CPUs of the machine. Replace CPU_FOREACH() with it. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 48 1

Re: [PATCH-for-9.1 16/21] target/sparc: Replace qemu_printf() by monitor_printf() in monitor

2024-04-24 Thread Philippe Mathieu-Daudé
On 24/4/24 09:44, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Replace qemu_printf() by monitor_printf() in monitor.c. Rename dump_mmu() as sparc_dump_mmu(). Signed-off-by: Philippe Mathieu-Daudé Same "why?" and "suggest to mention passing current monitor" as for PATCH 05. In

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-24 Thread Markus Armbruster
nifan@gmail.com writes: > From: Fan Ni > > Since fabric manager emulation is not supported yet, the change implements > the functions to add/release dynamic capacity extents as QMP interfaces. Will fabric manager emulation obsolete these commands? > Note: we skips any FM issued extent

[PATCH v3] target/riscv: Raise exceptions on wrs.nto

2024-04-24 Thread Andrew Jones
Implementing wrs.nto to always just return is consistent with the specification, as the instruction is permitted to terminate the stall for any reason, but it's not useful for virtualization, where we'd like the guest to trap to the hypervisor in order to allow scheduling of the lock holding VCPU.

Re: [PATCH 00/27] Add qapi-domain Sphinx extension

2024-04-24 Thread Markus Armbruster
John Snow writes: > On Tue, Apr 23, 2024, 3:48 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > On Mon, Apr 22, 2024 at 12:38 PM John Snow wrote: >> >> >> >> On Mon, Apr 22, 2024 at 5:20 AM Markus Armbruster >> >> wrote: >> >> > >> >> > John Snow writes: >> >> > >> >> > > On Fri,

[PULL 0/5] Housekeeping patches for 2024-04-24

2024-04-24 Thread Philippe Mathieu-Daudé
The following changes since commit 1a6f53953df65f31e922f8a1763dac9f10adc81b: Open 9.1 development tree (2024-04-23 17:33:36 -0700) are available in the Git repository at: https://github.com/philmd/qemu.git tags/housekeeping-20240424 for you to fetch changes up

Re: [PATCH v3] target/riscv: Raise exceptions on wrs.nto

2024-04-24 Thread Andrew Jones
On Wed, Apr 24, 2024 at 04:28:09PM +0200, Andrew Jones wrote: > Implementing wrs.nto to always just return is consistent with the > specification, as the instruction is permitted to terminate the > stall for any reason, but it's not useful for virtualization, where > we'd like the guest to trap to

[PATCH v2 RFC] fix host-endianness bug and prevent overflow

2024-04-24 Thread Alexandra Diupina
Add a type cast and use extract64() instead of extract32() to avoid integer overflow on addition. Fix bit fields extraction according to documentation. Also fix host-endianness bug by swapping desc fields from guest memory order to host memory order after dma_memory_read(). Found by Linux

Re: [PATCH v8 09/11] virtio-gpu: Resource UUID

2024-04-24 Thread Dmitry Osipenko
On 4/18/24 22:00, Dmitry Osipenko wrote: > @@ -1405,6 +1408,8 @@ static int virtio_gpu_blob_load(QEMUFile *f, void > *opaque, size_t size, > res->iov[i].iov_len = qemu_get_be32(f); > } > > +qemu_get_buffer(f, res->uuid.data, sizeof(res->uuid.data)); Save/loading

Re: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents

2024-04-24 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 05, 2024 at 09:09:05AM -0800, fan wrote: >> On Tue, Mar 05, 2024 at 04:15:30PM +, Daniel P. Berrangé wrote: >> > On Tue, Mar 05, 2024 at 04:09:08PM +, Jonathan Cameron via wrote: >> > > On Mon, 4 Mar 2024 11:34:08 -0800 >> > > nifan@gmail.com

Re: [PATCH for-9.1] util/log: add cleanup function

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
On 22.04.24 22:29, Stefan Hajnoczi wrote: On Wed, Apr 17, 2024 at 09:33:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: We leak global_filename, and do not close global_file. Let's fix that. What is the goal? Leaking global_filename does not cause unbounded memory consumption. I guess the

Re: [PATCH v4 0/7] qga/commands-posix: replace code duplicating commands with a helper

2024-04-24 Thread Konstantin Kostiuk
To series: Reviewed-by: Konstantin Kostiuk On Wed, Mar 20, 2024 at 6:17 PM Andrey Drobyshev < andrey.drobys...@virtuozzo.com> wrote: > v3 -> v4: > * Patch 1/7: > - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0; > - Renamed the field to 'total-bytes-privileged'; >

[PATCH 1/2] target/riscv/kvm: remove sneaky strerrorname_np() instance

2024-04-24 Thread Daniel Henrique Barboza
Commit d424db2354 excluded some strerrorname_np() instances because they break musl libc builds. Another instance happened to slip by via commit d4ff3da8f4. Remove it before it causes trouble again. Fixes: d4ff3da8f4 (target/riscv/kvm: initialize 'vlenb' via get-reg-list) Signed-off-by: Daniel

[PATCH 2/2] checkpatch.pl: forbid strerrorname_np()

2024-04-24 Thread Daniel Henrique Barboza
Commit d424db2354 removed an instance of strerrorname_np() because it was breaking building with musl libc. A recent RISC-V patch ended up re-introducing it again by accident. Put this function in the baddies list in checkpatch.pl to avoid this situation again. This is what it will look like next

[PATCH 0/2] riscv,kvm: remove another strerrorname_np()

2024-04-24 Thread Daniel Henrique Barboza
Hi, strerrorname_np() was removed last December due to problems with musl libc builds. And then I ended up adding another instance during the 9.0 cycle (commit ). So here I am removing the newly added instance and, this time, patching checkpatch.pl to forbid this function from showing up again.

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Prasad Pandit
On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: >On 1/6/23 05:18, Akihiko Odaki wrote: >> Recently MemReentrancyGuard was added to DeviceState to record that the >> device is engaging in I/O. The network device backend needs to update it >> when delivering a packet

Re: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new decoder

2024-04-24 Thread Paolo Bonzini
On Thu, Apr 11, 2024 at 5:05 PM Zhao Liu wrote: > HMM, I met Guest boot failure on this patch because of ata unrecognized. > I haven't located the exact error yet, so let me post my log first. > If there are other means I can use to dig further, I'd be happy to try > that too. > > # Command (boot

Re: [PATCH v3 5/5] qapi: introduce CONFIG_READ event

2024-04-24 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Send a new event when guest reads virtio-pci config after > virtio_notify_config() call. > > That's useful to check that guest fetched modified config, for example > after resizing disk backend. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[PATCH] vfio/ap: Use g_autofree variable

2024-04-24 Thread Cédric Le Goater
Also change the return value of vfio_ap_register_irq_notifier() to be a bool since it takes and 'Error **' argument. See the qapi/error.h Rules section. Signed-off-by: Cédric Le Goater --- hw/vfio/ap.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git

[PATCH] vfio/ccw: Use g_autofree variable

2024-04-24 Thread Cédric Le Goater
Also change the return value of vfio_ccw_register_irq_notifier() to be a bool since it takes and 'Error **' argument. See the qapi/error.h Rules section. Signed-off-by: Cédric Le Goater --- hw/vfio/ccw.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff

Re: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock feature name

2024-04-24 Thread Zhao Liu
Hi maintainers, Ping. Do you like this diea? Thanks, Zhao On Fri, Mar 29, 2024 at 06:19:47PM +0800, Zhao Liu wrote: > Date: Fri, 29 Mar 2024 18:19:47 +0800 > From: Zhao Liu > Subject: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock feature > name > X-Mailer: git-send-email 2.34.1 >

Re: Problems (timeouts) when testing usb-ohci with qemu

2024-04-24 Thread Gerd Hoffmann
> qemu hack: > > hw/usb/hcd-ohci.c | 11 +++ > hw/usb/hcd-ohci.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index fc8fc91a1d..99e52ad13a 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -267,6 +267,10 @@ static

Re: [PATCH for-9.1 1/7] target/i386/kvm: Add feature bit definitions for KVM CPUID

2024-04-24 Thread Xiaoyao Li
On 3/29/2024 6:19 PM, Zhao Liu wrote: From: Zhao Liu Add feature definiations for KVM_CPUID_FEATURES in CPUID ( CPUID[4000_0001].EAX and CPUID[4000_0001].EDX), to get rid of lots of offset calculations. Signed-off-by: Zhao Liu --- hw/i386/kvm/clock.c | 5 ++--- target/i386/cpu.h |

Re: [PATCH-for-9.1 03/21] target/i386: Move APIC related code to cpu-apic.c

2024-04-24 Thread Philippe Mathieu-Daudé
On 24/4/24 10:26, Zhao Liu wrote: On Thu, Mar 21, 2024 at 04:48:19PM +0100, Philippe Mathieu-Daudé wrote: Date: Thu, 21 Mar 2024 16:48:19 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 03/21] target/i386: Move APIC related code to cpu-apic.c X-Mailer: git-send-email 2.41.0 Move

[PATCH 6.1.y] virtio_net: Do not send RSS key if it is not supported

2024-04-24 Thread Konstantin Ovsepian
From: Breno Leitao commit 059a49aa2e25c58f90b50151f109dd3c4cdb3a47 upstream There is a bug when setting the RSS options in virtio_net that can break the whole machine, getting the kernel into an infinite loop. Running the following command in any QEMU virtual machine with virtionet will

RE: [PATCH v8 2/2] Implement SSH commands in QEMU GA for Windows

2024-04-24 Thread Aidan Leuck
Hi Konstantin, I wanted to thank both you and Dehan for spending the time to review and test this patch. I appreciate it and am happy to hear that everything is working as expected! I will resubmit the patch with the updated signed off field. Thank you, Aidan Leuck From: Konstantin Kostiuk

Re: Timeouts in CI jobs

2024-04-24 Thread Stefan Weil via
Am 24.04.24 um 19:09 schrieb Daniel P. Berrangé: On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: I think the timeouts are caused by running too many parallel processes during testing. The CI uses parallel builds: make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS

Re: [PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-24 Thread Peter Xu
On Wed, Apr 24, 2024 at 08:42:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 1. Most of callers want to free the error after call. Let's help them. > > 2. Some callers log the error, some not. We also have places where we >log the stored error. Let's instead simply log every migration >

[PATCH RFC v2 0/3] cxl: Multi-headed Single Logical Device (MHSLD)

2024-04-24 Thread Svetly Todorov
MHSLDs allow multiple hosts to access dynamic capacity on a single backing device. This complicates DC management because adds, removals, and accesses need to be vetted such that hosts don't stomp on each other's data. This patchset proposes a set of hooks to be called in cxl_type3.c when each of

Re: Problems (timeouts) when testing usb-ohci with qemu

2024-04-24 Thread Guenter Roeck
On 4/24/24 04:16, Gerd Hoffmann wrote: qemu hack: hw/usb/hcd-ohci.c | 11 +++ hw/usb/hcd-ohci.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index fc8fc91a1d..99e52ad13a 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -267,6

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-24 Thread Markus Armbruster
fan writes: > On Wed, Apr 24, 2024 at 03:09:52PM +0200, Markus Armbruster wrote: >> nifan@gmail.com writes: >> >> > From: Fan Ni >> > >> > Since fabric manager emulation is not supported yet, the change implements >> > the functions to add/release dynamic capacity extents as QMP

Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-24 Thread Collin Walling
On 4/24/24 02:19, Markus Armbruster wrote: > Collin Walling writes: > >> This optional parameter for query-cpu-model-expansion enables CPU >> model features flagged as deprecated to appear in the resulting >> list of properties. >> >> This commit does not add support beyond adding a new argument

[BUG, RFC] Base node is in RW after making external snapshot

2024-04-24 Thread Andrey Drobyshev
Hi everyone, When making an external snapshot, we end up in a situation when 2 block graph nodes related to the same image file (format and storage nodes) have different RO flags set on them. E.g. # ls -la /proc/PID/fd lrwx-- 1 root qemu 64 Apr 24 20:14 12 -> /path/to/harddisk.hdd # virsh

[PATCH RFC v2 3/3] mhsld: implement MHSLD device

2024-04-24 Thread Svetly Todorov
Using a shared-memory bytemap, validates that DC adds, releases, and reclamations happen on extents belonging to the appropriate host. The MHSLD device inherits from the CXL_TYPE3 class and adds the following configuration options: --mhd-head= --mhd-state_file= --mhd-init= --mhd-head specifies

[PATCH RFC v2 2/3] cxl_type3: add MHD callbacks

2024-04-24 Thread Svetly Todorov
Introduce an API for validating DC adds, removes, and responses against a multi-headed device. mhd_reserve_extents() is called during a DC add request. This allows a multi-headed device to check whether the requested extents belong to another host. If not, then this function can claim those

[PATCH RFC v2 1/3] cxl-mailbox-utils: move CXLUpdateDCExtentListInPl into header

2024-04-24 Thread Svetly Todorov
Allows other CXL devices to access host DCD-add-response payload. --- hw/cxl/cxl-mailbox-utils.c | 16 include/hw/cxl/cxl_device.h | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c

Re: [PATCH 0/4] X86: Alias isa-bios area and clean up

2024-04-24 Thread Bernhard Beschow
+Michael Am 22. April 2024 20:06:21 UTC schrieb Bernhard Beschow : >This series changes the "isa-bios" MemoryRegion to be an alias rather than a > >copy in the pflash case. This fixes issuing pflash commands in the isa-bios > >region which matches real hardware and which some real-world legacy

Re: [PATCH v7 00/12] Enabling DCD emulation support in Qemu

2024-04-24 Thread Svetly Todorov
I tested the v7 DC add/release as part of the MHSLD RFC work I did with Gregory. Those commands worked as expected. Feel free to tack on: Tested-by: Svetly Todorov mailto:svetly.todo...@memverge.com>>

[PATCH v11 19/21] i386: Add cache topology info in CPUCacheInfo

2024-04-24 Thread Zhao Liu
Currently, by default, the cache topology is encoded as: 1. i/d cache is shared in one core. 2. L2 cache is shared in one core. 3. L3 cache is shared in one die. This default general setting has caused a misunderstanding, that is, the cache topology is completely equated with a specific cpu

[PATCH v11 13/21] i386: Support modules_per_die in X86CPUTopoInfo

2024-04-24 Thread Zhao Liu
Support module level in i386 cpu topology structure "X86CPUTopoInfo". Since x86 does not yet support the "modules" parameter in "-smp", X86CPUTopoInfo.modules_per_die is currently always 1. Therefore, the module level width in APIC ID, which can be calculated by

[PATCH v11 12/21] i386: Introduce module level cpu topology to CPUX86State

2024-04-24 Thread Zhao Liu
Intel CPUs implement module level on hybrid client products (e.g., ADL-N, MTL, etc) and E-core server products. A module contains a set of cores that share certain resources (in current products, the resource usually includes L2 cache, as well as module scoped features and MSRs). Module level

[PATCH v11 11/21] i386/cpu: Decouple CPUID[0x1F] subleaf with specific topology level

2024-04-24 Thread Zhao Liu
At present, the subleaf 0x02 of CPUID[0x1F] is bound to the "die" level. In fact, the specific topology level exposed in 0x1F depends on the platform's support for extension levels (module, tile and die). To help expose "module" level in 0x1F, decouple CPUID[0x1F] subleaf with specific topology

[PATCH v11 08/21] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid()

2024-04-24 Thread Zhao Liu
In cpu_x86_cpuid(), there are many variables in representing the cpu topology, e.g., topo_info, cs->nr_cores and cs->nr_threads. Since the names of cs->nr_cores and cs->nr_threads do not accurately represent its meaning, the use of cs->nr_cores or cs->nr_threads is prone to confusion and

[PATCH v11 07/21] i386/cpu: Use APIC ID info get NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

2024-04-24 Thread Zhao Liu
The commit 8f4202fb1080 ("i386: Populate AMD Processor Cache Information for cpuid 0x801D") adds the cache topology for AMD CPU by encoding the number of sharing threads directly. >From AMD's APM, NumSharingCache (CPUID[0x801D].EAX[bits 25:14]) means [1]: The number of logical processors

[PATCH v11 18/21] hw/i386/pc: Support smp.modules for x86 PC machine

2024-04-24 Thread Zhao Liu
As module-level topology support is added to X86CPU, now we can enable the support for the modules parameter on PC machines. With this support, we can define a 5-level x86 CPU topology with "-smp": -smp cpus=*,maxcpus=*,sockets=*,dies=*,modules=*,cores=*,threads=*. So, add the 5-level topology

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-24 Thread Richard Henderson
On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-04-23 17:35:57 -0700) are available in the Git repository at:

Re: Qemu for TC377

2024-04-24 Thread Sameer Kalliadan Poyil
Hi Bastian, Thanks a lot. I have downloaded HighTec IDE from ( https://free-entry-toolchain.hightec-rt.com/) and tried to run the TSIM but no success. In web, I don't see any documentation how to run it. The doc comes along with tsim doesn't explain how to start the simulator. Could you let me

Re: Problems (timeouts) when testing usb-ohci with qemu

2024-04-24 Thread Guenter Roeck
On 4/24/24 08:23, Guenter Roeck wrote: On 4/24/24 04:16, Gerd Hoffmann wrote: qemu hack:   hw/usb/hcd-ohci.c | 11 +++   hw/usb/hcd-ohci.h |  1 +   2 files changed, 12 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index fc8fc91a1d..99e52ad13a 100644 ---

Re: Timeouts in CI jobs (was: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?)

2024-04-24 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: > Am 20.04.24 um 22:25 schrieb Stefan Weil: > > Am 16.04.24 um 14:17 schrieb Stefan Weil: > > > Am 16.04.24 um 14:10 schrieb Peter Maydell: > > > > > > > The cross-i686-tci job is flaky again, with persistent intermittent > > > >

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-24 Thread fan
On Wed, Apr 24, 2024 at 03:09:52PM +0200, Markus Armbruster wrote: > nifan@gmail.com writes: > > > From: Fan Ni > > > > Since fabric manager emulation is not supported yet, the change implements > > the functions to add/release dynamic capacity extents as QMP interfaces. > > Will fabric

[PATCH 2/5] tcg/i386: Simplify immediate 8-bit logical vector shifts

2024-04-24 Thread Richard Henderson
The x86 isa does not have this operation, so we need an expansion. Use the same algorithm that we use for expanding this vector operation with integers: perform the shift with a wider type and then mask the bits that must be zero. This reduces the instruction count from 5 to 2. Signed-off-by:

[PATCH v2 2/2] qapi: introduce exit-on-error paramter for migrate-incoming

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
Now we do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's provide a possibility for QMP-based orchestrators to get an error like with outgoing migration. For x-exit-preconfig we can enable new behavior unconditionally, as it's

[PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
1. Most of callers want to free the error after call. Let's help them. 2. Some callers log the error, some not. We also have places where we log the stored error. Let's instead simply log every migration error. 3. Some callers have to retrieve current migration state only to pass it to

[PATCH v2 0/2] migration: do not exit on incoming failure

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
Hi all! The series brings an option to not immediately exit on incoming migration failure, giving a possibility to orchestrator to get the error through QAPI and shutdown QEMU by "quit". Vladimir Sementsov-Ogievskiy (2): migration: rework migrate_set_error() to migrate_report_err() qapi:

[PATCH] fix host-endianness bug

2024-04-24 Thread Alexandra Diupina
Add a function xlnx_dpdma_read_descriptor() that combines reading the descriptor from desc_addr by calling dma_memory_read() and swapping desc fields from guest memory order to host memory order. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce

[PATCH] fix bit fields extraction and prevent overflow

2024-04-24 Thread Alexandra Diupina
Add a type cast and use extract64() instead of extract32() to avoid integer overflow on addition. Fix bit fields extraction according to documentation. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexandra Diupina

Re: [PATCH v2 2/3] target/s390x: add support for "disable-deprecated-feats" expansion option

2024-04-24 Thread Collin Walling
On 4/24/24 03:24, David Hildenbrand wrote: > On 23.04.24 23:06, Collin Walling wrote: >> Retain a list of deprecated features disjoint from any particular >> CPU model. When a query-cpu-model-expansion is provided with the >> "disable-deprecated-feats" option set, the resulting properties list >>

[PATCH v6 4/5] hw/arm : Connect DM163 to B-L475E-IOT01A

2024-04-24 Thread Inès Varhol
Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/b-l475e-iot01a.c | 59 +++-- hw/arm/Kconfig | 1 + 2 files changed, 58 insertions(+), 2 deletions(-) diff --git a/hw/arm/b-l475e-iot01a.c

[PATCH v6 0/5] Add device DM163 (led driver, matrix colors shield & display)

2024-04-24 Thread Inès Varhol
This device implements the IM120417002 colors shield v1.1 for Arduino (which relies on the DM163 8x3-channel led driving logic) and features a simple display of an 8x8 RGB matrix. This color shield can be plugged on the Arduino board (or the B-L475E-IOT01A board) to drive an 8x8 RGB led matrix.

[PATCH v6 5/5] tests/qtest : Add testcase for DM163

2024-04-24 Thread Inès Varhol
`test_dm163_bank()` Checks that the pin "sout" of the DM163 led driver outputs the values received on pin "sin" with the expected latency (depending on the bank). `test_dm163_gpio_connection()` Check that changes to relevant STM32L4x5 GPIO pins are propagated to the DM163 device. Signed-off-by:

[PATCH v6 3/5] hw/arm : Create Bl475eMachineState

2024-04-24 Thread Inès Varhol
Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/b-l475e-iot01a.c | 46 - 1 file changed, 32 insertions(+), 14 deletions(-) diff --git a/hw/arm/b-l475e-iot01a.c b/hw/arm/b-l475e-iot01a.c index

Re: [PATCH v2 0/2] riscv,kvm: remove another strerrorname_np()

2024-04-24 Thread Michael Tokarev
24.04.2024 23:24, Daniel Henrique Barboza wrote: Hi, In this new version a small change suggested by Phil was made in patch 2. No other changes made. Applied to trivial-patches tree. Note: checkpatch.pl is nagging quite a bit about the checkpatch.pl change this time, claiming that I'm

[PATCH v11 15/21] i386: Support module_id in X86CPUTopoIDs

2024-04-24 Thread Zhao Liu
Add module_id member in X86CPUTopoIDs. module_id can be parsed from APIC ID, so also update APIC ID parsing rule to support module level. With this support, the conversions with module level between X86CPUTopoIDs, X86CPUTopoInfo and APIC ID are completed. module_id can be also generated from cpu

[PATCH v11 14/21] i386: Expose module level in CPUID[0x1F]

2024-04-24 Thread Zhao Liu
Linux kernel (from v6.4, with commit edc0a2b595765 ("x86/topology: Fix erroneous smp_num_siblings on Intel Hybrid platforms") is able to handle platforms with Module level enumerated via CPUID.1F. Expose the module level in CPUID[0x1F] if the machine has more than 1 modules. Tested-by: Yongwei

[PATCH v11 04/21] hw/core: Support module-id in numa configuration

2024-04-24 Thread Zhao Liu
Module is a level above the core, thereby supporting numa configuration on the module level can bring user more numa flexibility. This is the natural further support for module level. Add module level support in numa configuration. Tested-by: Yongwei Ma Signed-off-by: Zhao Liu Tested-by: Babu

[PATCH] target/arm: Restrict translation disabled alignment check to VMSA

2024-04-24 Thread Richard Henderson
For cpus using PMSA, when the MPU is disabled, the default memory type is Normal, Non-cachable. Fixes: 59754f85ed3 ("target/arm: Do memory type alignment check when translation disabled") Reported-by: Clément Chigot Signed-off-by: Richard Henderson --- Since v9 will likely be tagged tomorrow

[PATCH 5/5] accel/tcg: Introduce CF_BP_PAGE

2024-04-24 Thread Richard Henderson
Record the fact that we've found a breakpoint on the page in which a TranslationBlock is running. Signed-off-by: Richard Henderson --- include/exec/translation-block.h | 1 + accel/tcg/cpu-exec.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 0/5] tcg: Misc improvements

2024-04-24 Thread Richard Henderson
One patch to allow two output operands from gvec expansion, to be used by target/arm for updating QC. One patch to record the result of the generic breakpoint search so target translators do not need to repeat it. Three small optimization patches. r~ Richard Henderson (5): tcg: Add

[PATCH 4/5] tcg/optimize: Optimize setcond with zmask

2024-04-24 Thread Richard Henderson
If we can show that high bits of an input are zero, then we may optimize away some comparisons. Signed-off-by: Richard Henderson --- tcg/optimize.c | 110 + 1 file changed, 110 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[PATCH 1/5] tcg: Add write_aofs to GVecGen3i

2024-04-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec-common.h | 2 ++ tcg/tcg-op-gvec.c| 30 ++ 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/include/tcg/tcg-op-gvec-common.h b/include/tcg/tcg-op-gvec-common.h index

[PATCH 3/5] tcg/i386: Optimize setcond of TST{EQ,NE} with 0xffffffff

2024-04-24 Thread Richard Henderson
This may be treated as a 32-bit EQ/NE comparison against 0, which is in turn treated as a LTU/GEU comparison against 1. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-target.c.inc

Re: [PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.24 22:40, Peter Xu wrote: On Wed, Apr 24, 2024 at 08:42:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: 1. Most of callers want to free the error after call. Let's help them. 2. Some callers log the error, some not. We also have places where we log the stored error. Let's instead

Re: [PATCH v2 5/6] hw/ppc: SPI controller wiring to P10 chip and create seeprom device

2024-04-24 Thread Chalapathi V
Hello Cedric, Thank You for reviewing v2 patches. Regards, Chalapathi On 22-04-2024 20:33, Cédric Le Goater wrote: On 4/9/24 19:56, Chalapathi V wrote: In this commit Creates SPI controller on p10 chip. Create the keystore seeprom of type "seeprom-25csm04" Connect the cs of seeprom to

Re: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents

2024-04-24 Thread fan
On Wed, Apr 24, 2024 at 03:12:34PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Mar 05, 2024 at 09:09:05AM -0800, fan wrote: > >> On Tue, Mar 05, 2024 at 04:15:30PM +, Daniel P. Berrangé wrote: > >> > On Tue, Mar 05, 2024 at 04:09:08PM +, Jonathan Cameron

[ANNOUNCE] QEMU 7.2.11 Stable released

2024-04-24 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v7.2.11 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-7.2.11.tar.xz

[PATCH 3/3] accel/hvf: Use accel-specific per-vcpu @dirty field

2024-04-24 Thread Philippe Mathieu-Daudé
HVF has a specific use of the CPUState::vcpu_dirty field (CPUState::vcpu_dirty is not used by common code). To make this field accel-specific, add and use a new @dirty variable in the AccelCPUState structure. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 3 +--

  1   2   3   4   5   >