Re: [Qemu-devel] [PATCH] spapr: make sure RMA is in first mode of first memory node

2013-11-04 Thread Thomas Huth
On Mon, 4 Nov 2013 12:28:12 +0100 Alexander Graf ag...@suse.de wrote: On 04.11.2013, at 11:55, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2013-11-04 at 11:44 +0100, Alexander Graf wrote: On 01.11.2013, at 11:21, Alexey Kardashevskiy a...@ozlabs.ru wrote: SLOF

Re: [Qemu-devel] [PATCH v2] spapr: make sure RMA is in first mode of first memory node

2013-11-06 Thread Thomas Huth
On Wed, 6 Nov 2013 18:54:11 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: The SPAPR specification says that the RMA starts at the LPAR's logical address 0 and is the first logical memory block reported in the LPAR’s device tree. So SLOF only maps the first block and that block needs to

Re: [Qemu-devel] [PATCH v3] spapr: make sure RMA is in first mode of first memory node

2013-11-07 Thread Thomas Huth
to span the full RMA. This makes sure that the RMA area is where SLOF expects it. Cc: Thomas Huth th...@linux.vnet.ibm.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v3: * removed unnecessary RMA fixup from

Re: [Qemu-devel] [PATCH v4] spapr: make sure RMA is in first mode of first memory node

2013-11-08 Thread Thomas Huth
to span the full RMA. This makes sure that the RMA area is where SLOF expects it. Cc: Thomas Huth th...@linux.vnet.ibm.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v4: * fixed a bug with preallocated RMA (thanks

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2013-11-12 Thread Thomas Huth
On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated this from the direct problem I was solving: PowerPC LE. Please apply! Rusty.

Re: [Qemu-devel] [PATCH v5 2/2] spapr: limit numa memory regions by ram size

2013-11-21 Thread Thomas Huth
]; +mem_start += node_size; } return 0; Apart from the typo in the commit message, the patch looks good to me. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] kvm: Query KVM for available memory slots

2013-11-25 Thread Thomas Huth
*/ soft_vcpus_limit = kvm_recommended_vcpus(s); hard_vcpus_limit = kvm_max_vcpus(s); @@ -1527,6 +1538,7 @@ err: if (s-fd != -1) { close(s-fd); } +g_free(s-slots); g_free(s); return ret; Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH 01/22] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2013-12-11 Thread Thomas Huth
On Thu, 12 Dec 2013 10:57:49 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: +static int bdrv_refresh_limits(BlockDriverState *bs) +{ +BlockDriver *drv = bs-drv; + +memset(bs-bl, 0, sizeof(bs-bl)); + +if (!drv) { +return 0; +} else if

Re: [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START

2013-12-17 Thread Thomas Huth
Hi Alex, On Tue, 17 Dec 2013 14:56:33 +0100 Alexander Graf ag...@suse.de wrote: On 17.12.2013, at 14:22, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: Thomas Huth th...@linux.vnet.ibm.com This patch adds the missing START order to the SIGP instruction handler. Does

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct RAM size check for SLOF

2011-11-08 Thread Thomas Huth
Am Tue, 8 Nov 2011 16:52:16 +1100 schrieb David Gibson da...@gibson.dropbear.id.au: The SLOF firmware used on the pseries machine needs a reasonable amount of (guest) RAM in order to run, so we have a check in the machine init function to check that this is available. However, SLOF runs in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification

2011-09-16 Thread Thomas Huth
Hi all! Am Fri, 16 Sep 2011 12:41:40 +0200 schrieb Paolo Bonzini pbonz...@redhat.com: On 09/16/2011 05:06 AM, David Gibson wrote: 1) do you mean, in Linux terms, one target per SCSI _host_ or one target per SCSI _channel_? i.e. if you looks at /sys/bus/scsi/devices, right now

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification

2011-09-19 Thread Thomas Huth
Am Fri, 16 Sep 2011 12:51:31 -0300 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: I've done some readings about this problem today, and I think I've got an idea what might be wrong here - seems like a bug in SLOF to me. First, according to the SLOF source code, it seems to me

[Qemu-devel] [PATCH] slirp: Fix packet expiration

2011-09-27 Thread Thomas Huth
. This zeroed expiration_date then finally causes the packet to be discarded during if_start(), so that TFTP packets were not transmitted anymore. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- slirp/mbuf.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/mbuf.h

[Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()

2011-10-10 Thread Thomas Huth
Hi! I am currently facing a problem when running QEMU (up-to-date git version) with OHCI and a lot of virtual USB devices. The emulator dies with the following assertion: qemu-system-arm: hw/usb.c:337: usb_packet_complete: Assertion `p-owner != ((void *)0)' failed. To reproduce this problem,

Re: [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()

2011-10-11 Thread Thomas Huth
Am Mon, 10 Oct 2011 15:03:41 +0200 schrieb Thomas Huth th...@linux.vnet.ibm.com: I am currently facing a problem when running QEMU (up-to-date git version) with OHCI and a lot of virtual USB devices. The emulator dies with the following assertion: qemu-system-arm: hw/usb.c:337

Re: [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()

2011-10-12 Thread Thomas Huth
Am Wed, 12 Oct 2011 11:02:42 +0100 schrieb Stefan Hajnoczi stefa...@gmail.com: On Tue, Oct 11, 2011 at 8:35 AM, Thomas Huth th...@linux.vnet.ibm.com wrote: Am Mon, 10 Oct 2011 15:03:41 +0200 schrieb Thomas Huth th...@linux.vnet.ibm.com: I am currently facing a problem when running QEMU

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-08 Thread Thomas Huth
Am Wed, 8 Feb 2012 21:48:40 +1100 schrieb David Gibson da...@gibson.dropbear.id.au: On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: On Wed, 8 Feb 2012, David Gibson wrote: From: Thomas Huth th...@linux.vnet.ibm.com These instructions for loading and storing byte-swapped 64

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-08 Thread Thomas Huth
Am Thu, 9 Feb 2012 11:26:09 +1100 schrieb David Gibson d...@au1.ibm.com: On Wed, Feb 08, 2012 at 02:27:35PM +0100, Thomas Huth wrote: Am Wed, 8 Feb 2012 21:48:40 +1100 schrieb David Gibson da...@gibson.dropbear.id.au: On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: On Wed, 8

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-27 Thread Thomas Huth
Am Wed, 26 Sep 2012 10:56:07 +0200 schrieb Alexander Graf ag...@suse.de: On 26.09.2012, at 03:18, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 26, 2012 at 03:03:10AM +0200, Alexander Graf wrote: [snip] spapr-nvram: if (!drive || checksum_is_bad(drive))

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-12 Thread Thomas Huth
Am Mon, 12 Aug 2013 16:03:24 +1000 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Mon, 2013-08-12 at 10:07 +0530, Prerna Saxena wrote: .../... I dont know what context lead to this observation. However, PAPR mentions the following nomenclature guideline: The value of

[Qemu-devel] target-ppc: Problem with mtmsr emulation

2014-03-28 Thread Thomas Huth
Hi all! There seems to be a problem with the emulation of the mtmsr instruction: According to the PowerISA spec, chapter Book III-S, the mtmsr opcode has a so-called L field at bit position 15. Looking at the function gen_mtmsr() in target-ppc/translate.c, the bit is taken into account since

Re: [Qemu-devel] target-ppc: Problem with mtmsr emulation

2014-03-28 Thread Thomas Huth
On Fri, 28 Mar 2014 18:25:02 +0800 Alexander Graf ag...@suse.de wrote: Am 28.03.2014 um 16:16 schrieb Thomas Huth th...@linux.vnet.ibm.com: Hi all! There seems to be a problem with the emulation of the mtmsr instruction: According to the PowerISA spec, chapter Book III-S

Re: [Qemu-devel] [PATCH v6 2/8] virtio: allow byte swapping for vring and config access

2014-03-28 Thread Thomas Huth
, vq-vdev)) != max); /* Now map what we have collected */ virtqueue_map_sg(elem-in_sg, elem-in_addr, elem-in_num, 1); Apart from the cosmetic nits, patch looks fine to me. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v6 1/8] virtio_legacy_get_byteswap: endian-ambivalent targets using legacy virtio

2014-03-28 Thread Thomas Huth
On Fri, 28 Mar 2014 11:57:17 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: From: Rusty Russell ru...@rustcorp.com.au virtio data structures are defined as target endian, which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec

Re: [Qemu-devel] [PATCH 1/5] s390x/cpu: Use ioctl to reset state in the kernel

2014-04-14 Thread Thomas Huth
On Mon, 14 Apr 2014 12:14:49 +0200 Alexander Graf ag...@suse.de wrote: On 26.02.14 12:38, Christian Borntraeger wrote: From: Thomas Huth th...@linux.vnet.ibm.com Some of the state in the kernel can not be reset from QEMU yet. For this we've got to use the KVM_S390_INITIAL_RESET ioctl

Re: [Qemu-devel] My OS hangup in KVM for some reasons, how can I debug?

2014-05-12 Thread Thomas Huth
On Sun, 11 May 2014 21:09:44 +0800 Jun Koi junkoi2...@gmail.com wrote: On Fri, May 9, 2014 at 11:24 AM, Jun Koi junkoi2...@gmail.com wrote: On Thu, May 8, 2014 at 4:28 PM, Jun Koi junkoi2...@gmail.com wrote: Hi, I have an weird OS that I am trying to boot in KVM. however, it

Re: [Qemu-devel] [PATCH] kvm: Fix enable_cap helpers on older gcc

2014-05-12 Thread Thomas Huth
On Sun, 11 May 2014 18:11:04 +0200 Alexander Graf ag...@suse.de wrote: Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6) seem to choke on signedness detection in inline created variables:

Re: [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc

2014-05-12 Thread Thomas Huth
[-Werror=type-limits] However - thanks to Thomas Huth for the suggestion - we can just cast the offending potentially 0 value to a signed type, making the comparison signed. Signed-off-by: Alexander Graf ag...@suse.de --- v1 - v2: - only do cast, leaving readability intact

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2014-02-14 Thread Thomas Huth
On Fri, 14 Feb 2014 10:38:02 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated

Re: [Qemu-devel] Buildbot failure: MinGW

2014-02-19 Thread Thomas Huth
On Wed, 19 Feb 2014 11:53:09 + Peter Maydell peter.mayd...@linaro.org wrote: On 19 February 2014 04:27, Stefan Weil s...@weilnetz.de wrote: Hi Gerd, hi Stefan, we now need a C++ compiler on the buildbots. Currently, it's missing for MinGW: /bin/sh: i686-pc-mingw32-g++: command

Re: [Qemu-devel] [PATCH 00/28] target-ppc: Altivec 2.07

2014-02-20 Thread Thomas Huth
On Thu, 20 Feb 2014 12:34:00 + Richard W.M. Jones rjo...@redhat.com wrote: [...] The second bug is kind of interesting. If you add ~ 256 disks (using virtio-scsi), then it looks as if the firmware crashes. The total console output is below. It looks as if c is some kind of prompt.

Re: [Qemu-devel] [PATCH] configure: check that C++ compiler actually works

2014-02-20 Thread Thomas Huth
-by: Thomas Huth th...@linux.vnet.ibm.com --- Apologies for the breakage for people who were building in setups with no C++ compiler -- I should have tested the original change more thoroughly. configure | 29 + 1 file changed, 29 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] configure: Make C++ test work with --enable-werror

2014-02-24 Thread Thomas Huth
-Wignored-qualifiers $gcc_flags gcc_flags=-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags Looks fine to me. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v5 0/2] target-ppc: CPU device tree id

2014-01-31 Thread Thomas Huth
On Fri, 31 Jan 2014 17:07:36 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 01/22/2014 03:20 PM, Alexey Kardashevskiy wrote: On 01/10/2014 07:20 PM, Alexey Kardashevskiy wrote: On 12/20/2013 12:16 AM, Alexey Kardashevskiy wrote: On 12/10/2013 07:16 PM, Alexey Kardashevskiy wrote: On

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Thomas Huth
Hi Alex, On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf ag...@suse.de wrote: On 24.04.14 17:34, Jens Freimann wrote: From: Thomas Huth th...@linux.vnet.ibm.com With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. ... diff

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Thomas Huth
On Fri, 25 Apr 2014 14:36:11 +0200 Alexander Graf ag...@suse.de wrote: On 25.04.14 14:15, Thomas Huth wrote: On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf ag...@suse.de wrote: [...] I also think we should rather align the code with the PTE handling somehow. This way it gets pretty

[Qemu-devel] [PATCH] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Thomas Huth
With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. And while we're at it, move the page table entry handling to a separate function, too, as suggested by Alexander Graf. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- target

Re: [Qemu-devel] [PATCH 7/8] spapr: remove @next_irq

2014-03-14 Thread Thomas Huth
On Fri, 14 Mar 2014 15:18:08 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: This removes @next_irq from sPAPREnvironment which was used in old IRQ allocator as XICS is now responsible for IRQs and keep track of allocated IRQs. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru ---

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-18 Thread Thomas Huth
On Tue, 18 Mar 2014 09:34:56 +0530 Kashyap Chamarthy kcham...@redhat.com wrote: On Tue, Mar 18, 2014 at 07:56:16AM +0800, Le Tan wrote: Hi, I am diving into the source code of qemu. I see the word coroutine appears in so many places. I can't figure out what it means. So, please, can anyone

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-19 Thread Thomas Huth
On Wed, 19 Mar 2014 11:05:02 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: On Tue, Mar 18, 2014 at 11:28:47PM +0100, Thomas Huth wrote: On Tue, 18 Mar 2014 09:34:56 +0530 Kashyap Chamarthy kcham...@redhat.com wrote: On Tue, Mar 18, 2014 at 07:56:16AM +0800, Le Tan wrote: Hi, I

Re: [Qemu-devel] [RFC patch 5/6] s390: implement pci instruction

2014-09-19 Thread Thomas Huth
Hi Frank, On Fri, 19 Sep 2014 13:54:34 +0200 frank.blasc...@de.ibm.com wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements the s390 pci instructions in qemu. This allows to attach qemu pci devices including vfio. This does not mean the devices are functional but

Re: [Qemu-devel] [PULL 7/8] s390x/migration: migrate CPU state

2014-10-10 Thread Thomas Huth
On Thu, 9 Oct 2014 17:28:57 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 9 October 2014 14:36, Cornelia Huck cornelia.h...@de.ibm.com wrote: From: Thomas Huth th...@linux.vnet.ibm.com This patch provides the cpu save information for dumps and later life migration and enables

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-21 Thread Thomas Huth
On Mon, 20 Oct 2014 17:15:48 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: On 20 October 2014 10:19, Markus Armbruster arm...@redhat.com wrote: Contributors rely on this script to find maintainers to copy. The script falls

Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically

2014-10-22 Thread Thomas Huth
On Wed, 22 Oct 2014 11:56:30 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/22/2014 11:33 AM, Michael S. Tsirkin wrote: On Wed, Oct 22, 2014 at 11:08:22AM +0200, Paolo Bonzini wrote: The list emitted by --git-fallback often leads inexperienced contributors to add pointless CCs.

Re: [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl

2014-10-22 Thread Thomas Huth
On Wed, 22 Oct 2014 11:08:18 +0200 Paolo Bonzini pbonz...@redhat.com wrote: See individual patches. My Perl-fu is limited, but the individual changes are easy enough. Paolo Bonzini (4): get_maintainer.pl: exit with status 1 if no maintainer found get_maintainer.pl: treat all M entries

Re: [Qemu-devel] [PATCH 2/3 RFC] s390: implement pci instructions

2014-10-23 Thread Thomas Huth
Hi Frank, On Wed, 22 Oct 2014 17:11:59 +0200 Frank Blaschka blasc...@linux.vnet.ibm.com wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of

Re: [Qemu-devel] [PATCH v3 02/15] softmmu: provide softmmu access type enum

2014-10-24 Thread Thomas Huth
, retaddr); +cpu_unaligned_access(ENV_GET_CPU(env), addr, MMU_DATA_STORE, + mmu_idx, retaddr); } #endif I very much like the idea to get rid of these magic numbers! Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Remove the --git-chief-penguins option

2014-11-03 Thread Thomas Huth
On Wed, 22 Oct 2014 15:16:29 -0400 Don Slutz dsl...@verizon.com wrote: On 10/22/14 08:28, Thomas Huth wrote: Linus likely does not want to get e-mails about QEMU, so let's just remove this option. Suggested-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Thomas Huth th

Re: [Qemu-devel] [PATCH] Add new instruction for M68K family

2014-11-03 Thread Thomas Huth
On Fri, 31 Oct 2014 04:28:16 + Guo, Lei guol-f...@cn.fujitsu.com wrote: This patch aims to add new instructions (ABCD) for M68K family. The original TCG for M68k doesn’t include all instructions,so I intend to add the unrealized instruction or fix wrong instructions step by step. This

Re: [Qemu-devel] [PATCH 1/2] s390x/kvm: Fix opcode decoding for eb instruction handler

2014-11-03 Thread Thomas Huth
IPA0_DIAG: r = handle_diag(cpu, run, run-s390_sieic.ipb); Looks right! Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes

2014-11-03 Thread Thomas Huth
) \ Looks right to me. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

[Qemu-devel] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

2014-11-21 Thread Thomas Huth
config.status and tests/qemu-iotests/common.env are generated files that should be deleted during 'make distclean'. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index f505202

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Remove the --git-chief-penguins option

2014-12-04 Thread Thomas Huth
On Mon, 3 Nov 2014 13:50:24 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On Wed, 22 Oct 2014 15:16:29 -0400 Don Slutz dsl...@verizon.com wrote: On 10/22/14 08:28, Thomas Huth wrote: Linus likely does not want to get e-mails about QEMU, so let's just remove this option

Re: [Qemu-devel] [PATCH 2/2] s390/pci: implement stpcifc instruction

2014-12-05 Thread Thomas Huth
Hi Frank, On Fri, 5 Dec 2014 10:19:59 +0100 Frank Blaschka blasc...@linux.vnet.ibm.com wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements the last remaining s390 pci instruction to query the function information block. Signed-off-by: Frank Blaschka

Re: [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state

2014-12-08 Thread Thomas Huth
= ZPCI_PCI_LS_OK; -cpu_synchronize_state(CPU(cpu)); - if (env-psw.mask PSW_MASK_PSTATE) { program_interrupt(env, PGM_PRIVILEGED, 6); return 0; Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v3 1/5] block: add bdrv functions for geometry and blocksize

2014-12-10 Thread Thomas Huth
): Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v3 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

2014-12-10 Thread Thomas Huth
On Fri, 5 Dec 2014 18:56:18 +0100 Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote: Put it in new probe_logical_blocksize(). Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com --- block/raw-posix.c | 44 +++- 1 file changed, 27

Re: [Qemu-devel] [PATCH v3 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-10 Thread Thomas Huth
On Fri, 5 Dec 2014 18:56:19 +0100 Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote: This patch introduces driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. The method is only implemented for host_device. For raw devices driver calls child's

Re: [Qemu-devel] [PATCH v3 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-10 Thread Thomas Huth
This patch looks basically good to me, I just got some cosmetic requests: On Fri, 5 Dec 2014 18:56:21 +0100 Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote: ... diff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c index 6fcf74d..fbd602d 100644 --- a/hw/block/hd-geometry.c +++

Re: [Qemu-devel] [PATCH v3 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-11 Thread Thomas Huth
On Thu, 11 Dec 2014 14:17:21 +0300 Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote: On 12/10/2014 04:14 PM, Thomas Huth wrote: On Fri, 5 Dec 2014 18:56:19 +0100 Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote: ... diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 401b967

Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers

2014-12-11 Thread Thomas Huth
files changed, 44 insertions(+), 32 deletions(-) Patch looks fine to me. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH RFC v6 04/20] virtio: add feature checking helpers

2014-12-11 Thread Thomas Huth
On Thu, 11 Dec 2014 14:25:06 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Add a helper function for checking whether a bit is set in the guest features for a vdev as well as one that works on a feature bit set. Convert code that open-coded this: It cleans up the code and makes it

Re: [Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits

2014-12-12 Thread Thomas Huth
On Thu, 11 Dec 2014 14:25:07 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: With virtio-1, we support more than 32 feature bits. Let's extend both host and guest features to 64, which should suffice for a while. vhost and migration have been ignored for now. Signed-off-by: Cornelia

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2014-12-12 Thread Thomas Huth
On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2014-12-12 Thread Thomas Huth
On Fri, 12 Dec 2014 12:18:25 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 12 Dec 2014 11:55:38 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: For virtio-1 devices, the driver must

Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h

2014-12-15 Thread Thomas Huth
On Fri, 12 Dec 2014 16:20:16 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Wed, Dec 10, 2014 at 07:44:04PM +, Peter Maydell wrote: On 10 December 2014 at 19:26, Eduardo Habkost ehabk...@redhat.com wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- exec.c

[Qemu-devel] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

2014-12-15 Thread Thomas Huth
config.status and tests/qemu-iotests/common.env are generated files that should be deleted during 'make distclean'. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index f505202

Re: [Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-18 Thread Thomas Huth
, .bdrv_media_changed = raw_media_changed, .bdrv_eject = raw_eject, Looks good to me now (apart from the very minor typo). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v5 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-18 Thread Thomas Huth
, BlockBackend *blk, BlockCompletionFunc *cb, void *opaque); +void blk_probe_blocksizes(BlockBackend *blk, BlockSizes *bsz); +int blk_probe_geometry(BlockBackend *blk, HDGeometry *geo); #endif Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v5 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-18 Thread Thomas Huth
-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
On Tue, 03 Feb 2015 16:22:32 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 03/02/2015 16:16, Thomas Huth wrote: Actually, I'd prefer to keep the virtual in the defines for the type of operation below: When it comes to s390 storage keys, we likely might need some calls for reading

Re: [Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
On Tue, 03 Feb 2015 14:04:43 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 03/02/2015 13:11, Thomas Huth wrote: On s390, we've got to make sure to hold the IPTE lock while accessing virtual memory. So let's add an ioctl for reading and writing virtual memory to provide this feature

[Qemu-devel] [PATCH RFC 0/1] KVM: ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
;-))? Or should I maybe try to pursue another approach? Thomas Huth (1): KVM: s390: Add MEMOP ioctls for reading/writing guest memory Documentation/virtual/kvm/api.txt | 44 + arch/s390/kvm/gaccess.c | 22 + arch/s390/kvm/gaccess.h |2 + arch

[Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
On s390, we've got to make sure to hold the IPTE lock while accessing virtual memory. So let's add an ioctl for reading and writing virtual memory to provide this feature for userspace, too. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Dominik Dingel din...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-04 Thread Thomas Huth
On Wed, 04 Feb 2015 09:26:11 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: Am 03.02.2015 um 16:22 schrieb Paolo Bonzini: On 03/02/2015 16:16, Thomas Huth wrote: Actually, I'd prefer to keep the virtual in the defines for the type of operation below: When it comes to s390

Re: [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity

2015-01-14 Thread Thomas Huth
|= 0x80; Looks right. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Thomas Huth
On Wed, 14 Jan 2015 16:36:26 +0100 Lluís Vilanova vilan...@ac.upc.edu wrote: ... Also, AFAIR it was decided to use gtk-doc instead of doxygen. If there's a consensus about which source code documentation style should be used for QEMU, could you (or somebody else) maybe add an appropriate

Re: [Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call

2015-01-21 Thread Thomas Huth
On Wed, 21 Jan 2015 12:23:18 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 20 Jan 2015 11:08:24 + Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote: @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1

Re: [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused

2015-01-21 Thread Thomas Huth
On Thu, 8 Jan 2015 12:19:47 + Peter Maydell peter.mayd...@linaro.org wrote: The function end_exclusive() isn't used on all targets; mark it as such to avoid a clang warning. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/main.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH 1/1] virtio: fix feature bit checks

2015-01-21 Thread Thomas Huth
On Fri, 12 Dec 2014 10:01:46 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Several places check against the feature bit number instead of against the feature bit. Fix them. Reported-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [Qemu-devel] [PATCH v2 02/17] include: import virtio headers from linux 4.0

2015-02-16 Thread Thomas Huth
On Sun, 15 Feb 2015 12:38:37 +0100 Michael S. Tsirkin m...@redhat.com wrote: Add files imported from linux-next (what will become linux 4.0) using scripts/update-linux-headers.sh Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/standard-headers/sys/if_ether.h | 1 +

Re: [Qemu-devel] [PATCH v2 15/17] scripts: add arch specific standard-headers

2015-02-16 Thread Thomas Huth
On Sun, 15 Feb 2015 12:39:25 +0100 Michael S. Tsirkin m...@redhat.com wrote: Move virtio header copying logic to a function, use that to copy arch specific virtio headers. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- scripts/update-linux-headers.sh | 56

Re: [Qemu-devel] [PATCH v3 07/17] virtio-blk: switch to standard-headers

2015-02-18 Thread Thomas Huth
{ -blkcfg.sectors = conf-secs; +blkcfg.geometry.sectors = conf-secs; } blkcfg.size_max = 0; blkcfg.physical_block_exp = get_physical_block_exp(conf); Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v3 08/17] virtio-net, tap: use standard-headers

2015-02-18 Thread Thomas Huth
of merged rx buffers */ -}; - #endif /* QEMU_NET_TAP_H */ Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v3 09/17] virtio-rng: use standard-headers

2015-02-18 Thread Thomas Huth
max_bytes; Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v3 05/17] virtio-balloon: use standard headers

2015-02-17 Thread Thomas Huth
VirtIOBalloonStat; typedef struct VirtIOBalloon { VirtIODevice parent_obj; Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v3 06/17] virtio-9p: use standard headers

2015-02-17 Thread Thomas Huth
; Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 0/4] Remove unused functions

2015-02-16 Thread Thomas Huth
There are quite a lot of completely unused functions scattered around in the QEMU sources - here are some patches to remove at least some of them. Thomas Huth (4): migration: Remove unused functions ui/console: Removed unused functions util: Remove unused functions block: Remove unused

[Qemu-devel] [PATCH 1/4] migration: Remove unused functions

2015-02-16 Thread Thomas Huth
dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() are completely unused and thus can be deleted. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Juan Quintela quint...@redhat.com Cc: Amit Shah amit.s...@redhat.com

[Qemu-devel] [PATCH 3/4] util: Remove unused functions

2015-02-16 Thread Thomas Huth
Delete the unused functions qemu_opt_get_number_del(), qemu_signalfd_available(), qemu_send_full() and qemu_recv_full(). Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- include/qemu-common.h |4 --- include/qemu/compatfd.h |1 - include/qemu/option.h |2 - util/compatfd.c

[Qemu-devel] [PATCH 2/4] ui/console: Removed unused functions

2015-02-16 Thread Thomas Huth
() and vnc_stop_worker_thread() since they are completely unused. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Anthony Liguori aligu...@amazon.com Cc: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 11 - include/ui/input.h |1 - include/ui/qemu-pixman.h

Re: [Qemu-devel] [PATCH] KVM: s390: Add MEMOP ioctls for reading/writing guest memory

2015-02-19 Thread Thomas Huth
On Thu, 19 Feb 2015 10:47:29 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Mon, 16 Feb 2015 13:16:41 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading

[Qemu-devel] [PATCH 4/4] block: Remove unused functions

2015-02-16 Thread Thomas Huth
qemu_try_blockalign0() and nbd_export_close_all() are not used anymore and thus can be removed. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com --- block.c | 11

Re: [Qemu-devel] [PATCH v2 01/17] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-16 Thread Thomas Huth
about getting the uintxx_t types, right? If so, I think it is also sufficient to just include stdint.h instead. +#include qemu/compiler.h +EOF +cat EOF $output/include/standard-headers/sys/if_ether.h +#define ETH_ALEN6 +EOF + rm -rf $tmpdir Reviewed-by: Thomas Huth th

[Qemu-devel] [PATCH] KVM: s390: Add MEMOP ioctls for reading/writing guest memory

2015-02-16 Thread Thomas Huth
On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading and writing logical memory to provide this feature for userspace, too. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- Documentation/virtual/kvm/api.txt | 45

[Qemu-devel] [PATCH 1/2] Update Linux headers with KVM_GUEST_MEM_OP ioctl

2015-02-16 Thread Thomas Huth
Synchronized the kvm.h Linux header for the new ioctl. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- linux-headers/linux/kvm.h | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index

[Qemu-devel] [PATCH 0/2] s390x/kvm: ioctl for reading and writing from/to guest memory

2015-02-16 Thread Thomas Huth
patch series that has been sent out to the qemu-devel list by Jens Freimann on last thursday. Thomas Huth (2): Update Linux headers with KVM_GUEST_MEM_OP ioctl s390x/mmu: Use ioctl for reading and writing from/to guest memory linux-headers/linux/kvm.h | 21 + target-s390x

[Qemu-devel] [PATCH 2/2] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-02-16 Thread Thomas Huth
Add code to make use of the new ioctl for reading from / writing to virtual guest memory. By using the ioctl, the memory accesses are now protected with the so-called ipte-lock in the kernel. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- target-s390x/cpu.h|7 +++ target

Re: [Qemu-devel] [PATCH 4/4] block: Remove unused functions

2015-02-17 Thread Thomas Huth
Hi Max, On Mon, 16 Feb 2015 17:26:56 -0500 Max Reitz mre...@redhat.com wrote: On 2015-02-16 at 16:41, Thomas Huth wrote: qemu_try_blockalign0() and nbd_export_close_all() are not used anymore and thus can be removed. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to standard-headers

2015-02-18 Thread Thomas Huth
On Mon, 16 Feb 2015 22:36:26 +0100 Michael S. Tsirkin m...@redhat.com wrote: Drop duplicate code. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio-serial.h | 40 +-- hw/char/virtio-serial-bus.c | 1 + 2 files

  1   2   3   4   5   6   7   8   9   10   >