Re: [Qemu-devel] [PATCH 3/3] libcacard: don't free sign buffer while sign op is pending

2014-10-20 Thread Paolo Bonzini
On 10/19/2014 08:23 AM, Alon Levy wrote: On 10/19/2014 05:12 AM, Ray Strode wrote: From: Ray Strode rstr...@redhat.com commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up the cac_applet_pki_process_apdu function to have a single exit point. Unfortunately, that commit introduced a bug

Re: [Qemu-devel] [PATCH 3/3] libcacard: don't free sign buffer while sign op is pending

2014-10-19 Thread Alon Levy
On 10/19/2014 05:12 AM, Ray Strode wrote: From: Ray Strode rstr...@redhat.com commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up the cac_applet_pki_process_apdu function to have a single exit point. Unfortunately, that commit introduced a bug where the sign buffer can get free'd and

[Qemu-devel] [PATCH 3/3] libcacard: don't free sign buffer while sign op is pending

2014-10-18 Thread Ray Strode
From: Ray Strode rstr...@redhat.com commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up the cac_applet_pki_process_apdu function to have a single exit point. Unfortunately, that commit introduced a bug where the sign buffer can get free'd and nullified while it's still being used. This