[Rd] Request for stopifnot

2021-10-06 Thread Tim Taylor
Would R-core be receptive to adding an additional parameter to stopifnot so we can hide the call in the output as in stop? i.e. The signature would become: stopifnot2 <- function (..., exprs, exprObject, local = TRUE, .call = TRUE) It looks like this would be a one-line change to the the

Re: [Rd] R/CRAN switch to UCRT on Windows

2021-12-08 Thread Tim Taylor
Hear, hear! Also thank you Uwe and the rest of the CRAN team for all the work you put in. It is much appreciated! From: R-devel on behalf of Uwe Ligges Sent: 08 December 2021 14:24 To: Tomas Kalibera; r-devel Subject: Re: [Rd] R/CRAN switch to UCRT on

Re: [Rd] model.weights and model.offset: request for adjustment

2022-02-03 Thread tim . taylor
> On 03/02/2022 11:14 Martin Maechler wrote: > > > > Ben Bolker > > on Tue, 1 Feb 2022 21:21:46 -0500 writes: > > > The model.weights() and model.offset() functions from the 'stats' > > package index possibly-missing elements of a data frame via $, e.g. > > >

Re: [Rd] R 4.3: Change in behaviour of as.character.POSIXt for datetime values with midnight time

2023-08-15 Thread Tim Taylor
Many thanks Martin! I was completely overlooking the behaviour for a length 1 vector with 00:00:00. More coffee needed for me I think. Best Tim On 15/08/2023 08:58, Martin Maechler wrote: Tim Taylor on Mon, 14 Aug 2023 12:26:51 +0100 writes: > Martin, > Tha

Re: [Rd] R 4.3: Change in behaviour of as.character.POSIXt for datetime values with midnight time

2023-08-14 Thread Tim Taylor
Martin, Thank you. Everything you have written is helpful and I admit I am likely guilty of using as.character() instead of format() in the past(). Ignoring the above though, one thing I’m still unclear on is the special handling of zero (or rather non-zero time) seconds in the method. Is the

[Rd] Hash table plans

2023-01-04 Thread Tim Taylor
I note in r-devel the hash table functionality is still marked as experimental. Is it expected that this will progress to non-experimental in 4.3 or is there a need for more feedback from the wider community first? Tim __ R-devel@r-project.org

Re: [Rd] memory leak in png()

2023-01-17 Thread Tim Taylor
On 17/01/2023 13:06, Duncan Murdoch wrote: I don't have a valgrind-capable version of R, but I'd be interested to see whether this is a one-time loss, or repeated.  That is, do you get a much bigger loss from running the lossy code in a loop like this?  for (i in 1:100) {

[Rd] R blog link on developer page

2022-11-08 Thread tim . taylor
The link to the R blog on https://developer.r-project.org/ currently points to the old site (https://developer.r-project.org/Blog/public). Should the link be updated to the new location (https://blog.r-project.org/)? Apologies if this was the wrong list to raise this - please flag if there's a

Re: [Rd] range() for Date and POSIXct could respect `finite = TRUE`

2023-04-28 Thread Tim Taylor
A tiny nit-pick nit-pick: I'd take NA to mean the finish date is missing and you know neither whether the event has finished or if it has finished at all :-) Either way the proposed method seems sensible. Tim On 28/04/2023 16:29, Paul McQuesten wrote: A tiny nit-pick: Seems to me that end

[Rd] as.matrix.dist patch (performance)

2023-08-10 Thread Tim Taylor
Please find attached a small patch to improve the performance of as.matrix.dist().  It's a tiny bit more involved than the current code but does bring a reasonable speed improvement for larger objects (remaining comparable for smaller ones). Example: set.seed(1) dat <- matrix(rnorm(2),

Re: [Rd] as.matrix.dist patch (performance)

2024-01-16 Thread Tim Taylor
g 2023 22:38:44 +0100 > Tim Taylor пишет: > >> Submitting here in the first instance but happy to move to Bugzilla >> if more appropriate. > > It's a fine patch. The 1.7 times speed up from not transposing the > return value shouldn't be sneezed at. I think it's time

[Rd] strcapture performance when perl = TRUE

2024-01-29 Thread Tim Taylor
I wanted to raise the possibility of improving strcapture performance in cases where perl = TRUE. I believe we can do this in a non-breaking way by calling regexpr instead of regexec (conditionally when perl = TRUE). To illustrate this I've put together a 'proof of concept' function called

[Rd] Regenerate news feeds?

2023-11-17 Thread Tim Taylor
The news feeds (e.g. https://developer.r-project.org/blosxom.cgi/R-devel/NEWS) have some stray "\abbr" floating around. Do they need generating with a more recent version of R-devel? I've run tools::Rd2txt on https://svn.r-project.org/R/trunk/doc/NEWS.Rd and r85550 does seem to remove these

Re: [Rd] R 4.4.0 has version of Matrix 1.7-0, but it's not available on CRAN

2024-04-26 Thread Tim Taylor
On Fri, 26 Apr 2024, at 11:32 AM, Martin Maechler wrote: >> Gábor Csárdi >> on Fri, 26 Apr 2024 11:55:36 +0200 writes: > > > I don't know if this is a bug, but it is certainly weird. AFAICT R > > 4.4.0 has Matrix 1.7-0. > > Yes, it *is* available from CRAN: You can see it

Re: [R-pkg-devel] Delays in CRAN Windows Binaries?

2020-10-23 Thread Tim Taylor
I've made an example at https://github.com/tjtnew/newbies that uses GitHub actions to monitor how many hours a package has been in the "newbies" queue. It updates hourly and saves to a csv in the repo. It's not something I have time to develop more but if someone wants to pick it up and take it

[R-pkg-devel] Test errors occurring on win-builder only

2020-12-10 Thread Tim Taylor
Morning all What's the best way to narrow down test errors that are occurring on win-builder only? I've tried checking the package on local installs of r-devel (both 32 bit and 64bit), and on the Windows installs on rhub and through GitHub actions. On all of these systems the checks pass

Re: [R-pkg-devel] Test errors occurring on win-builder only

2020-12-10 Thread Tim Taylor
) ** Cheers On Thu, 10 Dec 2020 at 10:02, Uwe Ligges wrote: > > WHich package? Where are the logs? > > Best, > Uwe Ligges > > > On 10.12.2020 10:39, Tim Taylor wrote: > > Morning all > > > > What

Re: [R-pkg-devel] Solaris Support

2021-08-23 Thread Tim Taylor
No direct experience, so others may know more, but I'd have thought in the system requirements of DESCRIPTION. See for instance what duckdb does https://github.com/duckdb/duckdb/blob/master/tools/rpkg/DESCRIPTION From: R-package-devel on behalf of Reed

Re: [R-pkg-devel] What to do when a package is archived from CRAN

2023-08-27 Thread Tim Taylor
Could you have been caught out with the precompiled binary that serde started distributing in a few of it’s versions (https://github.com/serde-rs/serde/issues/2538)? That could have been a reason if you pinned a version with it present but only CRAN could confirm if that was the reason. Tim

Re: [R-pkg-devel] Re-building vignettes had CPU time 9.2 times elapsed time

2023-08-26 Thread Tim Taylor
I’m definitely sympathetic to both sides but have come around to the view of Greg, Dirk et al. It seems sensible to have a default that benefits the majority of “normal” users and require explicit action in shared environments not vice-versa. That is not to say that data.table could not do

Re: [R-pkg-devel] Warning 'as.data.frame.POSIXct()' is deprecated

2023-07-06 Thread Tim Taylor
names(value) <- deparse1(substitute(x)) value } Kind regards Enrico Vincent On Thu, 6 Jul 2023 at 10:41, Tim Taylor wrote: Apologies - I've not had enough caffeine just yet. The reprex below highlights the issue but I think the code which implemented the change *may* ne

Re: [R-pkg-devel] Warning 'as.data.frame.POSIXct()' is deprecated

2023-07-06 Thread Tim Taylor
Apologies - I've not had enough caffeine just yet. The reprex below highlights the issue but I think the code which implemented the change *may* need tweaking not lapply. Tim On 06/07/2023 09:26, Tim Taylor wrote: This *may* be an issue in lapply.  Let's see what others day. Reprex below

Re: [R-pkg-devel] Warning 'as.data.frame.POSIXct()' is deprecated

2023-07-06 Thread Tim Taylor
This *may* be an issue in lapply.  Let's see what others day. Reprex below Sys.setenv("_R_CHECK_AS_DATA_FRAME_EXPLICIT_METHOD_" = TRUE) dat <- Sys.Date() as.data.frame(dat) #>  dat #> 1 2023-07-06 lapply(dat, as.data.frame) #> Warning: Direct call of 'as.data.frame.Date()' is deprecated. 

Re: [R-pkg-devel] Please install cmake on macOS builders

2023-05-12 Thread Tim Taylor
On 12/05/2023 08:47, Iñaki Ucar wrote: El vie., 12 may. 2023 5:58, Simon Urbanek escribió: I think it would be quite useful to have some community repository of code snippets dealing with such situations. R-exts gives advice and pieces of code which are useful, but they are not complete

Re: [R-pkg-devel] How to create a macos-arm64 virtual machine/cloud environment to debug R package?

2023-12-06 Thread Tim Taylor
This is just a punt from a quick glance at your tests. Try using the following on your local build to ensure it's not a time zone issue `TZ=NZ R CMD check --as-cran` `Apologies if this is just noise but whenever I've had issues with datetimes and mac tests this is the first thing I check.`

Re: [R-pkg-devel] Matrix 1.7-0 to be released in March with ABI-breaking SuiteSparse update

2024-04-10 Thread Tim Taylor
Hi Mikael Revisiting this. Have the plans changed for 1.7-0 release? Tim On Mon, 12 Feb 2024, at 6:36 PM, Mikael Jagan wrote: > Dear users and binary repository maintainers, > > We are preparing Matrix version 1.7-0 for CRAN submission on March 11, ahead > of the spring release of R version

Re: [R-pkg-devel] Matrix 1.7-0 to be released in March with ABI-breaking SuiteSparse update

2024-04-10 Thread Tim Taylor
On Wed, 10 Apr 2024, at 11:52 AM, Martin Maechler wrote: >>>>>> Tim Taylor >>>>>> on Wed, 10 Apr 2024 10:37:00 +0100 writes: > > > Hi Mikael Revisiting this. Have the plans changed for > > 1.7-0 release? > > > Tim &g

Re: [R-pkg-devel] Check errors for RMarkdown vignettes with error chunks

2024-06-07 Thread Tim Taylor
Does this issue over in knitr shed some additional light ... https://github.com/yihui/knitr/issues/2338 Tim On 07/06/2024 14:50, Ivan Krylov via R-package-devel wrote: В Fri, 7 Jun 2024 09:10:03 +0200 "C.H." пишет: RMarkdown vignettes are sometimes used to demonstrate errors and one can