Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-25 Thread Hervé Pagès
On 4/25/24 07:04, Kurt Hornik wrote: ... > Sure, I'll look into adding something. (Too late for 4.4.0, of course.) > > Best > -k Great. Thanks! H. -- Hervé Pagès Bioconductor Core Team hpages.on.git...@gmail.com [[alternative HTML version deleted]]

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-25 Thread Kurt Hornik
> Hervé Pagès writes: > On 4/24/24 23:07, Kurt Hornik wrote: >>> Hervé Pagès writes: >>> Hi Kurt, >>> Is it intended that numeric_version() returns an error by default on >>> non-character input in R 4.4.0? >> Dear Herve, yes, that's the intention. >> >>> It seems that I can turn this

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-25 Thread Kurt Hornik
> Dirk Eddelbuettel writes: > Hi Kurt, > On 25 April 2024 at 08:07, Kurt Hornik wrote: > | > Hervé Pagès writes: > | > | > Hi Kurt, > | > Is it intended that numeric_version() returns an error by default on > | > non-character input in R 4.4.0? > | > | Dear Herve, yes, that's the

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-25 Thread Dirk Eddelbuettel
Hi Kurt, On 25 April 2024 at 08:07, Kurt Hornik wrote: | > Hervé Pagès writes: | | > Hi Kurt, | > Is it intended that numeric_version() returns an error by default on | > non-character input in R 4.4.0? | | Dear Herve, yes, that's the intention. | | > It seems that I can turn this into

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-25 Thread Hervé Pagès
On 4/24/24 23:07, Kurt Hornik wrote: >> Hervé Pagès writes: >> Hi Kurt, >> Is it intended that numeric_version() returns an error by default on >> non-character input in R 4.4.0? > Dear Herve, yes, that's the intention. > >> It seems that I can turn this into a warning by setting >>

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-25 Thread Kurt Hornik
> Hervé Pagès writes: > Hi Kurt, > Is it intended that numeric_version() returns an error by default on > non-character input in R 4.4.0? Dear Herve, yes, that's the intention. > It seems that I can turn this into a warning by setting >

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-24 Thread Hervé Pagès
Hi Kurt, Is it intended that numeric_version() returns an error by default on non-character input in R 4.4.0? It seems that I can turn this into a warning by setting _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_=false but I don't seem to be able to find any of this mentioned in the NEWS

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-04-01 Thread Kurt Hornik
> Andrea Gilardi via R-devel writes: Thanks: should be fixed now in the trunk. Best -k > Thank you very much Dirk for your kind words and for confirming the bug. > Next week I will open a new issue on Bugzilla adding the related patch. > Kind regards > Andrea > On 29/03/2024 20:14, Dirk

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-03-30 Thread Andrea Gilardi via R-devel
Thank you very much Dirk for your kind words and for confirming the bug. Next week I will open a new issue on Bugzilla adding the related patch. Kind regards Andrea On 29/03/2024 20:14, Dirk Eddelbuettel wrote: On 29 March 2024 at 17:56, Andrea Gilardi via R-devel wrote: | Dear all, | | I

Re: [Rd] Question regarding .make_numeric_version with non-character input

2024-03-29 Thread Dirk Eddelbuettel
On 29 March 2024 at 17:56, Andrea Gilardi via R-devel wrote: | Dear all, | | I have a question regarding the R-devel version of .make_numeric_version() function. As far as I can understand, the current code

[Rd] Question regarding .make_numeric_version with non-character input

2024-03-29 Thread Andrea Gilardi via R-devel
Dear all, I have a question regarding the R-devel version of .make_numeric_version() function. As far as I can understand, the current code (https://github.com/wch/r-source/blob/66b91578dfc85140968f07dd4e72d8cb8a54f4c6/src/library/base/R/version.R#L50-L56) runs the following steps in case of