Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread Duncan Murdoch
On 04/07/2018 4:04 PM, Joris Meys wrote: On Wed, Jul 4, 2018 at 9:31 PM, Duncan Murdoch > wrote: That shouldn't matter.  That function was created in a local environment whose parent is (probably by the huxtable:::make_setter_getters function,

Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread Duncan Murdoch
On 04/07/2018 3:44 PM, Iñaki Úcar wrote: It seems Joris is right. The following patch seems to solve the issue for me: diff --git a/R/attributes.R b/R/attributes.R index e7f4ab9..18ebdab 100644 --- a/R/attributes.R +++ b/R/attributes.R @@ -156,6 +156,7 @@ make_getter_setters <-

Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread Iñaki Úcar
It seems Joris is right. The following patch seems to solve the issue for me: diff --git a/R/attributes.R b/R/attributes.R index e7f4ab9..18ebdab 100644 --- a/R/attributes.R +++ b/R/attributes.R @@ -156,6 +156,7 @@ make_getter_setters <- function(attr_name, attr_type = c('cell', 'row', 'col', '

Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread Joris Meys
I just took a look at your repo, and two remarks: - you use roxygen, and used both @export and @S3method. The latter one is deprecated, so you should use only @export, or @method (see eg Hadley's answer here : https://github.com/klutometis/roxygen/issues/741 ) - You're using some code in

Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread David Hugh-Jones
I figured that. Actually I just tried this. I now get the interesting result that all calls to a generic fail with the UseMethod error...? On Wed, 4 Jul 2018 at 16:12, Joris Meys wrote: > On Wed, Jul 4, 2018 at 4:22 PM, Hadley Wickham > wrote: > >> I don't think it's related to the error, but

Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread Joris Meys
On Wed, Jul 4, 2018 at 4:22 PM, Hadley Wickham wrote: > I don't think it's related to the error, but you shouldn't be exporting > this: > > export("align<-.huxtable") > > You should generally only export the method. > Hadley means to say that you should generally only export the generic, not

Re: [R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread Hadley Wickham
I don't think it's related to the error, but you shouldn't be exporting this: export("align<-.huxtable") You should generally only export the method. Hadley On Wed, Jul 4, 2018 at 9:00 AM, David Hugh-Jones wrote: > Hi all, > > The following shows an error for my package: >

[R-pkg-devel] Weird error on CRAN linux check

2018-07-04 Thread David Hugh-Jones
Hi all, The following shows an error for my package: https://www.r-project.org/nosvn/R.check/r-release-linux-x86_64/huxtable-00check.html Here's an excerpt: > ### ** Examples > > > ht <- huxtable(a = 1:3, b = 1:3) > align(ht) <- 'right' Error in UseMethod("align<-") : no applicable method for