Re: [R-pkg-devel] (Not) Reporting minimum R version in DESCRIPTION Depends Field

2019-07-26 Thread Ben Bolker
I'd add: as far as I know CRAN policy would only require you to report the minimum version if your package would fail on one of the older R versions that CRAN still tests (at present I think this goes back to 3.5.2). For regular package developers (i.e. without the resources of RStudio) it's

Re: [R-pkg-devel] (Not) Reporting minimum R version in DESCRIPTION Depends Field

2019-07-26 Thread Hadley Wickham
I no longer believe this to be good advice - I think you should only declare a specific dependency if you want to strongly assert that your package works with those versions. For example, all tidyverse versions depend on R 3.2 and later, because we test on all those versions. Hadley On Friday,

[R-pkg-devel] (Not) Reporting minimum R version in DESCRIPTION Depends Field

2019-07-26 Thread Jarrett Phillips
Hello, Numerous CRAN packages report minimum R versions within the Depends field of the DESCRIPTION file. Is this reporting always necessary? Hadley Wickham's book "R Packages" states: "You can also use Depends to require a specific version of R, e.g. Depends: R (>= 3.0.1) . As with packages,

Re: [R-pkg-devel] Example fails in check

2019-07-26 Thread Jeff Newmiller
Pipes are very functional, unlike data.table. However, their extensive use of non-standard evaluation a la `subset` or `with` does complicate the package check process. As to the actual question, Imports announces that the magrittr package is a private dependency for your package. Users would

Re: [R-pkg-devel] Example fails in check

2019-07-26 Thread Duncan Murdoch
On 26/07/2019 2:37 a.m., Sigbert Klinke wrote: Hi, im my package development I get the following error when checking an example: > m <- findMatch('test', x[[1]], FUN='leven(code)') %>% addWave(x[[2]]) Error in findMatch("test", x[[1]], FUN = "leven(code)") %>% addWave(x[[2]]) :

Re: [R-pkg-devel] "Additional issues" show WRITE outside an array

2019-07-26 Thread Ivan Krylov
On Fri, 26 Jul 2019 01:50:36 -0500 Jiahuan ye wrote: > I am very confused what causes the ERROR. Your code on line 197 of src/min_wgss.cpp causes memory access outside the block that had been allocated for the best_change_point vector. I have not read the code in depth, but it looks like the

Re: [R-pkg-devel] "Additional issues" show WRITE outside an array

2019-07-26 Thread Uwe Ligges
Checks with address sanitizers have to be done with instrumnted R versions and take a long time, hence we run these checks less frequently and only under one platform (here Linux for simplicity). Best, Uwe Ligges On 26.07.2019 08:50, Jiahuan ye wrote: Hi, Recently, my first r package

[R-pkg-devel] "Additional issues" show WRITE outside an array

2019-07-26 Thread Jiahuan ye
Hi, Recently, my first r package offlineChange was uploaded to CRAN, and there are three errors. I already figured out that two of the three errors are that the depend and import are inconsistent: Depends:R (≥ 3.5.0) Imports:

Re: [R-pkg-devel] Example fails in check

2019-07-26 Thread Uwe Ligges
I'd suggest not to use pipes in package code, as the parser does not know about them and hence debugging, error messages are more obfuscated. Why not use he functional way of R? For the question: I guess you do not have a corresponding entry in the NAMESPACE file? Best, Uwe On